- 27 Mar, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I63636d765697143f102b7d71ea4f27ef0a95b17f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124039Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753988}
-
Chromium WPT Sync authored
Using wpt-import in Chromium aeb4b3df. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I999eec24f9be33f8bb93e7cce4a9fefc1652d523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123809Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753987}
-
Eric Seckler authored
To verify whether this causes crashes in SharedMemoryABI::TryAcquireChunk. Bug: 1064020 Change-Id: Ia00ca5ef8fabdfad7a6fc5c1c86ba0c25b7c982f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124310 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#753986}
-
Eric Kuo authored
Add two routines, disk linear read and random read routines, which will simulate disk linear read and random read by creating a file with checksum, read it randomly or linearly, and validate the checksum of read back in a duration. --gtest_filter=CrosHealthdServiceConnectionTest.* Bug: b:146513388 Test: chromeos_unittests Change-Id: Ide8b1ccaf353186c9f96b49e089a2648ef10b40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046804 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#753985}
-
Jochen Eisinger authored
Change-Id: I1910e309ceae7816f0a8bc1ddda5cd44672ab681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124251Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753984}
-
Maksim Sisov authored
Currently, NativeViewGLSurfaceEGL has a bunch of code guarded by USE_X11. This should be unified and placed under X11 interfaces managed in compile time. What is more, this code must be shared with ozone/x11 as well. Thus, to avoid confusions in names of the classes/files, rename gl_surface_egl_x11 to gl_surface_egl_x11_gless and rename the class NativeViewGLSurfaceEGLX11 to NativeViewGLSurfaceEGLX11GLES2 as that is always used when --use-gl=egl is passed. In the next CL, I will extract all the x11 code from NativeViewGLSurfaceEGL and place it to NativeViewGLSurfaceEGLX11. The reason why this is going to be managed in such a way is that currently when Angle is used with X11, NativeViewGLSurfaceEGL is used instead of NativeViewGLSurfaceEGLX11. And, thus, all the code that is guarded by USE_X11 is compiled and executed. Thus, when --use-gl=angle is passed (this is default for x11/linux now), NativeViewGLSurfaceEGLX11 will be used. And when --use-gl=egl is passed, NativeViewGLSurfaceEGLX11GLES2 will be used (it initializes native platform window as well, which is not required in case of angle). Bug: 1036285 Change-Id: I9bfe89a24c36ce80061137eae05f3c4dc00aa1c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116629 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#753983}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/49f8e0d4..5851deb6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib290929c0740fdfd0216a941c27bd4edf575493b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123810Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753982}
-
Nohemi Fernandez authored
Adds a flag to the user sign-in and reauthentication flows to use the new sign-in architecture. Updates the add account sign-in coordinator to present on the base view controller. Bug: 971989 Change-Id: I092e88a917573e869b38efc53a5089215077db60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120356 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753981}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/02e15b249b12..48f3f6cb2acb git log 02e15b249b12..48f3f6cb2acb --date=short --first-parent --format='%ad %ae %s' 2020-03-27 digit@google.com Remove two minor compiler warnings/errors: Created with: gclient setdep -r src/third_party/swiftshader@48f3f6cb2acb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2c2ded784652d82782b33cde69c13dee9d060139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124216Reviewed-by:
-
Yuki Shiino authored
Adds v8_color_page_popup_controller.{cc,h}. Bug: 839389 Change-Id: Icd8b75effe0001c7cee8161eabfeed995dd32458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124330Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#753979}
-
Anastasiia Nikolaienko authored
Send login params together with credentials to C++. Params contain obfuscated Gaia id and Reauth Proof Token of the parent who is approving EDU login flow. We are getting this information on 'parent signin' step and passing it to the last ('EDU account signin') step. The params will be used to log parent consent for secondary account addition. Bug: 1054798 Change-Id: If1f1fcfc7bdb0ec9ba05c98add764fd51cd373c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096636 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#753978}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/123c8191bc01..7e40936b1d81 git log 123c8191bc01..7e40936b1d81 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 ilkos@google.com Merge "Improve the heap graphs ui" Created with: gclient setdep -r src/third_party/perfetto@7e40936b1d81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I11127f40128ed4f929a6418aa23b00bdab82a6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124214Reviewed-by:
-
Marc Treib authored
The "Update" tests often fail on ASSERT_TRUE(bubble_observer.IsUpdatePromptShownAutomatically()). The theory is that this happens because we submit a form directly after navigation, before the password manager has finished loading the existing credentials. To avoid this, do a roundtrip to the store right after each navigation, to make sure any pending loads have finished. Bug: 1058339 Change-Id: I444ec4646b04ce424d75437ccc357409c817f906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124254Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#753976}
-
Tim Schumann authored
TBR=mukai@chromium.org BUG: 1065345 Change-Id: Id1e409b9a077936836dc21d09ac6586594912db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124312Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Auto-Submit: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#753975}
-
Jan Wilken Dörrie authored
This change migrates the password_manager component off base::Bind, base::Callback and base::Closure, using the Once* versions where possible, and the Repeating* versions otherwise. Furthermore, all existing usages of base::BindRepeating were audited, and also converted to base::BindOnce where possible. The last remaining use of base::Bind and base::Callback is related to PromptUserToChooseCredentials, which will be cleaned-up in a follow up. Bug: 714018 Change-Id: Idd33aca01d71a9fba282e9ea2dbf721f349ce7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120363 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#753974}
-
Tim Schumann authored
TBR=dbertoni@chromium.org BUG:1065344 Change-Id: Ib760d8263dc8cdd75c750a07770244a5e3ff779b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124311Reviewed-by:
-
Nico Weber authored
Bug: 346399 Cq-Include-Trybots: chromium/try:win-asan Change-Id: I6821921fb14fa107928c9976fe78a1ddb80b606b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124047 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#753972}
-
Delan Azabani authored
This CL migrates the remaining DeprecatedEqualIgnoringCase comparisons where one of the arguments is a non-literal ASCII constant, including three cases where that’s effectively true at all existing call sites: • resource.cc:126 "content-" "x-content-" "x-webkit-" • html_plugin_element.cc:100 "src" "data" • database_authorizer.cc:348 "__WebKitDatabaseInfoTable__" That last one isn’t obvious, but you can verify it by heading to the line in Chromium Code Search [1] and clicking the following: • database_info_table_name_ → database_authorizer.h:113 • database_info_table_name_ → [cross references] • Reference database_authorizer.cc:41 • database_info_table_name → database_authorizer.cc:39 • DatabaseAuthorizer [constructor] → [cross references] • Reference database.cc:233 • kInfoTableName → static const char[] These changes are potentially author-facing, except where the constant in question contains none of {s,k,S,K} [2], but I’ve optimistically made them without any additional tests based on Rick Byers’ reasoning on blink-dev [3]. Please let me know if that’s not sufficient here. Engine changes are based on the following replacement under Sublime Text 2 (PCRE), with further non-functional tweaks by reviewers: Find: (?x-i) (?<figurative>(?=[^"]) (?:[^(),]|(\((?:[^()]*|(?-1))\)))*+){0} (?<!bool[ ]) DeprecatedEqualIgnoringCase (\s*\(\s*+(?&figurative)\s*,\s*+(?&figurative)\s*\)) Where: *.cc,-/path/to/src/out/*,-/path/to/src/.clangd/* Replace: EqualIgnoringASCIICase$3 [1] https://source.chromium.org/chromium/chromium/src/+/f7455871a37e53362183771af7de36844df73a38:third_party/blink/renderer/modules/webdatabase/database_authorizer.cc;l=348 [2] https://www.unicode.org/Public/UCD/latest/ucd/CaseFolding.txt [3] https://groups.google.com/a/chromium.org/d/msg/blink-dev/sFOpNuQ91UU/3u1HxbnQCQAJ Change-Id: If3cfe2cc8775bd9ae74d9a35770896dfd09b18c4 Bug: 627682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113394 Commit-Queue: Delan Azabani <dazabani@igalia.com> Reviewed-by:Mason Freed <masonfreed@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#753971}
-
Anastasiia Nikolaienko authored
Add component and strings for the signin screen. Bug: 1054798 Change-Id: I7e6c3480c94bd258857493718e04558a3d52e243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095101 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f2bee3043a5e..651fc45d3a29 git log f2bee3043a5e..651fc45d3a29 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 2df8c71258de..99508c1ce389 (1 commits) 2020-03-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 443c2caa1714..55f01953d6e9 (1 commits) 2020-03-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 77090261dabc..02e15b249b12 (8 commits) Created with: gclient setdep -r src/third_party/angle@651fc45d3a29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I1e0db266c285b625254dc660339ba74f6c6917d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124231Reviewed-by:
-
Yuki Shiino authored
Adds CORE_EXPORT to the implementation classes of IDL interfaces that need core-modules cross-component trampolines. Bug: 839389 Change-Id: I359b067f6063a804614b2f98d42526a9251a0b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114472Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#753968}
-
David Jean authored
GaiaAuthFetcherIOSNSURLSessionBridgeTest.FetchWithRedirect GaiaAuthFetcherIOSNSURLSessionBridgeTest.FetchWithCookieStore GaiaAuthFetcherIOSNSURLSessionBridgeTest.FetchWithEmptyCookieStore TBR=jlebel@chromium.org Bug: 1065349 Change-Id: If8eff6b531703a371f2d98f0d635fadb7d19f145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124255Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#753967}
-
Stepan Khapugin authored
Removes the BVWrangler from the temporary interface, and instead sets up a more permanent scheme: 1. SceneState exposes an interface provider 2. AppState allows access to SceneStates 3. MainController uses AppState's scenes to find an interface provider. Note that a lot of code in MainController still assumes a single window and this is not fixed in this CL. Also breaks down application_delegate_internal target by splitting out tab_opening. This allows to avoid a deps cycle. Bug: 1045660 Change-Id: Iabd71bc18c901d6990dfdec77190605c4f51cb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120404Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753966}
-
Minoru Chikamune authored
The reset() function will be called automatically when GC runs. So we don't need to call reset() manually. They are handled automatically by HeapMojoRemote::Wrapper::ContextDestroyed(). Bug: 1049056 Change-Id: I794a7804630142cdb6f1d3c9bd908e8e40590e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108268Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#753965}
-
Nohemi Fernandez authored
This patch fixes several inconsistencies between the old and new sign-in architecture UI and provides more consistency within Chrome. Changes include: rounded button corners and constraints that take into account the safe area. Bug: 971989 Change-Id: I7cedcf6955b2a4c6c109f652db12eb0951ce7686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122349 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753964}
-
Side Yilmaz authored
available in incognito. Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates test classes for the features that are not available in incognito mode, or are persistent in incognito mode. Note: This change is only code clean-up, does not change any behaviour. Bug: 1041781 Change-Id: Ida47baa6d42df948f1ee5c023973ff4ff61c4463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119512 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#753963}
-
Ambre Williams authored
There's no concept of home directory on Fuchsia. base::GetHomeDir() resolves to /tmp, which is not an appropriate place for mutable persistent data. Use /data (sandboxed persistent storage) as DIR_CAST_HOME instead. Bug: None Change-Id: I7758bc5ba1ad6ccf9f4d4d1a87c098d2f093d7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120414Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Benjamin Lerman <qsr@chromium.org> Commit-Queue: Ambre Williams <ambre@google.com> Cr-Commit-Position: refs/heads/master@{#753962}
-
David Jean authored
There is no path between 3p/perfetto and ios/web_view TBR=ichikawa@google.com Bug: 1065322 Change-Id: I72c14b7a80d3086cfb1e449e571e094e50bcd644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124368 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753961}
-
Side Yilmaz authored
available in incognito. Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates test classes for the features that are available in incognito mode, or are persistent in incognito mode. Note: This change is only code clean-up, does not change any behaviour. Bug: 1041781 Change-Id: Ia6d239d838d1cdde3799fe5864f753eb5948ceaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115514 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#753960}
-
Frédéric Wang authored
This CL removes dead code for -webkit-pictograph. It was added in [1] after -webkit-body but CSS parser for generic font-family only accepts keywords ranging from "serif" to "-webkit-body", at least since the latter was introduced in [2]. Currently, the only test in Chromium is a pixel test [3] but it actually works by checking the raw string in FontSelector::FamilyNameFromSettings rather than relying on enumerated values. Note that this case is different from "-webkit-body" (mapped to the FontDescription::kStandardFamily enum) and from generic names defined in the specification (mapped to "-webkit-*" strings). This will free one place in GenericFamilyType so that one can introduce the standard CSS property 'font-family: math' without increasing the size of FontDescription [4]. [1] https://source.chromium.org/chromium/chromium/src/+/14fc7ad2ef480 [2] https://source.chromium.org/chromium/chromium/src/+/c9ed7cc38acd0 [3] third_party/blink/web_tests/fast/css/font-family-pictograph.html [4] https://chromium-review.googlesource.com/c/chromium/src/+/2119534 Bug: 6606 Change-Id: I7cbfe5b4b4f47bbc5bba1a54c19d8d6d0249b206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119545Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#753959}
-
Jeff Yoon authored
Duplicate entries for ios_device release bot - Chromium iOS Goma RBE ToT had a different config as other ios release bots, but the values were the same. consolidated these. ios_use_goma_rbe pulled from ios-device and ios-sim - not all ios-devices and all ios-sims need to use ios_use_goma_rbe based on the recent migrations done by sque@. - pulling that out and applying the mixin to configs where it made sense. chromium.fyi 'ios13-sdk-device': same ios_release_device with rbe 'ios13-sdk-simulator': same ios_sim_debug_static_bot with rbe 'ios-webkit-tot': same ios_sim_debug_static_bot with rbe chromium.goma: 'Chromium iOS Goma RBE ToT': dedup and use ios_release_device without rbe chromium.mac: 'ios-device': ios_release_device with rbe tryserver.chromium.mac: 'ios-device': same as builder mb_config.pyl mixins: ios_cronet - alphabetical restructure ios-device + ios-sim - remove ios_use_goma_rbe ios_release_device - deleted for dedup Bug: 1064876 Change-Id: Ibd0bfb536a6f863229ab6cfb548e9104e9134106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122453Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#753958}
-
Tim Schumann authored
fast/hidpi/image-srcset-relative-svg-canvas.html is flaky on Win BUG:1065335 TBR=hayato@chromium.org Change-Id: I1e5aba81fd063a74b74d2755a3defd57137f2527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124309 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f955827d..49f8e0d4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib4116e3e388ea8dd58eae431a7e45656a29f4d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123518Reviewed-by:
-
Tobias Sargeant authored
These keys are collected on all other platforms, and are useful for identifying issues that are particular to a given GPU or driver. Bug: 1064594 Change-Id: I0c727209939b39cea09beb8ce55dba2a6227fb6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120308Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#753955}
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: Icd755377cfc84d9f8ff134aa3de9d1a8f159b5ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120499 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#753954}
-
Zain Afzal authored
The unprivileged frame needs the ability to load the next file in the directory as writable. This CL adds functions to expose this functionality on receivedFileList. Bug: 996088 Change-Id: If18a4141b451a3788ab2e60aa70aff2b88580f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123688 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#753953}
-
Henrique Ferreiro authored
This was unintentionally introduced in https://crrev.com/c/882191. Bug: 804471 Change-Id: I498109ea8a5ebdd236838653406e80ebbc307b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115541 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#753952}
-
Tim Schumann authored
This reverts commit b280cd38. Reason for revert: Introduced flakiness in NavigationPredictorBrowserTest.NavigationScoreSingleObserver Original change's description: > Pass the next likely navigations from external Android apps. > > Pass the next likely navigations from external Android apps > to observers of navigation predictor keyed service. > > For current two observers (isolated prerender and optimization > hints manager), this CL adds logic to return early if the > prediction source is an external Android app. > > Change-Id: If42d480f6620e7fa1b99dcb7f55a415f1a26e028 > Bug: 1014210 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920716 > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753843} TBR=tbansal@chromium.org,sophiechang@chromium.org,robertogden@chromium.org Change-Id: Id6ab6ec668d4bfe84f3ee9c25bd216c88eea00a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014210,1065340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124369Reviewed-by:
-
Renato Silva authored
Chrome OS, OOBE, Recommended Apps Screen Reduce the maximum size of the illustration that is shown to the user when the list of apps cannot be loaded. Fixed: 1056795 Change-Id: I4d493f454cb05be96e317dea8290f2e08d0c300f Bug: 1056795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088154Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#753950}
-
Karandeep Bhatia authored
The |json_rules_filepath| argument is redundant, remove it. Also, introduce a new struct TestRulesetInfo, since we anticipate extending WriteManifestAndRuleset to support multiple rulesets. BUG=754526 Change-Id: I85204f8c0dfabdfde6318e7513d6d590964987f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120097 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753949}
-
