GitLab

R=navabi@chromium.org
NOTRY=true
BUG=460630

Review URL: https://codereview.chromium.org/946733002

Cr-Commit-Position: refs/heads/master@{#317448}

The mouse cursor element is positioned relative to the document body (ie, ignoring
the title bar for apps v2). However, its position was being set using the x and y
coordinates of the mouse event, which are relative to the client viewport. This CL
fixes this, using offsetX/Y, which are relative to the target element.

BUG=410473

Review URL: https://codereview.chromium.org/923013004

Cr-Commit-Position: refs/heads/master@{#317447}

This makes the check_includes flag work the way one would expect. Previously we
would only skip include checking if all targets that include a file opt out.
This was coming up in the Android Java enum generator where a header file was
being processed by a script (so includes don't matter and there are no deps)
but that header was also listed as a source in a different target with header
checking enabled (which is always the case for this example).

Improves error messaging for cross-compiling. Previously if you were
cross-compiling and forgot a dependency on e.g. base, you'd get a message "you
must depend on "//base:base" or "//base:base" because it found the files in two
different toolchain builds of base. This patch prunes such duplicates when
possible, and turns on toolchain labels if things aren't all in the same
toolchain.

BUG=

Review URL: https://codereview.chromium.org/946043002

Cr-Commit-Position: refs/heads/master@{#317446}

BUG=

Review URL: https://codereview.chromium.org/936163003

Cr-Commit-Position: refs/heads/master@{#317445}

- It does not need to be virtual.
- Since it is a simple getter accessor it can be inlined in the header
file and thus renamed to just root().

BUG=None
R=dmazzoni@chromium.org,avi@chromium.org
TBR=dtseng@chromium.org

Review URL: https://codereview.chromium.org/940753002

Cr-Commit-Position: refs/heads/master@{#317444}

R=tbreisacher@chromium.org
BUG=393873

Review URL: https://codereview.chromium.org/945093002

Cr-Commit-Position: refs/heads/master@{#317443}

This only affects one of the two callers. --ignore-certificate-error ends up
causing some metrics to record on all errors rather than just certificate ones,
so we end up recording things based on a default-initialized SSLInfo.

BUG=none

Review URL: https://codereview.chromium.org/947453003

Cr-Commit-Position: refs/heads/master@{#317442}

This cl depends on
Chromium:
  - Introduce AppCacheResponseMetadataWriter to support metadata caching.
    https://codereview.chromium.org/932643002/
Blink:
  - CachedMetadata support for ServiceWorker script.
    https://codereview.chromium.org/929953002/

After https://codereview.chromium.org/929953002/, EmbeddedWorkerContextClient.setCachedMetadata/clearCachedMetadata will be called when V8ScriptRunner calls CachedMetadataHandler.setCachedMetadata/clearCachedMetadata in a ServiceWorker.
This cl implements these methods.

When these methods are called, ServiceWorkerScriptContext sends IPC to the broeser process.
ServiceWorkerVersion recieves these messages and calls ServiceWorkerScriptCacheMap.WriteMetadata/ClearMetadata.
ServiceWorkerScriptCacheMap creates ServiceWorkerResponseMetadataWriter to write/clear the metadata in ServiceWorkerStorage.

ServiceWorkerResponseMetadataWriter is a subclass of AppCacheResponseMetadataWriter which is introduced https://codereview.chromium.org/932643002/.

TEST=content_unittests.exe --gtest_filter=ServiceWorkerResourceStorageTest.*
BUG=449895

Review URL: https://codereview.chromium.org/931173002

Cr-Commit-Position: refs/heads/master@{#317441}

+ Dependent on cr/86724062

* Control the banner appearances via a kill-switch via an experiment.

* The app install alert flag in chrome://flags is now used to enable
  or disable app banners for Play Store apps.  Web app banners are
  only affected by the experiment.

BUG=457417

Review URL: https://codereview.chromium.org/941823002

Cr-Commit-Position: refs/heads/master@{#317440}

R=brettw@chromium.org
BUG=354261

Review URL: https://codereview.chromium.org/941863002

Cr-Commit-Position: refs/heads/master@{#317439}

BUG=460572

Review URL: https://codereview.chromium.org/942183002

Cr-Commit-Position: refs/heads/master@{#317438}

BUG=

Review URL: https://codereview.chromium.org/873553004

Cr-Commit-Position: refs/heads/master@{#317437}

BUG=432280,460221

Review URL: https://codereview.chromium.org/946553006

Cr-Commit-Position: refs/heads/master@{#317436}

crrev.com/48bb4848 introduced a new behavior
for menu buttons where they don't enter pushed state if they can be dragged.
Since ToolbarActionView emulates either a LabelButton or a MenuButton depending
whether it has a popup, it should override this.

BUG=458041

Review URL: https://codereview.chromium.org/935163002

Cr-Commit-Position: refs/heads/master@{#317435}

Add a new mode to the JNI generator which emits both native JNI exports
and manual registration code, and use this as the default mode (except
when compiling with clang as a clang bug prevents this from working at
present).

Native JNI exports are stripped from binaries by default to enforce that
the correct manual registration code is called (and to save increasing
the dynamic symbol table size), except for binaries that explicitly opt
in to using native exports (i.e. libwebviewchromium). Native exports are
not compatible with the crazy linker, so cannot be used universally.

The WebView-specific call to InitReplacementClassLoader, required by
native export mode, has been moved to base to make it easy for other
binaries to experiment with that mode.

Manual JNI registration can be disabled with a call to
base::android::DisableManualJniRegistration at the beginning of
JNI_OnLoad and this has been added to WebView. We plan to refactor the
Android library entry points to make it possible to avoid needing this
flag by just not calling JNI registration but the work is still ongoing;
the flag gets us the desired WebView startup time improvement in the
meantime.

BUG=442327

Review URL: https://codereview.chromium.org/920883002

Cr-Commit-Position: refs/heads/master@{#317434}

BUG=457590

Review URL: https://codereview.chromium.org/914963002

Cr-Commit-Position: refs/heads/master@{#317433}

- DRPIOData is a container for IOData lifetime objects, and constructed first.
- DataSaverService is a container for Profile/UI based lifetime objects, and
  constructed second. It can take raw pointers to DRPIOData, since
  DataSaverService is destroyed before DRPIOData.
- DRPIOData (and its classes) then fed a WeakPtr to the DataSaverService.
- DataSaverService is (temporarily) owned by DRPSettings (primarily because
  DRPChromeSettings is the KeyedService) - this will swap in a future CL.
- During KeyedService shutdown, the WeakPtr is invalidated.

Removal of redundant functionality in the DRPSettings:
- I/O thread related functionality (Canary check, IP address change) now lives
  in the Config class, with calls into DataSaverService to use the URLFetcher
- the Settings class no longer is aware of Params, and instead uses the Config
  class for retrieving information - this results in Params construction
  moving from Settings -> DRP IO/Data
- Certain information which is exposed to the UI (via the Settings class) is
  now cached after being retrieved from the Config class (for thread safety)

BUG=452773

Review URL: https://codereview.chromium.org/893003002

Cr-Commit-Position: refs/heads/master@{#317432}

d:\src\cr2\src\url\url_canon.h(737): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\url\url_canon.h(737): warning C4459: declaration of 'empty_string' hides global declaration
d:\src\cr2\src\url\gurl.cc(22): note: see declaration of '`anonymous-namespace'::empty_string'

R=brettw@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/937473003

Cr-Commit-Position: refs/heads/master@{#317431}

R=lcwu@chromium.org
BUG=336640

Review URL: https://codereview.chromium.org/945903004

Cr-Commit-Position: refs/heads/master@{#317430}

Previous CL was (potentially?) incorrect here.

R=rtenneti@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/946003003

Cr-Commit-Position: refs/heads/master@{#317429}

Sometimes the list of last known positions does not contain the full list of
extensions. Fix one such case, and account for any others.

BUG=460393

Review URL: https://codereview.chromium.org/941373002

Cr-Commit-Position: refs/heads/master@{#317428}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8ca446a..8569c5c

TBR=yosin@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/940423003

Cr-Commit-Position: refs/heads/master@{#317427}

bookmark_model.cc uses icu::Collator directly so it should have
direct dependency to icui18n, otherwise there will be a linking
issue on Linux for component builds and configuration_policy==0,
policy_component won't link because of the missing icui8n dependency.
It's a followup of CL 938003002.

Review URL: https://codereview.chromium.org/947443004

Cr-Commit-Position: refs/heads/master@{#317426}

Fix errors. Most of the problems were in net. Moves CreateAndConnectStreamForTesting's declaration to the header corresponding to the file it's implemented in.

Adds the other directories that don't pass yet to the list commented out so
it's easier to see what's still left.

TBR=armansito@chromium.org

Review URL: https://codereview.chromium.org/936953004

Cr-Commit-Position: refs/heads/master@{#317425}

Given access patterns that are just wrong, local & session storage can write many gigabytes per day or keep the disk perpetually spun up. To avoid excessive IO, we apply limits to the amount of data being written and the frequency of writes to address both kinds of 'bad' behaviors.

TBR=rvargas
BUG=176727

Review URL: https://codereview.chromium.org/896643002

Cr-Commit-Position: refs/heads/master@{#317424}

BUG=455349

Review URL: https://codereview.chromium.org/946013002

Cr-Commit-Position: refs/heads/master@{#317423}

TBR=primiano@chromium.org
BUG=459556

Review URL: https://codereview.chromium.org/944823005

Cr-Commit-Position: refs/heads/master@{#317422}

This is part 2/4 of a clean up to switch to int64 time stamps when caching metadata. The background to this is that converting int64 time stamps to double and back to int64 is lossy and causes false time stamp mismatches.

BUG=453298

Review URL: https://codereview.chromium.org/935963002

Cr-Commit-Position: refs/heads/master@{#317421}

Update the WebView's maximum legible scale to be the maximum scale.
This setting was introduced in Blink's r190132.

BUG=456869

Review URL: https://codereview.chromium.org/938173002

Cr-Commit-Position: refs/heads/master@{#317420}

We would like to be able to default to the ARM CPU for
Android builds, not the host cpu (so that you can get the
default Android build by just specifying os="android");
prior to my cpu_arch -> target_cpu changes, this was the
case, but I accidentally broke this.

However, the target_cpu changes at least allow us to remove
the target_arch hack which was how they were accomplishing
this before :).

TBR=brettw@chromium.org
R=cjhopman@chromium.org
BUG=344767
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/946683002

Cr-Commit-Position: refs/heads/master@{#317419}

[AppCache] Avoid frequent small writes and writing during startup by batching together updates to last access times.

BUG=460265

Review URL: https://codereview.chromium.org/924723002

Cr-Commit-Position: refs/heads/master@{#317418}

BUG=460584
TBR=grt@chromium.org

Review URL: https://codereview.chromium.org/948533002

Cr-Commit-Position: refs/heads/master@{#317417}

BUG=460581
TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/937373003

Cr-Commit-Position: refs/heads/master@{#317416}

BUG=460578
TBR=jiayl@chromium.org

Review URL: https://codereview.chromium.org/945043002

Cr-Commit-Position: refs/heads/master@{#317415}

The API is available only on Chrome 42 dev channel, but it's listed
as a stable API since 40 on developer.chrome.com
Adding a note about availability yo API description until this is
fixed.

Review URL: https://codereview.chromium.org/944103002

Cr-Commit-Position: refs/heads/master@{#317414}

BUG=459607,436357

Review URL: https://codereview.chromium.org/937833003

Cr-Commit-Position: refs/heads/master@{#317413}

BUG=none

Review URL: https://codereview.chromium.org/947453004

Cr-Commit-Position: refs/heads/master@{#317412}

Currently we record at the system default sample rate and convert it to the
sample rate required by whispernet. This is no longer needed since Whispernet
now accepts a "broadcast sample rate" which can be different than the encoding
sample rate. To avoid the expensive resampling, we now need to pass the samples
to Whispernet without conversion and tell whispernet what the recording sample
rate was.

Also change the tests to test this functionality.

Reviews requested,
ckehoe@ - General review.
dalecurtis@ - DEPS review for //media

R=ckehoe@chromium.org, dalecurtis@chromium.org
BUG=454885

Review URL: https://codereview.chromium.org/940123004

Cr-Commit-Position: refs/heads/master@{#317411}

Fix a tree breakage caused by network_configuration_handler.cc being
updated to depend on device_event_log.h right before it was moved by
https://crrev.com/4a84927b28b6b55d0ef9e4df59d2e1a14b2b3de2.

TBR=stevenjb@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/942973003

Cr-Commit-Position: refs/heads/master@{#317410}

Revert of sandbox: Fix Win64 porting issue by using SIZE_T instead of ULONG (patchset #3 id:40001 of https://codereview.chromium.org/921353002/)

Reason for revert:
Speculative revert after discussion on IRC, this seems pretty unlikely but may have caused the failures at:

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/35506

Original issue's description:
> sandbox: Fix some nt_internals.h function prototypes for Win64
>
> NtQuerySection should use ULONG instead of SIZE_T as it is dealing with PE section sizes.
>
> NtQueryVirtualMemory should use SIZE_T instead of ULONG as it is dealing with memory sizes.
>
> DynamoRIO, another project that consumes these native APIs, uses the prototypes introduced by this change.
>
> R=robertshield@chromium.org,rvargas@chromium.org
> BUG=458690
>
> Committed: https://crrev.com/4ede4e174a51d08262edfb2e2c05845504bd9b1a
> Cr-Commit-Position: refs/heads/master@{#317177}

TBR=jschuh@chromium.org,robertshield@chromium.org,thakis@chromium.org,wfh@chromium.org,rvargas@chromium.org,rnk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=458690

Review URL: https://codereview.chromium.org/943043002

Cr-Commit-Position: refs/heads/master@{#317409}