- 30 Jan, 2018 40 commits
-
-
Harald Alvestrand authored
This allows to observe how many WebRTC users use the deprecated SDES key agreement style and how many use the DTLS style. Bug: 804275 Change-Id: I0220328a0897e67fde387288ad6ec1475dca3de3 Reviewed-on: https://chromium-review.googlesource.com/891224 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#532847}
-
Yuta Kitamura authored
WebTaskRunner is being deprecated. Use SingleThreadTaskRunner instead. Bug: 794845 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7e4235744a65aaee263e388960366ed2cbebd941 Reviewed-on: https://chromium-review.googlesource.com/893018Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#532846}
-
Nico Weber authored
This CL was uploaded by git cl split. R=bauerb@chromium.org Bug: 177475 Change-Id: I83ec9e5eab7e96de49808c6ce1506aef1ea9bd55 Reviewed-on: https://chromium-review.googlesource.com/891902Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532845}
-
Nico Weber authored
This CL was uploaded by git cl split. R=treib@chromium.org Bug: 177475 Change-Id: I0bda56f41b13861fec0c2b0ffb604fce759d35f8 Reviewed-on: https://chromium-review.googlesource.com/891878Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532844}
-
François Beaufort authored
[Media Engagement]: Add copy to clipboard button and fixed nits described below in about:media-engagement Nits: - "Visits" have been renamed to "Sessions" - "Playbacks" have been updated to "Playbacks per session" - Rows text will never wrap to the next line. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia8892d1ef7ca9a64e196b569d623d03724392706 Reviewed-on: https://chromium-review.googlesource.com/886706Reviewed-by:
Mounir Lamouri (slow) <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#532843}
-
Nico Weber authored
This CL was uploaded by git cl split. R=mkwst@chromium.org Bug: 177475 Change-Id: I82a3074bce458d21c5a12300d54c8bf421a5b4de Reviewed-on: https://chromium-review.googlesource.com/889948Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#532842}
-
Nico Weber authored
Bug: 177475 R=mkwst@chromium.org Change-Id: I1494c1b0bdacea56c741bb0ec2734cff0d5e94ba Reviewed-on: https://chromium-review.googlesource.com/889758Reviewed-by:
-
Andy Paicu authored
The work for reporting has already been done, this only pipes into the content layer CSP the relevant info and then pipes it back down to webkit CSP when reports need to be submitted. Reporting spec: https://wicg.github.io/reporting/ Related: https://chromium-review.googlesource.com/c/chromium/src/+/629083 Bug: 726634 Change-Id: I5d598840e3170fc91de4f9169b66774cbe407ede Reviewed-on: https://chromium-review.googlesource.com/788855 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Marton Hunyady authored
Mirror account consistency can be required by an enterprise policy or in case the signed in user is a child account. This is done by adding the "X-Chrome-Connected: enable_account_consistency=true" header to the request. For regular requests, this is done by chrome/browser/signin/chrome_signin_helper.cc's FixAccountConsistencyRequestHeader, but the local new tab page uses a different code path. Bug: 790970 Change-Id: I81c86075c2b7488639beb4e919d429d53411c6fb Reviewed-on: https://chromium-review.googlesource.com/879141 Commit-Queue: Marton Hunyady <hunyadym@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
Colin Blundell authored
IdentityManager currently is informed of signin and signout events by observing SigninManager. This is problematic when incrementally converting the codebase to use IdentityManager rather than directly using SigninManager: other consumers also observe SigninManager, and the order of receiving observer notifications is not defined between these consumers and IdentityManager. This lack of ordering can result in consumers receiving (e.g.) a notification from SigninManager that signin has occurred while the IdentityManager still believes that the user is signed out. In the long term this won't be a problem, because there will be no direct consumers of SigninManager. However, for the conversion period we need to ensure that IdentityManager is notified of signin and signout events before any SigninManager observers. This CL makes that change by (a) adding a SigninManager::DiagnosticsClient interface whose callbacks fire just before the SigninManager::Observer callbacks (b) changing IdentityManager to modify its internal view of the primary account in response to the DiagnosticsClient callbacks rather than SigninManager::Observer callbacks. This CL also adds IdentityManager unittests of this property that fail before the production change is made. Bug: 796544 Change-Id: I089813d458e122e93b143099ba2a284f972e42fa Reviewed-on: https://chromium-review.googlesource.com/883347Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#532838}
-
Hwanseung Lee authored
reame CSSRotation to CSSRotate for consistency with others. https://github.com/w3c/css-houdini-drafts/pull/598 https://drafts.css-houdini.org/css-typed-om-1/#cssrotate Bug: 806736 Change-Id: Ibb62074598d1840b11be0b03cdeb253377038ccf Reviewed-on: https://chromium-review.googlesource.com/890157 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by:
nainar <nainar@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#532837}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/2baa39e81d42..f61b3ba65e3d $ git log 2baa39e81..f61b3ba65 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I71f7a1086e3123e5115c8b0f72eec45c474723a5 Reviewed-on: https://chromium-review.googlesource.com/892960 Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#532836}
-
Yuta Kitamura authored
WebTaskRunner is being deprecated. Use SingleThreadTaskRunner instead. Bug: 794845 Change-Id: I10f65dd1db120a489a61519d344aaada31c4fe32 Reviewed-on: https://chromium-review.googlesource.com/892724Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Pavol Marko authored
Sync latest proto changes from the server side. Bug: none Change-Id: I017024392d98a3b680e3340e4e8faae976436dbb Reviewed-on: https://chromium-review.googlesource.com/891859Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#532834}
-
Zhuoyu Qian authored
This is part of the gradual process of putting all types that derive from CSSValue into blink::cssvalue:: namespace. Bug: 667961 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ifaaa877a2395e1eb876624b2f351d6ace325b913 Reviewed-on: https://chromium-review.googlesource.com/892547 Commit-Queue: nainar <nainar@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
This is part of the gradual process of putting all types that derive from CSSValue into blink::cssvalue:: namespace. Bug: 667961 Signed-off-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cbd2275f..bf50906e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib908f5a484eb87be0ce3458e551e792f49a56d07 Reviewed-on: https://chromium-review.googlesource.com/892261Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#532831}
-
Daniel Vogelheim authored
Add use counter to support an upcoming origin trial. Count how many signatures are being checked, and how many of those were checked successfully. Change-Id: I12fdeb9e4c3444d2920ff87d6fff681c98eba40b Reviewed-on: https://chromium-review.googlesource.com/883804 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Network traffic annotations presubmit check returned an error if there was run-time errors. This was not an intended behavior as in error resilient mode, there might be some run time errors that will not block the CL from landing. The script is updated to return the exit code that auditor returns in all cases. Bug: 690323 Bug: 807146 Change-Id: Ic5a34511a78a3607b5e2071b267180236e88f358 Reviewed-on: https://chromium-review.googlesource.com/892858 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#532829}
-
Mounir Lamouri authored
The autoplay visibility observer is reset in various situations but wasn't when the source of the video was change which broke use cases such as playing A then switching to B. B would freeze to the first frame and never update. Bug: 804091 Change-Id: I984d4c5d67c575d3c45f50877d329264c1a6020e Reviewed-on: https://chromium-review.googlesource.com/890942Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#532828}
-
Yutaka Hirano authored
This is a reland of [1] which got reverted because of some link errors. This change moves some features defined in /content/public/common/content_features.h to /services/network/public/cpp/features. They need to be defined in /services/network in order to move /content/network files to /services/network. 1: https://chromium-review.googlesource.com/c/chromium/src/+/874980 Bug: 754918, 804769 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id2aec8ec1e000eb2542a89d1788d46adab476087 Reviewed-on: https://chromium-review.googlesource.com/890898 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#532827}
-
Matthew Cary authored
The previous change which disabled it for all ASAN was overeager, the bug only appears on clang. Bug: 804348 TBR: thestig@chromium.org,brettw@chromium.org,aberent@chromium.org Change-Id: I8ae959bce00feb1f77b23dda979ed129bd88b003 Reviewed-on: https://chromium-review.googlesource.com/892440 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#532826}
-
Thomas Tangl authored
This CL changes the vector icon used for the "Open Guest window" hover button. Bug: 786369 Change-Id: Ia45555c1e0beb750d11597bb34f8e8d901f85d79 Reviewed-on: https://chromium-review.googlesource.com/890939Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#532825}
-
tzik authored
VideoPlaybackQuality.idl and MIDIOutput.idl uses double as the time type. However, the specs are updated at some point to usp DOMHighResTimeStamp. https://wicg.github.io/media-playback-quality/#idl-def-videoplaybackquality https://webaudio.github.io/web-midi-api/#MIDIOutput Change-Id: Ib9d7e9a5c066ab673c880cbda3d22817fcff961d Reviewed-on: https://chromium-review.googlesource.com/892841Reviewed-by:
-
David Roger authored
- Now records "EnableSync" responses - Now records "SignoutPrimary" correctly during Dice migration Bug: 736310 Change-Id: I5b4e8e60ecaab18cac2454986f5849565529976a Reviewed-on: https://chromium-review.googlesource.com/891220Reviewed-by:
-
chrome://historysangwoo.ko authored
This shorcut will select or unselet all items. Bug: 792897 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9d0854c6e8bee90c947c741fc0ac4d14acd28e9d Reviewed-on: https://chromium-review.googlesource.com/885692Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#532822}
-
Kent Tamura authored
We had a bug that createElementNS() ignored prefixes. New behavior matches to the specification and Firefox. * Document-createElementNS.html: Fix a copypasta error. * ScriptCustomElementDefinition::CreateElementSync: Implement Step 6.1.10. * Document::createElementNS: Fix an argument of definition lookup. * CustomElement::CreateUndefinedElement: Use Document::CreateRawElement(), which sets prefixes correctly, instead of HTMLElementFactory::createHTMLElement(). * ustomElementDefinition::CreateElementAsync: Use Document::CreateRawElement(), which sets prefixes correctly, instead of HTMLElementFactory::createRawHTMLElement(). Bug: 806639 Change-Id: I74b431d4475d7cf84f65ab0ff1b24773cbc64079 Reviewed-on: https://chromium-review.googlesource.com/892802Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#532821}
-
Mostyn Bramley-Moore authored
This fixes the following error in jumbo builds: /../../third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDelegateTest.cpp:51:46: error: unknown class name 'Test'; did you mean '::testing::Test'? class ScreenOrientationDelegateTest : public testing::Test { ^~~~~~~~~~~~~ ::testing::Test Followup after https://chromium-review.googlesource.com/c/chromium/src/+/848735 TBR=haraken@chromium.org Bug: 678545 Change-Id: Ide6d0c6c0c7b8f1d45acad9aeca1e7998e5fa94e Reviewed-on: https://chromium-review.googlesource.com/891959Reviewed-by:Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
-
Kunihiko Sakamoto authored
We're rolling out this feature. The feature flag is enabled by default at ToT. Bug: 705400 Change-Id: Iccaa68d13a6d1989870bdb596f231b30cb4d7f00 Reviewed-on: https://chromium-review.googlesource.com/892189Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#532819}
-
Nico Weber authored
This CL was uploaded by git cl split. R=vabr@chromium.org Bug: 177475 Change-Id: I9f5deffdff32fbb2b733a3d3b8110638bac04bbb Reviewed-on: https://chromium-review.googlesource.com/891779Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532818}
-
Bhagirathi Satpathy authored
This patch contains 1. Test added to verify [TreatNullAs=EmptyString] behavior of |mediaText| attribute of MediaList. 2. Update MediaList |mediaText| IDL attribute to match the specification. https://drafts.csswg.org/cssom/#the-medialist-interface Bug: Change-Id: I6cf9380390113e3ec8f37c796b0f6fd68e2de6c8 Reviewed-on: https://chromium-review.googlesource.com/892718 Commit-Queue: Bhagirathi Satpathy <bhagirathi.s@samsung.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#532817}
-
Megumi Hattori authored
When the inline reply row is appering right after a "REPLY" button is clicked, the row is light gray first, and change to blue like ink drop. Bug=803757 Change-Id: Ie2e482be0de5edae2ff581c84c755545cd3beaf5 Reviewed-on: https://chromium-review.googlesource.com/890979 Commit-Queue: Megumi Hattori <megumihattori@google.com> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#532816}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/e4741fd0f2bc..5dd4ad896bcb $ git log e4741fd0f..5dd4ad896 --date=short --no-merges --format='%ad %ae %s' 2018-01-29 jmadill Vulkan: Add a perf test for the Pipeline cache. 2018-01-25 oetuaho Resubmit: Use ImmutableString for HLSL texture references 2018-01-29 oetuaho Only return symbol from TSymbolTable::find Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ibcca7649679b317324dc3a5d22c1aa07545e86ac Reviewed-on: https://chromium-review.googlesource.com/892367 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532815}
-
Matt Falkenhagen authored
R=horo Bug: 780435 Change-Id: Ie8ae9cf8dca55f122a7b4a984ca0a96035b0099f Reviewed-on: https://chromium-review.googlesource.com/892683Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#532814}
-
Shanmuga Pandi M authored
Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/o9Pnen-jNcI Bug: 534245 Change-Id: Iac7c42c1f284f5022ce2043acccafc05ff7c8e9c Reviewed-on: https://chromium-review.googlesource.com/883064Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#532813}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/10835cef..cbd2275f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic9ba6a2a79bb613bec2eebaa32fa52f3b8347886 Reviewed-on: https://chromium-review.googlesource.com/892639Reviewed-by:
-
Christos Froussios authored
The different states of the export flow are implemented as separate dialog instances which replace each other. Mocks: https://docs.google.com/presentation/d/1nIm5OmaOnb85ZAwMZPSVqHT0vkFbsRYZhOzbmznWU_c/edit#slide=id.g289b1efcd8_0_4 Bug: 789561 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id25af371164196ee8fffec723f080be2320e5b22 Reviewed-on: https://chromium-review.googlesource.com/800611Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#532811}
-
Vaclav Brozek authored
The OverrideState enum is converted in this CL to plain integers and @IntDef for efficiency. More context on the associated bug. Bug: 806315 Change-Id: Ie7b5d777394ca77c9f9447d8db33754bcf9f7017 Reviewed-on: https://chromium-review.googlesource.com/889738Reviewed-by:
-
Raphael Kubo da Costa authored
Nullable<T> is bindings-specific and does not seem to offer any advantage over WTF::Optional<T> and its //base counterpart, which are more widely used and maintained. Using Optional<T> with a garbage-collected type remains forbidden, but using it with a GC container type such as HeapVector is OK. Most of the changes in this CL are fairly mechanical: replace includes and adjust to API differences (.value() instead of .Get(), WTF::nullopt instead of nullptr etc). Everything should remain the same in terms of functionality. Bug: 798464 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I988f7cb4a941439cb9a6ab0d2c3bc26c78e59f00 Reviewed-on: https://chromium-review.googlesource.com/891178 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Ke He authored
Move the screen_orientation_dispatcher from //content/renderer/ to //blink. After the moving, the screen_orienation_dispatcher actually acts as a delegate of ScreenOrientationControllerImpl, it holds a device::mojom::blink::ScreenOrientationAssociatedPtr by which to send lock or unlock requests to browser process. So in blink, we rename it as ScreenOrientationDelegate. After the moving, the WebScreenOrientationClient interface has no reason to exist anymore, so we delete it. The layout-test needs to be migrated from using WebScreenOrientationClient to mojo. So in MockScreenOrientationClient, we provide a fake mojo implementation of ScreenOrientation and override the AssociatedInterfaceProvider in frame level. The unittest of original screen_orientation_dispatcher is moved to webkit_unit_test. Some other unittests which have dependencies on the removed WebScreenOrientationClient are also fixed. BUG=678545 Change-Id: If02f7661d53bbba83e368182f0e10f04b89c5fbe Reviewed-on: https://chromium-review.googlesource.com/848735 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by:
-
