- 14 Oct, 2020 40 commits
-
-
Xianzhu Wang authored
We still have several bugs about transform animation to fix. Bug: 1101002 Change-Id: I8ca37e70fd0391ee3b43c5e63e3436b810e169c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471817Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817219}
-
Eugene But authored
Synthetic crash reports created for UTEs (unexpected termination events) to provide some information about the crash. Synthetic crash reports can contain Breadcrumbs, session uptime, OS version, Device Type and other similar information to understand why app has crashed. Variations will help with slicing crashes by Finch study and look for culprits among launched features. Bug: 1103752 Change-Id: I440d5acaf7fab5b5d81d6137e2ae4603c78e5330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462822 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817218}
-
David Tseng authored
This was done back in https://chromium-review.googlesource.com/c/chromium/src/+/2231660 likely to support sending arrow keys in a prior iteration to support combo boxes. R=dmazzoni@chromium.org Fixed: 1137612 Change-Id: Iaa974ae8eecafc16612df092a5ebba36031a7d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472529Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#817217}
-
Emircan Uysaler authored
This CL adds Scenic commands that present the overlay ViewHolders as a part of the scene graph. This takes scale, translation and blend mode that is decided by the overlay processor into account. We also add a workaround that creates tiny elevation steps to avoid possible z plane errors from Scenic. ViewHolder interactions happen into ScenicSurface and its session. Presenting the view and video content happens through a different channel in ScenicOverlayView class. Bug: 1127984 Change-Id: Ib0cdddf77d3bf068c1ab1dd52974c5b664a374bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450892 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#817216}
-
Mehran Mahmoudi authored
When StartSurface experiment is enabled, it will either: 1. Be shown on startup if a certain condition is met, or 2. Not be shown on startup. Currently, paint preview is not displayed on startup if StartSurface is enabled, regardless of whether StartSurface will be actually shown or not (1 or 2 above). This CL will display paint preview on startup if StartSurface is enabled AND it won't be shown on startup (scenario 2 above). This is done by making sure that ReturnToChromeExperimentsUtil#getTotalTabCount works correctly when it's called pre-native and PAINT_PREVIEW_SHOW_ON_STARTUP experiment is enabled. Bug: 1134752 Change-Id: I4d51396d82bee837184db038198770905a7f972c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472432 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#817215}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602676072-ebb21a5d77144e96fd6267407ee41b0443253d5d.profdata to chrome-linux-master-1602698313-2c5e1ad3bbb75ee9feac0a345669fda97d41b13c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1f012bc29571acf2230a7e215fa0a236fc1511d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472625 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817214}
-
Nicholas Hollingum authored
Based on a discussion with Chrome Sydney C++, it is preferable not to have fine-grained Keyed services, and instead use an approach like the WebAppsPlatform does. Diagram in go/borealis-arch. Reasons given were: 1) Complicated crashes for getting keyed service per Profile-type (incognito OTR. guest, login-porile see http://go/chromium-profile-types) 2) Two-pass shutdown but no symmetric Two-pass Setup (circular deps) 3) The base classes API which you don't own (inability to control it) 4) A dependent KeyedService may enforce the creation of the dependee KeyedService for the unwanted profile type 5) 2 .cc + 2 .h files for each service (instead of simple one .cc + .h pair) 6) Simplicity vs overkill Bug: b/170596931 Change-Id: Iee61e29b5ac29abf1ba9b00b4939ffea65bd8be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465887 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nancy Wang <nancylingwang@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#817213}
-
Klaus Weidner authored
Update the frame time estimate to take into account ARCore's min/max framerates. Change-Id: I6177adff2093dbf59aabcb6db3bc6fc8ee625bc9 Bug: 1136276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468183 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#817212}
-
Scott Violet authored
It should only be set if overflow: clip is specified along both axis. BUG=1087667 TEST=StyleAdjusterTest.AdjustOverflow Change-Id: I3cddaf8b1b6e5041759762284f150f28b7b7662a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463749 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#817211}
-
Nick Czajka authored
This change sets all DisplayManager.* histograms to have expiry date 2021-07-15 and owners zentaro@chromium.org, cros-peripherals@google.com. This should make auditing easier as all notifications about histogram expirt will be sent to the same people at the same time. Bug: 1088714 Change-Id: Iae992cd4dfcf071447894add22acf7f2bccae1e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468303Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Nick Czajka <czajka@google.com> Cr-Commit-Position: refs/heads/master@{#817210}
-
Emircan Uysaler authored
This CL adds the necessary steps to allow fuchsia video frames that are associated with an independent ImagePipe to be promoted as overlays. This is mostly done though NativePixmap interface. - Note that, "use-overlays-for-video" flag added in a previous CL allows fuchsia to associate video frames with an independent ImagePipe through ScenicOverlayView class. - Adding NativePixmap::SupportsOverlayPlane() to query platform specific instances for overlay support. Fuchsia's SysmemNativePixmap checks for ScenicOverlayView association. - Add OverlayManagerScenic to filter overlay candidates. - Allow access to the underlying pixmap in SharedImageInterface through gpu::VulkanImage. Bug: 1127984 Change-Id: I1f76deb28c4b94e948f600061caf7215f2ee1382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446523 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#817209}
-
Aaron Leventhal authored
Make [de]serialization errors fatal any time DCHECK is on. Bug: None Change-Id: I6edaf9a44fc086916cda04ce353c03e5b50d3d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468238Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#817208}
-
Steven Bingler authored
Also removing obsolete cookie deprecation field trial entry as it is default enabled on ToT. Bug: 1030938 Change-Id: Id77635538483a0b976581b1e56af551003d81ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472344 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#817207}
-
Roberto Moura authored
Change-Id: Ie435c2d1b92b8595e1a8ee8dcdff757b8ca8d0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467880 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#817206}
-
Elaine Chien authored
Bug: 772945 Change-Id: I424e8f9f56737db9bf6deefd9e35d4169523b814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466619 Commit-Queue: Elaine Chien <elainec@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#817205}
-
Prakhar authored
coverage is now enabled on mac-rel Bug: 1024915 Change-Id: If210d6e3cced0be8101be70530940086e979aa73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473077 Commit-Queue: Prakhar Asthana <pasthana@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Prakhar Asthana <pasthana@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#817204}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cc40f8a7..ba4c87c9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I847885242fb7c317f2dfa2cbab09f8cdb589b134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472260Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817203}
-
Trevor Perrier authored
This CL uses updateConfiguration instead of applyOverrideConfiguration. The use of applyOverrideConfiguration is causing issues when loading language splits for non system languages. Resources.updateConfiguration is a deprecated method for overriding a Context configuration on the onCreate method of an Activity. Bug: 1128698, 1136096 Change-Id: I0a57963a245c69fd9bbef978267a94b1cb00b072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446991Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#817202}
-
David Tseng authored
R=rsorokin@chromium.org Change-Id: Ic88750f027faf3ef78bc0becdbadfc847afdc04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470749Reviewed-by:
-
Gayane Petrosyan authored
Bug: 1133910 Change-Id: Ie7c7758e939c0ff6bee6d64ae03ed0b7c13ea808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464044 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#817200}
-
Fabio Tirelo authored
TBR=tkent@chromium.org Bug: 1138589, 1138591 Change-Id: I3da96df78f549881d1f307469aa5532b7a289623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472343Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#817199}
-
Ryan Heise authored
Change-Id: Ie6c02304de3ea490d9f46d3b4fde53487d3478d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469442Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ryan Heise <heiserya@google.com> Auto-Submit: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#817198}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/49681b598556..61aa96cc7a59 2020-10-14 bingler@chromium.org Add Schemeful blocked cookies front end explanations 2020-10-14 kprokopenko@google.com Icon component If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1126031,chromium:1136839 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id6487daa8ddce3182891c105b2eb25355302b578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472079Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b82c2d3bf1e1..fa0140b92951 2020-10-14 sugoi@google.com Fix CommandPool memory management If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1107112 Tbr: swiftshader-team+autoroll@google.com Change-Id: I6a9181fa60ff0255907bd1b0c3e4974d6a44e394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472620Reviewed-by:
-
Andrew Grieve authored
Test symbols were missing containers. Bug: None Change-Id: Icb33385f0790942324cad23829c0fba3e7639c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463704Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#817195}
-
David Tseng authored
This change handles a corner case where the tts utility process stays around after the component extension gets unloaded. On re-load, the utility process is re-started correctly without this change (i.e. there are not multiple tts utility processes run), so this change is a minor cleanup. R=dmazzoni@chromium.org Test: trigger tts (e.g. via ChromeVox), attach to the utility process and wait for the tts component extension to be evicted after 15 seconds. Verify the utility process exits cleanly. Change-Id: Ieadf44d45ba902e298bf4497bc7433d44aa1a6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471803Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1410c33130bc..ca4153fa8b09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie8ed2ffa0080c2941c117b67d0e2874da6f86d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472604Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1410c33130bc..ca4153fa8b09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I38cd4bad5115d3fde9e4443c6985fdde08b40fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472426Reviewed-by:
-
Daniel Rubery authored
Since there are two kinds of FileTypePolicy (from Component Updater and a local resource bundle), these histograms are useful in identifying when we update one but not the other. Change-Id: I371e4c6ce5b8b23f482eb7a5cce1db67355d072c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469444Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#817191}
-
Lei Zhang authored
Add some new owners and note what areas some owners specialize in. Change-Id: I4767a7eca92251d636c146ae69f185a920dd1018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454850 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#817190}
-
Victor Costan authored
Change-Id: I836b9412f915cdebeff46883c535b83026ed6472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463873Reviewed-by:
-
Nicholas Hollingum authored
This is in-line with the nomenclature used in crostini/concierge/cicerone/etc. This is also needed because in a forthcoming CL we will need to know the container name separately from the VM name. Bug: b/162562622 Change-Id: I05cbe5d803bebe351fe57e2214895ae284d7f0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469418Reviewed-by:
-
Nicholas Hollingum authored
Errors will be reported via a result, which will hold either the context (on success) or an error status + message (on failure). We also tweak the callback slightly such-that callers are forced to deal with the result, where previously a bad startup was indicated by a certain field of the context. This allows you to treat the context as a state-object, i.e. if you have a reference to it then borealis must be running correctly. Bug: b/162562622 Change-Id: I17d4ae8ddff811e18a5bd057f54c7fa02ccbf13a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467818Reviewed-by:
-
Joshua Bell authored
I think this was unblocked by the change in: https://chromium-review.googlesource.com/c/chromium/src/+/2406233 Change-Id: I28e327c9caa73ada790e10fe71817b204dbf1352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469898 Auto-Submit: Joshua Bell <jsbell@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#817186}
-
Prashant Nevase authored
This patch adds plumbing code needed to call blink dark mode filter in compositor. The dark mode filter created in blink will be used for applying dark mode to images during rasterization. Bug: 1094005 Change-Id: I620e8ab8b6dbb6d9050a3696e37ff2e89d6728b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452091 Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
-
Hazem Ashmawy authored
This relands https://crbug.com/c/2438534 with a couple small changes: - android:windowSoftInputMode="adjustPan" attribute was missing in the test manifest but is used in prod manifest. Adding it to the tests manifest fixes the problem of auto-showing the keyboard on M devices which was causing the test flakiness. When the keyboard shows up it hides the view causing espresso to fail. - Merge the small change from https://crrev.com/c/2455687 to test whether the overrideFlagsMap has the correct entries. Fixed: 1135839, 1130599 Test: run_webview_instrumentation_test_apk -f "*FlagsFragmentTest*" on android M emulator Change-Id: I973e8cd2b7a9c12651d7a6e14f11a368f6e06bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453564Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#817184}
-
Alex Turner authored
Many uses of IdentifiabilityStudySettings::Get()->IsActive() and IsUserInIdentifiabilityStudy() are converted to more specific calls that check whether the corresponding type or surface is allowed. This will allow for the individual types or surfaces to be disabled via finch, instead of relying on an all-or-nothing approach. All users of the deprecated IsUserInIdentifiabilityStudy() method are migrated in this cl, so we also remove the method. Additionally, IdentifiabilityStudySettings::IsWebFeatureAllowed() is added as a convenience method. Bug: 973801, 1136938 Change-Id: I9b20a4f1c10154f2dd8ac6fa104e31197b2e0e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469258Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#817183}
-
Sadrul Habib Chowdhury authored
The display compositor (viz) can skip over some frames for various reasons, e.g. if the client is non-responsive, or if the gpu is busy processing previous frames, etc. For these skipped frames, no corresponding CompositorFrameReporter object is created. As a result, there are no PipelineReporter trace events, which can make it confusing when looking for dropped frames. To fix this, for every started frame, create reporters for any earlier frames that were skipped over by viz. BUG=1138086 Change-Id: I0b7f90de19d1148ccdb4e1877ee2e56e7ffad717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469777 Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Reviewed-by:
Mingjing Zhang <mjzhang@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#817182}
-
Chris Harrelson authored
This avoids crashing, and should not introduce any bugs that were not already there. Bug: 1138056 Change-Id: I4f67e003093141eee197c928a9b48cbecf66040d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472937Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#817181}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ca4153fa8b09..0581509dc2dd 2020-10-14 hjd@google.com Merge "Add fastrpc_dma_stat" 2020-10-14 hjd@google.com Merge "ui: Improve rendering of incomplete slices" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iaeff758e806c1c8b04d2f5abe0d7069906424e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472698Reviewed-by:
-
