GitLab

This CL replaces the turn-on-sync illustration in the user menu
with a new asset. The code to create the signin/turn-on-sync view
is refactored and the spacing is adjusted.

Bug: 811510
Change-Id: Ifd2155a20c79918b046eca96b94ccb59481ce5d1
Reviewed-on: https://chromium-review.googlesource.com/919281
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537303}

This CL:
 1. Refactors AutocompleteMatch so that we can't accidentally swap the
    contents and description of matches stored in the model code.

 2. Consolidates some swapping behavior living in the UI code in with
    the rest of the swapping behavior.

 3. Fixes ZeroSuggest swapped title and description for Cocoa.

Bug: 807702
Change-Id: Ibb17860122a52a9fba7df707ab2c18ac327297ac
Reviewed-on: https://chromium-review.googlesource.com/912101Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537302}

1. WebRtcRemoteEventLogManager did not always update the counts
   for active and pending logs correctly; this CL fixes the issue.
   For that fix, it was necessary to put the BrowserContextId as
   part of the PeerConnectionKey, so that when a log file is
   closed, we would be able to decrement the active logs count for
   that BrowserContext.
2. The opportunity is also taken to restructure some of the code:
   a. The internal methods now operate on PeerConnectionKey, rather
      than accept the render_process_id and lid separately.
   b. Additional DCHECKs were added to verify that the log count
      remains consistent.
   c. Removed the assumption that DisableForBrowserContext() would
      only be called during Chrome shutdown.

Bug: 775415
Change-Id: I33c327e2160b3035f6d413262b54b10887b37454
Reviewed-on: https://chromium-review.googlesource.com/918682
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537301}

This consolidates Chrome's behavior to be consistent everywhere
CompositeOperations are parsed, and to match Firefox. When a
CompositeOperation is found that we don't support, it is silently
replaced with kCompositeReplace.

When running without WebAnimationsAPI, developers should only expect to
have kCompositeReplace animations. When running with WebAnimationsAPI,
developers can detect which composite is in use by either querying:

  effect.composite;

  OR

  effect.getKeyframes(); // Check each keyframe for a keyframe-specific composite value.

Intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wRsafuGKr5w

Bug: 806139
Change-Id: I80fefff3fc833b62787c57d22cbec656365ec374
Reviewed-on: https://chromium-review.googlesource.com/896807
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537300}

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I19ac155dd3d809ccd5e770dc67fc5db5dc4679a2
Reviewed-on: https://chromium-review.googlesource.com/923505
Commit-Queue: Eric Noyau <noyau@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537299}

We cannot hold onto a lock that could potentially block the UI thread,
while calling into any getter in WebViewChromiumAwInit related to
chromium initialization. This is because those getters
1. hold a lock,
2. post a chromium-initialization task to the UI thread, and then
3. wait for the task to finish after releasing the lock in 1
So if thread X holds another lock, and calls a WebViewChromiumAwInit
getter, a deadlock occurs if the UI thread tries to hold onto that other
lock before running the chromium-initialization task.

We fix this issue by providing a getLock() method on
WebViewChromiumAwInit for WebViewChromiumFactoryProvider to re-use the
existing lock to guard its member variables (instead of using another
lock).

Bug: 812203
Change-Id: I2e8d69f2667bce1e4312cc821fc804d44b6deaba
Reviewed-on: https://chromium-review.googlesource.com/922823
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537298}

Bug: 812531
Change-Id: I0a9d54b28ef7e17d94358a692f7a2259130210a1
Reviewed-on: https://chromium-review.googlesource.com/920991Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537297}

Add a completionBlock parameter to ClearBrowsingDataCommand and
use it to wait for the completion of the browsing data removal
in BrowserStateDataRemover.

This allow removing the circular dependency between i/c/b/signin
and i/c/b/browsing_data and to simplify code.

Bug: none
Change-Id: I6ee62201dd321a453be8d7d6d588a8e713735d5f
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/916607
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537296}

Running glint and clang-format on JavaScript files.

Bug: 487804, 802170
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic13a1a141b74b761b83d5aee20c0f4bff384b57b
Reviewed-on: https://chromium-review.googlesource.com/919263Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537295}

Lock annotations mechanism was ported from Abseil in this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/885506

This mechanism provides Clang's built-in support for static lock analysis. This
would be really useful for workers, especially WorkerThread.

Bug: 812222
Change-Id: I88d4e24ea8a2d93edf126d61148d4c7aec060901
Reviewed-on: https://chromium-review.googlesource.com/919321Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537294}

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Note that this CL adds a usage of default timer task queue via WebThread
::GetTaskRunner(), but I think this is inevitable.

Bug: 624694, 804694
Change-Id: I3a18dc9908850096050de16c66f3c78aa0e3c666
Reviewed-on: https://chromium-review.googlesource.com/923833Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537293}

TaskQueueSelector had the logic to report when a task was prevented
from running due to one of RendererScheduler's interventions.
This feature is deprecated and now removed for sake of simplicity.

Bug: 783309
Change-Id: I0debabf6a9c340bacf780a03259006449006292e
Reviewed-on: https://chromium-review.googlesource.com/921963
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537292}

There were two problems:

1. We determined start/end inline margins from the direction of the
child, while we should use that of the containing block.

2. We applied alignment based on text-align:-webkit-{left,right} even if
there was an auto inline-end margin (so that we would override it).
Standard CSS declarations should take precedence over legacy HTML align
attributes (which is where text-align:-webkit-{left,center,right}
typically come from).

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ib0a22a6293b4b2b2668d09453db16b42ef9ff258
Reviewed-on: https://chromium-review.googlesource.com/922664
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537291}

Network Traffic Annotation Auditor adds the following switch when
calling the clang tool: '-Wno-tautological-unsigned-enum-zero-compare'

Also to be faster, auditor does not rerun the clang tool to get errors
when called in error resilient mode.

Bug: 690323
Change-Id: Ie099b902395da5c4bb9526925d71b6dd4b94c290
Reviewed-on: https://chromium-review.googlesource.com/924061
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537290}

Allows the voice search button to display alongside the delete icon in
the omnibox, as long as voice search is enabled. Hides the feature
behind a flag.

Bug: 807726
Change-Id: I3695222b9ca0f74673ca286e052b121fdfde924b
Reviewed-on: https://chromium-review.googlesource.com/896002
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537289}

https://chromium.googlesource.com/external/leveldb.git/+log/ca216e493f32..41172a24016b

This CL also adds Clang thread safety annotations [1] to Chrome's
leveldb::port::Mutex. This can't be done in a separate CL because the
primitives are used in Chrome code that is compiled with -Wthread-safety
turned on.

[1] https://cs.chromium.org/chromium/src/base/thread_annotations.h

$ git log ca216e493..41172a240 --date=short --no-merges --format='%ad %ae %s'
2018-02-13 costan Enable thread safety annotations in open source version.
2017-10-25 cmumford Add leveldb_options_set_max_file_size to the C API.
2017-10-23 cmumford Fixed style guide link in CONTRIBUTING.md
2017-10-19 cmumford Deleted unused assignments in Reader.
2017-10-17 cmumford leveldb::DestroyDB will now delete empty directories.
2017-10-10 costan Fix typo (forgotten reference operator) in test.
2017-10-10 costan Replace SSE-optimized CRC32C in POSIX port with external library.

Created with:
  roll-dep src/third_party/leveldatabase/src

Change-Id: I68dc2799673a93253bc338b141e0945b11db097a
Reviewed-on: https://chromium-review.googlesource.com/920773Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537288}

We no longer have WebTaskRunner, and the function is now essentially
identical to GetSingleThreadTaskRunnerForTesting().

This patch removes CreateWebTaskRunnerForTesting() along with its helper
class, and migrates all the call sites to GetSingleThreadTaskRunnerFor-
Testing().

Bug: 794845
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I11094734d79aca4dbf4d7b191df6adb76cce19c1
Reviewed-on: https://chromium-review.googlesource.com/923869Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537287}

In addition to setting request priority in the request itself, add it as
a get parameter to the fetch url.

This is needed for load shedding later.

Bug: 809986
Change-Id: I4d6520218d6ef9d25feada409cf894485e3e2872
Reviewed-on: https://chromium-review.googlesource.com/913618Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537286}

This CL adds a submenu arrow to the "Sync to another account"
button in the user menu to match the mocks under:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr68h8u9rYJdKa9KgqJ7geGGg

Bug: 786369
Change-Id: I9c3bad79535ba69bd1dc3bdf775fb059c608bba9
Reviewed-on: https://chromium-review.googlesource.com/919483
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537285}

Of the code pieces left to add jumbo support to, the one which benefit
the most from jumbo is //chrome/browser:browser which goes from 90 to
10 CPU minutes, a reduction of more than a CPU hour. This is about 10%
of the total effort compiling chrome+content_shell+blink_tests.

In jumbo builds many cc files compile in the same translation unit
which reduces the time spent generating debug data and machine code
for headers, as well as the time to actually process the headers.

Bug: 746957
Change-Id: I856f3fca1f16fa2b0738678444c455c303985962
Reviewed-on: https://chromium-review.googlesource.com/899368Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#537284}

1) Audio service is embedded into /content. For that DeferredSequencedTaskRunner for Audio service
is introduced in BrowserMainLoop. This task runner is passed into AudioServiceContext and queues
all the requests to the Audio service and its factory until it is started. And it is started after
AudioManager is created in BrowserMainLoop::BrowserThreadsStarted().

2) audio::CreateAudioSystem() is introduced as a replacement to
media::AudioSystem::CreateInstance(). At this point it still creates media::AudioSystemImpl
instance.

This CL does not change execution path, and (hopefully)  should not be a source of regressions.
The actual switch to using Audio service and audio::AudioSystemToServiceAdapter happens in
the follow-up https://chromium-review.googlesource.com/c/chromium/src/+/918901.

So if something breaks https://chromium-review.googlesource.com/c/chromium/src/+/918901 should
be reverted first (and most likely that should be enough).

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie69df7bf9f593fda6a2e85f5f57a49a90aeccdb9
Bug: 792441
Reviewed-on: https://chromium-review.googlesource.com/875927Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537283}

We incorrectly assumed it was called only once.  This patch fixes that
assumption.

Change-Id: I9d8e624634260ca1e352d9419e84b52e64e627a4
Reviewed-on: https://chromium-review.googlesource.com/921082
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537282}

This is the first in a series of patches to implement tabs.removeCSS

A style sheet injected with tabs.insertCSS will have an internal
autogenerated "key" that will be passed to StyleEngine. In the case of
files, this will likely be just the fully qualified name of the file,
whereas in the case of code it could be the code string itself or a hash
digest of the code string. In either case, a call to tabs.removeCSS with
the same options will deterministically generate the same internal key,
thus enabling the removal of a previously injected style sheet without
the explicit use of IDs and such.

This patch lays the groundwork in StyleEngine that will enable us to
implement behavior similar to that observed in Firefox 57.0.

Changes:

 1.  WebStyleSheetId is now WebStyleSheetKey (WebString)
 2.  WebDocument::InsertStyleSheet now accepts an optional key as a
     parameter
 3.  StyleEngine::InjectSheet and StyleEngine::RemoveInjectedSheet now
     take StyleSheetKey (AtomicString) instead of WebStyleSheetId
 4.  Both WebDocument::RemoveInsertedStyleSheet and
     StyleEngine::RemoveInjectedSheet now take the CSS origin as a
     parameter
 5.  StyleEngine::RemoveInjectedSheet now removes only the last style
     sheet injected with the given key and only from the specified
     CSS origin

BUG=608854

Change-Id: Ie62bfcb0d8309b18cbf0d2cd119c74908e396767
Reviewed-on: https://chromium-review.googlesource.com/877663Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Manish Jethani <m.jethani@eyeo.com>
Cr-Commit-Position: refs/heads/master@{#537281}

kLegacyUserAgentV0 type is gone, and now 2 bits are enough to
hold the type for ShadowRoot, instead of 3.

Bug: 787717
Change-Id: I64b00c9ac79d8d43830ac94cb5bd013a9043dcca
Reviewed-on: https://chromium-review.googlesource.com/923783Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537280}

TBR=jcivelli@chromium.org

Bug: 812998
Change-Id: I34b710517d8c6b066e9f66d6f98863194046ddfd
Reviewed-on: https://chromium-review.googlesource.com/923942Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537279}

This fixes jumbo builds after https://chromium-review.googlesource.com/923604

Change-Id: Ib7030da7e0a6acfdad8200564f9375ba218e8ca6
Reviewed-on: https://chromium-review.googlesource.com/923723Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#537278}

Also, ignore any actions buttons beyond the first two (instead of
silently moving them to the secondary toolbar) if they are explicitly
meant to go to the primary toolbar.

Bug: 810854
Change-Id: I97d4730c884209848096e79e5f2bc414e051a8b1
Reviewed-on: https://chromium-review.googlesource.com/919087Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537277}

The metrics themselves are added in the separate CL in webrtc.

Bug: webrtc:8355
Change-Id: Ic7d98d7e1f5b30d62a79418b110e3e9c7123008f
Reviewed-on: https://chromium-review.googlesource.com/921221Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537276}

During compaction each level is scanned at the same time sequentially.
This means there are files being read from each level at the same
time but each level is read in a sequential manner. Files are read
multiple times during scanning, first reading the end of the file then
contents inside.

Because of this behavior, most-recently-used eviction is the worst
because:
1. The multiple reads in a file (in a non-sequential manner) causes a
   ton of filesystem thrashing here.
2. Files are never re-read once they are finished being scanned in a
   level, so there is no reason to keep it the handle around.

Least-recently-used eviction more closely models the reading behavior
of a leveldb compaction, and this uses leveldb's sharded LRU cache.

File thrashing here is the suspected cause of the assigned bug, where
leveldb never opens. This is a speculative but educated guess fix.

Bug: 795369
Change-Id: I7f4965a2a93b05ae558688e58d220b0fcf549430
Reviewed-on: https://chromium-review.googlesource.com/905575
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537275}

The only thing such floats should affect is the block position of
subsequent floats (float rule §5 [1] and clearance). They should not
affect the inline position or inline size of subsequent floats or new
formatting contexts.

The spec isn't actually clear here, although the browsers agree on the
above. Submitted https://github.com/w3c/csswg-drafts/issues/2312

[1] https://www.w3.org/TR/CSS22/visuren.html#float-position

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ia9e724c8a58fcb017f86f26bdf90394f09414f4e
Reviewed-on: https://chromium-review.googlesource.com/919065Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537274}

Our C++ cloneNode() implemented web-exposed Node.prototype.cloneNode()
[1] and DOM "clone" algorithm [2]. This CL makes C++ cloneNode()
responsible only for [1], and moves [2] to virtual Node::Clone().

- Rename Node::importNode override functions to Clone().
- Add Document& argument to support importNode case
- Remove ExceptionState argument. Clone() never throws.

This is a preparation to use [2] for importNode().
This CL has no behavior changes.

[1] https://dom.spec.whatwg.org/#dom-node-clonenode
[2] https://dom.spec.whatwg.org/#concept-node-clone

Bug: 812089
Change-Id: I523e81b32bb8c1e80273e9aa9529cdd6972ca8bf
Reviewed-on: https://chromium-review.googlesource.com/923684Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537273}

TBR=perezju@chromium.org
NOTRY=true

Bug: 812807
Change-Id: If6797e1cf2ad7d3dd776570072294e62593ae70d
Reviewed-on: https://chromium-review.googlesource.com/922922Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537272}

Instead of using a bundled URLLoaderFactory that can selectively get
multiple factories. The bundled URLLoader factory's default factory
for network (e.g. for http/https) scheme may be replaced with custom
factories (e.g. AppCache one), and SW doesn't want to use it when
falling back.

We used to use 'constraints' flag in SharedURLLoaderFactory to control
this behavior but it's needed only one place where Worker makes
SW-controled fetch. Instead we can just pass the network-direct URLLoader
factory in addition to the bundled one, then we can eliminate the
'constraints' flag too.

R=falken@chromium.org, jam@chromium.org

Bug: 715640
Change-Id: I1604de28b22c95e0fd79aa230c5f0cb1c59edc85
Reviewed-on: https://chromium-review.googlesource.com/923621
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537271}

Currently 'git cl uplaod' fails when all files are skipped (e.g. fixing
LayoutTest). This patch makes it pass.

Bug: none
Change-Id: Ib028d39ed63e0cba21918cb565a5c264ad047da7
Reviewed-on: https://chromium-review.googlesource.com/923782Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537270}

We plan to have WebViewScheduler owned by Page, which will delay the
execution of WebViewScheduler's destructor because Page is garbage
collected.

This patch moves the execution of the destructor to WebViewImpl::
Close() to ensure nothing will break even if we clear the
WebViewScheduler object early.

Bug: 812986
Change-Id: I5de6b7ad3f3598922a408b2a26cec4718a132f6f
Reviewed-on: https://chromium-review.googlesource.com/923246Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537269}

We should never leave any node which has a LayoutObject, but doesn't have a parent in a flat tree
after having run UpdateStyleAndLayoutTree. That means we forget to detach a node which should be
detached.

Update TestExpectations because some tests would hit this assertion when IncrementalShadowDOM is
enabled.

Bug: 776656
Change-Id: I273b9ddd083766fe687aedb178fc6e0c65248fde
Reviewed-on: https://chromium-review.googlesource.com/920329
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537268}

When a synchronous profile load is happening (e.g. after chrome restart
on Chrome OS), make sure to invoke UserCloudPolicyManagerChromeOS's
OnStoreLoaded handling.
This is also the place where user affilitaion is determined.

BUG=810013
TEST=browser_tests --gtest_filter=*UserAffiliation*

Change-Id: Ib4a4b1ad3e61eba637f527dfa89cb5cd1fd2159b
Reviewed-on: https://chromium-review.googlesource.com/908565Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537267}

This patch changes "5206311-1.html" to utilize |selection_test()| for
ease of maintenance.

Following patch will rename this test file to
"delete_selection_contains_table_row.html" to provide hint about
what this test file verifies.

Change-Id: Ie0f6e54b998c9679e316f5e488e6a19679236d12
Reviewed-on: https://chromium-review.googlesource.com/914209
Commit-Queue: Hikaru Nishida <hikarun@google.com>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537266}

Change-Id: Ice85ebdd73350f8228a7591496716d73efe3695b
Reviewed-on: https://chromium-review.googlesource.com/922862
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537265}

This patch plus https://chromium-review.googlesource.com/c/chromium/src/+/921082
Fixes the broken headless browswer tests in
https://chromium-review.googlesource.com/c/chromium/src/+/762520

Bug: 777763
Change-Id: I44ef4ea78e673129e65d23fdd4cd1169569e478b
Reviewed-on: https://chromium-review.googlesource.com/922622
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537264}