- 19 Aug, 2020 40 commits
-
-
David Bokan authored
The scheduler prioritizes commits when we're in a scroll and there's a scroll handler. Today this is done by checking for scroll event handlers in scroll begin and storing that state. It seems like we could simply apply the scheduling strategy dynamically after scroll begin, which allows us to remove some connections between LayerTreeHostImpl and the ThreadedInputHandler. Bug: 915926 Change-Id: Ic7b0c7b388f77c2f708e5f73c235a9a0e5511d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363724 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799597}
-
Milica Selakovic authored
This CL adds check for scripts availability only if kPasswordChageInSettings flag is enabled. This CL also changes PasswordScriptsFetcherBridge so it does not use Profile information and can be used in SafetyCheck to prewarm cache. Bug: 1086114, 1092444 Change-Id: I87021c2e65c7886ad90ee80844b9a2e46fb4b626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351994 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#799596}
-
Christian Dullweber authored
mMaxPermissionOrder was not updated correctly. Avoid this problem by not storing it globally. Bug: 1117422 Change-Id: Ic200c7f6130347cec6635e4d09fa460c99a3a7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364533 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799595}
-
Chris Hamilton authored
Further CLs will migrate blink code to use these bit by bit. BUG=1096617 Change-Id: Iceb0090a4ea835cf5a524a7333da65068ee7afb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363552Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#799594}
-
David Bokan authored
This CL adds an interface through which LayerTreeHostImpl and the "graphics" side of the compositor can talk to the input handler. For now, LTHI keeps the concrete object and still owns it but eventually this will be moved out and LTHI will only have a reference to the interface. A followup will add an interface for the other direction so that the input system doesn't have to have a concrete reference to LTHI. Bug: 915926 Change-Id: Ieb4c0642e6674b6f09e8c7d8b6ff366cc8179bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359190Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799593}
-
Victor Hugo Vianna Silva authored
Bug: 1062344 Change-Id: I45a3ef9f01e234c342bd442ff9b38d802db5a9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362756Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#799592}
-
Alexander Surkov authored
Bug: 1115489 AX-Relnotes: n/a Change-Id: I9271c6325b6d32d3150e53617851ef4f009084d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360218Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#799591}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6a992541..b1eb63de Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9bac8c2d2464e07103f347fe6acf43a16bb20458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362344Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799590}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/050fece535f6..e90094abdc0a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dullweber@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: dullweber@google.com Change-Id: I39c5285fb231db998a38e1706034a88aaf9bfaab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364256Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799589}
-
Mark Mentovai authored
Change-Id: I795e424390afb6c9c6e77995e21f008e0be15d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363800 Auto-Submit: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799588}
-
Oleh Lamzin authored
Move a bit down comment about when closure compiler knows that input is {!Object}. Change-Id: Ia424d3ecce01e544c44f6e2728dca01e46dcde4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362924 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#799587}
-
Andreea Costinas authored
Currently, System-proxy requests proxy authentication credentials from the Network Service. This means the user has to first to login into the Browser and then use the Play Store for navigation. This CL creates a proxy authentication dialogue for System-proxy to request credentials for a remote proxy without going trough the Browser. Bug:1112722 TEST=unittests Change-Id: I263a38c8be4cbbdf0891e515500cd9e5584c63fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352828 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#799586}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/680531a67036..6177a5ec5b8b 2020-08-19 sigurds@chromium.org Fix bug where requests where shown twice 2020-08-19 sigurds@chromium.org Create new icon for blocked frame If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1051466,chromium:1093247 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iec1a32fd5822a3a960ce3dd0a358e36d3641d266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364258Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799585}
-
Boris Sazonov authored
Reason: flaky. Builder links: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/33134 https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/33135 TBR=wychen@chromium.org Bug: 1119322 Change-Id: Icf1cd4dcd2424c3aadf24b508ed25f3f02c406fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362926Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#799584}
-
Mugdha Lakhani authored
With this change: https://chromium-review.googlesource.com/c/chromium/src/+/2274888 WebLayerShellActivity exercised the newly added setTextClickListener() method on UrlBarOptions. This set the clicklistener passed in to the UrlBarView's TextView only, which is working as intended. However, the test team would like to retain the ability to click anywhere on the UrlBarView other than the security button and be able to show the editable text view. This change adds that back. I have removed the setTextClickListener() call since two click listeners doing the same thing on the non editable text view is rendundant. Before this change: https://drive.google.com/file/d/16ttRlvh-AqObs4_pA9TiDSRUKVf6bcO-/view?usp=sharing After this change: https://drive.google.com/file/d/1y1vFCd4eObMs8C84862V7zQ53siMMKqJ/view?usp=sharing Bug: 1114238 Change-Id: I98eb4314436dbf7d6509a77e4890d0f348b2eebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362817Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#799583}
-
Mark Mentovai authored
The baseline CPU for macOS on arm64 is the Apple A12 (Vortex/Tempest), and clang should default to this when building for this OS/CPU combination. Apple clang embedded in Xcode 12 does, but trunk clang does not, instead targeting the Apple A7 (Cyclone), the proper baseline CPU for iOS on arm64. https://reviews.llvm.org/D82699 would fix it, but it hasn't gained any traction. Specify the baseline CPU explicitly here. Bug: 1107587, 1119249 Change-Id: I2a132b00ef9b5c8262aa24f27a7519d83a3df41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363772 Auto-Submit: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799582}
-
Sreeja Kamishetty authored
This CL disables non-compatible render_frame_host_manager_browsertests with BackForwardCache. BUG=1102629 Change-Id: Ie62ef1a5bc76ef0877edbd2d9745a9d58004d244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354243 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#799581}
-
Mihai Sardarescu authored
This flag is used to enable using the Multilogin endpoint on desktop platforms. Bug: None Change-Id: If7add4d0adb85904fe61c782c65b480b7cc606dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362899Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#799580}
-
Anatoliy Potapchuk authored
This cl makes WebKioskAppData keep track of |icon_url_| provided by policy. Now, if the app has not been yet installed, we will schedule an icon download whenever its url changes. Bug: 1015383 Change-Id: I0e1d342cd11bd58d8e234becde5a81824302a63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353262Reviewed-by:
Anqing Zhao <anqing@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#799579}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c1e6d1aba7c7..876a3dc88ac4 2020-08-19 ivoc@webrtc.org Fix for NetEq simulations containing large gaps and multiple SSRCs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I917404600e3ac8e44294f698f0df11b6e6cc28a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364260Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799578}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0795384a7997..e60f72f6801e 2020-08-19 taylori@google.com Merge "Record trace event" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2c8bf025103fb9e56c3e18eb36d1ad5b3971fe57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799577}
-
Hitoshi Yoshida authored
The code generator for IDL dictionaries will be updated soon (issue 839389), and the new generator does not use WTF::String for IDL enumerations. In image_capture.cc, the type of |photo_capabilities_->fillLightMode()| will be Vector<V8FillLightMode> from Vector<String>. This CL makes the conversion work with both types using a template hack. This hack will be cleared after the migration of IDL compilers is completed. Bug: 839389, 1070871 Change-Id: I927cadba6947676115c7d781d33706b767757276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355632Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#799576}
-
Victor-Gabriel Savu authored
This reverts commit abaf2f5e. Reason for revert: Increased timeout for CreateVault in tast tests, it should fix the issue. Original change's description: > Sheriff: Disable session.RetrieveActiveSessions > > TBR=mnissler@chromium.org > TBR=hidehiko@chromium.org > > Bug: 1117324 > Change-Id: Iec44ae22a5c0452f9b6489c9e0c567e957c68b8b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359877 > Reviewed-by: Fergus Dall <sidereal@google.com> > Commit-Queue: Fergus Dall <sidereal@google.com> > Cr-Commit-Position: refs/heads/master@{#798951} TBR=hidehiko@chromium.org,mnissler@chromium.org,sidereal@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1117324 Bug: 1116379 Change-Id: Ifa20b34513c09a2a3bbf3ee17865b92229a52820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362818Reviewed-by:
Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#799575}
-
Alex Ilin authored
Bug: 1098677 Change-Id: Ie917e14b4d6caaf9d60cf61dcd3859c94fbbd59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362930 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#799574}
-
Aya ElAttar authored
Changed ManagedGuestSessionAutoLaunchNotificationReduced policy description to state that it's going to be deprecated as ManagedGuestSessionPrivacyWarningsEnabled policy is being launched in the Dpanel instead of it. Bug: 1117198 Change-Id: If02a6e40d79d33f3c9c153e6a9030983501d3a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360373Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#799573}
-
Sreeja Kamishetty authored
This CL fixes or disables failing content_browsertests with BackForwardCache. Bug: 1102629 Change-Id: I8b9f04d5686b57f005d05e9b8c9e918e6e735f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321220 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799572}
-
Yunke Zhou authored
Bug: 1101318 Change-Id: I32870d5da54df76c8cbdfe3d51a779940362c23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362587 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799571}
-
Yunke Zhou authored
Add new gaia end point for child account signin / signup DD: https://docs.google.com/document/d/1NJFsv7Mugy2ssYmyc3-Qh8_Ra5zwfKdeyYCFQ8WeAlQ Bug: 1101318 Change-Id: Ia6769f01dfe9f1409ee120b9cc71ab66ae658963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359073 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#799570}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5988d0f33501..193cfbd67529 2020-08-19 tsepez@chromium.org Add prefinalizers for other CXFA_FF* classes 2020-08-19 tsepez@chromium.org Add CFXA_FFTextEdit::PreFinalize() 2020-08-19 tsepez@chromium.org Encapsulate more knowledge of IXFA_DocEnvironment in CXFA_FFDoc. 2020-08-18 tsepez@chromium.org Garbage collect all the CXFA_Nodes. 2020-08-18 tsepez@chromium.org Make some more CFWL_Widget sub-widgets const members. 2020-08-18 thestig@chromium.org Roll v8/ 343030c9f..df143e8bd (525 commits) 2020-08-18 tsepez@chromium.org Plumb cppgc::Heap down into fwl/ layer. 2020-08-18 tsepez@chromium.org Remove CFWL_ComboBox::InitComboEdit() and InitComboList(). 2020-08-18 tsepez@chromium.org Small cleanup to CFWL_App. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: If178d85cfcb3e60cdcb405c663c54d9f39dd18b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364134Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799569}
-
Anna Malova authored
See b/165192953. Bug: 1085115 Change-Id: I56a7f3108d408a56c3663921a86ba8fd44f1530a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362915Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#799568}
-
Nick Diego Yamane authored
Wayland clients are only aware of surface-local coordinates and there is no implicit grab during DND sessions. This leads to tab detaching issues in Chrome's tab drag implementation. Such problems may happen when the detachable widget occupies any edge area of the window. In this case specifically, the tab strip is placed at top edge, so dragging a tab all the way up won't detach it into a new browser window as expected. This patch fixes it by dispatching a fake motion event with negative coordinates everytime a wl_data_device::leave is received in attached mode, so higher level UI components get a chance to detect when a widget must be detached, ie: pointer was dragged outside the detachable widget's bounds. R=msisov@igalia.com Bug: 896640 Test: Covered by ozone_unittests Change-Id: I1a9e5e07763634bb879f4040bf0da24ebfefa79d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362987 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#799567}
-
Alexander Alekseev authored
This CL adds CPU usage graph to the Ash HUD overlay: Gray - Idle Blue - User Red - System Magenta - Other Internally this Cl adds support for switching between graphs (CPU and RAM). Bug: 1085713, 1101715 Change-Id: I6ea1a07d77122c160ddb2229eb6ce5eb4cc829bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355553Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#799566}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 21278d15. With Chromium commits locally applied on WPT: ed257e2b "[CORS] Set preflight request mode correctly" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ib9f9a921976278cdb87bfdcbeb3f39e717a11a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362340Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799565}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/314d6b7155ca..680531a67036 2020-08-19 sigurds@chromium.org Expose COEP/COOP status in FrameDetailsView 2020-08-19 mathias@chromium.org Move page focus emulation to Renderer tab 2020-08-19 alexrudenko@chromium.org Reland: suggest accessible color If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1051466,chromium:1093227 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibc3d8080467505597fcdaad4b18fbb9954a51f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363971Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799564}
-
Rakina Zata Amni authored
When doing a main-frame same-site navigation where we did a proactive Browsing Instance swap and we're reusing the old page's process, we should run the pagehide and visibilitychange handlers of the old page to run before we run the new page. This CL adds a way to run those handlers just before we commit the new page, by sending the routing ID of old main frame. Note that we won't actually unload/freeze the old page nor run the unload handlers for it, as that needs a more complicated support on the browser side - we will work on this later. See: https://docs.google.com/document/d/1RXGDkrSWTfaeio76joXKWBLGDHAbiB48sHUdcTX6rdc/edit#heading=h.476deggm397n Bug: 977562 Change-Id: I83dd3b3d5655b7edc0806a583ddbcba9ec81244a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299824 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#799563}
-
Bruce Long authored
A crash in several interactive_ui_tests is seen if the feature flags WinUseBrowserSpellChecker and kWinDelaySpellcheckServiceInitfeature are set to be on by default. Fix is just to follow the same pattern used in other SpellCheckHostChromeImpl methods and do an early return if the SpellcheckService is null. Bug: 1118185 Change-Id: I785cd8cec37f42080acedb968b4a6671b01d2378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363871 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799562}
-
Yuta Kasai authored
This patch makes wait_for_state() in test-helpers.sub.js for a service worker WPT test check an unexpected state after adding the event handler. Before this patch, wait_for_state() only checks the equivalence of the state to the specific state. It might wait forever if the worker unexpectedly skips the state or it's unexpectedly evicted. Bug: 1000544 Change-Id: I7025fad3ba25648888a762e16ae0ded63f9c4f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344440 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799561}
-
Nohemi Fernandez authored
Follow-up to patch 2362248 that migrates all instances of the deprecated 'showMesage:' method to [MDCSnackbarManager.defaultManager showMessage:] in the Chrome remoting codebase. TBR=yuweih@chromium.org Bug: 1117399 Change-Id: I2e777c7759d7a16b51f989a225526dff94dfce87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363752Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#799560}
-
Ioana Pandele authored
Puts phished credentials before leaked ones and orders them by recency (from most recent to least recent) within each category. Bug: 1102025, 1092444 Change-Id: I6e7ef30e85a0df436ac4234e248b07c7d3bdaeab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360085 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#799559}
-
Christian Dullweber authored
This reverts commit 4838b76a. Reason for revert: 1119297 Original change's description: > Add more checks for chrome.debugger extensions > > Bug: 1113558, 1113565 > Change-Id: I99f2e030f9a38f1ffd6b6adc760ba15e5d231f96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342277 > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799514} TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org,caseq@chromium.org,yangguo@chromium.org,sigurds@chromium.org Change-Id: I01ad12ca99ac75197f9073e2c6c9d0eaa0d95147 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113558 Bug: 1113565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362920Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#799558}
-