- 20 May, 2018 22 commits
-
-
Morten Stenshorne authored
When there are adjoining floats that need to be separated from a cleared block, clearance is predetermined, and we have to force it on the block. Any large top margin on the child will just be eaten by negative clearance. There's nothing that can be done to prevent clearance in such cases. So make sure that we don't try to determine whether to apply clearance or not based on the clearance offset set in the constraint space. When clearance has been predetermined (which may have triggered a BFC offset resolution and what not), refusing to apply it to the child is a bug. This aligns the implementation with the "alternative" way of calculating clearance in the spec [1]. Everyone but Edge does this. I think what Edge does here is problematic, because it requires us to use a hypothetical position that was calculated before clearance got applied (clearance causes margins that would otherwise collapse to be separated). We'd end up using a hypothetical position not based on the actual layout situation.[2] [1] https://www.w3.org/TR/CSS22/visuren.html#flow-control [2] https://github.com/w3c/csswg-drafts/issues/2608 This fixes one existing test. Added a few new ones as well. Not all of them failed prior to this CL, but they serve as regression tests for things I found to lack coverage while working on this. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia45e9048c75c338477eee4923ff16eea3245bc6a Reviewed-on: https://chromium-review.googlesource.com/1061470 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#560208}
-
Darren Shen authored
Fixes an issue where CSSNumericValue.parse considers valid strings surrounded by whitespace to be invalid. Bug: 844290 Change-Id: I4c40044631276a611ef9a56aac21ddf09316a550 Reviewed-on: https://chromium-review.googlesource.com/1065532Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#560207}
-
Ken Rockot authored
Re-reland of r555117 with process handle leak actually fixed. Totes for reals. Original commit message follows. Mojo passes around base::ProcessHandle values for various reasons. On most systems this is fine, but at least on Windows, a ProcessHandle refers to an owned reference to a system process object, and if not careful it's possible for a base::ProcessHandle value to inadvertently change meaning over time. This CL introduces the concept of a move-only ScopedProcessHandle within Mojo, which on most platforms is just a base::PlatformHandle. On Windows, this represents an owned base::ProcessHandle which closes on destruction and clones correctly using DuplicateHandle rather than merely copying the raw handle value. ScopedProcessHandle is used in a few places where process handle ownership semantics were previously weaker than necessary, or were correct but implemented ad hoc. This also updates ScopedPlatformHandle (and supporting code like Channel::RewriteHandles) such that the |owning_process| field (if not the current process) is always an owned process handle. This ensures that when such handles are closed in unsent messages, they can be safely closed in the target process (from within the source process) without any risk of raciness against target process termination. TBR=jcivelli@chromium.org Bug: 837612 Change-Id: I182e6849fd87fb44e22f6ed21457b17422956613 Reviewed-on: https://chromium-review.googlesource.com/1066999 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#560206}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/da17f1e7df1d..5191880cbf3e $ git log da17f1e7d..5191880cb --date=short --no-merges --format='%ad %ae %s' 2018-05-18 caryclark remove toString 2018-05-18 brianosman Add drawBitmapLattice to SkDebugCanvas Created with: roll-dep src/third_party/skia BUG=chromium:830651 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: Ic416a02f00901a15956ee78e8f87dd9ee6d8e3cf Reviewed-on: https://chromium-review.googlesource.com/1067001 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560205}
-
Rohit Rao authored
When the UIRefresh UI is enabled, bookmarks is presented using a UIPresentationController with a custom presentation. UIAlertController chooses to draw as a popover in Regular horizontal size classes, so we need to provide a sourceView and sourceRect. For now, provide the center of the bottom UIToolbar, as that roughly corresponds to the "More" button. BUG=None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6e732460eb371158ac9e1754d752b923965f5b0b Reviewed-on: https://chromium-review.googlesource.com/1064916Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#560204}
-
Takuto Ikuta authored
Stop to use explicit dependency for indirect dependency in the CL broke Mac builder. https://chromium-review.googlesource.com/1041506 This CL uses deps/public_deps in create_bundle target always not to miss the dependency. Bug: 843470 Change-Id: Iae66f2a3aec20f67ea2e880bb5fd33d6c2aa2f91 Reviewed-on: https://chromium-review.googlesource.com/1065591Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#560203}
-
Jialiu Lin authored
1. Skip client side detection if page url matches enterprise whitelist 2. Trigger |OnSecurityInterstitialShown| and |OnSecurityInterstitialProceeded| extension events on SB and SSL interstitial. Bug: 811467, 811454 Change-Id: Ia361763f3102914f8be3896068809ccd599319aa Reviewed-on: https://chromium-review.googlesource.com/1056066 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#560202}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/04d6ced50cd8..da17f1e7df1d $ git log 04d6ced50..da17f1e7d --date=short --no-merges --format='%ad %ae %s' 2018-05-20 rmistry Omit "espn" from key_mobile_sites_smooth in RecreateSKPs bot Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: I91b10ca53e88ef86823b954562182b7c31dfedca Reviewed-on: https://chromium-review.googlesource.com/1067145 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Nico Weber authored
TBR=scottmg Bug: 845011 Change-Id: I06891b947b6eb444ab8a6af7b2f9a574e04d40f0 Reviewed-on: https://chromium-review.googlesource.com/1067151Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#560200}
-
Robert Sesek authored
This should force LaunchServices`clientIsAllowedToConnect() to always return false. Bug: 844660 Change-Id: Ib6e57b3d567da7efd2590858dff1e19f5e82c5db Reviewed-on: https://chromium-review.googlesource.com/1066482Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#560199}
-
Ria Jiang authored
Record the number of clients we asked when doing async targeting. 0 means we didn't take async path at all; 1 means we found the target when asking the first client; 2 means we found the target when asking the second client; ... This should give us a better idea of how many clients we usually ask in async path so we can try to optimize and reduce latency in async path. Note that we only report this UMA if Site Isolation is turned on and we actually did explicit hit-testing for that event. Bug: 732417 Change-Id: I164a9f8c853181c4ab6896a5bfcf9c0806a3da7d Reviewed-on: https://chromium-review.googlesource.com/1060286Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#560198}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=satorux@chromium.org Change-Id: I2e0380a22ffdbfd29f3db231b7b7adcdfb342804 Reviewed-on: https://chromium-review.googlesource.com/1067126Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#560197}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b292e56e..41a6376d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Iab746e59dc5d09c20ec415a6cf2a34ec61c22bda Reviewed-on: https://chromium-review.googlesource.com/1067098Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#560196}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Iaf53bf154f0704151e8d5d2ce25ab1c3448f4b81 Reviewed-on: https://chromium-review.googlesource.com/1067143Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560195}
-
David Grogan authored
ShrinkToAvoidFloats does this already. Possible artifact from a previous draft patchset of https://chromium-review.googlesource.com/c/chromium/src/+/888059 ? Change-Id: Ica9ec0d92403e8d90370ab4758b5504fa8a124f6 Reviewed-on: https://chromium-review.googlesource.com/1066853Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#560194}
-
John Budorick authored
Bug: 731985,790706 Change-Id: I3a0e3de9e5fbc883e6a42035b4aa9cf10f9e6814 Reviewed-on: https://chromium-review.googlesource.com/1066180 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#560193}
-
Pavel Feldman authored
Change-Id: I9bb1a1aadc3f50f8b6e9bed38ae7eb0834e3c66a TBR: dgozman Reviewed-on: https://chromium-review.googlesource.com/1066992Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#560192}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: If33411a07b66d701f7ee84d22cd0af5526d31807 Reviewed-on: https://chromium-review.googlesource.com/1067094Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#560191}
-
Pavel Feldman authored
Change-Id: Idbc930f4087158b413bd447698098792ec1b9b04 TBR: dgozman Reviewed-on: https://chromium-review.googlesource.com/1067133 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Idaa308c8de43f9bd0b9d6aaa3a6d31cecad4233b Reviewed-on: https://chromium-review.googlesource.com/1067136 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560189}
-
https://chromium.googlesource.com/angle/angle.git/+log/9b1a90845291..42cf958ce8fa $ git log 9b1a90845..42cf958ce --date=short --no-merges --format='%ad %ae %s' 2018-05-17 jmadill Make UNIMPLEMENTED a warning. 2018-05-17 jmadill dEQP: Use overload of CreateWindow. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I8615be45d9fed12790e35d0154df6f6d2fb326d0 Reviewed-on: https://chromium-review.googlesource.com/1067130Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560188}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/da816f070842..04d6ced50cd8 $ git log da816f070..04d6ced50 --date=short --no-merges --format='%ad %ae %s' 2018-05-19 angle-skia-autoroll Roll third_party/externals/angle2/ 78b7f3a8e..42cf958ce (3 commits) 2018-05-19 angle-skia-autoroll Roll third_party/externals/angle2/ a9ab0f37c..78b7f3a8e (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I017293cbc3122ee0c068c9869e5e9423b4cdab13 Reviewed-on: https://chromium-review.googlesource.com/1067086Reviewed-by:
-
- 19 May, 2018 18 commits
-
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/669dcb14ae89..1d08c644fb9a $ git log 669dcb14a..1d08c644f --date=short --no-merges --format='%ad %ae %s' 2018-05-18 dtu [pinpoint] Specify the Swarming pool through the dimensions. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I57792ceac981b669f456341a9b1f5227ac8b90dc Reviewed-on: https://chromium-review.googlesource.com/1067089 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560186}
-
Ken Rockot authored
Reland fixes a simple merge conflict which caused a non-existent header to be included. Original CL is https://chromium-review.googlesource.com/c/chromium/src/+/1066807 This is a public C API replacement for the EDK invitation API, i.e. Incoming/OutgoingBrokerClientInvitation et al. Here the new C calls are introduced and covered by unit tests. See the associated bug and the bugs it's blocking for more context and follow-up work. TBR=jcivelli@chromium.org Bug: 844231 Change-Id: If23b70ea381031a4caaed0ba5e6cf45c6b218971 Reviewed-on: https://chromium-review.googlesource.com/1067087Reviewed-by:
-
Scott Violet authored
This moves data structures that are needed at embed points to ClientRoot. BUG=837684 TEST=none Change-Id: I9c404a3e5d076df39d96777b21e858818f93a7c0 Reviewed-on: https://chromium-review.googlesource.com/1066916 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#560184}
-
James Darpinian authored
This reverts commit db2744fe. Caused failures on Win7 FYI trybots: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28AMD%29/1236 * gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_CSS3DBlueBox * gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_DirectComposition_Video_VP9 * gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_GpuRasterization_ConcavePaths * gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasAccelerated2D * gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasTransferAfterStyleResize * gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasTransferToImageBitmap * gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_SolidColorBackground * gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Video_VP9 * gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_WebGLGreenTriangle_AA_Alpha * gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_WebGLGreenTriangle_NoAA_Alpha * gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_WebGL_PremultipliedAlpha_False * gpu_tests.screenshot_sync_integration_test.ScreenshotSyncIntegrationTest.ScreenshotSync_GPURasterWithCanvas * gpu_tests.screenshot_sync_integration_test.ScreenshotSyncIntegrationTest.ScreenshotSync_SWRasterWithCanvas * gpu_tests.screenshot_sync_integration_test.ScreenshotSyncIntegrationTest.ScreenshotSync_SWRasterWithDivs Bug: 844849 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I57da87a7242d332af1d3642e4161c61fb20b7836 Reviewed-on: https://chromium-review.googlesource.com/1067083 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#560183}
-
Marcin Wiacek authored
Desktop Chrome / Firefox are decoding % sequences in URLs in the status bar, additionally desktop Chrome is omitting HTTP scheme there. Patch is including this functionality in the Android Chrome in the context menu URL and is replacing or extending: 1. crrev.com/2774143002/ 2. https://chromium-review.googlesource.com/c/chromium/src/+/877759 3. https://chromium-review.googlesource.com/c/chromium/src/+/1015229 BUG=705233 Change-Id: I70509448108e267b66413a9c8869518706375b68 Reviewed-on: https://chromium-review.googlesource.com/1037123 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#560182}
-
Saman Sami authored
If fallback SurfaceId was used during aggregation and a newer Surface becomes available later on, make sure we mark the display as damaged to force a draw and swap. Bug: 843290 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ie0d46b547ab0c983c21c0fe003af3fbf90759aba Reviewed-on: https://chromium-review.googlesource.com/1062585Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#560181}
-
Emilio Cobos Álvarez authored
...instead of replacing if the property is already set. This matches the spec[1] which was changed as a resolution from[2]. Intent thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/lzBoa1EAQpI/strfpNczAwAJ [1]: https://drafts.csswg.org/cssom/#set-a-css-declaration [2]: https://github.com/w3c/csswg-drafts/issues/1898 Bug: 782407 Change-Id: I4b72c0207a4cf734fc2e415bd62c7863103ec309 Reviewed-on: https://chromium-review.googlesource.com/1054867 Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/78b7f3a8e813..9b1a90845291 $ git log 78b7f3a8e..9b1a90845 --date=short --no-merges --format='%ad %ae %s' 2018-05-17 jmadill dEQP: Format display factory and clean up style. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I049f29b17cf4ed17705b04e5ebe7722c85aae342 Reviewed-on: https://chromium-review.googlesource.com/1067073Reviewed-by:
-
Clemens Hammacher authored
The metric was added to V8 in https://crrev.com/c/1061497 to measure the code size increase of Liftoff and get data to find a good upper limit on the wasm code space. R=mpearson@chromium.org CC=titzer@chromium.org Bug: chromium:787421 Change-Id: I6aee5a5633051be376f81b4e9fffbf036bc44ec1 Reviewed-on: https://chromium-review.googlesource.com/1064238Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#560178}
-
Scott Violet authored
The server assigns LocalSurfaceIds (each window may have a LocalSurfaceId). LocalSurfaceIds change any time the size changes. This means the server needs to notify the client any time the bounds change. Normally when a client requests a change that succeeds the server acks it, and that is it. What we've done with bounds of roots (where LocalSurfaceIds matter), is when the client requests the change the server responds with OnWindowBoundsChanged(), which includes the LocalSurfaceId, and then the server returns false. By returning false the client applies the LocalSurfaceId that was just sent from the server. services/ui/ws had this logic, this makes ws2 have the same logic. This is at least part of the problem as to why painting isn't working. BUG=837684 TEST=covered by test Change-Id: Ia66d3e5b4120adce2a5d033563a0c387c3bd7b7e Reviewed-on: https://chromium-review.googlesource.com/1066828 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Alex Moshchuk authored
This CL fixes a reordering problem between sizing changes and cross-process postMessages. Previously, it was possible for a frame to resize its child frame (forcing layout to guarantee the sizing IPC is sent), then send it a postMessage, and have the message delivered before the sizing change. This is because the browser process might throttle resizes, in particular if there had been another pending resize which hadn't been acked by the (child) renderer. To fix this, this CL flushes any pending sizing info to the child renderer before forwarding the postMessage. Bug: 822958, 828529 Change-Id: I49252ed6f91b5c25be96b210fd3e3c6248f14da6 Reviewed-on: https://chromium-review.googlesource.com/1063310 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#560176}
-
Ken Rockot authored
This reverts commit a523cf48. Reason for revert: Bad rebase, conflicted with another change Original change's description: > Mojo: Invitation API > > This is a public C API replacement for the EDK invitation API, i.e. > Incoming/OutgoingBrokerClientInvitation et al. Here the new C calls > are introduced and covered by unit tests. > > See the associated bug and the bugs it's blocking for more context > and follow-up work. > > Bug: 844231 > Change-Id: Iffa2e5b08eefbe3476430eb420efe2f52f4ad195 > Reviewed-on: https://chromium-review.googlesource.com/1066807 > Commit-Queue: Ken Rockot <rockot@chromium.org> > Reviewed-by: Jay Civelli <jcivelli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560164} TBR=jcivelli@chromium.org,rockot@chromium.org Change-Id: I798545dc19a146fe40a9e1ad7ff95a41d0d5dd25 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844231 Reviewed-on: https://chromium-review.googlesource.com/1067053Reviewed-by:
-
Steve Kobes authored
Bug: 823365 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I07e34f6e26394c073124886eef08d93a667918f5 Reviewed-on: https://chromium-review.googlesource.com/1066615 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#560174}
-
Jan Krcal authored
This CL removes the bridge pointer from the ModelReadyToSync function of the ModelTypeChangeProcessor interface.The CL finishes the larger effort of hiding the bridge interface from the internals of sync. When already touching all the files, it also removes the gMock hacks for move-only types from MockModelTypeChangeProcessor. The outcome is still not optimal because some standard actions as Invoke or SaveArg do not support move-only types; we have to use lambdas/WithArg, instead. Bug: 819993 Change-Id: I0f4db6c2b7b36d317b69a25a651180c1f63d9269 Reviewed-on: https://chromium-review.googlesource.com/1064612Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#560173}
-
Steve Kobes authored
Bug: 823365 Change-Id: I5951f7a868c11901d36cad63a24cfd4a39209ad3 Reviewed-on: https://chromium-review.googlesource.com/1066178Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#560172}
-
Devlin Cronin authored
All callers except the fileManagerPrivate API have been updated to not rely on GetAssociatedWebContentsDeprecated(). The fileManagerPrivate issue is being tracked separately. Remove the function GetAssociatedWebContentsDeprecated() and move it to be directly in the fileManagerPrivate API to avoid having usage spread. Bug: 461394, 844654 Change-Id: I69adc7f3534d4908497bf73d3fcab0f7443450e7 Reviewed-on: https://chromium-review.googlesource.com/1066733Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560171}
-
Pavol Marko authored
Moves the factory ping embargo check from rlz_lib::RlzValueStoreChromeOS to the function chromeos::system::GetFactoryPingEmbargoState. This avoids a dependency from chromeos to rlz_lib. Bug: 839353 Test: chromeos_unittests && rlz_unittests Change-Id: Ia20c9a268d1030a77b1e138632005866c24d0788 Reviewed-on: https://chromium-review.googlesource.com/1059409 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#560170}
-
Shakti Sahu authored
Fixed initialization of pending_state_ in SavePageRequest. Bug: 844652 Change-Id: I8c4b2134dc74155330bc918be5e02e614610b2a9 Reviewed-on: https://chromium-review.googlesource.com/1066694Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#560169}
-
