- 04 Oct, 2017 40 commits
-
-
Dave Schuyler authored
This CL adds a listener to the settings subpage that will allow setting the filter value. The filter may be cleared by setting the value to ''. Bug: 770423 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If4ac8e4bb1f1b38224b52e970f549293ff9b5e9d Reviewed-on: https://chromium-review.googlesource.com/693390 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#506486}
-
Tibor Goldschwendt authored
Bug: Change-Id: Ib0c511a7e032b05d9b3644966419520aa18160c3 Reviewed-on: https://chromium-review.googlesource.com/699702Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#506485}
-
Tom Sepez authored
This is another step towards normalizing (somewhat) the InitializeSandbox() API across the various platforms. Change-Id: I86279c2f5c26c9c1bd0b7586b7ac882c3667f6e5 Reviewed-on: https://chromium-review.googlesource.com/699154 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#506484}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/aafdc153a2b7..3e3a78b68c31 $ git log aafdc153a..3e3a78b68 --date=short --no-merges --format='%ad %ae %s' 2017-09-13 art-snake Improve readability for CPDF_LinearizedHeader. 2017-10-04 hnakashima Fix UAF in SetVisible(). 2017-10-02 art-snake Unify parsing of cross ref table v4. 2017-10-02 art-snake Simplify CPDF_DataAvail::ParseIndirectObjectAt Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I581e223cbaa4d2fc0e2410fd567fdad0d91ff96a Reviewed-on: https://chromium-review.googlesource.com/699644 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506483}
-
Scott Little authored
Bug: Change-Id: I9f792d5b74dd28ee9442725a182a69de62c4f66e Reviewed-on: https://chromium-review.googlesource.com/700794Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#506482}
-
rbpotter authored
Bug: 770851 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idc4fc5ac44534f51305f6573ba1a1f00c55d5672 Reviewed-on: https://chromium-review.googlesource.com/699638Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#506481}
-
Alan Bram authored
Change-Id: Iaf4d6035552698559e56b1459d5b3e4c4e47ac38 Reviewed-on: https://chromium-review.googlesource.com/699934 Commit-Queue: Alan Bram <flyboy@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#506480}
-
Devlin Cronin authored
It looks like many of the strings from the old delete browsing data interface are unused, but still included (the rest of the old browsing data settings UI was removed in crrev.com/1f2b58d7). Remove them. Bug: None Change-Id: Idb3c724430c626d5ae262f55e147107f6de34f60 Reviewed-on: https://chromium-review.googlesource.com/699804 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#506479}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/672cabd12c68..d0b91b8f3a17 $ git log 672cabd12..d0b91b8f3 --date=short --no-merges --format='%ad %ae %s' 2017-10-04 nednguyen Add snap-it tests to Catapult CQ Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I55dd57a09a38178eb2437fd9298ac940df0b92ae Reviewed-on: https://chromium-review.googlesource.com/700795 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506478}
-
Tom Anderson authored
This CL: * Fixes some manpage syntax. * Compresses the manpages. * Adds manpage entries for google-chrome-stable and google-chrome for the stable channel. * Fixes a reference to google-chrome in the RPM spec. * Handles rpmlint suppressions using a conf file instead of just filtering out what we don't want. This fixes the following lint errors: * lintian: * E: chromium-browser-stable: manpage-not-compressed usr/share/man/man1/chromium-browser.1 * W: chromium-browser-stable: manpage-has-errors-from-man usr/share/man/man1/chromium-browser.1 1: warning: macro `"' not defined * rpmlint: * chromium-browser-stable.x86_64: W: manpage-not-compressed bz2 /usr/share/man/man1/chromium-browser.1 * chromium-browser-stable.x86_64: W: manual-page-warning /usr/share/man/man1/chromium-browser.1 1: warning: macro `"' not defined * chromium-browser-stable.x86_64: W: no-manual-page-for-binary google-chrome * chromium-browser-stable.x86_64: W: no-manual-page-for-binary chromium-browser-stable BUG=771373 R=thestig@chromium.org Change-Id: I5d1921150945123b72b5f2a50714c3094a526648 Reviewed-on: https://chromium-review.googlesource.com/699855Reviewed-by:Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#506477}
-
Scott Violet authored
For OOPIF we want the parent renderer to embed the child. This is mediated by the browser. That is, we want something like the following: 1. Browser obtains WindowTreeClient from child renderer (cWTC). 2. Browser passes cWTC to parent renderer. 3. Parent renderer creates Window in mus and calls Embed() with cWTC. Unfortunately in step 2 if the parent renderer were compromised then it could directly call functions on cWTC, such as spoofing events. This is a security problem. To avoid this scenario I'm adding the option of a two phase embed. This results in the following: 1. Browser obtains WindowTreeClient from child renderer (cWTC). 2. Browser calls ScheduleEmbed() on it's WindowTree connection. ScheduleEmbed is a new function that takes a WindowTreeClient and returns a token. 3. Browser waits for token. 4. Browser passes token to parent renderer. 5. Parent renderer creates Window in mus and calls Embed() passing token. With this flow renderers don't end up with a WindowTreeClient from a different client. BUG=758387 TEST=covered by tests Change-Id: I819a57cd811d4939cbeecec8aeb8273eefca64f5 Reviewed-on: https://chromium-review.googlesource.com/699519Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#506476}
-
Andrew Grieve authored
This reverts commit 1dd22ad0. Reason for revert: Breaks when lint_suppressions_file is assigned within //build_overrides/build.gni Original change's description: > Android: Allow per-target lint suppression configuration > > This change allows for Android lint suppression configurations > to be defined on a per-target basis (assuming said target is > "Android lint capable") rather than having one global config. > This will allow embedders to keep upstream's lint config for > Chromium targets (w/o patching), while using a separate config > for the embedding application. > > Bug: 737897 > Change-Id: Ieccb95767e0ce541522d7a53edbe734c5bbfe6dc > Reviewed-on: https://chromium-review.googlesource.com/698297 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506393} TBR=agrieve@chromium.org,justmoto@amazon.com Change-Id: Ib15a61731179cc9ffc8d415844cfe8fbbc8e68eb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737897 Reviewed-on: https://chromium-review.googlesource.com/701014Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#506475}
-
Justin DeWitt authored
This enables the Downloads Home integration as well as the notification background task. The UI can still be disabled manually in chrome://flags. Bug: 701939 Change-Id: Ifd38830b4442465287bb47f6440afeb499e3e234 Reviewed-on: https://chromium-review.googlesource.com/699578Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#506474}
-
Justin DeWitt authored
This will cause downloads to error out of the download system once their freshness time has passed in prefetching's db. Bug: 701939 Change-Id: I78a2e026349405db643fd960a7b41aaf8f370b44 Reviewed-on: https://chromium-review.googlesource.com/699151 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#506473}
-
Andrew Grieve authored
Change-Id: I0c2898761911c0e517c8e0fa84ad3855959e38fb Reviewed-on: https://chromium-review.googlesource.com/700038Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#506472}
-
Tim Volodine authored
org.chromium.chrome.browser.suggestions.TileGridLayoutTest#testTileGridAppearance_Full org.chromium.chrome.browser.suggestions.TileGridLayoutTest#testTileGridAppearance_Two org.chromium.chrome.browser.suggestions.TileGridLayoutTest#testModernTileGridAppearance_Two org.chromium.chrome.browser.suggestions.TileGridLayoutTest#testModernTileGridAppearance_Full see crbug.com/771648. BUG=771648 TBR=bauerb@chromium.org,dgn@chromium.org NOTRY=true Change-Id: I80223ea645ae25bf27e4152ca872b685ea80b816 Reviewed-on: https://chromium-review.googlesource.com/700894Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#506471}
-
Rob Percival authored
Use net::DnsQuery to encode the DNS request. Bug: 667805 Change-Id: I89e03912522466dfb17bae4d3b6def448af80667 Reviewed-on: https://chromium-review.googlesource.com/671015Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Rob Percival <robpercival@chromium.org> Cr-Commit-Position: refs/heads/master@{#506470}
-
Samuel Huang authored
This reverts commit f9cc9601. Reason for revert: Speculative revert, for failing net_unittests on Android Tests (dbg). Original change's description: > SimpleCache: Port (unsequenced) use of SequencedWorkerPool over to TaskScheduler > > This is what it does behind scenes in Chrome anyway, but always using the scheduler > in tests as well is helpful since it means a single TaskScheduler::FlushForTesting() call > rather than needing both TaskScheduler and SequencedWorkerPool versions of FlushForTesting() > as separate calls, which causes trouble when control jumps back and forth between the two. > > Bug: 766221 > Change-Id: Iab6a49cad86f1fd5a31c66c50d25e2962c538d53 > Reviewed-on: https://chromium-review.googlesource.com/697925 > Reviewed-by: Asanka Herath <asanka@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506395} TBR=scottmg@chromium.org,asanka@chromium.org,morlovich@chromium.org Change-Id: Ie79bee31116c2fea12122a0c4cf8339af7a6b8a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 766221 Reviewed-on: https://chromium-review.googlesource.com/700934Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#506469}
-
Nate Chapin authored
Also, the timer in RawResource::MatchPreloads Expose the WebTaskRunner for loading on FrameFetchContext and wire it up for WorkerFetchContext, which enables us to get the ResourceFetcher constructor back down to one parameter and removes the need for thread and null checks when handling task runners in platform/loader/fetch/ Bug: Change-Id: I36a0bd8f1a9758b51a33badf8e93a84880618600 Reviewed-on: https://chromium-review.googlesource.com/671624 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#506468}
-
James Zern authored
demux,StoreFrame: restore hdr size check to min req avoids over reading if the reported ANMF payload is < 8 bytes. likely broken since: 81b8a741 Design change in ANMF and FRGM chunks: BUG=b/67381469 Change-Id: If2d82a063ef0d2d33385d6b816d7cea8a3455163 Reviewed-on: https://chromium-review.googlesource.com/699757 Commit-Queue: James Zern <jzern@google.com> Reviewed-by:
Urvang Joshi <urvang@chromium.org> Cr-Commit-Position: refs/heads/master@{#506467}
-
Bo Liu authored
Convert to Log.d to Log.i so that they work on release builds as well. Add trace logs to TestAwContentsClient since WebViewContentsClientAdapter isn't built into tests. Change-Id: I03652c5b25e6263bce7875242d612225b0451f80 Reviewed-on: https://chromium-review.googlesource.com/700816 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#506466}
-
Guido Urdaneta authored
Elements with srcObject contain MediaStreams and they cannot be cross origin since capture from cross-origin elements (with src) is disabled. The cross-origin check fails for mediaStreams since it uses the src, which is empty when the stream has been assigned to the element as an srcObject. Bug: 771388 Change-Id: I060ce54e37ba34814ac6186b0e098edfcc3d752e Reviewed-on: https://chromium-review.googlesource.com/699434Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#506465}
-
chrome://policy-toolAnton Urusov authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4f15ec24fe6fa4a7c96dbdabfc7517fd01a7191e Reviewed-on: https://chromium-review.googlesource.com/690574 Commit-Queue: Anton Urusov <urusant@google.com> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#506464}
-
liberato@chromium.org authored
AVDACodecAllocator previously was designed to work with AVDA on the GPU main thread. This CL makes it work properly even if clients call it from other threads, such as MCVD will do. It does three main things: - Create/ReleaseCodec calls post to the thread on which the allocator was constructed. This keeps everything ordered. Otherwise, it's very difficult to ensure that one client stopping threads won't happen concurrently with another posting tasks. Locks worked, but this prevents blocking the caller, and makes it easier to deal with the weakptr used to cancel StopThreadTask. - Responses to the client are on whatever thread it called on. This lets us continue to use client-provided WeakPtrs. - StartThread now sends its results asynchronously, since it posts to another thread sometimes. Bug: 760822 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib1bca55602a2f43ea9e2ecfd55fa98c877fb6217 Reviewed-on: https://chromium-review.googlesource.com/669799 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#506463}
-
Mustafa Acer authored
Bug: 396462 Change-Id: I7f23f1da022b700a15f6edd43781e20219999cac Reviewed-on: https://chromium-review.googlesource.com/666321Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#506462}
-
Becky Zhou authored
Bug: 507469 Change-Id: I023ba00b05b21bfd57ed9dc2a6f2ca0d7cd51c28 Reviewed-on: https://chromium-review.googlesource.com/699745Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#506461}
-
Uttam Thakore authored
This CL fixes the bit arithmetic in the constants used to generate UMA histograms for local network request metrics. The problems with the arithmetic are detailed in the associated bug. BUG=764852 Change-Id: Ifd06282b05b1893cae7756840893053fc1daa057 Reviewed-on: https://chromium-review.googlesource.com/699703Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: U Thakore <uthakore@chromium.org> Cr-Commit-Position: refs/heads/master@{#506460}
-
Daniel Murphy authored
Bug: 771630 Change-Id: I424e87f5873bd627b2756f9b54ee55e75c9b6ef0 Reviewed-on: https://chromium-review.googlesource.com/699766Reviewed-by:
Chris Mumford <cmumford@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#506459}
-
Simon Que authored
This feature is too specific. It should not be hard-coded into the log source system. Instead, it should be implemented by the caller of the API that uses these log sources. BUG=767742 Change-Id: I43da7adfb36c3ab899099fc174ce07a327673c00 Reviewed-on: https://chromium-review.googlesource.com/687810 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#506458}
-
Wez authored
The test file doesn't need to be so large, and the size exceeds a limit under Fuchsia, breaking the test. Bug: 771429 Change-Id: I8421843fe43b66a3e769d70e6cb626d7b60ec040 Reviewed-on: https://chromium-review.googlesource.com/699597Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#506457}
-
Will Chen authored
Makes it easier to see that we have a lot of slow tests in DevTools :( Bug: 667560 Change-Id: I6f09032d3f34502ea117480f1cf94f995c368052 Reviewed-on: https://chromium-review.googlesource.com/692979 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506456}
-
Francois Doray authored
Since the spellchecker code has been migrated from the FILE thread to TaskScheduler, tests need to use content::RunAllTasksUntilIdle() instead of base::RunLoop().RunUntilIdle() to wait for all spellchecker-related tasks to run. Bug: 770653 Change-Id: I8c4ac0e1183d8e11b8d60e334140e1fc1066d787 Reviewed-on: https://chromium-review.googlesource.com/695835Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#506455}
-
Max Moroz authored
I've been testing the changes on net_parse_cookie_line_fuzzer, which is a fuzz target of average size written in C++. Improvements step by step: 0) Original configuration, Coverage + ASan: 158 MB 1,000 exec/s 1) Prohibit ASan (and other sanitizers), use only Coverage instrumentation: 132 MB same speed The following change hasn't been applied, but let's keep it in the description FTR: - 2) Disable sanitizer coverage (which is different from clang source-based coverage): - 90 MB 1,088 exec/s (speed +8-10%) 3) Avoid optimize_for_fuzzing config (i.e. use -O3 instead of -O1 for coverage build): Same size 1,773 exec/s (speed +60-65% on top of the previous change) 4) Disable coverage for libFuzzer source code: 88 MB 3,988 exec/s (speed +125% on top of previous changes) 5) Disable coverage for libc++ and libc++abi sources (https://chromium-review.googlesource.com/#/c/chromium/buildtools/+/693570): 86 MB 4,110 exec/s (speed +3% on top of previous changes) In total, for that particular target: - build size reduced by ~45% - execution speed increased by ~310% I've also tested the changes with zlib_uncompress_fuzzer (a tiny fuzz target for C-library): - build size reduced by ~83% - execution speed increased by ~120% I haven't measured impact on the other fuzz targets, so it may vary a lot, but the result seems to be quite significant anyway. Bug: 759794 Change-Id: Icf61c979e38d0f7849ab7281bd9e24cf2b7a7d02 Reviewed-on: https://chromium-review.googlesource.com/693564Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#506454}
-
Nate Chapin authored
GetTaskRunner() will crash with a nullptr ExecutionContext, and all the other work is nonsensical in the absence of an ExecutionContext. Bug: 763040 Change-Id: Ide915c02265e35e55c7dc5aa234652efc5016b55 Reviewed-on: https://chromium-review.googlesource.com/698606 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#506453}
-
Helen Li authored
Moves upload bytes out of the for-loop to use less memory on the stack. Bug: 771366 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Icc1e20c8c6191f13c8889324699fd47bf8a1108c Reviewed-on: https://chromium-review.googlesource.com/700482 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#506452}
-
Peter Kotwicz authored
This CL makes WebApkUpdateManager store the "WebAPK update request" to disk and retrieve it from disk once the WebApkActivity is ready to do the update (Once the WebApkActivity is in the background). This CL is in preparation for https://codereview.chromium.org/2948713002/ The "WebAPK update request" cannot be encoded as an extra on com.google.android.gms.gcm.Task#setExtras() because GCMNetworkManager limits the total size of the extras to 10KB. We might send up to two PNG images as part of an update request BUG=713655 Change-Id: I9d86eb8ffe4f650340028ec6c4d12a7b8ddc1aec Reviewed-on: https://chromium-review.googlesource.com/581231 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#506451}
-
Sadrul Habib Chowdhury authored
Create a separate thread for the compositor. Use the thread the GpuMain instance is created on as the thread for the GpuService. This allows using it in content (in GpuChildThread), where the main thread is used for the gpu service. For the mus window server, until the gpu process-split happens, create a separate thread for the gpu service from the DefaultGpuHost. After the process split, the main thread of the new process can be used for the gpu service (like GpuChildThread in content). BUG=730213 Change-Id: I02eb4fef21bfbdac92201c35b96ac15473a43567 Reviewed-on: https://chromium-review.googlesource.com/693075Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#506450}
-
Tim Dresser authored
There was previously a rare race condition in which trace events would arrive in a different order, breaking this test. We don't actually care about the ordering of these events, so we no longer verify their order. Bug: 736836 Change-Id: Iabb65f603c7fbb985faa97f43a65a5313711c53f Reviewed-on: https://chromium-review.googlesource.com/700714Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#506449}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=cylee@chromium.org Bug: 666525 Change-Id: I08c5ee78b78aa268e37fe78651b915b12da0f635 Reviewed-on: https://chromium-review.googlesource.com/689024Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#506448}
-
Marc Treib authored
instead of separate *Result functions. This is made possible by Mojo, and resolves a TODO. Bug: none Change-Id: I5c1cda056b18beb0d9a2354078c05dffe5823c02 Reviewed-on: https://chromium-review.googlesource.com/695227 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#506447}
-