- 04 Nov, 2020 37 commits
-
-
mlcui authored
This fixes two issues: - If |has_invalid_dom_key| is set and |item.shortcut_message_id| was missing, the old logic would incorrectly DCHECK instead of displaying the "no mapping" string. - Dynamically changing the length of replacement strings does not change the shortcut message used. This isn't a problem with the current implementation, as the length of replacement strings is static, but may be a problem if replacement strings are dynamically chosen in the future. Change-Id: Idfa355b68e29508125e2278dac83a60f7a215807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513307 Commit-Queue: Michael Cui <mlcui@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#823833}
-
yilkal authored
If access token fetch fails, this cl logs the error and shows the error screen. Bug: 1144327 Change-Id: Ib8c4fbd3226cc05910eb209ba5ead1f47fd097b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511909Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#823832}
-
Ahmed Fakhry authored
In this CL, we observe the following events: - A window being recorded gets closed. - A display being fullscreen-recorded gets disconnected. - System shutting down. The above events end video recording. BUG=1142994 TEST=Added new tests. Change-Id: I5f03448d1399297e9589d561d9854b3c8cffc0f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516239 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#823831}
-
David Grogan authored
These failed due to firefox and chrome using different default fonts. I avoided that problem by assigning a fixed width to the divs containing the words. These tests now pass when I run them locally in firefox with ./wpt run --binary ~/ff-nightly/firefox firefox css/css-flexbox/gap-006* This was filed in https://github.com/web-platform-tests/wpt/issues/26326 Fixes web-platform-tests/wpt#26326 Change-Id: Ib0795c67bce5f80f7a33e1da74a026c1ed574b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515226Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823830}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b5bf82693f85..59eb5dd0e10d 2020-11-03 capn@google.com Set LLVM_ENABLE_ABI_BREAKING_CHECKS for Debug builds only If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1140854 Tbr: swiftshader-team+autoroll@google.com Change-Id: I9b97096aa12031db135e3c855a0eccf8bf9b3dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518119Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823829}
-
Gyuyoung Kim authored
//extensions/buildflags/buildflags.gni file has been importing build/config/features.gni file. But, it doesn't use any thing defined in build/config/features.gni. So, this CL removes the unneeded import. Bug: None Change-Id: Idd6528a33b0006a226cc2e1aae8ed82de5d51246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516059Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#823828}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I5492665f54e7d5a819f058d0f909d9ae609baa53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518099Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#823827}
-
David Black authored
Previously only horizontal (bottom) shelf was supported. RTL support still needs to be implemented in a follow up CL. Bug: 1142572 Change-Id: I3db767416869bb2c579850e4b8991d8bf1e568ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515094 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#823826}
-
Oleg Davydov authored
Replace std::string with ExtensionId in extension_updater.{cc,h} where applicable. This is a follow-up to https://crrev.com/c/2503690. Bug: None Change-Id: Idff56f4e5f6eb900834e355c62b2c8a8d3044521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516859 Auto-Submit: Oleg Davydov <burunduk@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823825}
-
Ana Salazar authored
As nearby shared files are added to the model, show the item chips in the holding space tray. The recently nearby shared files will show on the Downloads section and will be treated as regular downloads. Bug: 1130625 Change-Id: I082f46945138e487bb926c019a404af31b6871a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514774Reviewed-by:
-
Asanka Herath authored
These two parameters are necessary to partition statistically incompatible reports. Changes in `Generator` signal changes to code that affect how digests are calculated. Meanwhile changes to `Generation` signals that the study parameters have changed in a way that makes data from different `Generations` incompatible with each other. UKM Privacy Review: https://docs.google.com/document/d/15_Rcuc9P0UC26N26K8jM-W9uCsW57xEE83JksbWyZ-g/edit?usp=sharing (Google internal, but pretty much says the above). Bug: 1144225, 973801 Change-Id: I40e2d91e09150126ecbee9479db418a9f58c1193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510534Reviewed-by:
Alex Turner <alexmt@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#823823}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I0ff55e17f4b2dd73517509b1521297f582113665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518324 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#823822}
-
Evan Stade authored
Bug: 1057100 Change-Id: I1e69334805631fb697d35ef05d611921dc81854b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518138 Commit-Queue: Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#823821}
-
Hiroki Nakagawa authored
This reverts commit 573667ec. Reason for revert: LocalSyncTest.ShouldStart is failing on Mac bots: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/60761 https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/56727 Original change's description: > Enable roaming profile support on mac and linux. > > Don't add a default roaming profile location, so this feature > will only work when RoamingProfileLocation is set as well. > > BUG:1145172 > > Change-Id: I0353e65127bdb84fc7185201d1908bb4b545db18 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507890 > Commit-Queue: Chris Sharp <csharp@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823795} TBR=pastarmovj@chromium.org,csharp@chromium.org,treib@chromium.org Change-Id: I5cd261f409268e2318a27bfbe04e4091767afb6c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517345Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#823820}
-
David Van Cleve authored
Document.hasTrustToken is a JS method only available in secure contexts. Its implementation involves getting a Mojo interface from the browser and sending an IPC. In the browser-side code, in RenderFrameHostImpl, where we handle requests from the renderer for this Mojo interface, we perform a security check to make sure we aren't receiving requests for the interface from unexpected places, which could indicate a bad renderer. The current check makes sure that the request is coming from a frame with a potentially trustworthy origin. However, this is not exactly the same thing as a secure context: in particular, allow-scripts sandboxed iframes can be secure but not have potentially trustworthy frame origins. This leads to false positives in the check and unwanted renderer kills. This CL removes the check. R=dcheng Bug: 1144057 Change-Id: I0e57669606effb15c672586297ef7dcf2711bc91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511882 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#823819}
-
Jonathan Ross authored
The various GraphicsPipeline.* metrics are deprecated, replaced by the newer CompositorLatency.* metrics, which have more breakdowns from cc and blink. BUG=884851, 1088832 Change-Id: Ice3cd0cf07db8def51263bb080bfacebbaf9aa35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120362 Commit-Queue: Jonathan Ross <jonross@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#823818}
-
Mason Freed authored
With this CL, file:// URLs will no longer get an exemption to keep using Web Components v0 features. Bug: 1111843, 937746, 1025782 Change-Id: Ifbb8801b3d9eb02e124109c137e64dbbd8dafdf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514672 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823817}
-
Clemens Arbesser authored
An instance of this class will be shared across all trigger scripts to facilitate evaluating static trigger conditions. Bug: b/171776026 Change-Id: I07bef617159ec61f44ef6c96d899d8f3d01b771a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514154 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#823816}
-
Victor Costan authored
Change-Id: I8b65fa141781adc4016563bf54c6f621959ecc79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518323 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Michael Thiessen authored
Updates imports in content/ to use the base/ CriteriaHelper Bug: 1134178 Change-Id: I1993bf4128c1422491bf93ca36e328f51c5b78d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518037 Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823814}
-
Michael Thiessen authored
Updates imports in weblayer/ to use the base/ CriteriaHelper Bug: 1134178 Change-Id: If0dcbaff1e01f02220f22388c05f25171d138c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518793 Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
-
Becca Hughes authored
There is a memory leak in the cross thread copy of MediaPlayerWatchTime. This converts it into a unique_ptr which should prevent that. BUG=1144736 Change-Id: I8e47948a65ace5c8f4b58897fc927cd4165ed27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518096 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#823812}
-
Liquan (Max) Gu authored
Extracts the part of CPRService#onPaymentAppCreated that can be shared with WebLayerPRService into PRService. Bug: 1144527 Change-Id: I9d984e100a8ffa4935a0e4df6e174d0f91b55ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515049 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823811}
-
Justin Donnelly authored
Change-Id: Id6ca93ae981f128896138524891f8d1b1615e6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518713Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#823810}
-
Nate Chapin authored
Change-Id: I984d54a50f7317de35f08261b76eeef65365e36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518757 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#823809}
-
Hiroki Nakagawa authored
Sheriff: Mark http/tests/devtools/sources/debugger-ui/continue-to-location-markers-in-top-level-function.js as flaky Bug: 1144273 Change-Id: I471561caba1630c35a74f84927f64391e46b196f Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518305Reviewed-by:
-
Zufeng Wang authored
This change lets the inner frame of the help app clear the search index. Make the mock app add test data to the local search service similar to the chrome branded build. Bug: b/172018145 Change-Id: Ief94524c63b70a969500e94ece1b9e1aad811c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513806 Commit-Queue: Zufeng Wang <zufeng@google.com> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#823807}
-
Michael Thiessen authored
Updates imports in chrome/android/javatests/ to use the base/ CriteriaHelper Bug: 1134178 Change-Id: I7e919f3cb68f49a138bdb0513bea903769a07361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518217 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#823806}
-
Sinan Sahin authored
Bug: 1144773 Change-Id: I8cf714fa6923f99db29435b5c83917ac7fc9aa50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518094Reviewed-by:
Lijin Shen <lazzzis@google.com> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#823805}
-
James Cook authored
The Chrome OS exo Wayland server provides the zcr_cursor_shapes_v1 interface to allow clients to request server-side cursor shapes. Bind the interface and wrap it in a WaylandZcrCursorShapes class. Future CLs will use the interface for cursors for Lacros. Bug: 1143790 Change-Id: Ib6224e6ef5945f9e2f7403b0afd38a53611a88c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518765Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#823804}
-
Liquan (Max) Gu authored
This CL rearranges CPRService#invokePaymentApp and extracts the part that can be shared with WebLayer into PRService#invokePaymentApp. Bug: 1144527 Change-Id: I1a2a8a4983e58b9001da9b43b9ce901a56fea47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515047 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Peter Kasting authored
Bug: 772945 Change-Id: I438b94516567877c93f1357db189826e72a71470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515272 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#823802}
-
Mark Mentovai authored
On mac-arm64, allow the x86_64 Widevine content decryption module (CDM) to run under Rosetta translation, even when running native arm64 Chrome. This is necessary because there isn’t currently an arm64-native Widevine CDM. It’s not necessary to run the rest of Chrome as x86_64 under Rosetta translation. The isolated Widevine CDM runs in its own x86_64 utility process, and is IPC-compatible with the rest of Chrome. This alleviates any performance impact on the rest of Chrome, and allows crash reporting to work correctly for the rest of Chrome. An ordinary build of Chrome for mac-arm64, even an official build, will not include a bundled x86_64 Widevine CDM library (or, obviously, an arm64 one, as it does not yet exist). The x86_64 Widevine library is useless to an arm64 Chrome without an x86_64 process to host it. However, if a universal build of Chrome is created by merging same-version x86_64 and arm64 builds, the arm64 code will look for an x86_64 Widevine CDM and, if found, launch an x86_64 helper process under Rosetta translation to host it. https://chromium-review.googlesource.com/c/2515521/ is a proposal for creating such a universal build. Implementation notes: if no Widevine CDM library is found in the arm64 platform-specific location, Chrome on mac-arm64 will look for one in the x86_64 platform-specific location. This allows mac-arm64 Chrome to find the x86_64-only bundled Widevine library. Separately, any Widevine library found will be examined to determine its architecture. If it contains x86_64 code and no arm64 code, an x86_64 helper will be launched to host it. This is done because, although the Widevine library bundled in Chrome is known to be x86_64-only and will only exist in the x86_64 platform-specific location, it is expected that a future update distributed by the component updater will support arm64 natively. However, in the event that a component update is produced that supports x86_64 but not yet arm64, it is likely that the x86_64 version distributed to arm64 users as a component update will appear in the arm64 platform-specific location, despite being x86_64 code. This means that the platform-specific location path cannot be trusted to convey the actual architecture of the library contained therein, and the architecture must be determined by examining the library to be loaded. No behavior change for non-mac-arm64 builds. Bug: 1142017 Code-Word: calamity CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel Change-Id: Ib3f4a654f89f41c0fbf9239f99010387ea242763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493191 Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#823801}
-
Michael Thiessen authored
Updates imports in chrome/test/ to use the components/ CriteriaHelper Bug: 1134178 Change-Id: Ia1165bf9cd9427a1d696897e77767d96b076afd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518892 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#823800}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I60955c98bcf71e0b62d48a7335bb00acb947e88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518636Reviewed-by:
-
David Dorwin authored
This is necessary for forwards compatibility with SDK changes and consistent with most other clients. Bug: fuchsia:63529 Change-Id: I5dca17d93d0563849c288780fd90317b0ed5f953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518131 Auto-Submit: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823798}
-
Michael Thiessen authored
Updates imports in chrome/test/ to use the base/ CriteriaHelper Bug: 1134178 Change-Id: I6a0d12f41867d7f75361170ee4a562c3bdcd34fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518891 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#823797}
-
- 03 Nov, 2020 3 commits
-
-
Darren Shen authored
We want to enable autocorrect more widely, so enable it by default unless the app explicitly disables autocorrect or spellcheck. Bug: b/161490915 Change-Id: I4789906e65c325f4cb6c5687e1ce095eb2baa4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516139 Auto-Submit: Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#823796}
-
Chris Sharp authored
Don't add a default roaming profile location, so this feature will only work when RoamingProfileLocation is set as well. BUG:1145172 Change-Id: I0353e65127bdb84fc7185201d1908bb4b545db18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507890 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#823795}
-
Istiaque Ahmed authored
This CL runs PermissionsApiTest.OptionalPermission and PermissionsApiTest.OptionalPermissionsAutoConfirm tests with service worker based extensions. Bug: 986416, 1093066 Test: Test only change Change-Id: I9135147ca731f9d93ec723c989fe872275e7d3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516392 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
