GitLab

As above this is a partial revert of:
https://chromium-review.googlesource.com/c/chromium/src/+/1158391

(partial as LayoutObject::IsLayoutNGObject() is used elsewhere now).

Bug: 869866
Change-Id: I9e775fc484f004445a0a7d03cd899943dc5a07af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611859
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659682}

Deprecate the use of field trial, and use a feature instead.

Bug: 955544
Change-Id: I32c069d0e5960af90256382132db93250613d754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610582Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659681}

This is a reland of 3bd9684c

The failure was not getting an entry for click:
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/13241

Thus, we instead look at the mousedown. Since mousedown can be the first
input, we stop observing for firstInput but check that entry separately
as well.

Original change's description:
> [EventTiming] Fix programmatic click test
>
> Commits aee8357d and
> faed29aa landed almost at the same time,
> so we accidentally landed a test with the wrong script src for the
> helper functions.
>
> Bug: 961547
> Change-Id: Id8a615477a54e56139d9d90fc4feb5f780b729a2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606225
> Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#658761}

Bug: 961547
Change-Id: I11f1a5f28e7e4e5ebda28c90555d89669142cc09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610022Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659680}

After calling #setImageDrawable(null), the Bitmap is still retained
in the BitmapShader of mPaint. This CL resets the Shader in that case.

Bug: 959886
Change-Id: I995f46940281eedd4160b139e67a5ee4e18b5c34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595292
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659679}

The DerivedGeometry class gets moved from exclusion-space to
exclusion-space as a fast way of determining layout opportunities (where
lines, etc get placed).

For speed we only allocate "NGShapeExclusions" if we've seen any shapes
within the formatting context.

This crash was due to an inconsistent state of the:
NGExclusionSpaceInternal::track_shape_exclusions_ flag.

"other" NGExclusionSpaceInternal
 - derived_geometry_ = (non-null)
 - track_shape_exclusions_ = false
 - num_exclusions_ = 1u

"this" NGExclusionSpaceInternal
 - derived_geometry_ = null
 - track_shape_exclusions_ = true
 - num_exclusions_ = 2u (2nd exclusion has shape data).

Within the NGExclusionSpaceInternal::MoveAndUpdateDerivedGeometry method
we moved the derived geometry over to the "this" exclusion space.

However we didn't also move the track_shape_exclusions_ flag as a result
we'd try to add the 2nd shape exclusion, and a NPE was hit.

Bug: 962135, 962272, 962052
Change-Id: Id095bd2924f83ba6b2dbe90446d1f4613de09933
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610021
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659678}

This CL ports existing permission dialogs to use TouchlessDialogPresenter
when in touchless mode.
Since permission dialogs in touchless mode have titles that describe the
type of permission, this CL also adds the new GetTypeText() to the
PermissionRequest class.

Link to UX deck: https://docs.google.com/presentation/d/1c-aVSZ_zsBuzCwQ4CrBJppmRQjiupa6PXmlC2OS-F-Q/edit#slide=id.g4fb0666bdb_2_5

Bug: 959204
Change-Id: I749dcfe28b7d5264947325e0d72f62f5ca300c96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606564
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659677}

ComboboxModelObserver already exists that provides this functionality,
and ComboboxModel implementors already presume the existence of
ComboboxModelObserver via ComboboxModel::[Add|Remove]Observer.

Additionally, consumers of Combobox really shouldn't manually
call Combobox::ModelChanged(). This should be handled on the model
and the model itself needs to signal when changes occur.

This change as a result has the Combobox start listening to model
changes a la ComboboxModelObserver. This is a no-op for read-only
models as they get the no-op [Add|Remove]Observer default
implementation.

Dependent components have also been updated to account for this change
in behavior.

BUG=946299

Change-Id: Ie71949685dfa8015bad6fdb973512b7efb38c7a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610229Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659676}

The fix is not to allow paint fragment traversal if layout is
dirty. The traversal was triggered by:

NGPaintFragment::SetShouldDoFullPaintInvalidationForFirstLine

There were other methods doing unsafe paint fragment traversals,
and this will prevent all of them from traversing a dirty
layout tree.

Bug: 962141
Change-Id: I2b44a2cdb250f26f654e108787477f2190a35658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612219Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659675}

Bug: None
Change-Id: Ie09a114edcc86bc3489100cc5fcf3655fad9bf36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612053
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659674}

This made sense with SingleProcessMash, where we would have two aura::Envs.
As we're no longer doing mash, that restriction is no longer applicable.

BUG=958116
TEST=none

Change-Id: Idabfcebb5da1f0052d31eda44b221fb08748f38a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611113Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659673}

This CL makes sure certain ChromeMimeHandlerView tests do not run run
with MimeHandlerViewInCrossProcessFrame; these tests expect the MHV
to run BrowserPlugin which is not the case with the flag.

Bug: 961786
Change-Id: Idbf568be5dd2e38d6677084dea37e6e563795ac9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611966Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659672}

Bug: 802836
Change-Id: I1b5b4184631dcb98b5ea10e76c90238b8b4844f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604244Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659671}

This CL allows SimpleDownloadManagerCoordinator to take a callback
that can be used to create the full manager and perform a download.
For some clients such as fetch and Chrome OS, they require full manager
to download the content. If the coordinator is using in-progress manager
when those clients calls DownloadUrl(), it can switch to the full
manager and carry out the download.

BUG=942770

Change-Id: I7f1864635e87822b45f15c9e72d40edfb4a16a2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610528
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659670}

Fix 3 test failures on Windows.

Note: Manually tested on both Linux and Windows, since grit tests do
not run on the trybots.

Bug: 961359
Change-Id: I69ee6933b570795e3d963317f2b326fbfb6c0322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605158Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659669}

So that it will be tested by monochrome_apk_checker.

Removes some unittests from Android that were relying on pak entries
that the whitelist removes (not used on Android). Some adjacent unittests
also removed because they also seem to be desktop-specific (see previous
patchset bot results for which tests actually failed).

Bug: 960881, 961270
Change-Id: I00f571ac9bbffa1a90c8f6414b007b3ad9b4b478
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600421Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659668}

Change-Id: Iccb464ea241b504faa07fbf2dfb588fdfbbfb568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612323
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659667}

Bug: 943638
Change-Id: I66ca64966dcc2b315e48c2477c8ee66e57f3e7c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607158Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659666}

This CL adds a new histogram enum GAMEPAD_INTERACTION to
Arc.UserInteraction, which will be recorded on the first time a user
sends a gamepad event to an ARC++ app window. It resets every time the
window is deactivated.

This will be used as success metrics of ARC Improved Gamepad project
go/arc-improved-gamepad.

TEST=manual(Press gamepad buttons when an ARC++ app is active and check
chrome://histograms)
BUG=b:130597086

Change-Id: I90c4d00399a7227a102ebd9e81861b735bef6001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605667
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Maajid <maajid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659665}

This patch skips innerText processing for elements that are either
display locked, or are inside a locked subtree.

This is due to the fact that display locked subtrees are not painted
and so should behave in the same way as visibility hidden (or display
none elements).

This also ensures that we don't access text nodes when they have not
been laid out, which is possible in display locking. This causes
CHECKs with LayoutNG.

R=chrishtr@chromium.org, rakina@chromium.org, xiaochengh@chromium.org

Bug: 962569
Change-Id: I0f286b7ea55e72baada3d9f2c10f4ea693e268d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609666
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659664}

Having a local version of clang-format v7.0.1 fails due to differences
in chromium/src/.clang_format.

This is redundant anyway since it is covered by git cl format at the end
of cmake_update.sh

Change-Id: I58ae0ab1dcdda3c6c91b83e8402c6bdf05f2e106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610430
Auto-Submit: Johann Koenig <johannkoenig@google.com>
Reviewed-by: James Zern <jzern@google.com>
Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#659663}

Change-Id: I5b06e37fe7f3029a670f917443c688be5be01da6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589099
Commit-Queue: John Williams <jrw@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659662}

Currently FCP++ doesn't ignore the text paint in the block stage. The block
stage happens when we have font-display:block for a text node and the
webfont of the text is not yet loaded.

FCP++ should ignore the text because it's not visible to users. The text should
be captured only after the text starts to be visible.

The block stage is controlled by Font::ShouldSkipDrawing(). When a text node
is blocked on web-font, the text would be set to invisible-font. So FCP++ should
use this method to tell whether the text would not be drawn due to the
invisible font.

Bug: 944530
Change-Id: If80a5bdeccce0896d0e4e836c89bfd9aefbd627d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609669
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659661}

Add a bool in layer_tree_debug_state. And update the methods
where needed in the cc file.

Declare the flag and its definition in content_switches.

Finally, add the flag in the render_process_host_impl and use it in
the initialization of layer tree settings in render_widget.

Bug: 961846

Change-Id: Ia82da07d65dc5ea829824a077e971b7102e754bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603404Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Rasha Nasri <rnasri@google.com>
Cr-Commit-Position: refs/heads/master@{#659660}

PaintChunks can be printed using --vmodule=*paint_controller*=2 [1] but
the output format is verbose. This change introduces another verbosity
level to paint_controller:
1) Paint chunks and display item list in compact form.
  --vmodule=*paint_controller*=1
2) Paint chunks with detailed display item list.
  --vmodule=*paint_controller*=2
3) Paint chunks with detailed display item list with paint records.
  --vmodule=*paint_controller*=3

Sample output from --vmodule=*paint_controller*=1:
"chunks": [
  {
    "chunk": "LayoutSVGRoot 0x23d6a28338:LayoutSVGRoot svg class='qr':ClipPaintPhaseForeground:0",
    "state": "t:0x323d114b10 c:0x323d1c4a10 e:0x323d02c190",
    "displayItems": [
      "0x23d6a38018:LayoutSVGPath path:DrawingPaintPhaseForeground:0"
    ]
  },
  {
    "chunk": "InlineTextBox 'Text box' 0x23d6a60190:InlineTextBox 'Text box':DrawingPaintPhaseForeground:0",
    "state": "t:0x323d114840 c:0x323d1c48d0 e:0x323d02c190",
    "displayItems": [
      "0x23d6a60190:InlineTextBox 'Text box':DrawingPaintPhaseForeground:0",
      "0x23d6a60090:InlineTextBox 'text':DrawingPaintPhaseForeground:0",
      "0x23d6a60010:InlineTextBox 'more text':DrawingPaintPhaseForeground:0"
    ]
  }
]

[1] https://docs.google.com/document/d/1vgQY11pxRQUDAufxSsc2xKyQCKGPftZ5wZnjY2El4w8/edit#heading=h.me4dzticloz0

Change-Id: I87c02c16121d63edca4ba1255b3d5aff348013eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610494
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659659}

ProfileImpl curently has a unique_ptr<ConfigurationPolicyProvider> and a
UserCloudPolicyManager* that is points to the same object - when not in
Chrome OS.

This CL changes the ownership to be the most specific object type:
- unique_ptr<ConfigurationPolicyProvider> in Chrome OS
- unique_ptr<policy::UserCloudPolicyManager> in other platforms

This change is a precursor of
https://chromium-review.googlesource.com/c/chromium/src/+/1579768
which will break the Chrome OS options further.

Bug: 937770
Change-Id: I9aea3b2f40afbbd0801cca61cd1a64a3e63cc57c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606576
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659658}

This change requires for /ios_internal repository(submit only after this cl)
https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/1284283

This is part of EG1 to EG2 migration, which involves moving EarlGrey code from
app-side helpers into test code. For GREYAsserts, the policy is to take assert-
containing-helpers, modify them to return NSError* with localizedDescription
containing the assert failure (in the event of a failure), and then assert
on the result of the helper on the test side.

Bug: 922813
Change-Id: I42086810e5efe23139210fa1e198c14665f903bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606248
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659657}

Refactors the remaining WMR wrappers that have mock implementations
(those in wmr_timestamp.h and wmr_rendering.h) in the same way as
https://crrev.com/c/1603748.

Bug: 961020
Change-Id: I0a28f981cf705c4950b660058712c9643546a784
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611422
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659656}

This is removing the latest IPC for Picture-in-Picture and solves one bug that
had the element not notified of the Picture-in-Picture state change if the
window was closed after the src was reset and therefore the media player wasn't
able to get the IPC.

Bug: 919860, 940694
Change-Id: I3f2badd7724fc9037d360bf88fb22adc3b7f14a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611509Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659655}

Adds a parameter for the |sct_list| in CertVerifyProc::Verify and CertVerifier::RequestParams.
This parameter is ignored in the other CertVerifyProc subclasses.

Also hooks up the |ocsp_response| in ProofVerifierChromium::VerifyCertChain while we're there.

Bug: 953384
Change-Id: I49d036069d448da6f3452b7d75ee0dc375144250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592802
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659654}

https://www.chromestatus.com/feature/5730672977117184

Bug: 907952
Change-Id: I4a12d5b1cc5607d462b20e44c69cf842a27e277c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602676
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659653}

Simplifies the code, and avoids multiple queries to gather the set of pages.

Bug: 949162
Change-Id: Ibc4c0d4729b629d93424bc046ecd499b14ac01c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602974
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659652}

When a USB memory is plugged, we currently show "Removable
device detected" notification with one button, "OPEN FILES
APP". This CL adds one more button "OPEN SETTINGS" to the
notification when ARC is enabled for the user to allow the
user to control ARC apps' USB storage access settings.

UI mock: go/filesapp-arc-extdriveaccess (page 10)

BUG=936814
TEST=browser_tests --gtest_filter='FileManagerJsTest.DeviceHandlerTest'

Change-Id: I027d70a80e678ab86de4c192556f7890dd336d71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585382
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659651}

This CL fixes SplashScreen.visible tracing which regressed in
https://chromium-review.googlesource.com/c/chromium/src/+/1592829

BUG=817263

Change-Id: I279820ccabfbbb462bd4aa14c33151875c111c88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607500
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659650}

Under an experiment flag, indent keyword suggestions when fully in
keyword mode, to more obviously indicate separate state.

Bug: 883901
Change-Id: I9a7b90b6297e25699d1e811b5a7d27a34a338d9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602158
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659649}

This bubble will show after the user click on the omnibox share icon.

Bug: 958170, 950388
Change-Id: I4f41fae730d3b1724a3bae08b223af9bf8668920
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600376
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659648}

CL:1583420 added a new Chrome pref that controls ARC's storage access.
This CL adds a new UI to chrome://settings to update the pref value.

UI mock: go/filesapp-arc-extdriveaccess (page 9)

BUG=936814
TEST=try

Change-Id: I6708456460f40e7c61ddcff573eabbf8f88ede24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583425
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659647}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9d5d210a420f..40748dc575b7


git log 9d5d210a420f..40748dc575b7 --date=short --no-merges --format='%ad %ae %s'
2019-05-14 saklein@chromium.org Build API: Fix FEATURES default.
2019-05-14 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@40748dc575b7

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I3a6c654bcdc5af7db614cd220e375081556fedb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611382Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659646}

Updates the VR video test goldens to pick up a slight change to how one
of the characters in the timestamp is rendered. Also re-enables the test
since it was disabled due to the bad goldens.

TBR=alcooper@chromium.org

Bug: 962397
Change-Id: I12cb8d187d69a28c5dc0796a5838f5c6ec3a229c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610198Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659645}

Add metrics for recording how long it takes for the user to accept or
cancel an extension installation prompt (2 total).

Bug: 952427
Change-Id: Iaa6c9646a280d5e522dd1fa0943bc3573016be51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607340
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659644}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d56a905e68a2..ddf034cde9e9


Created with:
  gclient setdep -r src-internal@ddf034cde9e9

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com

Change-Id: I0fbcc2a83e3ccd3d9f90c925f1bf185b92d719a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611380Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659643}