- 13 Sep, 2017 40 commits
-
-
Aidan Wolter authored
This CL adds the required test changes for the recent CL that added the headless argument to CastWebContentsComponent. Bug: None Test: None Change-Id: I7e6a2d229b5c7c78067c158547662463b690f93e Reviewed-on: https://chromium-review.googlesource.com/663300 Commit-Queue: Aidan Wolter <awolter@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#501521}
-
Tom Anderson authored
Now that the Linux packages are going to be built on all of the linux CQ bots, we shouldn't spam the console with miscellaneous info. This CL guards all of the logging behing the VERBOSE flag, but still prints command stdout and stderr when the return code is nonzero. BUG=758654 R=thestig@chromium.org Change-Id: Ia037371b836cbf059d37131a602037c5b972c182 Reviewed-on: https://chromium-review.googlesource.com/656566Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#501520}
-
Brett Wilson authored
Cleans up the remaining references and removes the temporary using statement. Bug: 763556 Change-Id: I25f3cc449bfb7b0da0bd113da3171105d2594188 Reviewed-on: https://chromium-review.googlesource.com/663792 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#501519}
-
Ahmed Fakhry authored
TaskManager rewrite fixed the assert failure hit by this test. It no longer needs to be disbled. TBR=pkasting@chromium.org BUG=469717 Change-Id: Ifcd406a631953491123792fa61caaf5628d52223 Reviewed-on: https://chromium-review.googlesource.com/663303Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#501518}
-
Alex Moshchuk authored
DevTools audits trigger a ViewMsg_EnableDeviceEmulation on a pending RenderFrameHost (see EmulationHandler::UpdateDeviceEmulationState, via RenderFrameDevToolsAgentHost::AboutToNavigateRenderFrame), which is processed by the frame's widget (WebViewFrameWidget) before the frame commits. In that state, RenderWidget::OnOrientationChange crashed, because even though IsWebFrameWidget() was true for this widget, WebViewFrameWidget::LocalRoot() returned null, since the frame wasn't swapped into the tree yet. The LocalRoot() was then used to send screen orientation change events. It doesn't make sense to fire events on a frame that hasn't committed and isn't in the frame tree yet, so work around this by null-checking LocalRoot(). Bug: 764202, 764206 Change-Id: I26c1c9ce938abb7b18757b88356559a30aa08fec Reviewed-on: https://chromium-review.googlesource.com/662904 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#501517}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/db91c6e7fbfc..79a3aafc34c1 $ git log db91c6e7f..79a3aafc3 --date=short --no-merges --format='%ad %ae %s' 2017-09-12 benjaminwagner Add Clang GPU tasks. Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I8d472a0dc2385d6f22843a114b26e82963c67d64 Reviewed-on: https://chromium-review.googlesource.com/663894Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501516}
-
Daichi Hirono authored
Bug: 750997 Test: exo_unittests --gtest_filter=DataOfferTest.* Change-Id: Ic5d06494ae73d7b22e9463a5b303fb7c6a950259 Reviewed-on: https://chromium-review.googlesource.com/625513 Commit-Queue: Daichi Hirono <hirono@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501515}
-
Tetsui Ohkubo authored
This CL adds new material design icon to locale change notification. This CL also adds the notification title and shortens the message based on UX review (https://crbug.com/726241#c20). The icon and the accent color is effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG=726241 Change-Id: I16ac609c9f453064e27441c149ef2e4bcfa08d31 Reviewed-on: https://chromium-review.googlesource.com/662917Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#501514}
-
Stephen Martinis authored
TBR=rnephew Bug: 764543 Change-Id: I3d1bb5798f2de5f366a5ef4249d15696866c9586 Reviewed-on: https://chromium-review.googlesource.com/664351Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Walter Korman <wkorman@chromium.org> Reviewed-by:
rnephew <rnephew@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#501513}
-
Chris Cunningham authored
All supported video streams types should map to some VideoCodecProfile. This should be true even for "simple" codecs strings (e.g. VP8 and Theora) that only have one profile (or no formal notion of profile). This allows all codecs to be described simply by the VideoCodecProfile. For instance, media capabilities storage/querying of decode statistics is keyed by VideoCodecProfile. This change adds a profile entry for Theora and ensures that mime parsing code correctly maps to a profile for VP8 and Theora. BUG=695264 TEST=unit test Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7b48dfc6ab97d436820dae57606a4cf53d92af31 Reviewed-on: https://chromium-review.googlesource.com/658408Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#501512}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/5b2092a1ec59..f2ca50ffa2d2 $ git log 5b2092a1e..f2ca50ffa --date=short --no-merges --format='%ad %ae %s' 2017-09-12 tsepez Avoid double va_list traversal in CFX_WideString::FormatV Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I987609ebe506e6a02904fa571f0ef37abb30d937 Reviewed-on: https://chromium-review.googlesource.com/663834 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501511}
-
Philip Jägenstedt authored
Missing teams and components were identified using an ad-hoc script: https://chromium-review.googlesource.com/c/chromium/src/+/657580 Change-Id: I73c13f927f69df3d387ebd182091bc9a55dfff8c Reviewed-on: https://chromium-review.googlesource.com/659017 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#501510}
-
Evan Stade authored
message_center::NotificationDelegates. The Chrome specialization of this class just adds an id, but that id is always piped through to the underlying notification as the notification's id, so it's redundant. This patch introduces a new ctor for Chrome's Notification and switches over a couple of delegates. It also removes the delegate_id() pass through from Chrome's Notification since it's always the same as id(). Only a couple of NotificationDelegates are switched to extend message_center::NotificationDelegate, the rest are TODOs. It remains to be seen whether we can remove Chrome's Notification tag, but since the JS provided tag is cooked into the ID and for most non-web notifications the tag is identical to the id, I'm hopeful. TBR=stevenjb@chromium.org Bug: 763426 Change-Id: I69ced05e25129d428318fd10232eb20e7a8c4d0c Reviewed-on: https://chromium-review.googlesource.com/657599 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#501509}
-
Stephen Martinis authored
Bug: 717394 Change-Id: I4f3851f290d996746f209760f00ea8668e6091c8 Reviewed-on: https://chromium-review.googlesource.com/639577Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Sean McCullough <seanmccullough@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#501508}
-
Koji Ishii authored
This patch reflects recent renames to webkit.natvis. Tested by verbose output of natvis diagnostic messages. Change-Id: I2ce6b62eac562f6219c270d851710dbc99d6bd07 Reviewed-on: https://chromium-review.googlesource.com/662880Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#501507}
-
Guido Urdaneta authored
This patch makes VideoTrackAdapter ignore aspect-ratio limits when the input or output frame has zero area. Also, output dimensions are clamped to media::limits::kMaxDimension. Before this CL, an input source with zero area (e.g., from element capture) could result in undefined behavior when trying to correct the frame's aspect ratio due to casting of infinite or NaN floating-point values to int. Bug: 763676 Change-Id: I23794e7aba965ee8443bde5c36ef2adfe8cc2ba3 Reviewed-on: https://chromium-review.googlesource.com/663177 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#501506}
-
Devlin Cronin authored
This test was disabled for being flaky on XP. XP is dead. The test now passes 100 runs on Windows. Bug: 165834 Change-Id: I682cf656065e7006bb947aa7b04dc57d949ac516 Reviewed-on: https://chromium-review.googlesource.com/664077Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501505}
-
Brian White authored
This is an extension of cl/655922 that (temporarily) adds instrumentation to Android builds to try to determine the source of a core trampler. Bug: 744734 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I745eb4dcc40d59dfbcdf0e492e9bbd4aa31cab40 Reviewed-on: https://chromium-review.googlesource.com/657804Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#501504}
-
Kevin Cernekee authored
This is a new VPN type supported by shill, intended to let Android VPNs handle traffic from Chrome OS. BUG=696865 TEST=manually configure and query an ARCVPN network Change-Id: I591c914d5a6b22e4ba044a4d1c83520ee0e7fc36 Reviewed-on: https://chromium-review.googlesource.com/592541 Commit-Queue: Kevin Cernekee <cernekee@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#501503}
-
Tien-Ren Chen authored
This CL adds a new mode to use property tree to paint in SPv1, a.k.a. SPv175. The general strategy is to compute the property tree state of each drawable GraphicsLayer, and uses PaintChunksToCcLayer to generate meta display items using the state differences between the layer and each paint chunk. The scope of this CL: * Add blink feature SlimmingPaintV175 This flag is can be enabled manually or implied by SlimmingPaintV2. Setting this flag will enable full property tree building and paint chunk building. | Classic | SPv175 | SPv2 --------------------------+--------------------+--------------------+------------- REF::SPv175Enabled | false | true | true REF::SPv2Enabled | false | false | true Property tree | without effects | full | full Paint chunks | no | yes | yes Layerization | PLC/CLM | PLC/CLM | PAC Non-composited properties | meta items | PC2CL | PC2CL Raster invalidation | LayoutObject-based | LayoutObject-based | chunk-based * Add layer state support in GraphicsLayer The graphics layer will use PaintChunksToCcLayer (instead of AppendToWebDisplayItemList) to generate meta display items if a layer state specified. Eventually every drawable layer will have a property tree state in SPv175. * Compute main layer state in PropertyTreeBuilder This CL only computes the state of the main layer as proof of concept. Other notable drawable layers include scrolling content layers, squashing layers, will not work correctly and will be implemented by follow-up CLs. * Enable full property tree building, chunk processing, and disable meta display item creation This involves changing a bunch of REF::SPv2Enabled() to REF::SPv175Enabled(). Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I195b0b090207304e2d4b7064be8f8f3f252ad4b9 Reviewed-on: https://chromium-review.googlesource.com/654438 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#501502}
-
Siddhartha authored
To call OnHeapProfilingEnabled() on all providers, it is required to post task for each of them. This sometimes creates issues because the task runner may not be available when enabling profiling. So, only call on providers that support profiling. BUG=762994 Change-Id: Ic428f7c772e982167d3eb2260197e11a1f8685cf Reviewed-on: https://chromium-review.googlesource.com/657894Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#501501}
-
Sergey Ulanov authored
Two RangeGet tests were disabled in net_unittests on Fuchsia because they were flaky. It's likely that these two tests were fixed with http://crrev.com/500757 (which added IO event handling in RunLoop::RunUntilIdle()). Enable them to see if they are still flaky. Bug: 755552 Change-Id: I96146aa7e8247aff764853de656d9997d3cf5028 Reviewed-on: https://chromium-review.googlesource.com/663798Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#501500}
-
Bugs Nash authored
Bug: 668012 Change-Id: Ib461879750e52584990e1547c3807b12e08d6972 Reviewed-on: https://chromium-review.googlesource.com/663103Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#501499}
-
Oystein Eftevaag authored
Bug: 667892 Change-Id: I578c3b3386ee018b8a4ac2a097e56555a34c9f51 Reviewed-on: https://chromium-review.googlesource.com/611188Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#501498}
-
Jamie Madill authored
Now that we have enough CQ capacity, put the bots back in operation. BUG=713196,727437 NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I797460bac0313027f2f01031f1a49d223d4887df Reviewed-on: https://chromium-review.googlesource.com/663533 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#501497}
-
Pavel Feldman authored
Change-Id: I9feee0a202323ec4fce650f2042c24880ff485a0 Reviewed-on: https://chromium-review.googlesource.com/663528Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501496}
-
Erik Chen authored
Bug: Change-Id: Idd4d452d03c8c5c20628c35d788fb322ba99df39 Reviewed-on: https://chromium-review.googlesource.com/661945Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501495}
-
Andrew Moylan authored
Content shell and Android webview don't make network geolocation requests. Previously these embedders had dummy (no-op) implementations of AccessTokenStore. This CL removes the dummy implementations and instead uses the existing UseNetworkLocationProviders flag in GeolocationDelegate as a gate. This is part of the removal of all AccessTokenStores. Overall design: https://docs.google.com/document/d/1A-ZYMadJkwdQad_pC3MbpuCVNOOnRP_UZjGnXl-FOqE Details of reasoning why this is safe: Content shell: AccessTokenStore was being created but LoadAccessTokens was not being called on it (after crrev.com/c/641175). Android webview: AccessTokenStore was being created and LoadAccessTokens was being called on it, but to no consequence due to an "#if defined(OS_ANDROID)" block at location_arbitrator.cc:174. Bug: 748921 Change-Id: I10ed3668ee015f855acf604e445643617bbe7713 Reviewed-on: https://chromium-review.googlesource.com/658010 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Selim Gurun <sgurun@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501494}
-
Steven Bennetts authored
This adds support to networkingPrivate for selecting a Cellular mobile network. BUG=717063 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2cc89aaceae25e73d177cfdcb44e58912a5bbc2d Reviewed-on: https://chromium-review.googlesource.com/646571 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ben Chan <benchan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501493}
-
Erik Luo authored
Prior to this CL, some input fields did not have the 'x' button to clear text from the field. Namely, HeapSnapshotView's 'Class filter' and DatabaseTableView's 'Visible columns' will now behave consistently with the others. Screenshot: http://imgur.com/a/AJecJ Bug: none Change-Id: Ia1be529c0d2d851cbf63e01f4c69841f85ff75b0 Reviewed-on: https://chromium-review.googlesource.com/662398Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#501492}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ec37390b..36e9ca06 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I4e3b8048adf4e123a37c0939e132c707be1b29e0 Reviewed-on: https://chromium-review.googlesource.com/663301Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#501491}
-
Sergey Ulanov authored
Previously the classes for Unix domain sockets were compiled on all POSIX platforms, except NaCl, but the tests were disabled on iOS and filtered on Fuchsia. This change disabled compilation of these classes and unittests on all platforms on which they are not supported (iOS, Fuchsia and NaCl). Bug: 731302 Change-Id: I1da281845fd282d0f791cc4a324ef3d233f8a598 Reviewed-on: https://chromium-review.googlesource.com/664157 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501490}
-
Piotr Swigon authored
This is a revert of crrev.com/c/654118, as the decision has been made to hide the status bar icon on pre-O Android. This is because on pre-O users don't have the ability to selectivly silence notification channels, so making the notification least intrusive is important. Bug: 471623 Change-Id: If2efcdf680bba405fdf7c180119d6d6f331c38ab Reviewed-on: https://chromium-review.googlesource.com/663105Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Piotr Swigon <piotrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#501489}
-
Lisa Suzuki authored
This CL's intention is to adjust to the change of WebIDL's specification. Before this CL, Iterable's value types cannot be annotated. After this CL, however, Iterable's value types can be annotated types. In order to check if ASTs are dumped correctly, I also added pattern match based tests. Bug: 714866 Change-Id: I4e5cb09f36b6b7c04b7a0d3a32cff085691bcdc6 Reviewed-on: https://chromium-review.googlesource.com/662979Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#501488}
-
Sammie Quon authored
Move splitview window selector unittests to their own test class. Bug: None Test: ash_unittests Change-Id: I8153c916a05ef9ab6011105ca670dfc0e73ee257 Reviewed-on: https://chromium-review.googlesource.com/661327Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#501487}
-
Kyle Horimoto authored
This code was unnecessary, since the CryptAuth component is the one that needs to listen for these tokens. Additionally, the listener in this class was set up improperly, which made it possible to get "stuck" without a token. Bug: 763506, 672263 Change-Id: I3e02f10aa201b129591028a8606b6fb4eefbaf11 Reviewed-on: https://chromium-review.googlesource.com/663978 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#501486}
-
Victor Costan authored
Bug: 763650, 763848 Change-Id: Ideb5ab7ed300718458fe2665bf8af099bc56d272 Reviewed-on: https://chromium-review.googlesource.com/658838Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#501485}
-
Yoland Yan authored
Bug: 640116 Change-Id: I74053b1b4bcb37553a72305ece82703453354586 Reviewed-on: https://chromium-review.googlesource.com/636171 Commit-Queue: Yoland Yan <yolandyan@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#501484}
-
Matt Wolenetz authored
Previously, FrameProcessorTest had a boolean test parameter indicating whether or not to test using sequence append mode. This change adds a second dimension to the test parameter, which parameterizes the tests further by which version of the buffering API is being tested. The test ctor forces on/off the media::kMseBufferByPts feature accordingly. It no longer uses test ctor initializer to construct the FrameProcessor, since that must happen after adjusting enable/disable of the kMseBufferByPts feature later in the ctor. This change also captures the sequence mode boolean test parameter as a protected member, including related test cleanup to use that member instead of a local boolean or local GetParam() check. Three previous TEST_F (that did not need an append mode variation) are now TEST_P using the new FrameProcessorTestParams instantiations to keep this change simpler. BUG=718641 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9210900a29382bded23e3701b39af733864fceb2 Reviewed-on: https://chromium-review.googlesource.com/663765Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#501483}
-
Jaebaek Seo authored
This is a reland of 030794ca with deviceScaleFactor obtained from global device to avoid MSAN problem. Original change's description: > Scale heights of BrowserControls in compositor by DSF > > Bug: 737777 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I711e05e8747850041f2c799d3b482da34e7e520d > Reviewed-on: https://chromium-review.googlesource.com/645906 > Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> > Reviewed-by: Alexandre Elias <aelias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500841} Bug: 737777 Change-Id: I6a27221ce5baac8573e0f074895a657eaf21183f Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/662500Reviewed-by:
Alexandre Elias <aelias@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#501482}
-