GitLab

BUG=391943

Review URL: https://codereview.chromium.org/376183005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282088 0039d316-1c4b-4281-b951-d872f2087c98

Apparently some desktop drivers do not generate an INVALID_OPERATION, so we
should enforce it in GPU command buffer.

BUG=391953
TEST=conformance_renderbuffers_framebuffer_object_attachment passing on all GPU bots
R=kbr@chromium.org,bajones@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/379623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386652
R=sadrul@chromium.org, oshima@chromium.org
TBR=kevers@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/356263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282081 0039d316-1c4b-4281-b951-d872f2087c98

WebViewGuest is growing fairly large (~ 1600 lines). This CL aims to move all permission related code to a new helper class WebViewPermissionHelper:

- Rename PluginPermissionHelper to WebViewPermissionHelper;
- Move permission request code:
--- Include permissions: Download, PointerLock, Media, Geolocation, FileSystem, Plugin;
--- Not include: New Window API, Dialog API.

Review URL: https://codereview.chromium.org/347113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282080 0039d316-1c4b-4281-b951-d872f2087c98

A BUILD.gn file was checked into the real location so this secondary-tree file is unused.

R=tfarina@chromium.org

Review URL: https://codereview.chromium.org/378633005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282078 0039d316-1c4b-4281-b951-d872f2087c98

This variable changed name to avoid ambiguity with dependencies.

R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/374213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282077 0039d316-1c4b-4281-b951-d872f2087c98

This variable changed name.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/375873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282076 0039d316-1c4b-4281-b951-d872f2087c98

The default was "iPhone", but that's not supported in Xcode 6, so use
"iPhone 5" in that case.

Also remove an unnecessary call to |connect| when printing supported
devices on Xcode 6. This call is not needed and just hangs for a few
seconds so remove it (all that's really needed is to load the
CoreSimulation framework.

BUG=390581
TEST=With Xcode 6 installed, build iossim then run iossim with no
optional paramters (e.g. out/Debug-iphonesimulator/iossim path/to/my.app
TBR=rohitrao@chromium.org

Review URL: https://codereview.chromium.org/379863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282075 0039d316-1c4b-4281-b951-d872f2087c98

This CL brings SetGAIAGivenNameOfProfileAtIndex in line with SetGAIANameOfProfileAtIndex.

BUG=372381

Review URL: https://codereview.chromium.org/373093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282074 0039d316-1c4b-4281-b951-d872f2087c98

Changes committed in r281468 were overly restrictive about when the
zoom bubble can be shown. This CL restores the old behaviour, noting
that the usual cases where the zoom bubble is supressed, namely
for changes initiated from the wrench menu and for changes in the
dev tools window, are done elsewhere in the browser.

BUG=391680

Review URL: https://codereview.chromium.org/372813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282073 0039d316-1c4b-4281-b951-d872f2087c98

Without this, the class can hardly be used within a component (unless we work around it).

Adds a workaround for link failure of components_tests due to infobar component bug (crbug.com/386171).

BUG=387751,382865,386171
TBR=jam
TEST=Variations*

Review URL: https://codereview.chromium.org/366373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=True
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/377273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282071 0039d316-1c4b-4281-b951-d872f2087c98

On Android there is no software fallback for the video decoder.  Disable the
fallback path and remove the dependencies.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/364003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282070 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282069 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/6815011292f0a130db2b35ca0f862b246769f3b8..874a62acef5ec2ecccdbb99ec4d86402a3341e6a

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=jcgregorio@google.com
BUG=

Review URL: https://codereview.chromium.org/374403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282068 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282067 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13453: (noelallen) Create GN files for trusted source libraries.
r13454: (dyen) Added support for uploading log urls when uploading toolchain packages.
r13455: (dyen) Updated some documentation for the package_version files.
r13456: (dschuff) Give the minidump_generator_lib gyp rule a shorter name

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build
R=binji@chromium.org

Review URL: https://codereview.chromium.org/377083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282066 0039d316-1c4b-4281-b951-d872f2087c98

    
    Change HistoryService::ScheduleAutocomplete interface to take
    a base::Callback<void(HistoryBackend*, HistoryDatabase*)> and propagate
    to HistoryBackend::ScheduleAutocomplete and to the client.
    With this change HistoryService and HistoryBackend no longer need to be
    aware of the HistoryURLProvider and HistoryURLProviderParams.
    
    BUG=374728
    TEST=unit_tets --gtest_filter=History*

Review URL: https://codereview.chromium.org/376703007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282064 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds support for storage of the camera connection
information in the devices' names enumeration and subsequently
in the VideoCaptureDevice::Name structure.

-[AVCaptureDevice transportType] indicates the connection type 
to the camera: USB, Built-in, PCI, etc. Note that this info is only 
available for AVFoundation API and not for QTKit. 

Chromium style check forces to move complex constructors
and destructors from video_capture_device.h to .cc.

TEST: Verify that the FaceTime Built-in HD (USB) used in 
MBA >=2013 does not show incorrect modelID and vendorID
in the camera name -- those fields should be empty since
they only exist for USB or built-in cameras..

BUG=336651

Review URL: https://codereview.chromium.org/366593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282063 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392484
NOTRY=True
NOTREECHECKS=True
TBR=zty@chromium.org

Review URL: https://codereview.chromium.org/376253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282061 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282054 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org
BUG=392485

Review URL: https://codereview.chromium.org/376193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282052 0039d316-1c4b-4281-b951-d872f2087c98

This fixes LayerTreeHostAnimationTestAnimationsAddedToNewAndExistingLayers
whose single-thread versions were taking 4 seconds, since they couldn't
finish until there were no longer any running animations (in 
single-thread mode, having running animations means continually having
pending commits).

This removes the running animations, allowing the test to finish.

BUG=None

Review URL: https://codereview.chromium.org/378943004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282051 0039d316-1c4b-4281-b951-d872f2087c98

accessibility_unittests should run everywhere except iOS. It's small and
very fast.

chromevox_tests is only for Chromium OS.

BUG=322537
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280566

Review URL: https://codereview.chromium.org/350123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282050 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375482

Review URL: https://codereview.chromium.org/371353005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282049 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes the issue by calling net::GetMimeTypeFromFile on the blocking
pool.

TEST=unit_tests: *FileHandlersMimeUtilTest*"
BUG=392072

Review URL: https://codereview.chromium.org/374063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282048 0039d316-1c4b-4281-b951-d872f2087c98

The leak no longer reproduces.

BUG=285174
TBR=danakj@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/358133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282047 0039d316-1c4b-4281-b951-d872f2087c98

Enables removing a TODO and is needed for the bug linked below.

(Doesn't work for the webkit build for some reason, but that's currently
not built with clang anyhow.)

BUG=381053
R=cjhopman@chromium.org
TBR=brettw@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280406

Review URL: https://codereview.chromium.org/359783005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282046 0039d316-1c4b-4281-b951-d872f2087c98

Download destination on Chrome OS may be a virtual path that
needs to be acccessed via JavaScript FileSystem API. As a work around,
when such a path is set, fall back to the initial default directory
that is always a native local location.

BUG=381575

Review URL: https://codereview.chromium.org/375213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282045 0039d316-1c4b-4281-b951-d872f2087c98

The CL also fixes the insertion position of the new item, so that the new item
is inserted behind of the existing selected item.  Previously the image item is
inserted ahead of the selected item. It changes the index of the selected item,
and it causes the inconsistency between the selected index and the selected
item.

BUG=392055
TEST=manually

Review URL: https://codereview.chromium.org/371333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282044 0039d316-1c4b-4281-b951-d872f2087c98

Fix several WebContentsObserver implementations that are incorrectly
caching only frame routing IDs in order to act only on that frame in
later callbacks. Frame routing IDs by themselves are not suitable for
identity comparisons, since they are only unique within a given
RenderProcessHost.

Also clean up WebContentsObservers with a redundant WebContents
field. By definition, a WebContentsObserver must know which
WebContents it's observing, so there's no need for derived classes
to maintain their own WebContents field.

BUG=none

Review URL: https://codereview.chromium.org/373623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282043 0039d316-1c4b-4281-b951-d872f2087c98

This resolves the following 'gn check' error:

  ERROR at //base/prefs/mock_pref_change_callback.cc:5:11: Include not allowed.
  #include "base/prefs/mock_pref_change_callback.h"
            ^-------------------------------------
  It is not in any dependency of //base:prefs_test_support
  The include file is in the target(s):
    //base:base_unittests
  which should somehow be reachable from //base:prefs_test_support

Review URL: https://codereview.chromium.org/378653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282042 0039d316-1c4b-4281-b951-d872f2087c98

As client certificate information is now retrieved from policy, most of NetworkUIData can be removed except ONCSource to indicate whether a network was managed after the policy got removed.

BUG=391292
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/370623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282038 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/381663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282037 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377497
NOTRY=true

Review URL: https://codereview.chromium.org/377753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282036 0039d316-1c4b-4281-b951-d872f2087c98

Before this patch, we eagerly cleaned up purgeable resources when the
ServiceWorkerStorage object is initialized, which could result in an IO
flurry at browser startup. This patch:
- Cleans up uncommitted resources (not just purgeable resources) left
over from the last browser session
- Performs that cleanup lazily, when a mutation of the
purgeable or uncommitted resources is about to occur

BUG=388095

Review URL: https://codereview.chromium.org/374873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282035 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
NOTRY=True

Review URL: https://codereview.chromium.org/378323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282034 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes the create flag, and makes the Open operation fail if a file
doesn't exist. This is because a separate event for creating files is coming
soon.

TEST=unit_tests, browser_tests: *FileSystemProvider*Open*, *FileSystemProvider*ReadFile*
BUG=391362

Review URL: https://codereview.chromium.org/379743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282033 0039d316-1c4b-4281-b951-d872f2087c98

- Move constants into *_constants.{cc,h}.
- Remove unused constants.
- Lay foundation for detailed process exit codes.

BUG=385419

Review URL: https://codereview.chromium.org/365143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282032 0039d316-1c4b-4281-b951-d872f2087c98

Revert the content shell portion of:
  https://codereview.chromium.org/329223002/
This will enable landing of:
  https://codereview.chromium.org/371943003/

There is an unexplained error when the chromium linker is turned on for
the content shell.  It manifests (in logcat) as:

0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: FATAL EXCEPTION: ChildProcessMain
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: Process: org.chromium.content_shell_apk:sandboxed_process0, PID: 23281
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: java.lang.RuntimeException: Parcel android.os.Parcel@420d90b8: Unmarshalling unknown type code 6881388 at offset 244
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at android.os.Parcel.readValue(Parcel.java:2080)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at android.os.Parcel.readArrayMapInternal(Parcel.java:2314)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at android.os.Bundle.unparcel(Bundle.java:249)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at android.os.Bundle.keySet(Bundle.java:345)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at org.chromium.base.library_loader.Linker.createLibInfoMapFromBundle(Linker.java:1090)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at org.chromium.base.library_loader.Linker.useSharedRelrosLocked(Linker.java:737)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at org.chromium.base.library_loader.Linker.finishLibraryLoad(Linker.java:443)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at org.chromium.base.library_loader.LibraryLoader.loadAlreadyLocked(LibraryLoader.java:179)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at org.chromium.base.library_loader.LibraryLoader.loadNow(LibraryLoader.java:125)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at org.chromium.content.app.ChildProcessService$2.run(ChildProcessService.java:149)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at java.lang.Thread.run(Thread.java:841)

This does not occur with the chrome shell.  The change in

  https://codereview.chromium.org/371943003/

corrects chromium linker operation and resolves crbug/388356, but to land that
requires that we turn off the chromium linker on the content shell first.

BUG=388356

Review URL: https://codereview.chromium.org/379603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282030 0039d316-1c4b-4281-b951-d872f2087c98