- 26 Feb, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/346e10e8ae1a..8abc84294571 git log 346e10e8ae1a..8abc84294571 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 kjlubick@google.com [pathkit] fix perf Created with: gclient setdep -r src/third_party/skia@8abc84294571 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I1733e5a50887c2f582fb463d569372f0f80774ee Reviewed-on: https://chromium-review.googlesource.com/c/1489051Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635509}
-
Maksim Ivanov authored
Add unit tests for the implementation that is triggered by the extensions API when an extension opens a message channel for sending UI messages to the diagnosticsd daemon. BUG=chromium:910561,b:123925995 TEST=new unit tests: DiagnosticsdMessagingTest Change-Id: If49bcc3c0b63135acf47337c263943854cabbc80 Reviewed-on: https://chromium-review.googlesource.com/c/1475187 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#635508}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b02792b9. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 359fd7da "[PE] Fix rendering issue with effect escaping in pre-CompositeAfterPaint" 3685447d "[WPT] Move subresource_path from generator to referrer-policy-test-case.js" 4ea68472 "Creates an ICE transport object at DTLS transport initialization." 32a115f8 "[css-flexbox] ChildIntrinsicLogicalWidth needs to constrain by min/max" ec3bf6e6 "Fix class_white-space_[normal|pre-line]_wrapped.html wpt/webvtt tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I005ab3d20fa8d2476e834f1edf9235869c5156c0 Reviewed-on: https://chromium-review.googlesource.com/c/1488951Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635507}
-
Bo Liu authored
Change-Id: Ifef2a2d74500159096fe29763d64dca2647f18fd Reviewed-on: https://chromium-review.googlesource.com/c/1488023Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#635506}
-
Henrique Ferreiro authored
Replace uses of OverscrollBehavior from third_party/blink/renderer/platform/overscroll_behavior.h with the original type from cc/input/overscroll_behavior.h. This is part of a series of CLs to remove platform/scroll. Bug: 922111 Change-Id: I9f1d9dc8d6937c8eaee36c5bb272d30f2fe5bd2a Reviewed-on: https://chromium-review.googlesource.com/c/1488918Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#635505}
-
Elly Fong-Jones authored
This is part 1 of https://chromium-review.googlesource.com/c/chromium/src/+/1488032 TBR=thakis@chromium.org Bug: 897809 Change-Id: Ifb3291b69bbebaf862f022d45b33a206f705313d Reviewed-on: https://chromium-review.googlesource.com/c/1489091Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#635504}
-
Jérôme Lebel authored
Manage sync settings coordinator should listen to onPrimaryAccountCleared: notification. When the user is signed out, the Manage sync settings should be pop out, to come back to Google services settings. Bug: 914059 Change-Id: If08580a0dfe2cb2d94bad4e0276a5b3e3ef7c31c Reviewed-on: https://chromium-review.googlesource.com/c/1482952 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#635503}
-
Bo Liu authored
No DEPS file this time to prevent importing browser since there are actually two violations. Change-Id: Id62a279009965101ee4c417c10dd09e6c93b9e18 Reviewed-on: https://chromium-review.googlesource.com/c/1487141Reviewed-by:
-
Bo Liu authored
Mostly so that gn file can be modified without higher layer changes. Change-Id: I584f84b6356547fc8090c10cc9ab5d3facad2546 Reviewed-on: https://chromium-review.googlesource.com/c/1488016Reviewed-by:
-
Oleg Davydov authored
Add log message (on VLOG(2) level) for each extension which should be installed by policy, but appears not to be installed five minutes after policy update/login. We need this to investigate bug 917700, bug 904600 and other similar ones. Bug: 917700 Bug: 904600 Change-Id: I86a8e6b33c35b3ce83e06a30620e674faaee7f0c Reviewed-on: https://chromium-review.googlesource.com/c/1484095 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#635500}
-
Miyoung Shin authored
- unsigned short -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I070c42d5ce35c95b14759d86bf31c9167c5c29ec Reviewed-on: https://chromium-review.googlesource.com/c/1488404Reviewed-by:
-
Clemens Arbesser authored
This corresponds to the backend change cr/234129718. Bug: 806868 Change-Id: Id2ad7c8b60599ed0eef53018ec0a52fc1d367f29 Reviewed-on: https://chromium-review.googlesource.com/c/1477116 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#635498}
-
Alex Clarke authored
Long delay canceled tasks can really pile up if we don't activly remove them. We already do that in the renderer but we need to bring this technology to other SequenceMangers. Bug: 863341 Change-Id: Ie16674043028090f94c184c02acbef6efcf3471b Reviewed-on: https://chromium-review.googlesource.com/c/1483076 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#635497}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/83af02a24a8e..a4b0cda0fc1b git log 83af02a24a8e..a4b0cda0fc1b --date=short --no-merges --format='%ad %ae %s' 2019-02-26 khokhlov@google.com Reland "Replace CustomizeBrowserOptions() with CustomizeOptions() step 1" Created with: gclient setdep -r src/third_party/catapult@a4b0cda0fc1b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:8888888801528 TBR=sullivan@chromium.org Change-Id: Ic00ae326d3c93c3ba97e25cd9c7e3eda30f23ef5 Reviewed-on: https://chromium-review.googlesource.com/c/1488414Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ebeca2a9eb81..16ff21788126 git log ebeca2a9eb81..16ff21788126 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 lalitm@google.com trace_processor: ui: remove cpu from window table and all throughout Created with: gclient setdep -r src/third_party/perfetto@16ff21788126 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id7d03ee64b477186ec7b77d0f0f4798cdb3c2c61 Reviewed-on: https://chromium-review.googlesource.com/c/1488506Reviewed-by:
-
Maksim Ivanov authored
Add pre-defined native messaging destination that allows whitelisted extensions to send messages to the diagnostics_processor daemon (via the diagnosticsd daemon) and receive the responses back. The extension should use either chrome.runtime.sendNativeMessage or chrome.runtime.connectNative with the 'com.google.wilco_dtc' application in order to use this message pipe. The hardcoded whitelist for accessing this message pipe is currently empty - it will have to be updated once we figure out extension IDs that we'll use. BUG=chromium:907932,b:123926112 TEST=manual Change-Id: I9083dd87346b490cb43ca8aabd2f7534245215e2 Reviewed-on: https://chromium-review.googlesource.com/c/1463442Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Kush Sinha authored
Chrome OS Account Manager's clients relied on |AccountTrackerService| to map |AccountManager::AccountKey| to other representations (namely raw email and canonical email). Due to the relation between one such client, |ChromeOSOAuth2TokenServiceDelegate|, and |AccountTrackerService|, it was required that |AccountTrackerService| should be able to store account mappings for which a refresh token was not yet known. This usage model is no longer supported. See the attached bug for context. Fix this by adding a |raw_email| field in Chrome OS Account Manager's Account proto definition. Future patches will change clients to read this value. Bug: 925827 Test: chromeos_unittests --gtest_filter="*AccountManager*Test*" Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" Test: browser_tests --gtest_filter="*Arc*AuthService*Test*" Change-Id: I76ef741ec0a9ea38ae8757ff234c8be6dd7a3155 Reviewed-on: https://chromium-review.googlesource.com/c/1452003Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#635493}
-
Henrique Ferreiro authored
identity_get_auth_token_function.cc uses a mix of C++ and Mojo code. This CL ports GetAccessToken() to C++. Bug: 913853 Change-Id: I71ffbc6944dff0a886d57a4d8b10cb0fa334390b Reviewed-on: https://chromium-review.googlesource.com/c/1458300 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#635492}
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectible Blink objects with Oilpan or PartitionAlloc. However, some classes of //blink/renderer/modules/webaudio have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of ProcessorCreationParams and SharedAudioBuffer classes, they make sense to use USING_FAST_MALLOC because they have been used as member variables with smart pointers. Bug: 919389 Change-Id: I415dc3360abcadff5d2b3ce25035d09d674c2720 Reviewed-on: https://chromium-review.googlesource.com/c/1488399Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3812fa949a49..e2da93130748 git log 3812fa949a49..e2da93130748 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 kwiberg@webrtc.org Remove a leftover audio codec poison immutinty declaration 2019-02-26 asapersson@webrtc.org Add option to inject YuvConverter to SurfaceTextureHelper. 2019-02-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a55c7bb9..15651144 (635189:635345) 2019-02-26 kwiberg@webrtc.org Ban absl::StrSplit and absl::StrJoin 2019-02-25 thakis@chromium.org Fix -Wextra-semi warnings in webrtc fuzzers. 2019-02-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 81fda909..a55c7bb9 (635067:635189) 2019-02-25 amithi@webrtc.org Wiring up RIDs from the video engine to the RTP Sender. 2019-02-25 shampson@webrtc.org Fixing webrtc::IceTransportState. 2019-02-25 sakal@webrtc.org Revert "Remove VCMEncoderDataBase and put remaining code into VideoStreamEncoder" 2019-02-25 eladalon@webrtc.org Connect LossNotificationController to RtpRtcp 2019-02-25 srte@webrtc.org Avoids PostTask to repost a repeated task. 2019-02-25 mbonadei@webrtc.org Adding possibility to save an RTCEventLog of the call. 2019-02-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 95a23eca..81fda909 (634895:635067) 2019-02-25 srte@webrtc.org Reland "Adds resource path support for video files in scenario tests." 2019-02-25 sprang@webrtc.org Remove VCMEncoderDataBase and put remaining code into VideoStreamEncoder 2019-02-25 srte@webrtc.org Adds CoDel implementation to network simulation. 2019-02-25 srte@webrtc.org Stop using special RTT value for DelayBasedBwe. 2019-02-25 kuddai@google.com Delay bug during audio receiver stream recreation. 2019-02-25 mbonadei@webrtc.org Fix -Wextra-semi warnings. Created with: gclient setdep -r src/third_party/webrtc@e2da93130748 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:None,chromium:none,chromium:935572,chromium:None,chromium:933802,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie0a2dcd1ba6947c1ca8f49070855c2b9f8c45530 Reviewed-on: https://chromium-review.googlesource.com/c/1488504Reviewed-by:
-
Nick Diego Yamane authored
This CL is intended to make the Wayland data device initialization more robust, removing the assumption that data device manager global object is advertised before the wl_seat. Additionally this patch does a minor code cleanup in WaylandDataDeviceManager, removing the WaylandConnection setter, injecting connection instance via its constructor instead, as it is already being done in other classes, such as WaylandDataSource, for example. Bug: 578890 Change-Id: Ia700c164f18b2778b08047bfcb5ccf382e69328f Reviewed-on: https://chromium-review.googlesource.com/c/1487853Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Nick Diego Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#635489}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/565a6950b6fe..7fb544c58018 Created with: gclient setdep -r src-internal@7fb544c58018 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I41aa1b6383e5b7472b80f1c51b45f0b6d22a2c10 Reviewed-on: https://chromium-review.googlesource.com/c/1488413Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635488}
-
Yi Su authored
The limitation of displaying at most 2 rows of MostVisistedCells in NTP ContentSuggestionsCollectionView should be removed to support Dynamic Type. Bug: 893523 Change-Id: Ie22bc59b9149e154053bbf05e63e68ba0b850e99 Reviewed-on: https://chromium-review.googlesource.com/c/1482978 Auto-Submit: Yi Su <mrsuyi@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Colin Blundell authored
In identity_apitest.cc, there is a test that verifies that when the primary account is cleared, the chrome.identity.onSignInChanged event is fired. This event is fired when a refresh token is added/removed for a given account. However, when DICE is enabled, clearing the primary account does not result in its refresh token being removed (and hence does not cause this event to fire). This CL updates this test to short-circuit out if DICE is enabled. Note that a different existing test already verifies that an event is fired when the refresh token of the primary account is removed. This CL is concretely necessary to unblock the elimination of FakeSigninManager. When FakeSigninManager is eliminated, this test (and others) will use a SigninManager instance that has been configured with the account consistency mode passed by SigninManagerFactory, rather than the account consistency mode being hardcoded to disabled. Once the test is using SigninManager, we will update it to check that the event is *not* fired if DICE is enabled. It's not yet possible to do that as the test is still using FakeSigninManager. Bug: 796544 Change-Id: I8ec51b1c960ea068cb984c1781e2cc84c72ce0e4 Reviewed-on: https://chromium-review.googlesource.com/c/1488876Reviewed-by:
-
Colin Blundell authored
The SyncConfirmationHandler unittest inherits from BrowserWithTestWindowTest. It currently overrides the latter's CreateProfile() method to create and own a Profile instance via IdentityTestEnvironmentProfileAdaptor. However, this blocks the upcoming elimination of FakeSigninManager, via a subtle circular dependency that gets introduced: - SigninManagerFactory supplies |g_browser_process->local_state()| to SigninManager's Initialize() method. - In the testing context, the object thus supplied is actually owned by BrowserWithTestWindowTest's TestingProfileManager object. - Hence, the Profile of the question must be torn down before the TestingProfileManager to avoid a crash that otherwise occurs in SigninManager::Shutdown() when it accesses the PrefService pointer that it has cached. - However, it is not possible to move the teardown of the SyncConfirmationHandler unittest's |profile_| instance to be before the call to BrowserWithTestWindowTest::TearDown(), as that in turn causes a crash because other objects that BrowserWithTestWindowTest owns (namely, |browser_|) must be torn down *before* the Profile. This CL fixes the problem by simply eliminating SyncConfirmationHandler owning its own Profile instance. Instead, it just supplies the factories that IdentityTestEnvironmentProfileAdaptor requires directly to BrowserWithTestWindowTest via an override of GetTestingFactories(). This allows the natural teardown order in BrowserWithTestWindowTest::TearDown() to be preserved. Bug: 796544 Change-Id: I06528d564d836d83e1ac87a6cfc94c9ca12a033c Reviewed-on: https://chromium-review.googlesource.com/c/1488872Reviewed-by:
-
Mario Sanchez Prada authored
Migrate usage of base::Bind with repeating callbacks to base::BindRepeating. Bug: 755477 Change-Id: I8f68fde9a400e5216b2abe9efbb6ef8e2238b22d Reviewed-on: https://chromium-review.googlesource.com/c/1485931Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#635484}
-
Gauthier Ambard authored
Moves the tools menu button closer to the center of the toolbar to have the same spacing between the border of the screen and the first/last button. Bug: 912965 Change-Id: I2d4c9860c4eb9ffd9a821a90384b8d588a3bbe89 Reviewed-on: https://chromium-review.googlesource.com/c/1481314 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635483}
-
Miyoung Shin authored
- unsigned short -> uint8_t / uint16_t. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I84145b2996032f6b9e0e80d30ff63776628ef7c7 Reviewed-on: https://chromium-review.googlesource.com/c/1485617 Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Reviewed-by:
-
jdoerrie authored
This change moves the library features std::reference_wrapper, std::ref and std::cref from the to be discussed section to the allowed section, adds further documentation and links to the cxx@ discussion thread. Furthermore, it removes base::internal::ConstRefWrapper and modifies base::ConstRef to construct std::reference_wrappers instead. As a follow up to this change all usages of base::ConstRef should be replaced by std::cref, and base::ConstRef should be removed as well. Bug: 934808 Change-Id: Ie09884c38049a0f69bb3cb6442907c699e29da2e Reviewed-on: https://chromium-review.googlesource.com/c/1482958 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de280d758ae2..565a6950b6fe Created with: gclient setdep -r src-internal@565a6950b6fe The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If5d7b720f26a76af1e5352bb6e76ed101025e28f Reviewed-on: https://chromium-review.googlesource.com/c/1488505Reviewed-by:
-
Kush Sinha authored
This reverts commit 39ced93a. This is a speculative revert to check the status of MSAN flakiness. TBR=khmel@chromium.org Bug: 934796 Change-Id: I3e6f3f4e211d802bb1968ff7cfd39526a0361b68 Reviewed-on: https://chromium-review.googlesource.com/c/1487032Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#635479}
-
Miyoung Shin authored
- unsigned short/unsigned -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I3de2acf4bae0290e636c284b91f100a1c2b4c955 Reviewed-on: https://chromium-review.googlesource.com/c/1488473Reviewed-by:
-
Sylvain Defresne authored
FindExtendedAccountInfoForAccount returns the extended information for an account using the CoreAccountInfo as a key. This will be used in preparation to converting GetPrimaryAccountInfo to return a CoreAccountInfo. Bug: 930126 Change-Id: Iabd3058cb4f5851dc753a45527c67135eb304a55 Reviewed-on: https://chromium-review.googlesource.com/c/1481332 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
identity_get_auth_token_function.cc uses a mix of C++ and Mojo code. This CL ports GetPrimaryAccountWhenAvailable() to C++. Bug: 913853 Change-Id: I86c669bdc2fd0adb73cb3302c62e8355f6a21325 Reviewed-on: https://chromium-review.googlesource.com/c/1458202 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Gauthier Ambard authored
This reverts commit ca06f630. Reason for revert: Breaking compilation on WebView Original change's description: > [iOS][web] Add logic to BrowsingDataRemover > > This CL adds the logic to clear the browsing data from the web > implementation of the BrowsingDataRemover. > > Bug: 619783 > Change-Id: Ia4771a61a8482adf296816eed54dafb5498de932 > Reviewed-on: https://chromium-review.googlesource.com/c/1477831 > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635470} TBR=eugenebut@chromium.org,mrefaat@chromium.org,gambard@chromium.org Change-Id: I5539d07f8735a64465443d19c58de6456e03da71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 619783 Reviewed-on: https://chromium-review.googlesource.com/c/1488919Reviewed-by:
-
Miyoung Shin authored
- unsigned short/int -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I82c389e5865267daef3bbf25c5098aa584e17c76 Reviewed-on: https://chromium-review.googlesource.com/c/1488481Reviewed-by:
-
Colin Blundell authored
This CL removes the last functionality that FakeSigninManager adds on to SigninManager: overriding OnSignoutDecisionReached(). Presumably at one time this corresponded to some simplification of the production code. However, at this time the only difference that the override adds is that it doesn't log metrics. Logging metrics in a test context is not problematic, as testing will not emit live metrics (confirmed with rkaplow@ from the metrics team). Bug: 796544 Change-Id: Ic703c0e01637d6adbc3a495cb58d715ec33d8e4c Reviewed-on: https://chromium-review.googlesource.com/c/1486532 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
Don't show encryption error when sync is disabled. Bug: 914059 Change-Id: I719bf76ea87d670c8deda34532ed185a4d4d4685 Reviewed-on: https://chromium-review.googlesource.com/c/1487814Reviewed-by:
-
Alex Ilin authored
SharedPersistentMemoryAllocator is based on obsolete shared memory classes and is being replaced by {Writable,ReadOnly}SharedMemoryAllocator. SharedPersistentMemoryAllocator is still used in base/debug/activity_tracker.h and base/debug/activity_analyzer.h. This CL converts these last clients of the SharedPersistentMemoryAllocator to the new allocators and removes SharedPersistentMemoryAllocator. Bug: 920183 Change-Id: Ic789dc79a5798135a43bd59bbaaa4d2977c96cbf Reviewed-on: https://chromium-review.googlesource.com/c/1481297Reviewed-by:Brian White <bcwhite@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635471}
-
Gauthier Ambard authored
This CL adds the logic to clear the browsing data from the web implementation of the BrowsingDataRemover. Bug: 619783 Change-Id: Ia4771a61a8482adf296816eed54dafb5498de932 Reviewed-on: https://chromium-review.googlesource.com/c/1477831 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#635470}
-
