GitLab

We already have the same msvs_disabled_warnings declared at line 172. No
need to have it twice.

BUG=331829
TEST=gfx_unittests
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/555543003

Cr-Commit-Position: refs/heads/master@{#294756}

Revert of Cleanup: Remove base/file_util.h. Convert remaining references. (patchset #1 id:1 of https://codereview.chromium.org/568873004/)

Reason for revert:
Broke some internal builds. Need to give them a chance to fix their builds.

Original issue's description:
> Cleanup: Remove base/file_util.h. Convert remaining references.
>
> TBR=brettw@chromium.org
>
> Committed: https://crrev.com/6d63c4898c2da5a286d01f80229baeb914f99f18
> Cr-Commit-Position: refs/heads/master@{#294729}

TBR=brettw@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/565803006

Cr-Commit-Position: refs/heads/master@{#294755}

This is needed for the work to drop GCM sign-in enforcement. Since
we no longer wipe out the GCM data when the user signs out, we need
to give user a chance to clear the data if he or she wants.

BUG=384041
TEST=Manual test by selecting "Cookies and other site and plugin data"

Review URL: https://codereview.chromium.org/562423002

Cr-Commit-Position: refs/heads/master@{#294754}

https://chromium.googlesource.com/chromium/blink/+log/9cb8a59cf2f63b817c4c4929dd0ba33b4c2ee7e1..1c10331d9ed2cb8073d44563b1c6e243971b7557
TBR=

Review URL: https://codereview.chromium.org/573533002

Cr-Commit-Position: refs/heads/master@{#294753}

All current versions of host and client support capabilities, we
no longer need to keep support for older versions.

Review URL: https://codereview.chromium.org/565263006

Cr-Commit-Position: refs/heads/master@{#294752}

In the baseline policy, we restrict the |clk_id| parameter allowed in
clock_gettime(). This applies to all sandboxed process types.

In the renderer policy, we similarly restrict the |clk_id| parameter for
clock_getres().

BUG=413469, 413855

Review URL: https://codereview.chromium.org/566083002

Cr-Commit-Position: refs/heads/master@{#294751}

[MIPS64] Add build support for MIPS64 in libjpeg_turbo
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo/+log/3963fbcd6c16..034e9a9747e0

TBR=rmcilroy@chromium.org
BUG=400684

Review URL: https://codereview.chromium.org/559963004

Cr-Commit-Position: refs/heads/master@{#294750}

These functions should set needs commit, but didn't. This lead to stale
pointers in the impl tree.

BUG=413743,403866

Review URL: https://codereview.chromium.org/572483002

Cr-Commit-Position: refs/heads/master@{#294749}

BUG=
TBR= jianli@chromium.org

Review URL: https://codereview.chromium.org/571553004

Cr-Commit-Position: refs/heads/master@{#294748}

BUG=78512
TEST=no change

Review URL: https://codereview.chromium.org/568163004

Cr-Commit-Position: refs/heads/master@{#294747}

Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

It's a follow up patch to https://codereview.chromium.org/414423002/. We already restructured WebContents
functionalities from ContentViewCore. In this patch we are removing unwanted ContentViewCore methods,
so that ContentViewCore stake holders can directly call these methods.

BUG=398263

Review URL: https://codereview.chromium.org/481803004

Cr-Commit-Position: refs/heads/master@{#294746}

Cr-Commit-Position: refs/heads/master@{#294745}

This is implemented on top of ResourceFetcher.

BUG=410414

Review URL: https://codereview.chromium.org/532773002

Cr-Commit-Position: refs/heads/master@{#294744}

Changing in the intialization order of WeakPtrFactory in src/extensions module
such that all member variables should appear before the WeakPtrFactory
to ensure that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/573513002

Cr-Commit-Position: refs/heads/master@{#294743}

Picks up android.mk generator changes and emacs mode update.

Summary of changes available at:
https://chromium.googlesource.com/external/gyp/+log/94b57d39a88c..46282cedf40f

BUG=

Review URL: https://codereview.chromium.org/568833002

Cr-Commit-Position: refs/heads/master@{#294742}

Changing in the intialization order of WeakPtrFactory in "src/base" module
such that all member variables should appear before the WeakPtrFactory
to ensure that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/565123002

Cr-Commit-Position: refs/heads/master@{#294741}

Since Chrome 38, this policy is also forcing Safety Mode for YouTube.

BUG=344815

Review URL: https://codereview.chromium.org/559033002

Cr-Commit-Position: refs/heads/master@{#294740}

HTML Tags: object, ins, mark, i, legend, frameset, caption, body, th
Aria role: row, spinbutton
Aria state/property: aria-atomic

BUG=170580

Review URL: https://codereview.chromium.org/543953003

Cr-Commit-Position: refs/heads/master@{#294739}

Cr-Commit-Position: refs/heads/master@{#294738}

BUG=None

Review URL: https://codereview.chromium.org/506943003

Cr-Commit-Position: refs/heads/master@{#294737}

PrintWebViewHelperTest.PrintWithIframe document.write()s into
a loaded iframe without a document.close(). This blocks the load event in the parent frame and will soon block load completion notifications.

BlockScriptInitiatedPrinting operates on an initial empty document, which can have strange effects. Load one of the html strings provided in that file, just so we have a real document to work with.

BUG=

Review URL: https://codereview.chromium.org/568933002

Cr-Commit-Position: refs/heads/master@{#294736}

The IOHIDManager object manages the IOHIDDevice instances that it
creates. Calling IOHIDDeviceOpen on such an instance is a no-op and
calling IOHIDDeviceClose prevents the IOHIDManager from tracking the
lifetime of the device. The solution is to never open nor close these
devices.

BUG=413976

Review URL: https://codereview.chromium.org/568873003

Cr-Commit-Position: refs/heads/master@{#294735}

These classes do not need to be classes and expecially don't need to be
abstract classes as this leads to a complicated implementation and
complicated tests. All USB devices no matter the platform will have the
same descriptor data.

This change follows the model of device::HidDeviceInfo.

Relanding this patch (reverted in crrev.com/294640) after restoring the
call to libusb_free_config_descriptor that was removed during
refactoring and caused failures in the Linux ASan LSan tests.

BUG=

Review URL: https://codereview.chromium.org/568943002

Cr-Commit-Position: refs/heads/master@{#294734}

https://skia.googlesource.com/skia/+log/c34b0d4e9ad5806c1f882a1f85191f2ea8ddcdba..abaef86f2b37d8a939506a2076da07f6db456951

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/569843003

Cr-Commit-Position: refs/heads/master@{#294733}

This is a cleanup patch.

ServiceWorkerProviderHost owns ServiceWorkerRegistration and the registration
owns ServiceWorkerVersions, so the provider host doesn't need to hold them.

BUG=n/a
TEST=run_webkit_tests.py --debug http/tests/serviceworker/

Review URL: https://codereview.chromium.org/563923005

Cr-Commit-Position: refs/heads/master@{#294732}

- add 'No matches were found.' hint
- adjust search bubble content when text option content changes
- fix extra padding

BUG=413520,413522

Review URL: https://codereview.chromium.org/568973002

Cr-Commit-Position: refs/heads/master@{#294731}

We are still passing it around and scaling a rect by it but it is
always 1 so just make that explicit.

R=vmpstr

Review URL: https://codereview.chromium.org/566023004

Cr-Commit-Position: refs/heads/master@{#294730}

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/568873004

Cr-Commit-Position: refs/heads/master@{#294729}

These traces were really helpful in tracking out why things were getting
prioritized wrong.

BUG=410625

Review URL: https://codereview.chromium.org/568183002

Cr-Commit-Position: refs/heads/master@{#294728}

Currently we always intersect GetViewportForTilePriorityInContentSpace()
with the visible_content_rect(), so instead just intersect before
returning so we can always use that value more simply.

R=boliu

Review URL: https://codereview.chromium.org/571653003

Cr-Commit-Position: refs/heads/master@{#294727}

Since it's added to the NSThemeFrame directly as a subview, it also needs to be
removed/added during the fullscreen transition animation.

BUG=411770

Review URL: https://codereview.chromium.org/566473002

Cr-Commit-Position: refs/heads/master@{#294726}

We shouldn't have dependencies on chromium types and whatnot in
mojo/public/

Review URL: https://codereview.chromium.org/565323002

Cr-Commit-Position: refs/heads/master@{#294725}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/570773002

Cr-Commit-Position: refs/heads/master@{#294724}

This unfortunately means converting what are currently sandbox_bpf unit
tests into effectively integration tests for bpf_dsl, as they now test
both bpf_dsl + sandbox_bpf.  However, this is a necessary step towards
eliminating dependencies on the current sandbox_bpf API so that we can
more freely evolve it to fit bpf_dsl's needs.

For ease of review, this only converts tests that were already using
SandboxBPFPolicy (i.e., BPF_TEST()s are left alone), and some of the
conversions are slightly non-idiomatic in the interest of mimicking the
existing test structure.  Both of these will be addressed further in
followup CLs so that this CL can be reviewed as a mere translation of
policies from the sandbox_bpf API to bpf_dsl.

Review URL: https://codereview.chromium.org/559653004

Cr-Commit-Position: refs/heads/master@{#294723}

As the second of a three-sided set of change:
This change lays the groundwork for Blink to own the app-visible pieces
of the MSE initialization segment received algorithm. It lets
SourceState notify WebSourceBufferImpl upon parsing an initialization
segment. WSBI then notifies its WebSourceBufferClient.
Updated unit tests are included.

R=acolwell@chromium.org
TEST=No media_unittest regression
BUG=249428,397243

Review URL: https://codereview.chromium.org/547223003

Cr-Commit-Position: refs/heads/master@{#294722}

Ensure that on Windows 7, relaunching the browser via chrome://restart or changing about:flags relaunches into Chrome OS mode.

There were two problems here.
1. The viewer process on Windows 7 would not die : Fixed by destroying the window when we get a
   signal from the browser process that the viewer needs to die.

2. Relaunching on Windows 7 would relaunch the existing browser process with the same command line.
   On Windows 8 relaunch launches back into Windows 8 mode as delegate execute has code to launch back
   into the previous mode. On Windows 7 we don't have that luxury. The current approach is to detect
   that we are in Windows 7 in a browser launched to service the viewer process and return that we
   need to launch into Chrome OS mode. Additionally we set the corresponding pref to ensure that
   this is honored.

BUG=413101

Review URL: https://codereview.chromium.org/568623002

Cr-Commit-Position: refs/heads/master@{#294721}

This patch implements the Chromium-side change of
ServiceWorkerContainer#getRegistration().

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#navigator-service-worker-getRegistration

[1/3] https://codereview.chromium.org/553983010/
[3/3] https://codereview.chromium.org/540823003/

BUG=404951
TEST=content_unittests

Review URL: https://codereview.chromium.org/535753002

Cr-Commit-Position: refs/heads/master@{#294720}

BUG=314889

Review URL: https://codereview.chromium.org/560983002

Cr-Commit-Position: refs/heads/master@{#294719}

First, it is a good cleanup to avoid an extra copy of all the variable info.
Second, this cleanup will make switching to ANGLE's new APIs to query variable
info much easier.

BUG=401311
TEST=gpu_unittests, webgl_conformance_tests
R=bajones@chromium.org,kbr@chromium.org,piman@chromium.org

Review URL: https://codereview.chromium.org/566023002

Cr-Commit-Position: refs/heads/master@{#294718}

 Added CHECKs in static methods in ash::Shell/RootWindowController to identify the chrome code accessing ash

BUG=410444
TBR=sky@chromium.org
TEST=tested on Pixel

Review URL: https://codereview.chromium.org/549453005

Cr-Commit-Position: refs/heads/master@{#294717}