- 23 Apr, 2018 40 commits
-
-
Rob Buis authored
Fix errorprone MissingFail warnings and make sure it is treated as error after this CL. http://errorprone.info/bugpattern/MissingFail Bug: 803589 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I26bb2b58844a9a517e27cc25e334e529eaa6f06a Reviewed-on: https://chromium-review.googlesource.com/960422Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#552830}
-
Min Qin authored
The in_progress_download_observer_ never observes SavePage download items. So if it is added to the cache, it will never be removed. Since save page download cannot be resumed, there is no need to put them in in-progress cache. The UKM reporting is now moved into savepage class. Change-Id: I6ca9c1b93c8a9b6e8e0c0c00f50f8c08d5766fd3 Reviewed-on: https://chromium-review.googlesource.com/1019885 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#552829}
-
Xiyuan Xia authored
Make DataReductionProxyConfig/NetworkQualityEstimator call net::GetWifiSSID() on a worker thread instead of the IO thread on ChromeOS as a work around for https://crbug.com/821607. This CL does not solve the underlying problem that is still being investigated. It gives the user a crippled system instead of a dead one with a frozen screen. Bug: 821607 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8e4db5091e8b080ed2bd7f9bc4a3e04b6e6e8018 Reviewed-on: https://chromium-review.googlesource.com/1020297Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#552828}
-
Gabriel Charette authored
Migrate MessageLoop::current() to MessageLoopCurrent in /content/public/test/test_download_http_response.cc These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=xingliu@chromium.org Bug: 825327 Change-Id: I80c03d93cac977fdf2c2782ee394f25067d295f3 Reviewed-on: https://chromium-review.googlesource.com/1024478 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Katie D authored
Bug: 823359 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I772e1fa78e0f3f7ed3a6ab858f4855f65f18513f Reviewed-on: https://chromium-review.googlesource.com/1014491 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#552826}
-
Lei Zhang authored
This reverts commit 4c002763. Reason for revert: Causing CQ failures. Original change's description: > remove webgl suppression for gl-bindAttribLocation-aliasing-inactive.html > > TBR=kbr@chromium.org > > Bug: 829541 > Change-Id: I6b6e481ec11abf895debe2cf3cfe44e812b2b436 > Reviewed-on: https://chromium-review.googlesource.com/1023715 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552732} TBR=kainino@chromium.org Change-Id: Id155fd5d4d80143a8880ce6a53b7d993da4bab4c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829541, 835967 Reviewed-on: https://chromium-review.googlesource.com/1024718Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#552825}
-
Eric Roman authored
The comments regarding generating HTML files no longer seems relevant, as the canonical reference for working with markdown files in Chromium is https://chromium.googlesource.com/chromium/src/+/master/docs/README.md#Creating-Documentation This leaves only some notes about how to re-generate the svg files, which seems better suited for a shell script. Change-Id: I943b1d387ae578b698d72a30fe7282fe455b8e63 Reviewed-on: https://chromium-review.googlesource.com/1024511Reviewed-by:
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=djacobo@chromium.org Bug: 825327 Change-Id: I75c44a73f3b047c021a3bb48989cbef2b3cdf870 Reviewed-on: https://chromium-review.googlesource.com/1024289 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#552823}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=creis@chromium.org Bug: 825327 Change-Id: I577eea2864ba08f79a0cd7a8d4dc5ef8228cf75d Reviewed-on: https://chromium-review.googlesource.com/1024409 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#552822}
-
Elly Fong-Jones authored
The old spacings: 12pt label <-> icon, 0pt between New spacings: 8pt label <-> icon, 6pt between Before & after screenshot attached to the bug. Bug: 826264 Change-Id: I63b042bd7188a02a12d6150936d6236ef6e97478 Reviewed-on: https://chromium-review.googlesource.com/1023319Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#552821}
-
khmel@google.com authored
Test: Manually Bug: 835911 Change-Id: Id2942cb8249003e52b7147c924db6e5785b79a51 Reviewed-on: https://chromium-review.googlesource.com/1024408Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#552820}
-
Hidehiko Abe authored
BUG=None TEST=Ran trybots. Change-Id: I3450f37691347e96d2c563128974c375c904b49e Reviewed-on: https://chromium-review.googlesource.com/1006694 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
-
Ken Rockot authored
Replaces the internal ref-counted PlatformSharedBuffer type with base::subtle::PlatformSharedMemoryRegion throughout the EDK. Takes egregious liberties abusing the new base shared memory API's serialization and deserialization support interfaces to support Mojo API behavior within the boundaries of the base API's constraints. This *should* just work, though there is some risk of one or more Mojo shared buffer consumers engaging in the following no-longer-supported sequence of operations: 1. Allocating a shared buffer 2. Duplicating it non-read-only at least once 3. Duplicating it read-only Step 3 will always fail now. This is a precursor to adding a creation flag to the Mojo API to support distinction between "safe" writable-by-one-owner buffers and "unsafe" writable-by-anyone buffers and deprecating the READ_ONLY duplication flag in favor of this more explicit choice. Bug: 826213 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0ef125fdb7f512c045463dd54c7a43f3a19c60a3 Reviewed-on: https://chromium-review.googlesource.com/987318Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#552818}
-
Fabio Tirelo authored
Bug: 768881 Change-Id: I0af141a018e7f90ef0945d1587d676a2a8175512 Reviewed-on: https://chromium-review.googlesource.com/1024270Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#552817}
-
Kyle Horimoto authored
The SoftwareFeature enum will be utilized in a follow-up CL. Bug: 824568, 752273 Change-Id: Ideda29fe6569d9376014ac33ccfe22768af149b9 Reviewed-on: https://chromium-review.googlesource.com/1017346Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#552816}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=dougarnett@chromium.org Bug: 825327 Change-Id: I6e76633f91ff6f0eb37fbb0ef2e8802508906835 Reviewed-on: https://chromium-review.googlesource.com/1024252 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#552815}
-
Jun Cai authored
As discussed at: https://groups.google.com/a/chromium.org/forum/#!topic/network-service-dev/GWJCro1UnKw The WorkerTest.SharedWorkerHttpAuth doesn't test what it means to test, and what it means to test doesn't work with or without network service, so this CL removes this test. Bug: 783990 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8fa60dbd145926bfc3955fd9060c4105a733cf1c Reviewed-on: https://chromium-review.googlesource.com/1024485Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#552814}
-
Kevin Bailey authored
Changed ZeroSuggestProvider::Start() to call Stop() when wouldn't have started - not from Omnibox focus or invalid input. Also added small unit test. Bug: 825318 Change-Id: I962f1a858731e66e74a2dfb35128ac1cdabf2b81 Reviewed-on: https://chromium-review.googlesource.com/1022077Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#552813}
-
Alexei Svitkine authored
This addresses TODOs added in: https://chromium-review.googlesource.com/c/chromium/src/+/1015293 For actions, names are now sorted in a case insensitive way, to match histograms. For histograms, suffixes are now sorted. Both of the changes require reformatting of the relevant XML file, which is also done in this CL. Landing TBR to avoid rebasing/merge conflicts given this changes histograms.xml extensively. Bug: 835915 TBR: isherman@chromium.org Change-Id: Ic8807f695206e2bc31a33440dd47c48f89224f00 Reviewed-on: https://chromium-review.googlesource.com/1024404 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#552812}
-
Xida Chen authored
Two animation-types layout tests fails because the expected-txt is out of date. This CL update it. TBR=smcgruer@chromium.org NOTRY=true Bug: None Change-Id: I6a37e9763bc7599356c1d9fe108edb8feb67bc06 Reviewed-on: https://chromium-review.googlesource.com/1024883Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552811}
-
Justin Cohen authored
Since there is only 1 device at the moment, skip the health check. Bug: 723764 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic06468c2c0669413ce5507abdc0aeb3b2181ceb7 Reviewed-on: https://chromium-review.googlesource.com/1024299Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552810}
-
Jun Choi authored
Bug: 798573, 808637 Change-Id: I43d93e8b7ec295324901305e168e31506c1a547e Reviewed-on: https://chromium-review.googlesource.com/1022831 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#552809}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=pkasting@chromium.org Bug: 825327 Change-Id: I6c014006f6e83d53a8cc1f57c3377163a89bba51 Reviewed-on: https://chromium-review.googlesource.com/1024245 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
Anything that calls out to client_ can cause FileReaderLoader to be destroyed, so make sure to check for that situation. Bug: 835639 Change-Id: I57533d41b7118c06da17abec28bbf301e1f50646 Reviewed-on: https://chromium-review.googlesource.com/1024450 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#552807}
-
Aaron Leventhal authored
Accessibility checks from http://crrev.com/c/981937 fail in ComponentToolbarActionsBrowserTest.ComponentToolbarActionsShowUpAndRespondToClicks. This adds an accessible name via the controller used in the test. Bug: 819350 Change-Id: I64c95fbea582816c47d0215065fc8983f78a2bb7 Reviewed-on: https://chromium-review.googlesource.com/1023211 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#552806}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=erikchen@chromium.org Bug: 825327 Change-Id: I1637b4694aa8bc4fed82436c554013b4d8dd96fd Reviewed-on: https://chromium-review.googlesource.com/1024437Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#552805}
-
Gabriel Charette authored
Migrate MessageLoop::current() to MessageLoopCurrent in /third_party/blink/renderer/platform/scheduler/child These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=rmcilroy@chromium.org Bug: 825327 Change-Id: I4bbe57deb6fe22c898dcf4526ca5576bd461ef46 Reviewed-on: https://chromium-review.googlesource.com/1024295 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552804}
-
Greg Daniel authored
In skia getTextureHandle is deprecated and this change moves to using the new API. Change-Id: I44d5b3b45dcee0420f475dd5b93c4f5337bbfb96 Reviewed-on: https://chromium-review.googlesource.com/1024292 Commit-Queue: Greg Daniel <egdaniel@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#552803}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Bug: 825327 Change-Id: I0fba6092e86514d3744298ecced1a82327be5181 Reviewed-on: https://chromium-review.googlesource.com/1024407 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552802}
-
Theresa authored
Add a link at the bottom the Explore on Content panel to allow users to easily send feedback. BUG=833965 Change-Id: Id8a94d5dbc9110abc503255e9e65051996d15d35 Reviewed-on: https://chromium-review.googlesource.com/1022260Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#552801}
-
Gabriel Charette authored
Migrate MessageLoop::current() to MessageLoopCurrent in /base/test/android/java_handler_thread_helpers.cc These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=torne@chromium.org Bug: 825327 Change-Id: I2fc1aeccf94e9db6175d8630eeec5a3a4f4345ca Reviewed-on: https://chromium-review.googlesource.com/1024477 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#552800}
-
Fernando Serboncini authored
Both classes work together to provide RequestAnimationFrame to workers. Bug: 833902 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I541b47355ed8ff8cafbb5f4f2b791b2ff16ff4c6 Reviewed-on: https://chromium-review.googlesource.com/1015288 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Olivia Lai <xlai@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#552799}
-
Chris Kuiper authored
The original value of 1sec was needed to have sufficient time to establish an accurate reference timestamp. With new audio HAL code provided by the SoM vendor that improves timestamp jitter significantly, we can reduce the stability time. This has the benefit of a faster playback startup time. Bug: internal b/78129008 Test: playback tests and obverving startup times in logs Change-Id: I2bf9a21b32dc5e6b0cf400d1d195099e56b517a7 Reviewed-on: https://chromium-review.googlesource.com/1024312Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Chris Kuiper <ckuiper@chromium.org> Cr-Commit-Position: refs/heads/master@{#552798}
-
Lei Zhang authored
BUG=835943 NOTRY=true Change-Id: I468b0d573bf5cda24e930e34ea7ae7a581202713 Reviewed-on: https://chromium-review.googlesource.com/1024758Reviewed-by:
-
Weidong Guo authored
BUG=835012 Change-Id: Ib59301c4ef4aece078daaa41aa3ce4fb0639e8c8 Reviewed-on: https://chromium-review.googlesource.com/1022710 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
Stephen Martinis authored
This reverts commit dea64670. Reason for revert: Re-landing CL Original change's description: > Revert "Webkit layout test runner: Add option for zero tests executed" > > This reverts commit e3ce4282. > > Reason for revert: Causing failures on webkit linux trusty leak bot https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/17952 > > Original change's description: > > Webkit layout test runner: Add option for zero tests executed > > > > Adds --zero-tests-executed-ok, which makes the layout test runner exit > > with an ok status if zero tests are executed. This is important for > > re-running layout tests without patch, which we do on tryservers to > > check if the test was being flaky. > > > > Bug: 533481 > > Change-Id: I7d6bcd805b99818fdf82ecb88e71863ff72b72e7 > > Reviewed-on: https://chromium-review.googlesource.com/1018590 > > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > > Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org> > > Reviewed-by: Robert Ma <robertma@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#552426} > > TBR=qyearsley@chromium.org,dpranke@chromium.org,martiniss@chromium.org,jeffcarp@chromium.org,robertma@chromium.org > > Change-Id: Ibfe5f1bc3c02354a975d058c5d6338d0762c6e34 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 533481 > Reviewed-on: https://chromium-review.googlesource.com/1022555 > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: Jesse Doherty <jwd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552470} TBR=jwd@chromium.org,qyearsley@chromium.org,dpranke@chromium.org,martiniss@chromium.org,jeffcarp@chromium.org,robertma@chromium.org Change-Id: I76b1a0fdd188aa174eeb546d548aa4e4a751e4f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 533481 Reviewed-on: https://chromium-review.googlesource.com/1022556 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#552795}
-
Geoff Lang authored
These capabitilites were not implemented in the passthrough command decoder which resulted in poor MSAA performace on Intel high DPI. BUG=801659 BUG=800133 BUG=800011 BUG=799951 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2e1f0f3b4b8267421646279b6d3154223f8199b0 Reviewed-on: https://chromium-review.googlesource.com/1024282Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#552794}
-
Francois Doray authored
Before this CL, base::Process::CanBackgroundProcesses() used a LazyInstance to ensure that a bool was initialized only once. The same result with less code using a static variable. Change-Id: I00b5cea3619bd71701e48a8e5cc80b5fc0db10e8 Reviewed-on: https://chromium-review.googlesource.com/1024232Reviewed-by:
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=torne@chromium.org Bug: 825327 Change-Id: Id2340299ab2a3c4e3329b66a625d49f41a2e5443 Reviewed-on: https://chromium-review.googlesource.com/1024443 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
-
Mina Almasry authored
Audio master AV sync will not function for some of our use cases, so we switch here to video master AV sync. Currently only tested with manual testing, and it works great on that. There are still some extraneous corrections but those are pretty minor and not noticable, especially since we're adjusting the rate of playback of the audio. This CL makes the unittests now obselete. The unittests mocked the audio pipeline, which is not what we want with video master AV sync. The unittests still build, run and pass with this CL, but do not provide meaningful results. They will be adjusted in a follow up CL. Bug: b/74612005, b/73746352 Test: Manual, on device, unittests Change-Id: Ic6b2eced95e794d646ad1ecc3f07e452c0bc96e6 Reviewed-on: https://chromium-review.googlesource.com/1011705Reviewed-by:
-
