- 24 Oct, 2016 40 commits
-
-
kylechar authored
WindowServerTestBase already implements the WindowManagerDelegate interface to be a WM client. Instead of connecting to service:ui as a WM client, it connects using mojom::WindowTreeHost. This interface is only used in tests and doesn't exercise the real display codepath in service:ui. Change WindowServerTestBase to connect WM client. The first response that it receives will be in OnWmNewDisplay() instead of OnEmbed(), so move call QuitRunLoop() to OnWmNewDisplay() as well. BUG=none Review-Url: https://codereview.chromium.org/2438193003 Cr-Commit-Position: refs/heads/master@{#427159}
-
pfeldman authored
TBR=dgozman NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2440953003 Cr-Commit-Position: refs/heads/master@{#427158}
-
Krishna Govind authored
Cr-Commit-Position: refs/heads/master@{#427157}
-
gangwu authored
Update the commit/update counters for USS BUG=328606 Review-Url: https://codereview.chromium.org/2420213002 Cr-Commit-Position: refs/heads/master@{#427156}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/19b91531e912..3d3a65c48816 $ git log 19b91531e..3d3a65c48 --date=short --no-merges --format='%ad %ae %s' 2016-10-24 scroggo Rename GIFImageReader to SkGifImageReader 2016-10-24 bungeman Add gif sources to public.bzl. 2016-10-24 kjlubick Fix fuzzer's bools to be 0 or 1 only 2016-10-24 msarett Use SK_ALWAYS_INLINE in SkColorSpaceXform 2016-10-24 scroggo Clear background to white in animatedGif GM 2016-10-24 scroggo Include "SkBitmap.h" in CodecAnimTest.cpp 2016-10-24 raftias Refactored SkColorSpace_A2B to allow arbitrary ordering of elements 2016-10-24 mtklein Print what crashed DM on Android too. 2016-10-24 bungeman SkShader* refAs... to sk_sp<SkShader> makeAs... 2016-10-24 benjaminwagner Update trooper doc with chrome-infra chat. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=reed@google.com Review-Url: https://codereview.chromium.org/2444923004 Cr-Commit-Position: refs/heads/master@{#427155}
-
perumaal authored
* Includes fixes from recent github commits. * Chromium fixes for load-balancing and Android build. BUG= Review-Url: https://codereview.chromium.org/2443773002 Cr-Commit-Position: refs/heads/master@{#427154}
-
xlai authored
This CL implements convertToBlob on OffscreenCanvas for both worker and main threads. The OffscreenCanvasRenderingContext2D cases are complete. For the Webgl rendering context, currently convertToBlob() can only work for PNG image type. BUG=563830 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2420203002 Cr-Commit-Position: refs/heads/master@{#427153}
-
sammiequon authored
User name would flash on startup before the rest of the user pod. Pin keyboard would show up for users with disabled keyboards and the easy unlock icon would clash with the re-authentication icon. I hide the easy unlock icon whenever the re-authentication icon is shown. BUG= 655221, 654300, 655308 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2427073002 Cr-Commit-Position: refs/heads/master@{#427152}
-
jamesr authored
This adds trace entries for loading imports and for blocking on an import for longer than 20ms. These make gn's tracelog significantly easier to understand when imported files take a long time to process. For example, in the Chrome build on Mac //build/toolchain/mac/BUILD.gn blocks for ~240ms running sdk_info.py because //build/config/mac/mac_sdk.gni runs that script and //ui/base/BUILD.gn blocks for ~350ms because it is waiting for the import lock on mac_sdk.gni to be released. Without these traces, it is not immediately obvious why //build/toolchain/mac/BUILD.gn is running that script and it is very unclear why //ui/base/BUILD.gn takes so long. Review-Url: https://codereview.chromium.org/2424233002 Cr-Commit-Position: refs/heads/master@{#427151}
-
yusukes authored
Also remove an extra 'explicit' qualifier in arc/. BUG=None TEST=try Review-Url: https://codereview.chromium.org/2447773003 Cr-Commit-Position: refs/heads/master@{#427150}
-
ericrk authored
Revert of Remove GpuRasterization.BlueBox suppression for Win/AMD. (patchset #1 id:1 of https://chromiumcodereview.appspot.com/2442963002/ ) Reason for revert: Looks like the tests use --force-gpu-rasterization, which overrides the blacklist. I think we still need this suppression. See: https://build.chromium.org/p/tryserver.chromium.angle/builders/win_angle_rel_ng/builds/2567 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28ATI%29/builds/6394 Original issue's description: > Remove GpuRasterization.BlueBox suppression for Win/AMD. > > GPU rasterization has been disabled on this configuration. > > BUG=653538 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > TBR=zmo@chromium.org > > Committed: https://crrev.com/516005ea9c2ffe59b5d468bf4673a549996010df > Cr-Commit-Position: refs/heads/master@{#426972} TBR=zmo@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=653538 Review-Url: https://codereview.chromium.org/2443283002 Cr-Commit-Position: refs/heads/master@{#427149}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e64d0caf..1f4fc5c8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2445743002 Cr-Commit-Position: refs/heads/master@{#427148}
-
kylechar authored
Replace TestDisplaySnapshot with FakeDisplaySnapshot in tests. FakeDisplaySnapshot has builder that makes it more readable. Delete an unncessary build target along with TestDisplaySnapshot. Tests should be unchanged for the most part. One test was split into two tests where two very different behaviours were being checked. Also update tests to use C++11 features where possible. Mostly replacing raw pointers with unique_ptr<> and NULL with nullptr. BUG=none Review-Url: https://codereview.chromium.org/2407153008 Cr-Commit-Position: refs/heads/master@{#427147}
-
sunyunjia authored
AutoscrollForSelection is triggered when selecting text and dragging mouse out of the container. However, we don't want selecting text in a fixed-position element triggers autoscroll otherwhere. Inside findAutoscrollable, when we find the object is inside a fixed-position element, we should prevent AutoscrollForSelection from happening. BUG=655489 Review-Url: https://codereview.chromium.org/2441683002 Cr-Commit-Position: refs/heads/master@{#427146}
-
sataya.m authored
Adding rootlayerscrolls-specific test expectations for these test cases virtual/rootlayerscrolls/css3/filters/blur-filter-page-scroll-parents.html virtual/rootlayerscrolls/css3/filters/blur-filter-page-scroll-self.html virtual/rootlayerscrolls/css3/filters/blur-filter-page-scroll.html BUG=651793 Review-Url: https://codereview.chromium.org/2412013003 Cr-Commit-Position: refs/heads/master@{#427145}
-
jam authored
The previous fix depended on ensuring we add hooks to all the code paths that cause the first active WebContents to get added to the tab strip. We're still missing some code paths. So instead restore the old behavior. Even though it did miss navigation starts, fix that by using the time from NavigationHandle for PlzNavigate. This should restore the metrics for non-PlzNavigate case. For PlzNavigate, the start timings were already different regardless from non-PlzNavigate because of how navigations are structured very differently. This change shouldn't affects things too much for PlzNavigate though, because the only difference should be the IPC time from the renderer to the browser thread. BUG=650349 Review-Url: https://codereview.chromium.org/2448553002 Cr-Commit-Position: refs/heads/master@{#427144}
-
emircan authored
On Macbook Air 2013, letting this be default results in a keyframe every ~5 seconds. This is too often for some applications. This CL changes this limit so that max keyframe interval is 4 minutes. BUG=658429 TEST=AppRTC loopback on Mac. Review-Url: https://codereview.chromium.org/2431223011 Cr-Commit-Position: refs/heads/master@{#427143}
-
chfremer authored
* Moved files video_capture*.* from media/base to media/capture * Split out video capture related part from media/base/ipc/media_param_traits* into new files media/capture/ipc/capture_param_traits*. * Added include for newly created file to content/common/view_messages.h This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL1.7.2pre. This is in preparation for CL1.7.2, see [2]. BUG=584797 TEST=media_unittests, content_unittests, capture_unittests [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing [2] https://codereview.chromium.org/2405423002/ Review-Url: https://codereview.chromium.org/2415703002 Cr-Commit-Position: refs/heads/master@{#427142}
-
sclittle authored
Design doc: https://docs.google.com/document/d/1691W7yFDI1FJv69N2MEtaSzpnqO2EqkgGD3T0O-pQ08/edit?usp=sharing This CL introduces support for issuing a range request for just the first few bytes of an image, and showing a translucent gray box of the same size as the image in the image's place if the original image's dimensions can be decoded from the returned range. Currently, this behavior is only activated via a blink-settings flag. In the future, features such as Data Saver will activate this functionality to save data for users. BUG=605350,605351 Review-Url: https://codereview.chromium.org/2423683002 Cr-Commit-Position: refs/heads/master@{#427141}
-
mahmadi authored
before: https://screenshot.googleplex.com/KjwA5O8fX2D.png after: https://screenshot.googleplex.com/eRH0ibx9yKe.png BUG=651121 Review-Url: https://codereview.chromium.org/2431553003 Cr-Commit-Position: refs/heads/master@{#427140}
-
einbinder authored
BUG=none Review-Url: https://codereview.chromium.org/2442843003 Cr-Commit-Position: refs/heads/master@{#427139}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/b44976ebd44e3bd838900b904cb6a68124467365 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/0d401b1e358f376f4b19afb9ff26c6f99d68af40 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/66cdab51e19ccc92d7b35f341466fffc38918e96 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/70d11c3759a5113bd2c26a1026467021caac6327 git_cl: fix GetPreferredTryMasters() feature (nodir@chromium.org) recipe_engine: https://crrev.com/19b97eb65b25648c4101c279e30f2aa9d7754844 Refactor expectations of properties recipe_module. (tandrii@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2447813004 Cr-Commit-Position: refs/heads/master@{#427138}
-
spqchan authored
- Moved the animation logic from FullscreenToolbarController into a new class - Replaced DropdownAnimation with SlideAnimation BUG=643418 Review-Url: https://codereview.chromium.org/2430403003 Cr-Commit-Position: refs/heads/master@{#427137}
-
flackr authored
BUG=644833,651305 Review-Url: https://codereview.chromium.org/2450473002 Cr-Commit-Position: refs/heads/master@{#427136}
-
rouslan authored
If the user launches a payment app from expanded payments UI and cancels the payment in the app, then the payments UI should again be expanded. BUG=658222 Review-Url: https://codereview.chromium.org/2441833003 Cr-Commit-Position: refs/heads/master@{#427135}
-
mgersh authored
Calling enableNetworkQualityEstimator() first is no longer required. Review-Url: https://codereview.chromium.org/2444083002 Cr-Commit-Position: refs/heads/master@{#427134}
-
ericwilligers authored
Observer lists now support range-based for loops. BUG=655021 Review-Url: https://codereview.chromium.org/2444753002 Cr-Commit-Position: refs/heads/master@{#427133}
-
benwells authored
BUG=542537 Review-Url: https://codereview.chromium.org/2445643002 Cr-Commit-Position: refs/heads/master@{#427132}
-
haraken authored
BUG=626703 TBR=dmazzoni@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2444793004 Cr-Commit-Position: refs/heads/master@{#427131}
-
dschuyler authored
This CL replaces a var counter for fetching cookie data with javascript promises. The counter had issues with reentrancy, while promise arrays are more robust. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2439233002 Cr-Commit-Position: refs/heads/master@{#427130}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2443803002 Cr-Commit-Position: refs/heads/master@{#427129}
-
mfoltz authored
This CL uses the last committed origin of a frame making a presentation request, instead of the full URL. Frames created in script have an empty last committed URL. Note the following: - Only the origin is used from the frame URL presentation request (that is why this change is safe). PresentationRequest should be converted to use url::Origin instead of GURL to avoid unnecessary conversions. Tracked in crbug.com/632623. - Is it possible for a frames to not have a last committed origin? If so, the strict checking for valid, non-empty origins will need to be relaxed. - TODO: Add functional tests in a separate patch. BUG=658409 Review-Url: https://codereview.chromium.org/2433283005 Cr-Commit-Position: refs/heads/master@{#427128}
-
dmazzoni authored
BUG=654221 Review-Url: https://codereview.chromium.org/2432583002 Cr-Commit-Position: refs/heads/master@{#427127}
-
krasin authored
BUG=568891 Review-Url: https://codereview.chromium.org/2445033002 Cr-Commit-Position: refs/heads/master@{#427126}
-
chrishtr authored
BUG=651511 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 NOTRY=true (added after it passed on all CQ bots except android which failed because of Java heap error) Review-Url: https://codereview.chromium.org/2444593002 Cr-Commit-Position: refs/heads/master@{#427125}
-
mbrunson authored
Adds DeviceChanged callback for BluetoothAdapter::Observer in Device. Logs received DeviceChanged events in console. BUG=651282 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2404623002 Cr-Commit-Position: refs/heads/master@{#427124}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2441223002 Cr-Commit-Position: refs/heads/master@{#427123}
-
estade authored
BUG=633986 Review-Url: https://codereview.chromium.org/2441043003 Cr-Commit-Position: refs/heads/master@{#427122}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2439273002 Cr-Commit-Position: refs/heads/master@{#427121}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4d43e1baaf06..dd582ea2140c $ git log 4d43e1baa..dd582ea21 --date=short --no-merges --format='%ad %ae %s' 2016-10-24 jbudorick [dependency manager] Add an update script. 2016-10-24 bpastene devil: Change in type of temp dumped in device monitor to float. 2016-10-24 nednguyen Update ChromeTracingAgent exception handling BUG=649481,657674 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2444033002 Cr-Commit-Position: refs/heads/master@{#427120}
-