Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 13 Jun, 2018 4 commits
    • Nate Fischer's avatar
      Revert "Check if ARCore is installed or needs update." · 91a0deb0
      Nate Fischer authored 
      This reverts commit 703de90c.

Reason for revert: lint errors (http://crbug.com/852189)

Original change's description:
> Check if ARCore is installed or needs update.
> 
> When requesting a session and after the camera permission is confirmed
> to have been granted, check if ARCore is installed and if the version
> used in Chromium is compatible with it. If ARCore is not installed
> or an update is required, a prompt will be shown.
> 
> Bug: 838954
> Change-Id: I35ae39041e7958743bba9cc1c71f5af817bf4240
> Reviewed-on: https://chromium-review.googlesource.com/1074494
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Klaus Weidner <klausw@chromium.org>
> Commit-Queue: Iker Jamardo <ijamardo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566589}

TBR=ddorwin@chromium.org,vollick@chromium.org,pkasting@chromium.org,yfriedman@chromium.org,bshe@chromium.org,mthiesse@chromium.org,estade@chromium.org,twellington@chromium.org,agrieve@chromium.org,klausw@chromium.org,billorr@chromium.org,lincolnfrog@chromium.org,ijamardo@chromium.org

Change-Id: I1f88a1de68d4929a842a4c7bf95aa90a7f48bcba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 838954
Bug: 852189
Reviewed-on: https://chromium-review.googlesource.com/1098335Reviewed-by: default avatarNate Fischer <ntfschr@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566635}
      91a0deb0
    • Sasha Morrissey's avatar
      Some minor fixes for setupAndWaitUntilReady · 7006136b
      Sasha Morrissey authored 
      Bug: 719959
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5ff560a2d842e91be024d265fd8599675636c16e
Reviewed-on: https://chromium-review.googlesource.com/1088350
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: default avatarJoel Hockey <joelhockey@chromium.org>
Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566634}
      7006136b
    • Antoine Labour's avatar
      Merge GenMailboxCHROMIUM into ProduceTextureDirectCHROMIUM · 3a776dc1
      Antoine Labour authored 
      ProduceTextureDirectCHROMIUM is always called after GenMailboxCHROMIUM
(or equivalently gpu::Mailbox::Generate()), so merge both calls into a
single one. This isn't intended to change any behavior.

Note, TakeFrontBuffer still takes an explicitly generated gpu::Mailbox.

Bug: 847674
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7227ddffba6291c1efe3ed589bfbc6166f3319fe
Reviewed-on: https://chromium-review.googlesource.com/1089695
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: default avatarJeremy Roman <jbroman@chromium.org>
Reviewed-by: default avatarJonathan Backer <backer@chromium.org>
Reviewed-by: default avatarJustin Novosad <junov@chromium.org>
Reviewed-by: default avatarDavid Reveman <reveman@chromium.org>
Reviewed-by: default avatarFrank Liberato <liberato@chromium.org>
Reviewed-by: default avatarKlaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566633}
      3a776dc1
    • David Benjamin's avatar
      Split URL_REQUEST_DELEGATE into per-delegate logs. · 9776ca20
      David Benjamin authored 
      Before, one must guess from context which delegate was called:

t=2141 [st=  0] +REQUEST_ALIVE  [dt=301]
                 --> priority = "HIGHEST"
                 --> url = "https://example.com/"
t=2141 [st=  0]    URL_REQUEST_DELEGATE  [dt=1]
t=2142 [st=  1]   +URL_REQUEST_START_JOB  [dt=298]
                   --> load_flags = 18432 (MAIN_FRAME_DEPRECATED | MAYBE_USER_GESTURE)
                   --> method = "GET"
                   --> url = "https://example.com/"
t=2142 [st=  1]      URL_REQUEST_DELEGATE  [dt=0]
t=2142 [st=  1]      HTTP_CACHE_GET_BACKEND  [dt=0]
t=2142 [st=  1]      HTTP_CACHE_OPEN_ENTRY  [dt=0]
                     --> net_error = -2 (ERR_FAILED)

Now it is spelled out explicitly:

t=2141 [st=  0] +REQUEST_ALIVE  [dt=301]
                 --> priority = "HIGHEST"
                 --> url = "https://example.com/"
t=2141 [st=  0]    NETWORK_DELEGATE_BEFORE_URL_REQUEST  [dt=1]
t=2142 [st=  1]   +URL_REQUEST_START_JOB  [dt=298]
                   --> load_flags = 18432 (MAIN_FRAME_DEPRECATED | MAYBE_USER_GESTURE)
                   --> method = "GET"
                   --> url = "https://example.com/"
t=2142 [st=  1]      NETWORK_DELEGATE_BEFORE_START_TRANSACTION  [dt=0]
t=2142 [st=  1]      HTTP_CACHE_GET_BACKEND  [dt=0]
t=2142 [st=  1]      HTTP_CACHE_OPEN_ENTRY  [dt=0]
                     --> net_error = -2 (ERR_FAILED)

(Okay, I cheated and made the "before" example by editting the "after" one, but
whatever.)

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie5fe7b4405c2389eaece479ff1c93774fe18b8ba
Reviewed-on: https://chromium-review.googlesource.com/1096083Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566632}
      9776ca20
  3. 12 Jun, 2018 36 commits