- 30 Nov, 2020 40 commits
-
-
Xi Han authored
The bug is caused by missing a call of triggerUrlFocusAnimation() when the Instant Start is enabled. In this CL, we cache the pending request, and call the function when native is ready. Bug: 1152306 Change-Id: I8621a1bd6ebdb859683e6bfef3e0d88576fa502c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562745Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#832074}
-
David Lei authored
I think this isn't used. Change-Id: Icf334d0b5729f7b370a0878e718501f160466674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545962 Auto-Submit: David Lei <dlei@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#832073}
-
Garrett Beaty authored
Bug: 1145230 Change-Id: I4cbcff5d544802cca74675136eabc34aa541854f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566373 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#832072}
-
Etienne Pierre-doray authored
IsCompleted is backwards. For a more consistent api, the function is renamed IsActive and logic is flipped. Following up on rename in v8 https://chromium-review.googlesource.com/c/v8/v8/+/2510969 The intend is to make the distinction between IsActive and IsValid obvious. Change-Id: I196c889138bf244ff96568fc6f1e11b5aa4acd47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514480Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#832071}
-
Gavin Williams authored
Use an observer on current app state to determine what should be showing in the preview pane. Add more testing for preview page logic. Bug: 1059779 Change-Id: Iccd4c924e292f41a662bc472125f78eb82861095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564899Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#832070}
-
David Van Cleve authored
crrev.com/c/2442229 added some temporary histogramming to FetchManager to identify why failing Trust Tokens operations were failing. Now that we've found the cause (crbug.com/1128174; internal due to internal repro instructions, sorry), we can remove this instrumentation and clear up a hundred lines or so in fetch_manager.cc. We're keeping Net.TrustTokens.NetErrorForTrustTokenOperation, which we added at close to the same time, around to use a health indicator. Change-Id: Ib7178d30a03b1aaa529aafdd4c9f36cfc84e1dbc Fixed: 1133944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561778 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#832069}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I422d9d8833c0657a2ed4043d01fd9dd28f0df504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566030Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832068}
-
Tommy Martino authored
This rolls to the most recent version of the Text Fragments Polyfill lib, which includes context-based matches (i.e., prefix/suffix params) to improve robustness of URL generation. Bug: 1153973 Change-Id: I6e8786655ee4b6662846365595a466a2c7523edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566050Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#832067}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I7bde24a2f8e6d12603b92020da1b5410d3cf8457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555066 Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#832066}
-
Nina Satragno authored
Parametrize the minimum PIN length on the "Set a new PIN" security keys settings dialog. Previously, it was hard-coded to four, which did not match the error handling message. TBR'ing cpu@ for grdp file changes. Tbr: cpu@chromium.org Fixed: 1152604 Change-Id: I0e47224f6874722b6abc0618f3a572d40fafcb8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562972 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#832065}
-
Thomas Lukaszewicz authored
Following the launch to ChromeOS, Tab Search intends to launch to the remaining desktop platforms Linux, Mac and Windows. This CL updates the fieldtrial testing config accordingly. Bug: None Change-Id: If15721273439669515d5ea673c0ce261e0ea4894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565652Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#832064}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/c6465ca683e6..4d25bf856b13 2020-11-30 miu@chromium.org Add discovery and console menu interface to standalone sender. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Id8b0293f728095735836cf19b8a90faa09bfe61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566211Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832063}
-
Stephen Chenney authored
A previous patch adding the metrics reporting forgot to update the histograms.xml file, and the review failed to catch it. Fix the problem so we have dashboard data. Bug: 1149691 Change-Id: I37792e3d52b56c6ccde4cbc6e614743eceb175b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563714 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#832062}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: If11c9be19eb36a63b1281ae3eeb7543c3fa7c6a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556678 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#832061}
-
Markus Handell authored
The WebmMuxer buffers frames guaranteeing original capture timestamps fed out in monotonically increasing order to the WebM file. This has the consequence that the muxer buffers all incoming frames from the non-muted track in the presence of a simultaneously recorded muted track. Relax this by adding API to the WebmMuxer to tell it about when tracks become muted, and allow it to temporarily flush out samples while the other end is muted. Internally, libwebm's mkvmuxer will hold on to audio frames awaiting video frame delivery. This change also adds API to WebmMuxer to control how often data output is forced by forcing new WebM clusters. The cluster enforcement frequency is capped to a max frequency of 10 Hz, and is set from MediaRecorderHandler to be the value of the MediaRecorder |timeslice| parameter. Tested: manually using FB testpage at crbug/1145203. Bug: 1145203 Change-Id: I6713d14f6e478d6b05c1fe84d5471f8eae759db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564638 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#832060}
-
Chris Sharp authored
Also update description_guidelines.md to have a ph tag for Android. Bug: 1137865 Change-Id: Icfe0fff13d54e7c72003196c587dd3414ff8b129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562219 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#832059}
-
Matthew Mourgos authored
Change-Id: I4a3ab25d7da7397ef2f17077aea0f8d1f9adde9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565950 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#832058}
-
David Bertoni authored
These test were disabled for SW-based extensions due to flakiness. This CL uses a workaround to enable file access for the two tests that are flaky when restarted to remove file access. Bug: 1115182, 1146173 Change-Id: Id586996467847d42a6ec6eb60a034d0152a16d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380137 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Auto-Submit: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832057}
-
Aaron Leventhal authored
This CL progresses towards removal of ShouldUseLayoutBuilderTraversal(), simplifying AddChildren() and removing conditions that lead to lack of symmetry in child-parent relationships. NOTRY: true Bug: None Change-Id: I195438d46522aad0c66da996df56d5716823992b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564380 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#832056}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/aa212ee81f71..eac3c5bf5197 2020-11-30 dsinclair@chromium.org Add tricium config. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I59c713a953b93ac63afae9706dd048c0923faf98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565890Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832055}
-
Toni Barzic authored
Note that transform animations may conflict with animation done for home to overview nudge. To avoid issues, provides an method to home_to_overview_nudge_controller to get the layer that should be used to animate hotseat while showing the nudge. The layer to be used for nudges is set to the hotseat widget delegate view (which is changed to paint to layer). BUG=None Change-Id: If73900d02e575d4437f1dd26d6b529f6787bf3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557197Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#832054}
-
Livvie Lin authored
Cleanup since the feature has fully launched (crbug.com/1108425) Change-Id: Ib8573a164066e8fa3ac3312f1cf2d3a7199a5582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555884 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#832053}
-
Greg Thompson authored
Also remove the casting that was introduced in https://crrev.com/830328, as it is no longer necessary. BUG=1147071 Change-Id: Id41ef7ae9c8aff4f74c7e67e0024af651de0e239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550676 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#832052}
-
Aleks Totic authored
Based on TableCellPaintInvalidator. TablesNG paint algorithm differs from Legacy: - Table/Section/Row paint their background into cell's backgrounds. - Table column backgrounds are painted by table into cell's background. - All collapsed borders are painted by Table in foreground phase. Table's fragment size often does not change after layout. LayoutNG invalidates paint by default only if fragment size changes. Because of this, table paint has to be invalidated explicitly whenever grid is regenerated. Bug: 958381 Change-Id: I14c30a8bbab31b253f0bf5daf5ef4583f9079a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563373Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#832051}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7cbb98085a26..1eadcfb3be99 2020-11-30 srisser@google.com Accept Sign/Zero Extend operands in OpImageRead 2020-11-30 srisser@google.com Implement shaderSubgroupBroadcastDynamicId If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8bc526e19758a9d93a00b3d8263631d0f259c635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565404Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832050}
-
Robert Sesek authored
The latter is deprecated, and they have the same constant value, so no change in behavior. Bug: 1153883 Change-Id: I530981290fd5101995550e68d65a013f5722683e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564395 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#832049}
-
Jesse Schettler authored
The histograms are still monitored and used for OKR planning. Bug: 1151970 Change-Id: I13147270f2831dae5cc4da85deb5f18124dae302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565741 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#832048}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eb386eb3d290..f819411f2a3c 2020-11-30 ehmaldonado@google.com [dirmd] Bump to 8d8dfbbee8184bf5f1c90c875e80d0dd58659f03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Id62db623d8fd61527c842d19501073c425d460a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565116 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832047}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/140364ea8c33..494efc70ded6 2020-11-30 tsepez@chromium.org Tidy fxjs/cjs_global.cpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I7847a9d97821422e614bd9bd3f84bec67e740535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565406Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832046}
-
Alex Newcomer authored
When available, use plain-text for html content. Otherwise show the placeholder "HTML Content" string. Bug: 1152856 Change-Id: Ifbe40c49fb106d5a30d259b98ab5c893953c0a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566035 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#832045}
-
Michael Thiessen authored
It looks like when we send CTA to the background, then call finish() on it, it doesn't actually get Finished. Likely Android just doesn't bother actually finishing background Activities right away (maybe something to do with the launcher)? I haven't been able to reproduce the issue, but this appears to be the commonality between the failing tests, and this should fix it if so. If this works, I'll follow up with some infra changes to detect/advise in this case. Bug: 1153712 Change-Id: Ic46c30c99df390e0cf8c7d732c3a10535dddc2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565619 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#832044}
-
Joao Victor Almeida authored
For out-of-process iframes, the current code has the following values for the upper-bound that limits percent-based deltas: - the visualviewport size in blink (ScrollableArea::ResolveScrollDelta) - the iframe's size in CC (ThreadedInputHandler::ResolveScrollGranularityToPixels) In this CL we plumb the size of the visualviewport to LayerTreeHostImpl and update ThreadedInputHandler to use it, making CC and Blink behave the same when clamping percent-based scroll deltas. Bug: 1090075 Change-Id: I4aca6c13b49e7537abdbfff0843000de41a7fd7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376069Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Commit-Queue: João Victor Almeida de Aguiar <joalmei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#832043}
-
rbpotter authored
Currently, grit sets the key in the id dictionary for a grd file to its basename if the generated folder does not reside inside the src/ folder. This case occurs when building Chrome OS, and causes breakages if two generated grd files happen to have the same basename. To make this less fragile, match the file name to the ID using the full path after substitutions instead. Bug: 1150466 Change-Id: I5b491180b31035f7c7ddcab5113e138423ce2696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559635 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#832042}
-
Brandon Wylie authored
Change-Id: I6982068089cd7a90f2c5add9662a1991ee1121bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555473Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#832041}
-
Jesse Schettler authored
The Scan app can still be disabled by the ScanningUI feature flag and the SystemFeaturesDisableList enterprise policy. Bug: 1059779 Change-Id: I54e0115c619088cbbe2d07372717d3fe44f50106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553389 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#832040}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9941ec95. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ica2c211606ba22e4c67c775e05a475822e129ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565618Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832039}
-
Akihiro Ota authored
Moving this out of http://crrev.com/c/2488081 for cleaner review. Usage of externs file can be found in that change. Bug: N/A Change-Id: I3596c377cf73b83f39ae74e9562be578499100c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564763Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#832038}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e177dd9adffc..236d4f36e63d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xialinyan@google.com,rogerta@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1145230 Tbr: xialinyan@google.com,rogerta@google.com Change-Id: I917611e2caa90319539bad0d854e8a0f8ad430ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565394Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832037}
-
Sophie Chang authored
I still need to pass the download file to the store but will do that in the next CL to unblock Bug: 1146151 Change-Id: Ide99d8437c8601aae95e2ee4400970a3348bce77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565699 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#832036}
-
Sammie Quon authored
As per UX it is preferred we draw a shield over the wallpaper instead of using a color filter to mix the two together. It will make it work better in light mode since previously it was blending the colors with kDarken. Also, this fix a bug where tablet mode shield was too dark. Bug: 1145342 Test: manual Change-Id: I0ecd2b8fbd55eae029125c454887fffaf19e0406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551954Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#832035}
-