GitLab

Quit() is deprecated and we should switch to QuitWhenIdle().

BUG=131220
R=darin@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11794032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176082 0039d316-1c4b-4281-b951-d872f2087c98

Error messages were black on almost black background. The color has been changed to white.

TEST=Invoke an error message by eg. opening a broken image file (eg. empty jpg file).
BUG=168041


Review URL: https://chromiumcodereview.appspot.com/11833026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176081 0039d316-1c4b-4281-b951-d872f2087c98

This test flaked with timeouts on Vista Tests.

TBR=tim
BUG=166261

Review URL: https://codereview.chromium.org/11818030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176080 0039d316-1c4b-4281-b951-d872f2087c98

First draft at moving the strong reference native side into a
weak reference and maintaining the strong reference on the
java side.

Android only change, android bots green.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11802002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176079 0039d316-1c4b-4281-b951-d872f2087c98

Also adds a complemetary DEPS file, in a subset of the gclient DEPS format, that specifies what files are needed for telemetry.

third_party/davclient is required to make interfacing with a WebDAV server simpler.

BUG=162301
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/11741030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176078 0039d316-1c4b-4281-b951-d872f2087c98

TBR=marshall@chromium.org,jsbell@chromium.org
BUG=150995,162829
TEST=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11778089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176077 0039d316-1c4b-4281-b951-d872f2087c98

> GTTF: Enable debugallocation by default.
>
> TBR=willchan
>
>BUG=30715
>
>Review URL: https://codereview.chromium.org/11794029


TBR=phajdan.jr@chromium.org
BUG=30715
TEST=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11829054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176076 0039d316-1c4b-4281-b951-d872f2087c98

> LTHI's bg animation timer should set the fake thread to impl.
> 
> The single thread proxy expects this to be true.
> 
> BUG=165399
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11532009
This is causing failures on mac:

http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%281%29&number=32119
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tests%20%28dbg%29%281%29&number=5885

TBR=vollick@chromium.org
Review URL: https://codereview.chromium.org/11820049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176075 0039d316-1c4b-4281-b951-d872f2087c98

BUG=169237

Review URL: https://codereview.chromium.org/11817041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176073 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168957

Review URL: https://codereview.chromium.org/11824061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=169049

Review URL: https://codereview.chromium.org/11827050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176071 0039d316-1c4b-4281-b951-d872f2087c98

BUG=169239

Review URL: https://codereview.chromium.org/11824060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176070 0039d316-1c4b-4281-b951-d872f2087c98

TBR=svenpanne@chromium.org
BUG=34994
TEST=none
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11824059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176069 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111316
TEST=W3C SVG tests pass
R=marja@chromium.org
TBR=jam@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11828028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176068 0039d316-1c4b-4281-b951-d872f2087c98

Remove:
cc/copyfiles.py
webkit/compositor_bindings/copyfiles.py

These files were deleted in https://chromiumcodereview.appspot.com/11779006

TBR=torne@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11827048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176067 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds test cases for google_apis::GetAboutOperation.
Also, it naturally introduces the testing base code for the operations
communicating with a drive api server, so that it will be reused for unit tests
of other operation classes in drive_api_operations.{h,cc} later.

BUG=162155
TEST=Ran unit_tests


Review URL: https://chromiumcodereview.appspot.com/11824023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176066 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176065 0039d316-1c4b-4281-b951-d872f2087c98

control: https://codereview.chromium.org/11783080/
Review URL: https://codereview.chromium.org/11826040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176064 0039d316-1c4b-4281-b951-d872f2087c98

Pass TaskRunner to ResourceRequestBody::ResolveElementsAndCreateUploadDataStream and use it for file operations.

BUG=167524
TEST=net_unittests

Review URL: https://chromiumcodereview.appspot.com/11778016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176063 0039d316-1c4b-4281-b951-d872f2087c98

A Profile* can be passed to the constructor of DriveProtocolHandler and
the handler uses the given Profile* for processing the request.
This will help us adding unittests and introducting support for multiple profiles.
If the handler is constructed without Profile*,  it will use the profile from
ProfileManager::GetDefaultProfile().

BUG=167249
TEST=unittests. try opening a URL of 'drive://' (e.g. HTML file stored in Google Drive) on Chrome OS.


Review URL: https://chromiumcodereview.appspot.com/11785018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176062 0039d316-1c4b-4281-b951-d872f2087c98

The single thread proxy expects this to be true.

BUG=165399


Review URL: https://chromiumcodereview.appspot.com/11532009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176061 0039d316-1c4b-4281-b951-d872f2087c98

If the channel between a renderer and a plugin encounters an error, currently we display an infobar saying "<plugin_name> has crashed.".
This may cause confusion, because the plugin process may still be alive and no crash dump is generated in that case.

With this CL, we display a different prompt if the plugin process is still alive:
"<plugin_name> has encountered an error."

This CL only affects Windows.

TEST=None
BUG=None


Review URL: https://chromiumcodereview.appspot.com/11820009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176060 0039d316-1c4b-4281-b951-d872f2087c98

../../testing/gtest/include/gtest/gtest-printers.h:169:42: error: ‘level’ may be used uninitialized in this function [-Werror=uninitialized]
../../chrome/browser/extensions/api/alarms/alarms_api_unittest.cc:280:32: note: ‘level’ was declared here

(introduced in http://crrev.com/176004)

TBR=jyasskin

Review URL: https://codereview.chromium.org/11823052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176059 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11819044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176058 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166375
TEST=None


Review URL: https://chromiumcodereview.appspot.com/11824019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176057 0039d316-1c4b-4281-b951-d872f2087c98

- FileOperationCallback
- GetEntryInfoCallback

BUG=141521
TEST=None

Review URL: https://chromiumcodereview.appspot.com/11820020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176056 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166496
BUG=167187
TBR=scottmg

Review URL: https://chromiumcodereview.appspot.com/11819049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176055 0039d316-1c4b-4281-b951-d872f2087c98

This is a manual revert, drover did not like the deleted files

> Run the JSON Schema Compiler's bundle compilation on JSON files. Previously it
> was only run on IDL files. Clean up all the code which that simplifies.
>
> TBR=isherman@chromium.org,battre@chromium.org,akalin@chromium.org
> BUG=141318
>
> Review URL: https://chromiumcodereview.appspot.com/11747025

TBR=isherman@chromium.org,battre@chromium.org,akalin@chromium.org
Review URL: https://codereview.chromium.org/11778097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176054 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176053 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 176015
> > Run the JSON Schema Compiler's bundle compilation on JSON files. Previously it
> > was only run on IDL files. Clean up all the code which that simplifies.
> > 
> > TBR=isherman@chromium.org,battre@chromium.org,akalin@chromium.org
> > BUG=141318
> > 
> > Review URL: https://chromiumcodereview.appspot.com/11747025
> 
> This seems to be causing complation failures on release win builders:
> http://chromegw/i/chromium.chrome/builders/Google%20Chrome%20Win/builds/15702
> 
> TBR=kalman@chromium.org
> Review URL: https://codereview.chromium.org/11826048

Drover messed up this revert, reverting it

TBR=ricow@chromium.org
Review URL: https://codereview.chromium.org/11778096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176051 0039d316-1c4b-4281-b951-d872f2087c98

> Run the JSON Schema Compiler's bundle compilation on JSON files. Previously it
> was only run on IDL files. Clean up all the code which that simplifies.
> 
> TBR=isherman@chromium.org,battre@chromium.org,akalin@chromium.org
> BUG=141318
> 
> Review URL: https://chromiumcodereview.appspot.com/11747025

This seems to be causing complation failures on release win builders:
http://chromegw/i/chromium.chrome/builders/Google%20Chrome%20Win/builds/15702

TBR=kalman@chromium.org
Review URL: https://codereview.chromium.org/11826048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176047 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176046 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 175890: actually, looks like we want this to also help move chromeos webui pages out of src/chrome.
> > Revert 175822
> > 
> > After more investigation of what it would take to share the webui code framework from chrome with content, it didn't seam feasible to do this. The code in chrome (i.e. ChromeURLDataManager) is heavily tied to chrome, and is used by chrome for non-webui stuff. The JS code is also specific to Chrome. It seems better to not bring in all this stuff to content.
> > 
> > > Allow multiple WebUIControllerFactory objects to be registered. This makes is possible to implement webui inside content.
> > > Review URL: https://codereview.chromium.org/11783038
> > 
> > TBR=jam@chromium.org
> > Review URL: https://codereview.chromium.org/11818036
> 
> TBR=jam@chromium.org
> Review URL: https://codereview.chromium.org/11819050

This seems like the most obvious candidate for chromiumos failures:
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/11017
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28amd64%29/builds/5918

TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/11828040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176043 0039d316-1c4b-4281-b951-d872f2087c98

Moves ui/app_list code specific to toolkit-views to ui/app_list/views.
Update gyp[i], include guards, #includes for moved files.
Seed chrome/browser/ui/cocoa/app_list and ui/app_list/cocoa with a
skeleton Cocoa UI.

BUG=138633
TEST=Mostly build changes. Functionality of AppLauncher on ChromeOS
     and Windows should be unchanged.
     On OSX, without chrome running, `Chromium.app/Contents/MacOS/Chromium --show-app-list`
     should show a borderless gray window for 1 second (note: this is for
     testing only -- OSX needs a different approach for IPC).

Review URL: https://chromiumcodereview.appspot.com/11784034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176042 0039d316-1c4b-4281-b951-d872f2087c98

Use with --vmodule=web_navigation_api=2

BUG=167279
R=asvitkine@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11827032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176041 0039d316-1c4b-4281-b951-d872f2087c98

This can be used to simulate the offline state.

BUG=162350
TEST=none; no changes in production code.

Review URL: https://codereview.chromium.org/11827045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176040 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11820037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176039 0039d316-1c4b-4281-b951-d872f2087c98

The CL adds an event filter that transforms input event properties
in the extended desktop environment. It currently scales scroll/fling
events' offset values based on the following logic:

1. Linear scaling w.r.t. the device scale factor, which is 2x for
   highDPI displays.
2. 1.2x scaling for external displays, since they are usually larger
   than internal ones.

Both scalings can stack on each other, i.e. you can get as high as
a 2.4x boost if you have a high DPI external display.

Contributed by sheckylin@chromium.org

BUG=chromium:166392
TEST=Tested on link w/o external display.

Change-Id: Ie29e03fcf9f6e5ae1dd6231990103237c3129fd6


Review URL: https://chromiumcodereview.appspot.com/11743013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176038 0039d316-1c4b-4281-b951-d872f2087c98

The call to scrollBy() can result in the curve going away, so it's unsafe to
touch member variables after making the call. Covered by webkit_unit_tests.

BUG=169156

Review URL: https://chromiumcodereview.appspot.com/11778080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176037 0039d316-1c4b-4281-b951-d872f2087c98

to hide the details how we create a root URI string for IsolatedFileSystems
from each extension code.

BUG=none
TEST=existing tests

Review URL: https://codereview.chromium.org/11833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176036 0039d316-1c4b-4281-b951-d872f2087c98