- 14 Jan, 2021 40 commits
-
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610582310-441e5d44b17635eb24bffd5edcdc41a0f840e530.profdata to chrome-linux-master-1610603782-a901bed343e038af516adf3da71b37fc556670e5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I882d48dc698f1f85a791e0003f9b960991e02e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625754Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843429}
-
Victor Costan authored
Bug: 1016065 Change-Id: I25f113d45ee642759555b7b08d0f24fc38c0f917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628068 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#843428}
-
Michael Bai authored
Bug: 1151542 Change-Id: I25545f36d588ca926ce1de9514ae919f3f441a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628040 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#843427}
-
Aya ElAttar authored
- Migrated ValidateCompletionCallback & OwnershipStatusCallback from base::Callback to base::OnceCallback as they are only run once. - Moved the callbacks instead of const passing them using constant references. Bug: 714018 Change-Id: I1a92f95c8bd7cf373bd8cdc4d1fc79dd118855af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627156Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#843426}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1169b2e38c9b..b0279c680047 2021-01-14 bmeurer@chromium.org [e2e] Rebaseline test expectations after Chromium roll. 2021-01-14 annabelzhou@google.com Add AccessibilityNode web component and display non-interactive tree If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1165304,chromium:887173 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I313b628d46faddb91eb221bdd1032d1317877fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628840Reviewed-by:
-
Glen Robertson authored
Sometimes WebAppMetrics is still holding a foreground_web_contents on shutdown, and thus fails to deregister itself as an observer of the associated AppBannerManager, which is already gone. This change adds extra checks to try to prevent getting into this state, and dumps crash reports if in an unexpected state. Bug: 1162123 Change-Id: I142e6cc30395decf7a09ca2c6773de8c65865535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620919 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#843424}
-
Nicholas Verne authored
Added "devlopment environment" to some uses. Fixed: 1166405 Change-Id: I11871d1bf709a4176cbffbcf0a8635e1269c64bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626725 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#843423}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/af9b58e287b5..f435ada424df 2021-01-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 424fd828893e to 6f833b7f78c9 (17 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: I4d92af8f66f607a07a80df87cb12e3747200a4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628585Reviewed-by:
-
rajendrant authored
Bug: 1166280 Change-Id: I9ce5d95e5d0eb68d20753ab2832e78f6af30f874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628187 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#843421}
-
Hirokazu Honda authored
The hardware video decoder outputs color artifacts with av1 10bits streams. We deny av1 10bits so that software decoders are instead used for them. Bug: b:174722425 Test: No artifacts with 10 bits streams (i.e. software decoders are used) on volteer Change-Id: I0280d9e2206366761ca670b123f90e49752d8448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616642 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#843420}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2cc3490759bb..5255c465bbba 2021-01-14 swiftshader.regress@gmail.com Regres: Update test lists @ 2cc34907 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I689225190034a60e229714eb95eeeac5f9a63dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627630Reviewed-by:
-
Rushan Suleymanov authored
Extended histograms: * Sync.BookmarkGUIDSource2 * Sync.DuplicateBookmarkEntityOnRemoteUpdateCondition * Sync.LocalSyncTransportDataStartupState Bug: 1156209, 1153772 Change-Id: If2af4a95d1ab4cece1924362f006416250e99099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627275Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#843418}
-
Eric Willigers authored
We add a browser test that writes to the socket using script. Bug: 905818 Change-Id: Ica84ba877eab844d3f9ae0b4cb76fe18b0046b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624371 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#843417}
-
Jiewei Qian authored
Fix typo in WaylandToplevelWindow::HandleSurfaceConfigure(), widht -> width. Change-Id: Ice9cb872ee721461c5fb5eb24466d3a3d07b4ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628632 Commit-Queue: Jiewei Qian <qjw@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#843416}
-
Harvey Yang authored
BUG=b:168434557 TEST=unit tests Change-Id: I896495d19cc5c8ebdc3a696e537b18302644d389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624128 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#843415}
-
Philipp Hancke authored
assert they do not throw and reject all the but first m=-line BUG=799030 Change-Id: I4242eaacc7ae039a32643034eca535acf6cd1f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627321Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#843414}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da4de1dd41b6..8a9d4fceede9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yutak@google.com Change-Id: I29f116a1b78d037d13988e15f7d4bdf2a03b7854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628584Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843413}
-
Sammie Quon authored
This reverts commit 11748b2a. Reason for revert: Breaks chromeos-kevin-chrome bot Original change's description: > Add a new Android.ArmCpuPart UMA. > > This will record the ARM CPU's implementer and part number values. > > Bug: 1164549 > Change-Id: I09ea0d852fda6b05c50a16b64bfcde6f4f5f62b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615326 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843243} TBR=dcheng@chromium.org,thakis@chromium.org,jwd@chromium.org,agrieve@chromium.org,rsesek@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I20c9ea46a720a62d76c72d449ee0d6b31de598f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1164549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626321Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#843412}
-
rajendrant authored
This is a reland of eacc052e Original change's description: > Add browser test for canceled image request > > When image request is cancelled the robots rules request should be > invalidated correctly. This CL adds a test. > > This CL also creates component for subresource_redirect and moves some > utility functions there. Subsequent CLs could move more independent code > out of chrome/renderer/subresource_redirect to the component. > > Bug: 1160424 > Change-Id: I29b20fe4f7057a1e8778995ea5e1114e36843da8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619421 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842806} TBR: sky@chromium.org,mcrouse@chromium.org Bug: 1160424 Change-Id: I4c9563032812fc2e843df1a96ccea91550a01e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628650Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
-
Regan Hsu authored
Fixed and ran 100 times with the failing gn args, and they pass. Re-enables the browser test. Fixed: 1146224 Change-Id: I6e53f6c0e6fa0d97dd527a0e16c6ee508c91ed43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628503 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Asami Doi authored
This CL enables a nested blob URL worker to inherit the active service worker from the parent worker host. `creator_worker_token` has the parent worker token when the worker is nested, and the child worker can access the parent's service worker via the parent worker host. Bug: 1017034 Change-Id: If28169fa5cedac158c220d7a5f16c7874e733a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614526Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843409}
-
Hirokazu Honda authored
If VaapiWrapper continues executing SubmitBuffer() even after the previous SubmitBuffer() fails, VABuffers stored in a pending list will be submitted to a driver by vaRenderPicture(). Some of the submitted buffers might not be related to the current processing and therefore the processing will fails. We assume VaapiWrapper client stops using the VaapiWrapper and destroys it if SubmitBuffer() fails. Although this should be true, this CL makes sure that the pended VABuffers are not used for the next processing by destroying them within SubmitBuffer_Locked() on failure. Bug: b:175897723 Test: vaapi_wrapper_unittest Change-Id: I24eaa5f94a00f69d18c2a2f1bda707e4ccb21c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612292 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5135af05fe14..1169b2e38c9b 2021-01-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibfd2e927e9575abe7ee0dbfd424b7a6a451a80f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627819Reviewed-by:
-
Oriol Brufau authored
CompositeEditCommand::MoveParagraphs has a start and end positions, and constrains them with Most{Forward,Backward}CaretPosition. The problem was that the resulting positions could end up reversed, triggering a CHECK failure in CreateMarkup. This patch changes CompositeEditCommand::MoveParagraphs so that it only attempts to contrain the positions if they are different, and also changes MostBackwardOrForwardCaretPosition to ensure that the shadow- adjusted candidate is not further from the initial position than the non-adjusted candidate. Bug: 1165325 TEST=CompositeEditCommandTest.MoveParagraphContentsToNewBlockWithUAShadowDOM TEST=SelectionAdjusterTest.AdjustSelectionTypeWithShadow TEST=VisibleSelectionTest.ShadowCrossing TEST=VisibleSelectionTest.ShadowNested Change-Id: Ib52ed472809e15aa551fdfc4ed1fa2323433d4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627368 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843406}
-
Joe DeBlasio authored
This CL updates Chrome to use a newer variant of the report proto. It does not change any logic in Chrome otherwise. In particular, the updated proto supports submitting SCTs for multiple certificates at once. This CL does not change Chrome logic to aggregate across reports. As a result, every report has exactly one certificate report in it. Bug: b/175493719 Change-Id: I3586998f04846509a589b7f09fa65fe949a8e4ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588811Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#843405}
-
Yoshifumi Inoue authored
This patch changes |LayoutBlock::PositionForBox()| to return null position if |LayoutBlock| is anonymous for avoiding call |Position::FirstPositionInOrBeforeNode()| with null position. Note: |LayoutBlock::PositionForBox()| is used only for legacy layout. Note: I don't have the test case to reproduce because ClusterFuzz's test case is too huge (large than 1MB) to reduce. Bug: 1157993 Change-Id: Ief106d22bb6c29620182fbb9a4f5fe84919879c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626820 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843404}
-
Miyoung Shin authored
This CL updates RemoteObjectImpl#close() to unreference the object from the registry for the case that RemoteObject outlives RemoteObjectHost. Bug: 1105937 Change-Id: I74f91d0267ade082fc4ecce350bab448c3b37560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567022Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#843403}
-
Peter Kotwicz authored
The motivation for the migration is that FragmentStatePagerAdapter is deprecated. BUG=1162839 Change-Id: I600ef392633b9c75cf1b11a6e56a862a685f7c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611949 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843402}
-
David Bertoni authored
Prior to this CL, the default was that test extensions were loaded with file access enabled. This is not necessary, and doesn't reflect the real world, where most APIs work without needing file access. With this CL, the default is that a test must explicitly request file access for the extension. To reflect this, some member functions have been renamed and their behavior modified so that it's clear that the test is requesting file access. This also fixes the PermissionsApiTest.OptionalPermissionsFileAccess test, which had incorrect embedded extension IDs. Bug: 1163548 Change-Id: Ib0f80b0448f49628488074082bfd54486dde3aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613306Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#843401}
-
Tommy Li authored
Some users have their DSE set to an autogenerated TemplateURL created as the user browses (via OpenSearch). Those engines are automatically deleted when the corresponding History entry is deleted. This code protects those DSEs from removal. This was part of the CanReplace() clause in M88 and before, so we regressed this in M89. This CL fixes the regression and adds a test to prevent future regression. BUG=1166372 Change-Id: I448d053b7dcfc38343f2d82e5c86df8c5e168d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628045 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#843400}
-
Kuo Jen Wei authored
The calculation of default window size is based on fixing width to 764px in all preview aspect ratio cases(3:4, 4:3, 9:16, 16:9) and deriving height from that fixed width so that after preserve space for left, right, bottom icons(--xxx-line*2), the |#preview-box| can fit in preview aspect ratio as close as possible. After these, the new default window size under different preview aspect ratio will be: 3:4 -> 764x888; 4:3 -> 764x552; 9:16 -> 764x1144; 16:9 -> 764x444. Also change the minimal window width x height to 486 x 444 accordingly. Bug: b/175324385 Test: Manually verify default window size under 3:4, 4:3, 9:16, 16:9 preview. Change-Id: Ic4c569819f29b813029f478e6920f66453ab4792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615730Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#843399}
-
Solomon Kinard authored
The key |use_dynamic_url| is a valid key to the exclusion of |matches| or |extension_ids| only if it's set to true. Otherwise one of the latter two keys must be present. Prior to this change, a false value set for the former would have acted as a wildcard for the latter two keys. Bug: 1133624 Change-Id: Ic37253a5931968fc57284ecb7068d032f0bfac6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612484 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
-
Harvey Yang authored
The flag indicates if IIO Service is running in ChromeOS, which determines sensor clients to use Mojo implementations or not. BUG=b:173485266, b:168434557, b:172414302 Change-Id: Ib89dea49b03671e9ba36f19720c30e6035521731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624327 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#843397}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c593077f725b..5135af05fe14 2021-01-14 cjamcl@chromium.org Fix Lighthouse locale fetching. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1131516 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib0ce99d3d3a6351e4ccd3733e1e0e1c7fab65207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628572Reviewed-by:
-
Mark Pearson authored
It's flaky. I can't figure out how to mark it as flaky using this test harness, so disabling instead. BUG=1166314 Change-Id: I744540f637ec527dc33acf7d96190fd9a89e5914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626415 Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#843395}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8ba0a01d1e59..6f833b7f78c9 2021-01-14 hao.x.li@intel.com Add internal compute pipeline in ResolveQuerySet for Timestamp Query 2021-01-14 enga@chromium.org dawn_wire: Skip device inject error if the client drops the device 2021-01-13 bclayton@google.com ShaderModule: Include extra information in shader errors 2021-01-13 bajones@chromium.org Enabled BindGroupLayout deprecation warning and fixed tests it broke. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ib1d6bf38eb17951aed647b2c0f998c99a8cd0152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628582Reviewed-by:
-
Hirokazu Honda authored
The hardware video decoder outputs color artifacts with av1 film grain streams. We deny av1 film grain streams so that software decoders are instead used for them. Bug: b:176927551 Test: No artifacts with film grain streams (i.e. software decoders are used) on volteer Change-Id: I85eceb0a82ee6e021943194d2429c1c6be87fe4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615723 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
-
sczs authored
- Sets the NTPViewController to the ntp_home_mediator so it can save/load the Feed scrolling offset for the refactored feed. - Adds setContentOffset to ntp_view_controller to set the offset to the saved value. Bug: 1114792 Change-Id: Ib4256a3cb4d65a8e7e6e6f00ec017a13a1447250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628316 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#843392}
-
Austin Sullivan authored
PermssionContext -> PermissionContext Bug: N/A Change-Id: I2934e259a7c5640998ed702e2ac2d09e660958a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618520 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/32f5f4343ba8..703f21e21747 2021-01-14 bpastene@chromium.org Revert "presubmit: Use new API to check for owners approval" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1166467 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I277ab8329f5e0d5bbf5b11653e634365aa4b4879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627170Reviewed-by:
-
