Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 27 Oct, 2018 10 commits
    • Jazz Xu's avatar
      Reland "[Media Controls] Added animation to overflow menu" · 91d505d9
      Jazz Xu authored 
      Change-Id: Ic3f0448ae77c9226421132ce911181f53b5ceb7d
Reviewed-on: https://chromium-review.googlesource.com/c/1303099Reviewed-by: default avatarTommy Steimel <steimel@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603271}
      91d505d9
    • Fredrik Hubinette's avatar
      make VP9Decoder understand color spaces · 3cebc620
      Fredrik Hubinette authored 
      This should make VP9Decoder set color spaces on returned
video frames correctly on windows and chromeos.

Bug: 647725, 847573
Change-Id: I602e61e078795a511caef134256a0676199f031e
Reviewed-on: https://chromium-review.googlesource.com/c/1298635
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: default avatarMiguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603270}
      3cebc620
    • Tim Haloun's avatar
      Re-enable QoS for UDPSocket under Windows. · 66923ce7
      Tim Haloun authored 
       - Move QoSCreateHandle to a background task, letting critical socket operations continue unblocked while it executes.
 - Improve resetting handle when it returns REINITIALIZATION_NEEDED
 - Widen unit tests
 - Undo ifdef disabling QOS that was added because of hangs/stalls noted in bug 812137

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I383955c2a218f23974a3f5e7044ae0464e99a43f
Bug: 812137, webrtc:5836
Reviewed-on: https://chromium-review.googlesource.com/c/1195936Reviewed-by: default avatarRyan Hamilton <rch@chromium.org>
Reviewed-by: default avatarSergey Ulanov <sergeyu@chromium.org>
Reviewed-by: default avatarWez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Tim Haloun <thaloun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603269}
      66923ce7
    • Nektarios Paisios's avatar
      Revert "Reland "Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants"" · 41463733
      Nektarios Paisios authored 
      This reverts commit eb17833e.

Reason for revert:
Broke linux-chromeos-dbg again.
AXPlatformNodeDelegateBase::Create and GetData are not defined.



Original change's description:
> Reland "Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants"
> 
> This is a reland of cb9c3091
> 
> R=​dmazzoni@chromium.org,aleventhal@chromium.org
> TBR=afakhry@chromium.org,ellyjones@chromium.org,sky@chromium.org
> Bug: 811277
> 
> Original change's description:
> Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants
> 
> Also renamed some methods to make interface more consistent.
> In preparation for more changes in AXVirtualView.
> 
> Change-Id: I815d6d941f18ef84864636bc02423af20b0bbc97
> Reviewed-on: https://chromium-review.googlesource.com/c/1303093
> Reviewed-by: Nektarios Paisios <nektar@chromium.org>
> Commit-Queue: Nektarios Paisios <nektar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603255}

TBR=ellyjones@chromium.org,dmazzoni@chromium.org,sky@chromium.org,afakhry@chromium.org,nektar@chromium.org,aleventhal@chromium.org

Change-Id: I954e26880106e51fe78daa79717300f5ab833341
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 811277
Reviewed-on: https://chromium-review.googlesource.com/c/1303556Reviewed-by: default avatarNektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603268}
      41463733
    • Xiaoqian Dai's avatar
      splitscreen: Fix the crash when snapping an always on top window. · d6ce76dd
      Xiaoqian Dai authored 
      Bug: 898403
Change-Id: If85fb9d0c90c583110f96a712ae50719c0a3925a
Reviewed-on: https://chromium-review.googlesource.com/c/1300105
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603267}
      d6ce76dd
    • jonross's avatar
      Viz Disabled Tests on FYI Bots · fb1225d6
      jonross authored 
      VizDisplayCompositor has been on my default on the CQ for a while.

However as we've been preparing for launching to stable, we've realized that
we have no coverage of the non-Viz path. So we currently can't be sure that
nothing has broken.

We want to bring up three test suites on FYI bots, with Viz Disabled. So that
we can get coverage back. These are for Linux, Windows, Android and Mac, as Viz
is not yet enabled on Chrome OS.

I plan to remove this once we are closer to launch: M-71

TEST=browser_tests, content_browsertests, content_unittests.

Change-Id: Icd32248beeab3788070bbab10a194f9046c652d9
Reviewed-on: https://chromium-review.googlesource.com/c/1302693Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603266}
      fb1225d6
    • danakj's avatar
      Remove SetVisible calls when setting the root layer in WebViewImpl. · bb5335de
      danakj authored 
      The call in SetRootGraphicsLayer() comes from this CL:
https://codereview.chromium.org/1078473002/diff/100001/Source/web/WebViewImpl.cpp#newcode4168

In that CL it mentions that visibility is not always propagated to the
WebViewImpl, but in a racey way. At that time WebViewImpl would
initialize its compositor on line 452 after SetVisibilityState on line
449.

This means at startup the compositor's visibility would not be set. It
would only be toggled if the browser send a shown IPC to the renderer,
which it appears did not always end up arriving.

Things have changed significantly since then. We now SetVisible on the
compositor in order to start its scheduler. At the time we had a
separate start signal via SetLayerTreeHostClientReady(). So now
RenderWidget would set the compositor as visible if its marked as
shown when it is created.

The call in SetRootLayer was moved in 7e410b31 from
WebViewImpl::attachPaintArtifactCompositor() which included
-    // TODO(jbroman): This is cargo-culted from setRootGraphicsLayer. Is it
-    // necessary?
-    m_layerTreeView->setVisible(page()->isPageVisible());

So I would say no it is not.

R=enne@chromium.org

Change-Id: Icaea3fb4b164b9b4de348dd2e216c4a6a3344b60
Bug: 896836, 894899
Reviewed-on: https://chromium-review.googlesource.com/c/1298341Reviewed-by: default avatarenne <enne@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603265}
      bb5335de
    • Abhishek Bhardwaj's avatar
      Reland "arc: Add wake lock based logic to re-suspend after dark resume" · 91b547aa
      Abhishek Bhardwaj authored 
      This is a reland of https://crrev.com/c/1297474.

This change adds functionality to support lock screen notifications for
Android. The wake lock module now listens to dark resume notifications
from the power manager. It -

1. Starts a timer to check for partial wake locks acquired by Android.

2. After the timer in 1 expires, if no partial wake lock is acquired the
power manager is requested to re-suspend the system. If a partial wake
lock is acquired, then another hard timeout timer is set and also an
observer to wake lock release is set.

3. If wake lock is released, the system is re-suspended immediately.

4. If a wake lock is still acquired but the hard timeout expires then
the system is re-suspended immediately.

5. If the system transitions to a full resume all dark resume related
state and timers are cleared.

On top of this change -

1. Changes were added to fix linker errors by declaring static constants
in the source file as well.

2. Refactored some functions in the test code.

BUG=chromium:898297
TEST=Unit tests and end to end test with Android applications.

Change-Id: I573f130fad2ed092d8acb83fb3319614b4ce8e02
Reviewed-on: https://chromium-review.googlesource.com/c/1302866Reviewed-by: default avatarYusuke Sato <yusukes@chromium.org>
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603264}
      91b547aa
    • Stephen Martinis's avatar
      git_cl.py: Use build_address instead of URL parsing · 667acf6d
      Stephen Martinis authored 
      The URL structure of the build info returned by `git cl try-results` is
different on LUCI than it was on buildbot. This CL changes git_cl.py to
instead look at the build_address of the build to determine the build
number.

Bug: 891729
Change-Id: I448638178942f2adbbb23c5dd947e305821a5417
Reviewed-on: https://chromium-review.googlesource.com/c/1302097
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: default avatarRobert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603263}
      667acf6d
    • Julie Jeongeun Kim's avatar
      Reland "Move the APIs using XRANR to ui/base/x folder" · be448bda
      Julie Jeongeun Kim authored 
      This is a reland of e14722dd

Original change's description:
> Move the APIs using XRANR to ui/base/x folder
> 
> It creates x11_display_util.cc/h files and moves the APIs to
> get display information using XRANR from DesktopScreenX11 to
> share the implementation with Ozone/X11.
> 
> 'GetXrandrVersion' is to get xrandr version,
> 'GetFallbackDisplayList' is to get a fallback display and
> 'BuildDisplaysFromXRandRInfo' is to get a list of displays from
> the current screen.
> 
> It also moves 'GetICCProfileForMonitor' from DesktopScreenX11
> to x11_util.cc.
> 
> These APIs are required for Ozone/X11 as well. This change doesn't
> bring any behavioral changes.
> 
> Bug: 891175
> Change-Id: Idb42b1929b7bfab4501ced4403fc176342ebdada
> Reviewed-on: https://chromium-review.googlesource.com/c/1295762
> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
> Reviewed-by: Dan Erat <derat@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602634}

Bug: 891175
Change-Id: I742eec8285b023adda84d28d68a21f7545a87f8c
Reviewed-on: https://chromium-review.googlesource.com/c/1301036Reviewed-by: default avatarDan Erat <derat@chromium.org>
Reviewed-by: default avatarThomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603262}
      be448bda
  3. 26 Oct, 2018 30 commits