GitLab

Includes changes to:
- Deprecate the MX_PORT_OPT_V2 option.
- Remove various empty header files previously provided to aid porting
  of Linux code (e.g. sys/syscalls.h).

Bug: 707030
Change-Id: Ibb56470f791036037be69a341ebb716825b16b40
Reviewed-on: https://chromium-review.googlesource.com/572883
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487345}

Reland of https://chromium-review.googlesource.com/c/573324 after
one-line compile fix.

We are inconsistent in our usage of this namespace. We mostly use it
for test support code, but not always. We sometimes wrap tests in it,
but not always.

After discussion with top-level ash OWNERS we're going to eliminate
the namespace entirely. This is more consistent with unittest.cc
files in the rest of Chrome.

TBR=reveman@chromium.org
TBR=derat@chromium.org

Bug: none
Test: compiles, ash_unittests, chrome unit_tests
Change-Id: I6afce9fb02614469e36a20cc1b0f53b1ddca551d
Reviewed-on: https://chromium-review.googlesource.com/575766Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487344}

BUG=667892

Change-Id: I25c809655f4be1f170bcd07e25574766348c2de8
Reviewed-on: https://chromium-review.googlesource.com/575670Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487343}

This is a reland of a66ebc8a
Original change's description:
> Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager
> 
> Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param.
> Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing.
> 
> Add BrokenAlternativeService::Clear() and update HttpServerPropertiesImpl::Clear() to call that.
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
> 
> BUG=705029
> 
> Change-Id: Idb411192e47d275cde3362b479a6b9e9fa773a17
> Reviewed-on: https://chromium-review.googlesource.com/562604
> Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: Yixin Wang <wangyix@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486519}

Bug: 705029
Change-Id: I14f36cc6014f001d9aefa4678a7bfa8f621b2834
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/571044Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Yixin Wang <wangyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487342}

Change-Id: I5aa8186935e0739052c4804f514f022a72318a26
Reviewed-on: https://chromium-review.googlesource.com/575525Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487341}

We previously forced every CSS mask to composite due to not handling
grouping of effects. This is no longer the case.

BUG=683425

Change-Id: Iec8d474794825f8ee7ce559d0b6d416403477464
Reviewed-on: https://chromium-review.googlesource.com/568249Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487340}

Changes displayed timing info in network panel to use the requestStarted
(TTFB) instead of headersReceivedEnd. This will be more on par with what
HAR format uses. This is a minor change and most of the time
requestStarted and headersReceived is the same since the first packet
often has all the headers.

R=caseq
BUG=374557

Change-Id: I3e887b80f482843c0a98ae9ebc660bdfa611fe9c
Reviewed-on: https://chromium-review.googlesource.com/557466Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487339}

The static BoxPainter::PaintFillLayer method is used to paint LayoutBox,
LayoutInline, and LayoutView content. Thus it is marked static and takes
a LayoutBoxModelObject (rather than a LayoutBox) as LayoutInline isn't a
sub-class of LayoutBox. This isn't ideal and requires unsafe casting and
makes code sharing across legacy layout and LayoutNG problematic.

This change moves the BoxPainter::PaintFillLayer method into a new class
called BoxModelObjectPainter that can be used to paint blocks & inlines.

Bug: 743221
Change-Id: Ib7c9ef6095a4034d2c56a6a1c6d081245b494198
Reviewed-on: https://chromium-review.googlesource.com/572336
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487338}

Each POSIX(ish) platform uses a different underlying MessagePumpForIO
implementation, but all are required to implement a common interface
to support asynchronous I/O on file descriptors.

This CL adds a set of MessageLoopIoPosixTests, which exercise those
functions to verify the semantics of all the implementations. These
include existing tests moved from MessageLoopTest and
MessagePumpLibeventTest, and a new test for mid-callback teardown.

Bug: 
Change-Id: I2b7071107342489530076dfc611738a7ec39065c
Reviewed-on: https://chromium-review.googlesource.com/571518
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487337}

This patch fixes the flash of white between the splash screen and the
web content in installed web apps. This is achieved with waiting for
a compositor frame swap before starting splash screen hiding animation.

Adding callbacks for next frame swap in CompositorViewHolder might not
be at the right level of abstraction - feedback welcome. I introduced
a generic mechanism as we might need it different places as well.
E.g. In CustomTabActivity the same issue is solved with a time delay,
which I plan to change to this mechanism in a follow up patch.

Existing tests for a webapp splash screen cover showing/hiding it in
various circumstances. Writing a specific test to assert flash of white
is fixed would be more work than it's worth it.

FYI: On Google Pixel this causes the splash screen to be shown about
50-100 later, which seems like the time time when flash of white was
visible.

Bug: 734500
Change-Id: I70f8bde54f251c283e260d17a291685738f9e080
Reviewed-on: https://chromium-review.googlesource.com/569552
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487336}

This CL migrates ArcUserSessionService.

BUG=672829
TEST=Ran try.

Change-Id: Icdd45e1f52b2372bd3613266ed96fa463c801a9a
Reviewed-on: https://chromium-review.googlesource.com/572474
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487335}

Previously printing code was in a mix of chromeos:: and
chromeos::printing.  This standardizes everything on chromeos::,
removing the chromeos::printing namespace completely.

These changes are almost entirely mechanical.  I did rename the factory function "CreateProvider" to the less generic "CreatePpdProvider" since it's now in ::chromeos directly.

BUG=702710

Review-Url: https://codereview.chromium.org/2975013002
Cr-Commit-Position: refs/heads/master@{#487334}

Bug: 738233
Change-Id: I7c8f474904a4203ee7c069a674722c3bc60545c4
Reviewed-on: https://chromium-review.googlesource.com/575764
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487333}

Forward drm and overlay command line flags for Guest session.

Bug: 
Change-Id: Ie9b167aefc7ab813116913534653903ccf5e323f
Reviewed-on: https://chromium-review.googlesource.com/572583Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487332}

This reverts commit d0591a30.

Reason for revert: Speculative revert in an attempt to find a culprit of https://bugs.chromium.org/p/chromium/issues/detail?id=741837

Original change's description:
> Add Windows implementation of GetDiscoveryNetworkInfoList
> 
> This change enables DiscoveryNetworkMonitor to work on Windows.  It
> supports both MAC addresses and WiFi SSIDs for the network ID.
> 
> Bug: 698943
> Change-Id: I0c94743fd51019438fd53472f38a2d83e21a3246
> Reviewed-on: https://chromium-review.googlesource.com/527774
> Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Derek Cheng <imcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485431}

TBR=kmarshall@chromium.org,imcheng@chromium.org,btolsch@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 698943
Change-Id: I99404e9121fc59ce0d52a7049836ec2d2e7e0bd6
Reviewed-on: https://chromium-review.googlesource.com/574614
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487331}

This reverts commit 06f34ffd.

Reason for revert: Seems to have caused a test failure: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F61641%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FPDFExtensionTest.DisablePlugin%2F0 in https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61641

Original change's description:
> Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED()
> 
> This change will allow for the detection of tasks running in
> TaskScheduler that fail to post their task in a COM STA Task Runner
> instead.
> 
> BUG=706512
> 
> Change-Id: If8ea9df63cface0dc48aa11b5254ab3e6d87dc4f
> Reviewed-on: https://chromium-review.googlesource.com/549223
> Commit-Queue: Robert Liao <robliao@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487269}

TBR=gab@chromium.org,robliao@chromium.org

Change-Id: Ie490ffab894364493a8b79fdb517e360d36ea4ee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 706512
Reviewed-on: https://chromium-review.googlesource.com/574894Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487330}

It's not currently used, and the class is eventually going away.

Bug: None
Change-Id: Iba2792c54663e155b4515efef02b150cd47f0afd
Reviewed-on: https://chromium-review.googlesource.com/571422Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Ben Greenstein <bengr@chromium.org>
Commit-Queue: Ben Greenstein <bengr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487329}

See bug for details. We want to make the icons for the palette tray when a mode is active larger, so users can identify easier which mode they are currently in.

Test: manual
Bug: 742524
Change-Id: I99e3afa0c04d2dc85c4541970271985428c00a46
Reviewed-on: https://chromium-review.googlesource.com/575022Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487328}

Also changes an incorrect DCHECK to be a safe runtime check in the event
of racy usage by callers.

BUG=740044
TBR=jcivelli@chromium.org

Change-Id: I8725648035eda70ac5bf9fb046073f21557727bc
Reviewed-on: https://chromium-review.googlesource.com/575521Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487327}

- Actually uses IPC::SyncChannel to send sync messages.
- More accurately record the endtime.

After this change the Mojo sync IPC is faster than IPC-over-Mojo sync IPC:
(On linux z620; release build with profiling turned on.)

MojoChannelPerfTest.ChannelProxySyncPing
IPC_ChannelProxy_Perf_50000x_144  6507.49 ms

MojoInterfacePerfTest.MultiprocessSyncPing
IPC_MultiprocessSync_Perf_50000x_144  5283.86 ms

BUG=743263

Change-Id: Ie1834869b8d88e25a5986bdc9714132d6b7fc87b
Reviewed-on: https://chromium-review.googlesource.com/575032
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487326}

This reverts commit 16d3c419.

Based on more discussion about this in https://bugs.chromium.org/p/chromium/issues/detail?id=742049 I've decided to revert the patch we landed here.

I'm going to let the behavior that we released in M60 stand, which is that mic/camera requests from about:blank origins will fail. The reasons being:
1) It's consistent with the behavior of other permissions
2) It's potentially confusing/misleading for a user granting permission because the origin displayed in the omnibox is "about:blank".

If the behavior is changed such that document.write triggers a navigation and the URL in omnibox is updated to reflect the origin, then it would be more acceptable to allow permission requests to occur.

Original change's description:
> Allow webrtc requests to be made from about:blank URLs that are secure contexts
> 
> https://codereview.chromium.org/2880503002 added checks to
> PermissionContextBase::GetPermissionStatus that ensured that the
> embedding origin was secure if the permission required a secure context.
> The problem is that in the case of about:blank URLs, the browser does
> not know if they are secure or not. They may be secure contexts (from
> the perspective of blink) if opened and modified by a secure context.
> 
> This change caused media permissions to stop working from about:blank
> URLs so it is removed. There are still renderer-side checks which ensure
> that the current context is secure before permitting media access. In
> the long term we should unify the browser/renderer-side secure context
> checks.
> 
> BUG=740540
> 
> Change-Id: Iff319f62284f9d22ca54706526b2747a73477e86
> Reviewed-on: https://chromium-review.googlesource.com/569544
> Reviewed-by: Timothy Loh <timloh@chromium.org>
> Commit-Queue: Raymes Khoury <raymes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486288}

TBR=raymes@chromium.org,timloh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 740540
Change-Id: I55be050873745910e282be420d4ac8030a2d141f
Reviewed-on: https://chromium-review.googlesource.com/572479Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487325}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a9f03426f2e4..b0acf6c12b29

$ git log a9f03426f..b0acf6c12 --date=short --no-merges --format='%ad %ae %s'
2017-07-17 simonhatch Pinpoint - Check auto_explore checkbox properly.
2017-07-17 phsilva Retrieve ownership information from alerts

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia14cd0a9cf500e1a3e42e80b6905f1532879e81d
Reviewed-on: https://chromium-review.googlesource.com/574933
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487324}

Previously if the sheet was open and another BottomSheetContent was
displayed, opening a new tab (e.g. via a launcher shortcut) did not
switch to the "Home" content.

BUG=743066

Change-Id: Ib1dc72c1e301e31685580e334a0b5da0f2719dd5
Reviewed-on: https://chromium-review.googlesource.com/572040Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487323}

This CL moves surface_manager_ref_unittest to
components/viz/service/frame_sinks, renaming it to
surface_references_unittest to better capture what it does. This set
of unit tests operate at the Frame Sinks layer because they use
CompositorFrameSinkSupport but then interrogate SurfaceManager to ensure
references are tracked correctly.

This CL also updates includes, forward declarations and namespaces
appropriately.

Bug: 722935
Change-Id: If899a6a1a7a084a4afa077beef4d0bc44a6bc541
Reviewed-on: https://chromium-review.googlesource.com/574883Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487322}

I missed this in r486111

BUG=736375

Change-Id: I26b4381945063f7216bab29412bfe0df1c3d95a9
Reviewed-on: https://chromium-review.googlesource.com/575393
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487321}

BUG=734762

Change-Id: I679f42eec506a033b9ab53799db4043f57a52293
Reviewed-on: https://chromium-review.googlesource.com/572328
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487320}

It's a regression caused by https://codereview.chromium.org/2979903003/.
We need to make sure newPrinter is not a null object when automatically
switch from auto-discovery dialog to manual-add-printer dialog.

Bug: 744551
Change-Id: If535c64aa2bb716e3f8e813852b556f6f6f8f796
Reviewed-on: https://chromium-review.googlesource.com/575381Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487319}

Creates a fast runtime path for checked and clamped absolute value.

Change-Id: Ibabc3cd8d4eda0a44703d3197d03bba7c746ba11
Reviewed-on: https://chromium-review.googlesource.com/573529Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487318}

This reverts commit cb4af30e.

Reason for revert: Broke ChromeOS build.
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/61952

Original change's description:
> cros: Eliminate the ash::test namespace
> 
> We are inconsistent in our usage of this namespace. We mostly use it
> for test support code, but not always. We sometimes wrap tests in it,
> but not always.
> 
> After discussion with top-level ash OWNERS we're going to eliminate
> the namespace entirely. This is more consistent with unittest.cc
> files in the rest of Chrome.
> 
> TBR=reveman@chromium.org
> 
> Bug: none
> Test: compiles, ash_unittests, chrome unit_tests
> Change-Id: I5afb42abcd06acab673ac1b459cfe071018f4400
> Reviewed-on: https://chromium-review.googlesource.com/573324
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487299}

TBR=derat@chromium.org,jamescook@chromium.org,sky@chromium.org

Change-Id: Iffa518b0f95c9f889af59fe94ccf98063b3aac71
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/574698Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487317}

This patch changes the insets and control spacing and the match count text

We space the controls in the find bar using margins to ensure that the
distances are computed to the vector image glyphs and not to the border.

Next steps would be to tackle the rest of the items in this dialog for harmony

BUG=651643
TBR=blundell

Review-Url: https://codereview.chromium.org/2968713003
Cr-Commit-Position: refs/heads/master@{#487316}

Add struct_traits for OverlaySurfaceCandidate to enable mojo IPC in
ozone.

BUG=620927

Change-Id: I16a6058f6ef411ab7acfeedc8ba35d080baed674
Reviewed-on: https://chromium-review.googlesource.com/571980
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487315}

The Fuchsia FileDescriptorWatcher attempted to cancel the wait operation
on deletion, failing if the pump was already deleted because the
underlying wait port was no longer valid.

FileDescriptorWatcher now access the wait port handle via a WeakPtr to
the associated MessagePumpFuchsia, allowing it to skip cancelling the
operation in this case.

Bug: 738275
Change-Id: Icd2a8811219de182c9c9a3208224e46a9ce1d186
Reviewed-on: https://chromium-review.googlesource.com/575291
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487314}

Bug: 725999
Change-Id: I78948e0d82f88a4303877788ddf7db7df60e3654
Reviewed-on: https://chromium-review.googlesource.com/570808
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487313}

[CrOS Tether] Show the "connection to host failed" notification when a Tether connection attempt fails.

The notification is removed when it is clicked or when a new connection attempt
is started.

Bug: 672263, 734241
Change-Id: I985554345796b953c166024e4bcddf141703591f
Reviewed-on: https://chromium-review.googlesource.com/575526Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487312}

This CL creates a separate class that is in charge of recording UMAs on behalf
of TabManager for tab and system-related properties and events during session
restore and background tab loading. The RecordSwitchTo metric method has been
moved out of TabManager and into TabManagerStatsCollector.

In this implementation, the TabManagerStatsCollector is scoped to the lifetime
and owned by the TabManager, and the TabManagerStatsCollector holds a pointer
to the TabManager.

Bug: 740625
Change-Id: Ic3c77d5d99563ceefedab3d417721a7624d02ffe
Reviewed-on: https://chromium-review.googlesource.com/565353Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Commit-Queue: Scott Haseley <shaseley@google.com>
Cr-Commit-Position: refs/heads/master@{#487311}

This change enables perf_data_generator to upload results from a
list of benchmarks to the flakiness dashboard.

BUG=chromium:717394

Change-Id: I3952887c527c40fb5d061e9ee8aa4875794075c7
Reviewed-on: https://chromium-review.googlesource.com/574687
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#487310}

Due to a clang bug, adding the API_AVAILABLE annotation also changes the
visibility to be "default". This causes an unintentional leak of
global-visibility symbols. Explicitly re-specify "hidden" visibility to work
around this.

https://bugs.llvm.org/show_bug.cgi?id=33796

Bug: 669240
Change-Id: I1118de5ddb6035402f8b787cece33e0bb040ff15
TBR: reillyg@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/574683
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487309}

+ adds a wrapper around defaults and makes this a singleton.
+ Creates a new settings object to save settings in.
+ Serializes the settings to and from defaults.

Change-Id: I8e4aaed4c38fd02ca8a71b410c6d441e17da72b6
Reviewed-on: https://chromium-review.googlesource.com/574888
Commit-Queue: Scott Nichols <nicholss@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487308}

Bug: 744204
Change-Id: I3a0bea65287c1b724ac0576dd7d03486789c2f96
Reviewed-on: https://chromium-review.googlesource.com/575205
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487307}

We had a bug where FFmpegDemuxer usage was too high due to excessive
buffering caused by not taking into account enabled/disabled stream
status. This unit test should provide test coverage for that.

BUG=740138

Change-Id: Ia29175a8c90be4465aeffe189d7d8e48e738ef68
Reviewed-on: https://chromium-review.googlesource.com/575390Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487306}