Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 13 Dec, 2017 37 commits
  3. 12 Dec, 2017 3 commits
    • Raymes Khoury's avatar
      Add features::kGrantNotificationsToDSE to about:flags · 582b4313
      Raymes Khoury authored 
      This adds features::kGrantNotificationsToDSE to about flags for easy
toggling for testing purposes.

Bug: 780344
Change-Id: Iffbfe175fbafea5aef368255a226a7780cc3ab44
Reviewed-on: https://chromium-review.googlesource.com/821991
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: default avatarBen Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523611}
      582b4313
    • catapult-deps-roller@chromium.org's avatar
      Roll src/third_party/catapult/ d076c5980..30c927c2b (1 commit) · 427d109e
      catapult-deps-roller@chromium.org authored 
      https://chromium.googlesource.com/catapult.git/+log/d076c5980367..30c927c2b8f3

$ git log d076c5980..30c927c2b --date=short --no-merges --format='%ad %ae %s'
2017-12-12 simonhatch Dashboard - Fix find_anomalies and graph_revisions called with None

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I67368146f9866f3093f726ad3db37e87f53eaa74
Reviewed-on: https://chromium-review.googlesource.com/822216
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523610}
      427d109e
    • Lukasz Anforowicz's avatar
      Revert "Improve granularity of window namespaces in Blink." · e4c10ef6
      Lukasz Anforowicz authored 
      This reverts commit 1c950906.

Reason for revert: Broke Hangouts Chrome App - see https://crbug.com/794079

Original change's description:
> Improve granularity of window namespaces in Blink.
>
> This CL ensures that blink::FrameTree::Find(const AtomicString& name)
> only looks for a match in the current set of related browsing contexts
> (represented in the browser by content::BrowsingInstance).  This CL
> means that window.open's behavior won't change just because a renderer
> process happens to host multiple unrelated browsing contexts (possible
> for example after reusing a renderer process because of hitting the
> process limit).
>
> This CL consists of 3 parts:
>
> - New browser tests.
>   - RenderFrameHostManagerTest.ProcessReuseVsBrowsingInstance
>     for verifying browsing instance boundaries when the
>     renderer processes get reused.
>   - ExtensionFunctionalTest.FindingUnrelatedExtensionFramesFromAboutBlank
>     for verifying that extensions can still lookup unrelated frames
>     from the same extension.
>
> - Having blink::Page maintain a set of related pages.
>   - Page::next_related_page_ and Page::prev_related_page_ form a
>     circular, double-linked list of related pages.
>   - Page::CreateOrdinary takes a new |opener| parameter and treats the
>     new page and the |opener| as related and puts them on the same list.
>   - |opener| is propagated from content::RenderViewImpl, through
>     blink::WebViewImpl into blink::Page.
>
> - Falling back to blink embedder when blink::FrameTree::Find finds no frame
>   with the given name.
>   - The fallback is needed to preserve the old behavior for extensions.
>   - The fallback goes through blink::LocalFrameClient,
>     blink::WebFrameClient / content::RenderFrameImpl,
>     content::ContentRendererClient / ::ChromeContentRendererClient,
>     ::ChromeExtensionsRendererClient and finally is implemented
>     by extensions::ExtensionFrameHelper.
>   - Currently the fallback iterates through all same-origin frames in
>     the given process, but requires that the |relative_to_frame| is an
>     extension frame.  In the future we might want to restrict piercing
>     of browsing instances to specific scenarios where it is needed
>     (e.g. restrict it to background pages / contents only?).
>
> I've tested this CL via:
> (all tests below pass before and after the CL, except for
> ProcessReuseVsBrowsingInstance which is fixed by this CL)
>
> - New tests:
>     - RenderFrameHostManagerTest.ProcessReuseVsBrowsingInstance
>       (web -> web shouldn't violate browsing instance)
>     - ExtensionFunctionalTest.FindingUnrelatedExtensionFramesFromAboutBlank
>       (extension/about:blank -> extension can violate browsing instance)
>
> - Existing tests:
>     - ExtensionApiTest.WindowsCreate_WithOpener and _NoOpener
>       (chrome.windows.create stays in the same browsing instance depending
>        on the setSelfAsOpener parameter)
>     - AppBackgroundPageApiTest.Basic
>       (hosted app -> background page can violate browsing instance;
>        tests handling of mapping of web urls [full url, not just origin]
>        to extensions)
>
> - Manual testing:
>   - Hangouts Chrome *extension* continues to work (sufficient to
>     validate that sign-in works).  Tested with version 2017.1019.418.1.
>
> Bug: 718489
> Test: See above.
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Tbr: tommycli@chromium.org
> Change-Id: Icdc9ec7bef0e35b59e04fb12385045f22db80c3a
> Reviewed-on: https://chromium-review.googlesource.com/764487
> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
> Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521917}

TBR=dcheng@chromium.org,creis@chromium.org,thestig@chromium.org,wolenetz@chromium.org,tommycli@chromium.org,rdevlin.cronin@chromium.org,lukasza@chromium.org,rbpotter@chromium.org


Bug: 718489, 794079
Change-Id: I7ee06ae1b8341044377d5e0ae975888c99d8f700
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/822756Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarMatthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: default avatarŁukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523609}
      e4c10ef6