- 07 Aug, 2018 40 commits
-
-
Matt Menke authored
The test was using a notification to watch for the download that is only sent by the RDH, which is not used when the network service was enabled. Make the test use a download testing observer class instead. Since the test was the only thing using the notification, also remove the old notification from RDH. And remove a couple obsolete entries from testing/buildbot/filters/mojo.fyi.network_browser_tests.filter, while I'm modifying it. Bug: 769401 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5e0cd2ecc1c7e10933ad1903e6eaa9c6fee83c61 Reviewed-on: https://chromium-review.googlesource.com/1162646Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#581211}
-
Juan Antonio Navarro Perez authored
Story has been flaky. NOTRY=true TBR=nednguyen@google.com Bug: 871708 Change-Id: Ie0b464376c7257be0d75c16ed80b12cafa2b7f1c Reviewed-on: https://chromium-review.googlesource.com/1165229Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#581210}
-
Peng Huang authored
Bug: 838899 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I5e8cfd0ad6fc86c6e4e1dcc5983f372a3a3142b3 Reviewed-on: https://chromium-review.googlesource.com/1160770Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#581209}
-
Sami Kyöstilä authored
Change-Id: Ibb08b16a76fd89dbdd91cae4f6285d4007a9bf1e Reviewed-on: https://chromium-review.googlesource.com/1165162Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 501f8950. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22558 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy worker-dev@chromium.org: external/wpt/workers TBR=markdittmer No-Export: true Change-Id: Icb1c9f92c4a4e81a331a1c012242f515fbe8a778 Reviewed-on: https://chromium-review.googlesource.com/1165103 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#581207}
-
Rune Lillesveen authored
TBR=tnijssen@google.com Bug: 871740 Change-Id: I3e57e7d01bca2a31eb25d05dc6305c3092b747d5 Reviewed-on: https://chromium-review.googlesource.com/1165227Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#581206}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/973f34ce..67c8e92b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia7c05d9803fdd046ec3e926233ce95063396c28d Reviewed-on: https://chromium-review.googlesource.com/1164846Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581205}
-
Alexis Hetu authored
With surfaceless EGL implemented in SwiftShader a few months ago, it should be possible to use SwiftShader for headless Chrome on all platforms where it is required. Note: SwiftShader's GPU initialization still has an issue on Chromecast, which will be fixed in a different cl. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5da4f94b7b71a845564627680c7376e70d203a1d Reviewed-on: https://chromium-review.googlesource.com/1161172Reviewed-by:Kenneth Russell <kbr@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581204}
-
Elly Fong-Jones authored
The URL's contrast on the selected grey background is too low. This change increases the brightness of the URL and darkens the background, pushing the contrast ratio over threshold. Bug: 870290 Change-Id: I30f40bcf85b283ee1ca6ddf82dd20e3dbeb9d91f Reviewed-on: https://chromium-review.googlesource.com/1163731Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#581203}
-
Ramin Halavati authored
Traffic annotation auditor's binary is rolled. Change-Id: I226db1602997e3d8af6c36a8afcd461eddd289b5 TBR: georgesak@chromium.org Change-Id: I226db1602997e3d8af6c36a8afcd461eddd289b5 Reviewed-on: https://chromium-review.googlesource.com/1165083Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581202}
-
Matt Menke authored
This CL moves code related to opening files out of the NetworkService (which will eventually be sandboxed), as well as factoring out some of the shared features of the NetLog subclasses, to make code deduplication easier. Implementations are provided for ChromeContentClient and ShellContentClient classes. Bug: 847961 Change-Id: I0a332b4429a2f20cbb38ae1671b8df0fbee28ba1 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1161470 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#581201}
-
Hajime Hoshi authored
This is a part of efforts to forbid V8 execution on the default task runner of the main thread. Bug: 870606 Change-Id: Ic4c8d968e3b07157d5092f54d617b2e69236fae2 Reviewed-on: https://chromium-review.googlesource.com/1165002Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581200}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e19516b87bb1..3cb00fbd5681 git log e19516b87bb1..3cb00fbd5681 --date=short --no-merges --format='%ad %ae %s' 2018-08-07 anthonyalridge@google.com Create a scatter/dot plot for grouping data by label. Created with: gclient setdep -r src/third_party/catapult@3cb00fbd5681 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: I70309eb1cbc227ae86e0fb333aea97128d0c561b Reviewed-on: https://chromium-review.googlesource.com/1164448Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581199}
-
Sheng-Hao Tsao authored
This CL hides camera icon of internal camera app in guest mode. Since extensions are not allowed in guest mode, users can't perform any actions after clicking on the camera icon. Bug: 866412 Test: Tested on eve that there's no camera icon in guest mode. Change-Id: Idf7cc42a50087aeced3283eafd6372144281b570 Reviewed-on: https://chromium-review.googlesource.com/1152147Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#581198}
-
Yutaka Hirano authored
This is a reland of https://crrev.com/e87203b986d8ee7a7a4c46a25d2fe464c1cd31a6. The result change is due to service worker servicification. Cq-Include-Trybots: luci.chromium.try:linux_mojo Bug: 736308 Change-Id: I24d926c13211d8a579640fc6a156c01a3eb725bb Reviewed-on: https://chromium-review.googlesource.com/1164971Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#581197}
-
Marc Treib authored
Previously, we'd post a task to perform the shutdown. This meant that there was a brief period where the unrecoverable error was already set, but Sync was still active, which made things hard to reason about. This CL removes the task-posting and instead just directly calls OnUnrecoverableErrorImpl (which calls ShutdownImpl), which doesn't seem to have any ill effects. Bug: 839834 Change-Id: I998488332c531e817ffcd19e44df0e1273d091a5 Reviewed-on: https://chromium-review.googlesource.com/1163707 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#581196}
-
Rune Lillesveen authored
This reverts commit 30d8a3b9. Reason for revert: Made SetIconAPITest.Overview test flaky (871720) Original change's description: > Fix flaky webrequest related network service tests in component builds > > These tests needed some extra synchronization due to the changes made in > http://crrev.com/c/1139048. These were flaking in component builds. > > Bug: 871224 > Change-Id: Ibe370f9b9c8ebb94ee1dd21ba204c06e91518057 > Reviewed-on: https://chromium-review.googlesource.com/1163987 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580980} TBR=jam@chromium.org,cduvall@chromium.org Change-Id: If7bb80ef219f5aa5107ffd012981839dfaceac76 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871224, 871720 Reviewed-on: https://chromium-review.googlesource.com/1165122Reviewed-by:
-
Rune Lillesveen authored
Only one of the subtests reported flaky, but didn't know how to disable them separately. TBR=noel@chromium.org Bug: 871684 Change-Id: Ie4f27cc5681ba3c6174853dbbfd16d1ba665c451 Reviewed-on: https://chromium-review.googlesource.com/1164958Reviewed-by:
-
Koji Ishii authored
TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I16f3f57a2389c3d48573817fb5e96a30a825e85a Reviewed-on: https://chromium-review.googlesource.com/1164867 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#581193}
-
Oscar Johansson authored
When building using jumbo, files gets merged together and macros with the same name may end up in the same namspace and conflict. This happens for the macro UMA_HISTOGRAM_MBYTES. This commit solves the issue by moving the macro to a shared util file. Bug: 871163 Change-Id: If3af541913a6add55ce739eb43f5a747cf4afd9a Reviewed-on: https://chromium-review.googlesource.com/1163602Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#581192}
-
Adam Rice authored
Display a console message (in the context of the page) when a WebSocket is created via the Pepper pp::WebSocket API. Also add deprecation warnings to the documentation. Tested by manual verification that the console message is shown when the PPAPI WebSocket browser_tests are run. Intent to deprecate thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/3NYHaxhRs14/XOdUJBvHAwAJ BUG=870586 Change-Id: Ib4631d11cd94cecad6c42e6b3fb1fb81ffc2b7fb Reviewed-on: https://chromium-review.googlesource.com/1161712 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581191}
-
Jean-denis Muys authored
This CL is part of the long-term goal of eliminating SigninManager as a public API for Chromium's identity code, replaced by IdentityManager. signin_error_notifer_ash_unittest builds a fake signin manager. This is not necessary: tests succeed without that. So removed creation of unused fake signin manager from tests. Bug: 797899 Change-Id: I7bcfca18f2c94192e629385a7c481957387e7fec Reviewed-on: https://chromium-review.googlesource.com/1158685Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Jean-Denis Muys <jdmuys@chromium.org> Cr-Commit-Position: refs/heads/master@{#581190}
-
Morten Stenshorne authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4dcc14002fc786887ed5dbbe1523c4ba22af94df Reviewed-on: https://chromium-review.googlesource.com/1163518Reviewed-by:
-
Morten Stenshorne authored
Orthogonal flow root children are going to need to calculate an extrinsic constraint space. We already got this right for direct block children, but not for floated children of inline child nodes. Three tests start to pass, but I wrote a new test as well, that's more to the point (it used to fail a DCHECK, and then render incorrectly, if we bypassed that). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iffea4e8cb26f41f8b5caac4bbb7185df5f62f7d7 Reviewed-on: https://chromium-review.googlesource.com/1162175Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#581188}
-
Philip Jägenstedt authored
TBR=markdittmer@chromium.org No-Try: true Change-Id: I7711071a625d3a98c06d09663541cd250e0b9839 Reviewed-on: https://chromium-review.googlesource.com/1164951Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#581187}
-
Mohamed Amir Yosef authored
This CL checks bookmark fields for validity/existence before parsing them when migrating from directory to USS architectures in uss_migrator.cc. The original problematic code has been introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/1162226 Bug: 516866,871671 Change-Id: I843c62325f3e3ec37ce05783c999bdfd5f3542a0 Reviewed-on: https://chromium-review.googlesource.com/1164946 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Manuel Rego Casasnovas authored
The CSSWG decided to change how percentage row tracks and gutters in a grid container with indefinite height are resolved. The CSSWG issues are: * https://github.com/w3c/csswg-drafts/issues/1921 * https://github.com/w3c/csswg-drafts/issues/509 So far they were resolved as "auto", like it happens with percentage heights in regular blocks. But now they're going to behave similar to what happens in the columns axis, they would be ignored to compute the intrinsic height. This causes that we need to repeat the track sizing algorithm when we have a grid container with indefinite height that has some percentage rows using the intrinsic height calculated on the first pass. Then the percentages will be resolved against the intrinsic height. We are adding two new tests for this new behavior on top of updating several tests that were using percentages. We also add a test for content alignment and the second pass when the row size changes, the last case fails due to crbug.com/871230. JFTR, intent to implement and ship thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/CJgcT4hR7Rk/58WfZNbWBQAJ BUG=846187 TEST=css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-001.html TEST=css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002.html TEST=css/css-grid/alignment/grid-content-alignment-second-pass-002.html Change-Id: I2a1959af6c95e0c47d294580599fdbf9bc432348 Reviewed-on: https://chromium-review.googlesource.com/1142409 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#581185}
-
Alexander Timin authored
In addition to existing limit of 200 messages in a single task also limit it to 10 milliseconds to avoid starvation. This logic will be removed when message-per-task mojo dispatching will be implemented. BUG=867133 R=mek@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1152815Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579751} Change-Id: Idb757ddbc91c3e732e34e834bf8e00cc2292ddb5 Reviewed-on: https://chromium-review.googlesource.com/1163782 Cr-Commit-Position: refs/heads/master@{#581184}
-
Jan Krcal authored
This CL implements the following features in the wallet_metadata USS sync bridge: - caching current sync data and filling the cache on start, - informing the processor the bridge is ready to sync, - reacting to local single modifications of server profiles and cards (i.e. to updating the use stats when the address/card is used). Bug: 853688 Change-Id: I07405e02cdf9cd0eb814179d883594253859845c Reviewed-on: https://chromium-review.googlesource.com/1151628 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#581183}
-
Gauthier Ambard authored
This CL disables JavaScriptDialogTestCase/testShowJavaScriptAlert and PrintControllerTestCase/testPrintNormalPage as they are failing on iPad iOS 10 simulator for the multitasking test suite. Bug: 871685 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0486941bdfcba501001e6c3e8e6e3ff0c997245a Reviewed-on: https://chromium-review.googlesource.com/1164944 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#581182}
-
jdoerrie authored
This change simplifies and generalizes base::STLIsSorted() by dispatching to std::is_sorted() and allowing C arrays as input containers by making use of std::begin() and std::end(). Bug: NONE Change-Id: I6c29fb2aea508b10420a2703d96d5306a849444e Reviewed-on: https://chromium-review.googlesource.com/1160163Reviewed-by:
-
Scott Wu authored
The purpose is to share this logic with both ios chrome and ios web view Bug: 865114 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id6f16a05eb3408238c2772b420ec408e499ed2e8 Reviewed-on: https://chromium-review.googlesource.com/1151181Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Scott Wu <scottwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#581180}
-
Gauthier Ambard authored
This CL updates the top margin of the SideSwipe image, which is otherwise wrong after changing device orientation as the toolbar height is different. Bug: 869902 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I767ab0fa76fea9c538e4e2c4e1ad49bc86b0d652 Reviewed-on: https://chromium-review.googlesource.com/1158826Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#581179}
-
Hayato Ito authored
This is a follow-up CL after http://crrev.com/581145. Rewrite each caller of EventTarget::DispatchEvent(Event*) to use EventTarget::DispatchEvent(Event&). Now we can remove EventTarget::DispatchEvent(Event*). There are still a lot of other places where Event* should be replaced with Event&, which can be addressed in another CL. See also http://crbug.com/871662, where we might want to make various Event::Create(..) functions return a reference, instead of a pointer. BUG=871637 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If2e04cbaeea4b540428937dea6a1f9eedf7821ba Reviewed-on: https://chromium-review.googlesource.com/1164806Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#581178}
-
Koji Ishii authored
This patch removes fragments after ellipsis when 'text-overflow: ellpisis' is applied. When the container box has paddings, ellipsizing is computed for the content box, but clipping is performed for the padding box. This patch hides fragments that fall into the paddings. We may need to revisit how to hide them. Before this patch, we moved them outside of the content box. With this patch, we stop producing fragments for them. Neitehr is paint- effects as the spec defines, and may require other parts to special case. I'll explorer other options if problems arose with this approach. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I44256440b4afbf1f4caf35269abf3450372fbf65 Reviewed-on: https://chromium-review.googlesource.com/1158670 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Yi Su authored
Current Copy Image feature downloads the image outside WKWebView. This CL adds functionality of fetching image's data by JavaScript in 2 steps: 1. Draws <img> to <canvas> and exports it; 2. If 1 failed, downloads the picture by XMLHttpRequest, which may be responsed from cache. Both 2 methods may fail due to cross-origin restriction, but under different conditions. More info in this design doc: https://docs.google.com/document/d/1twZ1-Ssn4_9L4eN23-7H-wJkKKWSWLJTSt6Kwn0DqsU/edit?usp=sharing Bug: 163201 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I12bac9d6bd40b4c42d35a23745edaa4dca9fa071 Reviewed-on: https://chromium-review.googlesource.com/1145276 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#581176}
-
Gauthier Ambard authored
This CL updates the ConsentBump ViewController such as it is showing the "More" button instead of "Yes, I'm in" when the view isn't scrolled to the bottom. Bug: 866506 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib31c7622007c0aab713e15aed9a6f277b751c837 Reviewed-on: https://chromium-review.googlesource.com/1163681Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#581175}
-
Gauthier Ambard authored
This CL updates the SideSwipe animations, using transforms instead of modifying frames. Modifying frames wasn't working as expected as the cards are positioned using autolayout. Bug: 867968 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3532a50a50078c07ee68e4c47f59c426c7dd461c Reviewed-on: https://chromium-review.googlesource.com/1158824Reviewed-by:
-
Makoto Shimazu authored
Previously ChromeDoNotTrackTest only tested updates in RendererPreference instead of issuing actual network request. This CL is to change the test to send a request to check if the header is sent with respecting to the preference. Bug: 853085 Change-Id: I62d7eb88b3fea14db68baf5a23d1c44b4e8ab8db Reviewed-on: https://chromium-review.googlesource.com/1164862Reviewed-by:
-
Tetsui Ohkubo authored
According to UX spec, UnifiedSystemTray should keep the position of the notification list from the bottom of the notification. Notifications should be pushed up when UST is expanded, and the notification right under the expand button should be the same one. TEST=manual BUG=856060 Change-Id: I0393dadca02a2e1d633a5a7e3fa165b7c4e3ba82 Reviewed-on: https://chromium-review.googlesource.com/1164807 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#581172}
-
