GitLab

If there is an error bubble on the login screen, and the user clicks
on the status-tray, then the bubble should close. Instead of sending
complicated messages from the UI to the login webui code, it is much
simpler to just close the bubbles when the login window loses focus.

BUG=127092
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/10827015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148866 0039d316-1c4b-4281-b951-d872f2087c98

Fix a SPDY crash bug where a CHECK() is hit because a cancelled stream is considered active by the spdy session.

BUG=139375
TEST=SpdySessionSpdy2Test.CancelStream


Review URL: https://chromiumcodereview.appspot.com/10829066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148865 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148864 0039d316-1c4b-4281-b951-d872f2087c98

When the token service is initialized, tokens are read from disk via LoadTokensFromDB. The callback for this function after the DB read completes is LoadTokensIntoMemory.

When LoadTokensIntoMemory is run, it calls UpdateCredentials, which implicitly rewrites the just-read credentials back to the DB. This DB write is unnecessary. An unintended side effect is that the credential caching service does an unnecessary file-write to "Sync Credentials" every single time Chrome is restarted, even though the sync credentials haven't changed in any way.

This patch modifies LoadTokensIntoMemory to merely update |credentials_|, the in-memory credentials object, without updating the DB too.

BUG=139263
TEST=unit_tests; Sign in to sync, restart chrome, and make sure TokenService credentials are not re-written to DB during initialization.


Review URL: https://chromiumcodereview.appspot.com/10829051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148863 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10829057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148862 0039d316-1c4b-4281-b951-d872f2087c98

This add gesture related functionality to the java side to ContentViewCore and also
adds some missing calls on the routing path of the gesture events to webkit. The WebKit side
for related parts of the WebCompositorInputHandler has already been upstreamed.

BUG=136680
TEST=

Review URL: https://chromiumcodereview.appspot.com/10790066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134372,123162
TEST=none
TBR=flackr

Review URL: https://chromiumcodereview.appspot.com/10673017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148860 0039d316-1c4b-4281-b951-d872f2087c98

cc1plus: warnings being treated as errors
./chrome/browser/extensions/api/api_resource_manager.h: In member function 'void extensions::TestExtensionSystem::CreateSocketManager()':
./chrome/browser/extensions/api/api_resource_manager.h:28:error: 'id' is used uninitialized in this function
chrome/browser/extensions/test_extension_system.cc:55: note: 'id' was declared here



/b/build/slave/cr-mac-rel/build/src/chrome/browser/extensions/test_extension_system.cc:56:3:error: variable 'id' is used uninitialized whenever '&&' condition is false [-Werror,-Wsometimes-uninitialized]
  DCHECK(BrowserThread::GetCurrentThreadIdentifier(&id));
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../base/logging.h:706:35: note: expanded from macro 'DCHECK'
  LAZY_STREAM(LOG_STREAM(DCHECK), DCHECK_IS_ON() && !(condition))   \
                                  ^
../base/logging.h:670:3: note: expanded from macro 'DCHECK_IS_ON'
  ((::logging::g_dcheck_state ==                                        \
  ^
../base/logging.h:362:5: note: expanded from macro 'LAZY_STREAM'
  !(condition) ? (void) 0 : ::logging::LogMessageVoidify() & (stream)
    ^~~~~~~~~
/b/build/slave/cr-mac-rel/build/src/chrome/browser/extensions/test_extension_system.cc:57:56: note: uninitialized use occurs here
  socket_manager_.reset(new ApiResourceManager<Socket>(id));
                                                       ^~
/b/build/slave/cr-mac-rel/build/src/chrome/browser/extensions/test_extension_system.cc:56:3: note: remove the '&&' if its condition is always true
  DCHECK(BrowserThread::GetCurrentThreadIdentifier(&id));
  ^
../base/logging.h:706:35: note: expanded from macro 'DCHECK'
  LAZY_STREAM(LOG_STREAM(DCHECK), DCHECK_IS_ON() && !(condition))   \
                                  ^
../base/logging.h:670:3: note: expanded from macro 'DCHECK_IS_ON'
  ((::logging::g_dcheck_state ==                                        \
  ^
../base/logging.h:362:5: note: expanded from macro 'LAZY_STREAM'
  !(condition) ? (void) 0 : ::logging::LogMessageVoidify() & (stream)
    ^
/b/build/slave/cr-mac-rel/build/src/chrome/browser/extensions/test_extension_system.cc:55:3: note: variable 'id' is declared here
  BrowserThread::ID id;
  ^
1 error generated.


- Improve unit testing of socket API.

Add socket_api_unittest.cc, which calls Socket API functions directly.
This skips the whole browser_tests setup that is relatively slow and
expensive. The current test merely validates the socket-type argument
handling, but the next phase will simulate blocking socket operations.

BUG=112902
TEST=see above


Review URL: https://chromiumcodereview.appspot.com/10795052

TBR=miket@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10830061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148859 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148858 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148857 0039d316-1c4b-4281-b951-d872f2087c98

Add socket_api_unittest.cc, which calls Socket API functions directly.
This skips the whole browser_tests setup that is relatively slow and
expensive. The current test merely validates the socket-type argument
handling, but the next phase will simulate blocking socket operations.

BUG=112902
TEST=see above


Review URL: https://chromiumcodereview.appspot.com/10795052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148856 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139088
TEST=Linux CrOS build.

Review URL: https://chromiumcodereview.appspot.com/10827031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148855 0039d316-1c4b-4281-b951-d872f2087c98

This is the default value. It can be overridden with GYP_DEFINES. It is with
the swarm master.
Also remove the corresponding XXX_run targets. These can be problematic when
developers are moving files around, especially with DEPS rolls.
This simplifies build slave management during the deployment as the .isolate
files are being rolled out.

TBR=cmp@chromium.org
NOTRY=true
BUG=139426

Review URL: https://chromiumcodereview.appspot.com/10828061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148854 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10835024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148853 0039d316-1c4b-4281-b951-d872f2087c98

Move the render process host tests in content to chrome. These test chrome specific behavior with things like extensions/webui/singleton tabs.

BUG=90448
Review URL: https://chromiumcodereview.appspot.com/10820056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148852 0039d316-1c4b-4281-b951-d872f2087c98

Also removes a no-longer necessary -respondsToSelect: check since we no longer support 10.5.

BUG=20053
TEST=Right click on a BMB folder and click edit. Buttons should be "Cancel" and "Save".
Right click on BMB and select "Add Folder...". Buttons should be "Cancel" and "Add".

Review URL: https://chromiumcodereview.appspot.com/10832052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148851 0039d316-1c4b-4281-b951-d872f2087c98

Do not individual files that are needed since the list of needed files for
new-run-webkit-websocketserver is too often changing.

Contrary to the previous .isolate CLs, this one was done manually. A rule in isolate_common.py will be added in a follow up change.

TBR=dpranke@chromium.org
NOTRY=true
BUG=139426


Review URL: https://chromiumcodereview.appspot.com/10828059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148850 0039d316-1c4b-4281-b951-d872f2087c98

own pp_file_handle{.h,idl}.

BUG= none
TEST= trybots

Review URL: https://chromiumcodereview.appspot.com/10824048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148849 0039d316-1c4b-4281-b951-d872f2087c98

-Put nodoc on experimental.apps.{notify,clearAllNotifications} since those
aren't available in new packaged apps and we'll probably be doing some changes
to them before we'd move them to supported anyway.

-Remove nodoc from experimental.apps.onLaunched

BUG=138754
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10810074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148848 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138115

TEST=


Review URL: https://chromiumcodereview.appspot.com/10824067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148847 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=Compile


Review URL: https://chromiumcodereview.appspot.com/10825048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132886


Review URL: https://chromiumcodereview.appspot.com/10827054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148845 0039d316-1c4b-4281-b951-d872f2087c98

This function isn't used anywhere.

BUG=


Review URL: https://chromiumcodereview.appspot.com/10824068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148844 0039d316-1c4b-4281-b951-d872f2087c98

These 2 CL's were reverted due to some DCHECK failures we saw in the field,
but it turned out a different change was likely the underlying culprit. I'm
now re-applying these changes to solve the original bug.

https://chromiumcodereview.appspot.com/10446027 (crrev.com/138961)
https://chromiumcodereview.appspot.com/10444063 (crrev.com/139371)

TBR=asargent@chromium.org

BUG=129587
TEST=Autoupdate and blacklist of extensions/apps from WebStore should
still work. Also existing unit/browser tests should pass.


Review URL: https://chromiumcodereview.appspot.com/10833057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148843 0039d316-1c4b-4281-b951-d872f2087c98

Currently when we switch between displays with extended displays turned on, the sequence is,
Mirrored -> Extended -> Extended (reversed) -> Mirrorer.

Change this to switch only between extended and mirrored displays if the extended display flag is enabled,
i.e.,
Mirrorer -> Extended -> Mirrored.


R=oshima@chromium.org
BUG=137727
TEST=Tested on a ChromeOS device with a secondary display to confirm that the inteded sequence is followed on switching displays.


Review URL: https://chromiumcodereview.appspot.com/10829026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148842 0039d316-1c4b-4281-b951-d872f2087c98

returned from memory bot.

Fix for https://chromiumcodereview.appspot.com/10555005

BUG=118280
TEST=Same test scenarios as in change 10555005.

Review URL: https://chromiumcodereview.appspot.com/10825059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148841 0039d316-1c4b-4281-b951-d872f2087c98

This adds the ability to implement "instance" messages (as opposed to resource messages) to PpapiHost via a message filter interface. The ownership model for these filters works just like RenderViewObserver. All non-resource messages are sent through this list of filters.

This adds the ability to add such filters in the Chrome layer (as opposed to just content) by plumbing through some notifications. This patch responds to the trivial "Flash print" interface by calling the existing function in the renderer.

This doesn't change the in-process case. Making this code path work in process will require that the "core" instance interface be done first or at the same time. As a result, the old in-process implementation is kept (it forwards to the same function in the end).

This patch adds a HostResourceFactory for Chrome but doesn't hook it up yet. There is a TODO for this. I need to conver the host factories to a filter-like system to allow dynamic adding of filters from the Chrome layer. I'll do this in a follow-up patch.

TEST=manual
BUG=none

Review URL: https://chromiumcodereview.appspot.com/10803050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148840 0039d316-1c4b-4281-b951-d872f2087c98

Add GetSitesWithData and FreeSiteList methods to PPP_Flash_BrowserOperations interface and hook them up in PepperFlashSettingsManager.


BUG=132409
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10825018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148839 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138195
TEST=


Review URL: https://chromiumcodereview.appspot.com/10808074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148838 0039d316-1c4b-4281-b951-d872f2087c98

https://bugs.webkit.org/show_bug.cgi?id=92059 adds an optimization on color
matrix filters so that they can be combined in a single pass as long as the
resulting colors don't need to be clamped. Brightness needs clamping, so it
should go last.

This also fixes an uninitialized value that made us stick a grayscale filter randomly on layers.

BUG=138645
TEST=new startup animation


Review URL: https://chromiumcodereview.appspot.com/10833027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148837 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10821067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148835 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139236
TEST=see bug description

Review URL: https://chromiumcodereview.appspot.com/10821060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148834 0039d316-1c4b-4281-b951-d872f2087c98

For problem description and other info please see the BUG page.
This is for DictionaryValue.

BUG=138946
TEST=N/A (no fix & no new feature)
TBR=jar scottbyer achuith agl mnissler davemoore garykac akalin hans bulach phajdan.jr jamesr

Review URL: https://chromiumcodereview.appspot.com/10834004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148833 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112525
TEST=unittests, manual 

Review URL: https://chromiumcodereview.appspot.com/10823050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148830 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=policy.PolicyTest.testSetDownloadDirectory
NOTRY=True


Review URL: https://chromiumcodereview.appspot.com/10835023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148829 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10825025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148828 0039d316-1c4b-4281-b951-d872f2087c98

Clean up TFP in VAVDA:
- properly restore currently bound texture after binding our own
- use the extracted Binders for the above
- use glXDestroyPixmap instead of glXDestroyPixmapGLX
- do not bind texture twice

Also modify TextureImageTransportSurface to use the extracted Binders.

BUG=
TEST=manual runs of VAVDA


Review URL: https://chromiumcodereview.appspot.com/10827052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148827 0039d316-1c4b-4281-b951-d872f2087c98

support web intents picker button.

R=bauerb@chromium.org
BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10835020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148826 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sergeyu

Review URL: https://chromiumcodereview.appspot.com/10820061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148825 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10825052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148824 0039d316-1c4b-4281-b951-d872f2087c98