GitLab

This adds a build step after generated_resources.h is generated. This step
parses generated_resources.h, extracting all the IDS_* names, index pairs and
produces a mapping from a hash of each name to its index.

This is the first step to implement a mechanism to allow us to override UI
strings with server provided strings from the variations_service.

Design doc for this feature: https://docs.google.com/a/google.com/document/d/1UCQCZzF0Ox9dyD3R66_Fn1RYfckF9BTVjM0o5u4YaWg/edit?usp=sharing

BUG=370033

Review URL: https://codereview.chromium.org/246123007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269880 0039d316-1c4b-4281-b951-d872f2087c98

This broke again - http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tests%20%28dbg%29%281%29&number=23472

> Only commit cookie changes in prerenders after a prerender is shown
> Will create a PrerenderCookieStore for each prerender, retaining all cookie
> operations of a prerender until the prerender is shown to the user.
> Forces prerenders to be in a new render process by themselves for this to work.
> BUG=371003
> 
> This is a resubmission of https://codereview.chromium.org/233353003, which had
> to be reverted due to build breaks. See LGTM's there.
> 
> Review URL: https://codereview.chromium.org/278403003

TBR=tburkard@chromium.org

Review URL: https://codereview.chromium.org/280383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269879 0039d316-1c4b-4281-b951-d872f2087c98

Likely cause to ASAN issues in http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20Tests%20%28sandboxed%29/builds/1616/steps/browser_tests/logs/stdio

> Pepper: Fix crash on allocation failure.
> 
> GetPNaClResourceInfo() currently performs a 1 megabyte allocation. Though any
> memory allocation can fail, this one is more likely due to its size.
> 
> This change mitigates this problem in two ways. If memory allocation fails, we
> report an error and return early instead of using memory.
> 
> Additionally, this change checks the size of the file before performing a
> memory allocation. This should lead to smaller allocations and more successful
> plugin loads.
> 
> BUG=370965
> 
> Review URL: https://codereview.chromium.org/274673002

TBR=teravest@chromium.org

Review URL: https://codereview.chromium.org/279323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269876 0039d316-1c4b-4281-b951-d872f2087c98

These codes were modifying command parameters along with command path, which resulted in
page filtering failures for telemetry blink tests.

BUG=371215
NOTRY=true

Review URL: https://codereview.chromium.org/280343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269875 0039d316-1c4b-4281-b951-d872f2087c98

I really wanted this in some debugging I was doing.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/280273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269873 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372423
R=noamsml@chromium.org

Review URL: https://codereview.chromium.org/286483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269872 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359598

Review URL: https://codereview.chromium.org/261403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269871 0039d316-1c4b-4281-b951-d872f2087c98

This only works on linux, so the script still errors out on non-linux platforms.

R=sbc@chromium.org
BUG=369189

Review URL: https://codereview.chromium.org/262753005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269869 0039d316-1c4b-4281-b951-d872f2087c98

CapturePixels has a special branch for printing code, but
CapturePixelsAsync before this patch doesn't.  Because WebKitTestRunner
calls the async version in compositing mode, printing tests fail if it
doesn't also handle this case.

The stateful canvas() accessor that the paintPagesWithBoundaries
modifies is a bit of a code smell that previously existed, but it can't
be easily cleaned up until the CapturePixels function gets removed.

BUG=361729

Review URL: https://codereview.chromium.org/274253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269867 0039d316-1c4b-4281-b951-d872f2087c98

They are a better option since server-side wait is supported by default.
It also avoids the broken EGL_KHR_fence_sync implementation
on Qualcomm drivers.

BUG=371530,278606,341867
R=piman@chromium.org, reveman@chromium.org

Review URL: https://codereview.chromium.org/285523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269863 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/284603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269862 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/274373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269859 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269858 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372143

Review URL: https://codereview.chromium.org/282573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269857 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=173856:173886&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/283503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269856 0039d316-1c4b-4281-b951-d872f2087c98

Will create a PrerenderCookieStore for each prerender, retaining all cookie
operations of a prerender until the prerender is shown to the user.
Forces prerenders to be in a new render process by themselves for this to work.
BUG=371003

This is a resubmission of https://codereview.chromium.org/233353003, which had
to be reverted due to build breaks. See LGTM's there.

Review URL: https://codereview.chromium.org/278403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269855 0039d316-1c4b-4281-b951-d872f2087c98

It might not be good to switch thread_local to use ThreadPlatformStorage
on all platforms, in order to pass all tests in Linux, the number of TLS
slot has be 1024, it means 4k memory will be temporarily increased in stack,
and then move to heap for every thread which use the TLS.

Android only needs 256 slot which is much smaller than Linux's usage, and
TLS slot is currently only running out on Android's tests.

So this patch is only for Android platform.

BUG=264406

Review URL: https://codereview.chromium.org/189263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269854 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=jln@chromium.org, jschuh@chromium.org

Review URL: https://codereview.chromium.org/273423007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269852 0039d316-1c4b-4281-b951-d872f2087c98

Recreation of issue 267393011.

BUG=368860

Review URL: https://codereview.chromium.org/280123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269851 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=372512

Review URL: https://codereview.chromium.org/280633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269848 0039d316-1c4b-4281-b951-d872f2087c98

Removes it from the RenderWidgetCompositor and
WebLayerTreeViewImplForTesting classes.

Depends on: https://codereview.chromium.org/276753002/

R=piman
BUG=251936

Review URL: https://codereview.chromium.org/277703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269842 0039d316-1c4b-4281-b951-d872f2087c98

Only the check for an outdated install should be suppressed in this case.

BUG=342465
R=robertshield@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/277403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269840 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269838 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13160: (noelallen) Roll bionic version, and add missing flag to force libstdc++ rebuild.
r13161: (dyen) Fixed some issues testing without GDB on windows toolchain builds.
r13162: (noelallen) Add a test for parsing properties in scons files.
r13163: (noelallen) Update GN build files.
r13164: (dyen) Correctly identify the windows arch for i686-w64-mingw32 to be x86-32.
r13165: (mark) Use pthread_mach_thread_np(pthread_self()) instead of mach_thread_self().
r13166: (jfb) PNaCl translator build: install FEATURE_VERSION file
r13167: (jfb) Update revision for PNaCl r13154->r13166

BUG=none
TEST=browser_tests and nacl_integration
R=bradnelson@google.com

Review URL: https://codereview.chromium.org/275393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269837 0039d316-1c4b-4281-b951-d872f2087c98

R=scottmg@chromium.org
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/280173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269836 0039d316-1c4b-4281-b951-d872f2087c98

R=danakj@chromium.org,enne@chromium.org
BUG=369757,368935

Review URL: https://codereview.chromium.org/266913021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269835 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372487
TBR=darin@chromium.org
TEST=waterfall

Review URL: https://codereview.chromium.org/276343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269833 0039d316-1c4b-4281-b951-d872f2087c98

The expectation is that clients sending changes to the server always
increment the value. The server only accepts changes if the ids
match, otherwise the change is rejected. This puts the onus on the
client as to how to resolve out of order changes.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/277563006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269832 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359742
TEST=run unittests
NOTRY=true

Review URL: https://codereview.chromium.org/278403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269831 0039d316-1c4b-4281-b951-d872f2087c98

Ran in trybot to make sure this is not flaky, 200 runs were successful on win and linux trybots.

BUG=368077
Test=None, internal test only change.

Review URL: https://codereview.chromium.org/271593009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269830 0039d316-1c4b-4281-b951-d872f2087c98

where it makes sense to do so in existing code.

This migration shook out a couple of bugs in mach_logging.h carried over
from mac_logging.h (fixed there too).

R=rsesek@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/278923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269829 0039d316-1c4b-4281-b951-d872f2087c98

This is a stepping stone towards having audio/video renderers accurately
report their buffering state. For now we use the Preroll() callback to
signal that enough data has been buffered.

Notable changes:
  - The kStarting/kStarted states have been merged into kPlaying
  - DoPlay() is now done implicitly after entering the kPlaying state
  - Transitioning from waiting to non-waiting states (or vice versa)
    now controls the starting and stopping of playback

BUG=144683

Review URL: https://codereview.chromium.org/276973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269828 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269823 0039d316-1c4b-4281-b951-d872f2087c98

crazy_linker: Add a callback feature.
https://android-review.googlesource.com/#/c/92881/

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/278323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269822 0039d316-1c4b-4281-b951-d872f2087c98

R=isherman@chromium.org, kalman@chromium.org
BUG=346488

Review URL: https://codereview.chromium.org/232183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269820 0039d316-1c4b-4281-b951-d872f2087c98

It is possible for a non-menu source to start a nested message loop
(e.g. for dragging a menu-item). So attempting to terminate the current
iteration of the message-loop when the menu is closed can be problematic.
So instead, terminate the message-loop through the DispatcherClient.

BUG=367850, 372208
R=sky@chromium.org

Review URL: https://codereview.chromium.org/279073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269819 0039d316-1c4b-4281-b951-d872f2087c98

Use the scale factor in the image in the DrawImageIntHelper function in case we are not drawing in pixels.

BUG=370392
R=oshima

Review URL: https://codereview.chromium.org/275693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269818 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269817 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370460
R=derat@chromium.org

Review URL: https://codereview.chromium.org/278023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269816 0039d316-1c4b-4281-b951-d872f2087c98

Add target_build_type flag to bisect-perf-regression tool to enable bisecting of a Debug build with run-bisect-manual-test.py tool.

The run-bisect-manual-test.py uses bisect-perf-regression.py under the hood, and currently it
is not possible to bisect a Debug build this way.  This CL addresses this.

Also fixes browser.Start() / browser.Close() in manual-test.py.

BUG=370373
NOTRY=true

Review URL: https://codereview.chromium.org/277993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269815 0039d316-1c4b-4281-b951-d872f2087c98