- 12 Dec, 2018 40 commits
-
-
Alice Boxhall authored
Bug: 872438 Change-Id: I86931802744baa8d41a4c6ed2b1c89967fc47138 Reviewed-on: https://chromium-review.googlesource.com/c/1372105 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#615791}
-
John Lee authored
Bug: 910476 Change-Id: If8d3676d21133f49b0e872bca84d389d0a8042f3 Reviewed-on: https://chromium-review.googlesource.com/c/1372416Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#615790}
-
Brandon Wylie authored
TBR=twellington@chromium.org Bug: 913937 Change-Id: Idb4c3142dd6db2806662922effe2132eb1e790b6 Reviewed-on: https://chromium-review.googlesource.com/c/1372651 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#615789}
-
Ahmed Fakhry authored
Chrome used to call into debugd to get the list of user log files that it should read itself. Those files are generated by Chrome itself, and hence they should be listed in Chrome itself without the need to ask debugd to list them. BUG=907193 TEST=File feedback report, make sure the following entries are part of the system logs: * chrome_user_log, * libassistant_user_log, * login-times, * logout-times. Change-Id: I2e164db999edfc6e7089a0ae905cc6db57121621 Reviewed-on: https://chromium-review.googlesource.com/c/1352681Reviewed-by:Dan Erat <derat@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#615788}
-
Hiroshige Hayashizaki authored
https://chromium-review.googlesource.com/1153598 switched WorkerClassicScriptLoader::ResponseURL() (which is used as WorkerGlobalScope's URL later) from ResourceResponse::CurrentRequestUrl() to ResourceResponse::ResponseUrl() (in terms of the current ToT), but the same-origin check for Issue 861965 remained unchanged, i.e. checking ResourceResponse::CurrentRequestUrl(), which doesn't reflect ServiceWorker interception. This CL updates the same-origin check to also check ResourceResponse::ResponseUrl(), to ensure WorkerGlobalScope's URL and SecurityOrigin always match even if a ServiceWorker returns a response with a cross-origin URL. Bug: 861965, 861564 Change-Id: I9915599dc1ee16dbd4879525db90c4cb38da4eb3 Reviewed-on: https://chromium-review.googlesource.com/c/1368460 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#615787}
-
liberato@chromium.org authored
Change-Id: I82dce2160fd1809091fdfdbef9c854d9aef16844 Reviewed-on: https://chromium-review.googlesource.com/c/1372578 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#615786}
-
CJ DiMeglio authored
Change-Id: Ib9d49e22b1483f5df6310b00c70879cb48f8659f Reviewed-on: https://chromium-review.googlesource.com/c/1372891 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#615785}
-
Alice Boxhall authored
This reverts commit 0ed2b6ca. Reason for revert: Seems to be causing build breakages on Fuchsia bots https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20ARM64/47071 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64/25530 Original change's description: > [Fuchsia] Generate more complete GN target names for FIDL packages. > > FIDL package names consist of multiple dot-delimited segments, to allow > scoping of packages to avoid clashes. Our GN generator script was using > only the final segment of each package's name, resulting in clashes, > e.g. between fuchsia.auth and fuchsia.modular.auth, if both were > present in the SDK. > > We continue to generate targets under the //third_party/fuchsia-sdk/sdk > namespace, but use the full name rather than only the final segment, > e.g. custom.modular.auth would become custom_modular_auth. > > We also special-case the top-level "fuchsia" namespace to be ignored, > e.g. fuchsia.modular_auth becomes just modular_auth. > > Bug: 910670 > Change-Id: I675d894c72b5d43b6d8b20fb026075573a5a3380 > Reviewed-on: https://chromium-review.googlesource.com/c/1372892 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615763} TBR=wez@chromium.org,kmarshall@chromium.org Change-Id: Ibc33ed422c1365b019bf53ca8e4fdb26ee781038 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910670 Reviewed-on: https://chromium-review.googlesource.com/c/1372111Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615784}
-
Alice Boxhall authored
This reverts commit 573f4675. Reason for revert: Seems to be causing EffectiveTouchActionPropagatesAcrossNestedFrames to fail https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927388648425983952/+/steps/content_browsertests_on_Intel_GPU_on_Mac_on_Mac-10.12.6/0/logs/SitePerProcessBrowserTouchActionTest.EffectiveTouchActionPropagatesAcrossNestedFrames/0 Original change's description: > Remove code to store the last popup transiently in WebFrameWidgetImpl > > This code was copied over from WebViewImpl when adding the HidePopups > call in order to have a pinch zoom or scroll tap outside the current > popup in a non-main-frame-local-rooted iframe hide the current popup. > > This is modifying state on WebViewImpl meant to track between TapDown > and Tap, to avoid the Tap showing a popup that was hidden by TapDown. > > WebFrameWidgetImpl does not show popups on Tap, and if it did, it > should track this transient state locally not on WebViewImpl. > > Also remove the undocumented FALLTHROUGH which was not explained > in 671732 as it now goes to nothing. > > R=dcheng@chromium.org > > Change-Id: I9d67539cf0afbb9db239b73bf83418e1a877e6db > Bug: 912193, 671732 > Reviewed-on: https://chromium-review.googlesource.com/c/1372539 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615708} TBR=danakj@chromium.org,dcheng@chromium.org,wjmaclean@chromium.org Change-Id: Ifddbb605fc6165505774105d5618d57b62e3159c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912193, 671732 Reviewed-on: https://chromium-review.googlesource.com/c/1372110Reviewed-by:
-
Carlos IL authored
Added SB committed interstitials flag, and changed the cancellation error code to ERR_BLOCKED_BY_CLIENT if the flag is set. Bug: 910794 Change-Id: I43853600bee91f7fdeea78409248994372fd7091 Reviewed-on: https://chromium-review.googlesource.com/c/1364330 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#615782}
-
Peter Boström authored
* Uses EASE_IN_OUT for the progress bar to match the throbber. * Uses FAST_OUT_SLOW_IN for favicon per UX request. Bug: chromium:912620 Change-Id: I3ce0a376996c016904a605aa8195cc741b8e03d1 Reviewed-on: https://chromium-review.googlesource.com/c/1373016Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#615781}
-
Joel Einbinder authored
Bug: 685385 Change-Id: I1adae3ac86a2af361b1253f7e723aa86a7ce397e Reviewed-on: https://chromium-review.googlesource.com/c/1371086Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#615780}
-
Robbie McElrath authored
Bug: 838942 Change-Id: Ibb116e15580dace63bb271af04e983d37db56167 Reviewed-on: https://chromium-review.googlesource.com/c/1371208 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615779}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a719fc18a57d..24328a055465 git log a719fc18a57d..24328a055465 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 jbolz@nvidia.com Recognize OpTypeAccelerationStructureNV as a type instruction (#2190) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@24328a055465 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9532f93180366e06ba00925d3ca8d795ce128a3f Reviewed-on: https://chromium-review.googlesource.com/c/1372356Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615778}
-
Jinsuk Kim authored
Bottom toolbar animation in Chrome duet mode was hidden behind the ephemeral tab in peek mode. This CL keeps the toolbar entirely hidden while overlay panel is showing. Bug: 894619 Change-Id: Ib6147629a3eb939d367e14a7359823a9eae64333 Reviewed-on: https://chromium-review.googlesource.com/c/1359992Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#615777}
-
Wenzhao Zang authored
Bug: 914144 Change-Id: Iaa3ef0883ed373d30ddfb2d65e5822a3b1bfcab5 Reviewed-on: https://chromium-review.googlesource.com/c/1372361 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#615776}
-
Zhenyao Mo authored
at glGenerateMipmap() call to work around a driver bug on MacOSX BUG=913301 TEST=webgl_conformance,submitted test case R=kbr@chromium.org Change-Id: I9b83949111fa799274b51fddeabdf5fe4777c8e9 Reviewed-on: https://chromium-review.googlesource.com/c/1372179Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#615775}
-
Alice Boxhall authored
Revert "Remove hard coded accessibility desktop tree id and make RenderFrameHost implement AXHostDelegate" This reverts commit 701b9ed0. Reason for revert: Seems to be causing network_service_browser_tests to fail: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17534 Original change's description: > Remove hard coded accessibility desktop tree id and make RenderFrameHost implement AXHostDelegate > > This change is part of the effort to move AutomationManagerAura into ui/. This change in particular removes deps on content/ inside of AutomationManagerAura. > > Highlights: > - removes usage of hard-coded desktop tree id in automation api (native and js bindings) > - makes all known tree managers implement AXHostDelegate > > TBR=servolk@chromium.org > > Bug: 888152 > Test: existing browser_tests (Automation Api tests, ChromeVox tests). > Change-Id: I86a211d7588d280223c6dbacda0f0f1ad056a4fa > Reviewed-on: https://chromium-review.googlesource.com/c/1361650 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615677} TBR=jamescook@chromium.org,dmazzoni@chromium.org,sky@chromium.org,dtseng@chromium.org Change-Id: I8a2eedc503827eafea6f40e3b22e6ba515eaa043 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 888152 Reviewed-on: https://chromium-review.googlesource.com/c/1372991Reviewed-by:
-
Peter Boström authored
Bug: chromium:907494 Change-Id: I123ff28187f2cc482ae89453e2bd79a2414f9e04 Reviewed-on: https://chromium-review.googlesource.com/c/1372895Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/05e255178ba2..f78267e16157 git log 05e255178ba2..f78267e16157 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 tsepez@chromium.org Add ScriptType column to attributes.inc table 2018-12-11 tsepez@chromium.org Check return values for all uses of GetFirstChildByClass<>() 2018-12-11 thestig@chromium.org Fix nits in CPWL_Caret and delete dead code. 2018-12-11 thestig@chromium.org Clean up CPWL_Timer and CPWL_TimerHandler. Created with: gclient setdep -r src/third_party/pdfium@f78267e16157 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If625d75e2517b89f3772bdccba2a2f5b90029e50 Reviewed-on: https://chromium-review.googlesource.com/c/1372656Reviewed-by:
-
Simon Que authored
Previously this was dropped to 10% due to infra failures. See http://crrev.com/c/1361583 We have since added the builder to a no-alert blacklist. See comment at http://crbug.com/911187#c13 Bug: 911187 Change-Id: I616dc30869649087b083fc7f8c84157d07e51501 Reviewed-on: https://chromium-review.googlesource.com/c/1370238Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#615771}
-
Maggie Chen authored
(1) Merge GLImageDXGIHandle into GLImageDXGI. For those three override functions BindTexImage(), GetInternalFormat() and ReleaseTexImage(), Check handle_ before continuing processing handle related code. Rename GLImageDXGIHandle::Initialize() to GLImageDXGI::InitializeHandle() (2) Merge GLImageDXGIBase into GLImageDXGI. Bug:776010 Change-Id: Id2906a4fcb19e4286c13f718ae1913e73994d303 Reviewed-on: https://chromium-review.googlesource.com/c/1361588 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#615770}
-
sebsg authored
Bug: 913983 Change-Id: Ib2519bffbb11861ff525e4c3488623d4b574a1cb Reviewed-on: https://chromium-review.googlesource.com/c/1372265 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#615769}
-
Robbie McElrath authored
This makes the HttpAuthCache copying in SigninPartitionManager work when the network service is enabled. Bug: 838942 Change-Id: I679885ad0b9f8ca3fada00b777f5a955ba7b4d0f Reviewed-on: https://chromium-review.googlesource.com/c/1368949 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
-
Jon Napper authored
Added support for 8-bit quantized NN classifier models for AssistRanker. The model must be dequantized prior to inferencing. Bug: 907727 Change-Id: Ie52a55eb531eac9b3617dfd47bf27aa91b528347 Reviewed-on: https://chromium-review.googlesource.com/c/1370229Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Jon Napper <napper@chromium.org> Cr-Commit-Position: refs/heads/master@{#615767}
-
Charlie Andrews authored
TBR=crouleau@chromium.org CC=kouhei@chromium.org,ksakamoto@chromium.org Bug: 914100 Change-Id: Ie5bb8c15ea8b8bf8dcc49cd53bd917df7784f30b Reviewed-on: https://chromium-review.googlesource.com/c/1372727Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#615766}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7814fa265093..149e7c6373d2 git log 7814fa265093..149e7c6373d2 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 benjhayden@chromium.org Switch catapult wct from go to js version. 2018-12-11 rajekumar@google.com [ftrace importer] Add rss stat parser Created with: gclient setdep -r src/third_party/catapult@149e7c6373d2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Icdc98a5771790c46dfccced0ec4ba9303a28443a Reviewed-on: https://chromium-review.googlesource.com/c/1372355Reviewed-by:
-
Dmitry Gozman authored
- Replaced multiple parameters with a single struct. - Merged LoadHTMLString, CommitNavigation and CommitDataNavigation methods. - Helper constructor turning WebNavigationInfo to WebNavigationParams. - Moved srcdoc handling from FrameLoader to DocumentLoader. Bug: 855189 TBR=tommycli@chromium.org,thestig@chromium.org Change-Id: If009a2da035b223ce50d60c6eb9bf474fd1539d2 Reviewed-on: https://chromium-review.googlesource.com/c/1274609 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#615764}
-
Wez authored
FIDL package names consist of multiple dot-delimited segments, to allow scoping of packages to avoid clashes. Our GN generator script was using only the final segment of each package's name, resulting in clashes, e.g. between fuchsia.auth and fuchsia.modular.auth, if both were present in the SDK. We continue to generate targets under the //third_party/fuchsia-sdk/sdk namespace, but use the full name rather than only the final segment, e.g. custom.modular.auth would become custom_modular_auth. We also special-case the top-level "fuchsia" namespace to be ignored, e.g. fuchsia.modular_auth becomes just modular_auth. Bug: 910670 Change-Id: I675d894c72b5d43b6d8b20fb026075573a5a3380 Reviewed-on: https://chromium-review.googlesource.com/c/1372892 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615763}
-
Tony de Luna authored
Changes in this cl: * Split SectionHeaderRowView and subclasses to a new file. * Remove the concept of a "subtitle" in a section header. * MobileHeaderRowView no longer subscribes to network updates directly, toggle status is triggered by NetworkListView. * Display mobile status messages with similar logic as we display WiFi status messages. * Initializes section headers on NetworkListView constructor to simplify logic. * Removes unused headers. Current UI spec no longer has the concept of a "subtitle". It was confusing that mobile status messages were being shown as a "subtitle", while WiFi status messages are a label in NetworkListView. Mobile toggle state and status message logic is complex. Decided to make NetworkListView call MobileHeaderView to get the mobile status message. This way we can re-use existing subtitle selection logic. Change-Id: I46c99d01100db39cc4541910d3b19f670cd1fc50 Reviewed-on: https://chromium-review.googlesource.com/c/1371902 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#615762}
-
Robbie McElrath authored
This adds functions to NetworkContext to facilitate copying HttpAuthCache contents from one NetworkContext to another. This copying is needed during ChromeOS sign in to copy any proxy authentication that happened in the login screen into the user's session. We'll need to somehow reference one NetworkContext from another in order to do the copying, which isn't curently possible. We considered 3 approaches to address this: 1. Add an ID to all NetworkContexts, and use the source NetworkContext's ID in the copy call. The network service can then look up the HttpAuthCache for that NetworkContext and copy from it. 2. Create a Mojo struct containing the relevant portions of the HttpAuthCache entries, and add a GetHttpAuthCacheEntries method to NetworkContext that will return a list of all entries. We can then pass that list back to the destination NetworkContext via a SetHttpAuthCacheEntries method. 3. Add a NetworkContext method to save the current HttpAuthCache contents somewhere not associated with that NetworkContext, and return some token/key/id that can be used to reference the saved data in a subsequent call on the destination NetworkContext. Here are my thoughts on each approach: 1. I don't think this features is enough of a justification for adding a NetworkContext ID. NetworkContexts are logically tied to a StoragePartition, and currently access to them is mostly tied to their StoragePartition as well. I think that's the way it should be, and adding a unique ID to them makes it easier to reference them from other places. 2. In order to convert the existing HttpAuthCache entries into a mojo struct, we'd need to add accessors to the vector of entries, as well as path list and nonce of each individual entry. While this is doable, I felt like this was too big of a change to the HttpAuthCache API, and was exposing too much of its implementation. 3. I'm not a huge fan of this API, but it's very simple, doesn't require any changes to net/'s API, and doesn't require serializing the HttpAuthCache and transmitting it twice across processes. This CL implements approach 3, but I'm happy to change it. This also refactors ProfileAuthData to use the new API. ExistingUserController and SigninPartitionManager will also need to be migrated to this new API, but those will be done in followup CLs. Bug: 838942 Change-Id: I47367dcff41f73e86535f487035e20dde5cbb86c Reviewed-on: https://chromium-review.googlesource.com/c/1366877 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615761}
-
Kent Tamura authored
Bug: 843412 Change-Id: I5f5b67cbefe1fa6f591a62cd646b0babacbe4a4f Reviewed-on: https://chromium-review.googlesource.com/c/1371309Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#615760}
-
Theresa authored
BUG=594166 Change-Id: Ie5871930e089b8926f31a83854df6e8315d093a9 Reviewed-on: https://chromium-review.googlesource.com/c/1371820 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou (OOO Dec 12 - Dec 31) <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615759}
-
jonross authored
When running with VizDisplayCompositor virtual/user-activation-v2/fast/events/no-fake-mousemove.html was flaking with timeouts. However it was only flaking on one particular bot WebKit Mac10.13 (retina). We suspect that the extra process is leading to increased delay in this test. Marking this test as slow will allow us to confirm that. TEST=virtual/user-activation-v2/fast/events/no-fake-mousemove.html Bug: 912364 Change-Id: Ic04f50efa612782fdf66ecc4cb2ea260defb04a1 Reviewed-on: https://chromium-review.googlesource.com/c/1372470Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#615758}
-
Hiroshige Hayashizaki authored
Follow-up of https://chromium-review.googlesource.com/1352042 Bug: 880027 Change-Id: I1c289288239749bfd33e20bbdec948e6ab89512f Reviewed-on: https://chromium-review.googlesource.com/c/1371045Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#615757}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a039a0255e18..79ff98db91ae Created with: gclient setdep -r src-internal@79ff98db91ae The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icc1f03384c5faff3830abd6c35acf68f972b7fca Reviewed-on: https://chromium-review.googlesource.com/c/1372354Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615756}
-
Giovanni Ortuño Urquidi authored
GetAvailableDevices returns devices we consider to be available i.e. devices we're recently seen, paired devices, and connected devices. Bug: 870192 Change-Id: I0076003ee9b47e9d828c30c4aca6caf6200896ec Reviewed-on: https://chromium-review.googlesource.com/c/1359834Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#615755}
-
Jeffrey Cohen authored
Send Tab to Self is an experimental feature to send Tabs to external devices logged in with the same Gaia ID. These files are loosely based on the reading list sync component, this first CL has stubbed out c files in order to avoid bloating the CL past being easily reviewed. Bug: 910390 Change-Id: I655d40757c43eab0fcf17b618fe8c754cad19b97 Reviewed-on: https://chromium-review.googlesource.com/c/1312991 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615754}
-
Yiming Zhou authored
Bug: 885350 Change-Id: I8c1fed2a1bec2d3a649d12ccf26adc5920e1772a Reviewed-on: https://chromium-review.googlesource.com/c/1372912Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Yiming Zhou <uwyiming@google.com> Cr-Commit-Position: refs/heads/master@{#615753}
-
Steven Bennetts authored
https://crrev.com/c/1366879 fixed small window repositioning for Mash but exposed a bug in ChromeKeyboardBoundsObserver::ShouldEnableInsets. This fixes that issue and includes some cleanup done while debugging. It also updates the filter file tpo remove tests that are now passing! Bug: 906888 Change-Id: I64dcfe8de4a5970d69a76f26646b80be01016a50 Reviewed-on: https://chromium-review.googlesource.com/c/1372319 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
