- 21 Apr, 2020 40 commits
-
-
Sylvain Defresne authored
This reverts commit b7db0ccb. Reason for revert: This causes code to dereference nullptr on iOS 12, thus causing consistent crashed. Original change's description: > Enables kInfobarUIRebootOnlyiOS13 by default > > This is now needed in order to enable this locally and not via a finch > config which might not land before the re-sping gets to users. > > Bug: 1071853 > Change-Id: I71b42ca95e54197ddf76b4301616be36c37ad1ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157505 > Commit-Queue: Sergio Collazos <sczs@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760756} TBR=eugenebut@chromium.org,sczs@chromium.org Change-Id: I534ea0a7d177a3a5452d91ea4bf945375cd2f606 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071853, 1073091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159469Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#760984}
-
Leonid Baraz authored
Bug: b:153361703 Change-Id: I68934bd618382637a41dc3780009e5784269f147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147870Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#760983}
-
Alexei Svitkine authored
The data reported is not useful and there are plans to revamp this information with something more actionable. Bug: 1072801 Change-Id: I21bbf56dd8d221fb795824eb432fea7f122059bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157835Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#760982}
-
Kevin Ellis authored
This patch moves the processing of the keyframes rule into a separate method as a preliminary step in aligning the keyframe generate process for CSS animations with the spec (https://drafts.csswg.org/css-animations-2/#keyframes). Once this change is in, further refinement to align the algorithm with the spec should be easier to follow. Bug: 1070627 Change-Id: I04c558afa8f3aa9db85c8c473e4fbc5577633da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154824Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#760981}
-
Steven Bingler authored
The UMAs SameSiteDifferentSchemeResponse SameSiteDifferentSchemeRequest and the UKMs SameSiteDifferentSchemeReqsponse SameSiteDifferentSchemeRequest do not capture the complete/correct information relating to cookies that would be affected by schemeful same-site. This CL obsoletes and removes the metrics logging code along with the necessary framework code used to capture the metrics. Bug: 1066231 Change-Id: Ia4c952626ac8fbdf19e6da348ea9f6ca61ee043e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151481Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#760980}
-
Amr Aboelkher authored
This CL is doing the following: - Update the BUILD.gn correspondingly with the latest changes - Adding new patch for using absl optional instead of std - Update the Support-SHELL-in-chromium patch Bug: 1072286 Change-Id: Id3c4bc2da5183f92345440eb887f5391f8d7b2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153443Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#760979}
-
Elly Fong-Jones authored
Bug: 1073062 Change-Id: I0f1895ebcf4a6169197ee6bb0b8a8fc05e6748eb Tbr: collinbaker@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158972Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#760978}
-
Rainhard Findling authored
* Defines a separate visibility for safety check. * Hides safety check in guest mode. Bug: 1015841,1073023 Change-Id: I07990d36b90de2a0798499ee1098cb72325287ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159241Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#760977}
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from this directory. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Bug: 1029822 Change-Id: I2a7ca6f4df896588a29eacf8beed05f11720145d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108820Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#760976}
-
Elly Fong-Jones authored
Bug: 1044417 Change-Id: Iab0333296dfb31dbd4e402f2e06a7ccd5c038ab8 Tbr: apotapchuk@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159310Reviewed-by:
-
Hiroki Nakagawa authored
This CL fixes timeout on client-navigate.https.html, and removes unused code in testharness.js. This change is a follow-up for: [1] https://github.com/web-platform-tests/wpt/pull/21162 [2] https://github.com/web-platform-tests/wpt/pull/22086 After the change [1], fetch_tests_from_workers() helper uses ExtendableMessageEvent.source instead of MessageChannel to communicate between a window and a service worker. This change works well for most of cases, but fails some tests. The fetch_tests_from_workers() helper takes a service worker object to post a "connect" message to the worker, and then passes the worker object to RemoteContext in testharness.js. RemoteContext adds an onmessage event handler on self.navigator.serviceWorker. This works well as long as the given worker object is associated with `self`. However, these failing tests pass the worker object associated with the inner frame to the helper. In this case, the helper uses an inner frame's service worker object for postMessage(), while the helper waits on the main frame's navigator.serviceWorker.onmessage. Consequently event.source is the inner frame, and a reply from the service worker is dispatched on the inner frame's navigator.serviceWorker.onmessage. This results in timeout. To fix this, this CL makes the main frame pass its own service worker object instead of the inner frame's service worker object. Those objects should be equal other than associated contexts, and this change doesn't affect what the tests verify. Bug: 1057682 Change-Id: I0f30f1fe9c54c3de1006276f3445c5e2b92ea5a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155760Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#760974}
-
Sebastien Lalancette authored
The tests have been failing on the 12.4 bots since the recent refactor: https://chromium-review.googlesource.com/c/chromium/src/+/2147778 isActive was changed to use the presentation state of the ViewController. Apparently, this state is not reliable in unit tests on iOS 12. I switched the tests to use the existing Presentation callbacks instead. Sample failure: https://ci.chromium.org/p/chrome/builders/ci/iphone-device/8012 Bug: 1068606 Change-Id: I3e80de5e77d788da56b984b942e554c5022a98e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158975Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#760973}
-
Tarun Bansal authored
Remove unused local histogram NQE.CongestionAnalyzer.CountInflightRequestsForPeakQueueingDelay.* in NQE. It's also using the local macro incorrectly causing crashes. Macro histograms are expected to use static name (and not a runtime generated name). Change-Id: I196449d759cff2eeb1919f1bfb39af66e7225c1a TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159405 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#760972}
-
François Doray authored
This reverts commit a4c66592. Reason for revert: https://crbug.com/1072977 Original change's description: > [threadpool] Record sequence size to histogram on task push. > > This is recorded to determine how often the size of a sequence grows > above 10000 tasks, and whether it is reasonable to upload a process > dump when that happens. > > Bug: 1071862 > Change-Id: Ia0e7ea5a48d5086bfd4c7aa9c121fa3ccb381ad8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154845 > Auto-Submit: François Doray <fdoray@chromium.org> > Commit-Queue: Brian White <bcwhite@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760528} TBR=gab@chromium.org,fdoray@chromium.org,bcwhite@chromium.org Change-Id: Ida7a3c7124902b3f5027679c87889dea2d1a405b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071862, 1072977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159312Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#760971}
-
Dan Harrington authored
I found the way we were updating surfaces for the additional slices was bug-prone, so I changed how it works. SurfaceUpdater was starting to get larger, so I went ahead and moved it to its own file. SurfaceUpdater improvements: - Building the slice list is always done in a single function, which helps ensure we're sending slices consistently. - SurfaceUpdater manages its own observer list, giving it better control over sent updates. - It sends a load-more spinner. Bug: 1044139 Change-Id: I3ab0c45390c19db7852c0d4750060ab78ce6c880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150769 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#760970}
-
Mugdha Lakhani authored
All //chrome dependencies have been removed from PageInfoController, and it can now be moved to //components so that WebLayer can build Page Info UI using it. Bug: 1052375 Change-Id: Ide78e32c7b83385d5cb30bc667827674e469bf0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153053Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#760969}
-
Xinghui Lu authored
Corresponding Chrome code was removed in https://crrev.com/i/2854162. Metrics obsoleted in this CL: SB2.RemoteCall.LocalBlacklistsAgeInMs SB2.RemoteCall.LocalBlacklistsLookupResult SB2.RemoteCall.LocalBlacklistsUpdateSucceeded SB2.RemoteCall.CanUseLocalBlacklists Bug: 1037224,1037226 Change-Id: Ib8f40d365f82524f7de0bde4ce161f72f551598d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158052 Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#760968}
-
Yue Zhang authored
Currently, we use TabUiTestHelper#isShowingPopupTabList to verify if TabGridDialog is showing or hidden. However, even if this call is good enough to verify that the dialog is completely hidden, passing this check doesn't ensure that the dialog showing animation has ended. This is a problem exposed by extra checks introduced in http://crrev.com/c/2143671. This CL fixes this issue by separating the logics of checking dialog showing and hiding into two methods with different criteria. Bug: 10723760, 1072374 Change-Id: Iabb1e9488a8f94ced36988b90b08ec90df2ba911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158054Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#760967}
-
Elly Fong-Jones authored
Bug: 1073052 Change-Id: If3b28d0c2370b8d34aeaa5ff7ad9abb48a231318 Tbr: karandeepb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159308Reviewed-by:
-
Omar Morsi authored
This CL extends platform keys service by introducing one new function (GetSubjectPublicKeyInfoList), which returns a list of SubjectPublicKeyInfo strings for the public keys available in a certain slot. Bug: 1045895 Change-Id: I68d0f59d96df506784acd137b0df68ce41ed3c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153045Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#760965}
-
Elly Fong-Jones authored
Bug: 1073069 Change-Id: I1e21101f4b0c688626b34f27eb912c60c1c4ca9a Tbr: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158974Reviewed-by:
-
Nicolás Peña Moreno authored
Bug: 1007641 Change-Id: I9b02fb01862b99d5f8fbf7bc0bf3fd75bf659c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105755Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#760963}
-
Joshua Pawlicki authored
Bug: 1059229 Change-Id: I94276c7e55255c84b2afef70d7788c0f061972e5 Fixed: 1059229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150694Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#760962}
-
Vladimir Levin authored
This patch extracts a snippet used for retrieving and updating a layout object for scroll action into a separate function, and uses it in the three OnNativeScroll* functions. R=aleventhal@chromium.org, chrishtr@chromium.org Change-Id: I68a580f7dc5887841a874fb705eeaf9da6916740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157671Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#760961}
-
Austin Eng authored
This CL also changes the client-to-server ScopedTransferBufferPtr member variable to be a normal member, and not a separate unique_ptr allocation. Bug: chromium:1070392 Change-Id: I75d5e4e346dd77b8ae3d6ac9328774b98f2cd030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143111 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#760960}
-
Pavol Marko authored
Have been crashing the renderer on Linux since WPT import. Bug: 1073060 Change-Id: I693f9344edb0920c415661a9de495c255f83cd47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159466 Commit-Queue: Pavol Marko <pmarko@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Pavol Marko <pmarko@chromium.org> Reviewed-by:
-
Doug Arnett authored
This is part of supporting translation for sub frames. Specifically this moves the analysis of the untrusted contents obtained from an accessiblity tree snapshot out of the browser process and into a sandboxed utility process. Bug: 1063520 Change-Id: I0792d209541558a753f168f78f421e66745748d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140605 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Tommy Li authored
This CL changes the about:flags configuration to get SERP ZeroSuggest suggestions even if Query in Omnibox is OFF. Bug: NONE Change-Id: I9330dd44b288710c6342d92b6d0a089cbc13749c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158053 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#760957}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/075e3e17b781..e784d74686e7 git log 075e3e17b781..e784d74686e7 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 tvanderlippe@chromium.org Properly cleanup on process teardown when pre-emptively stopping mocha 2020-04-21 petermarshall@chromium.org [test] Add a test that creates a new Browser window from a BrowserContext 2020-04-21 alexrudenko@chromium.org Make Devices list more accessible 2020-04-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@e784d74686e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1071369 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic8dcdabd578a95315f001d9ab557ad27133e9b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159129Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760956}
-
Gabriel Charette authored
[base] Make MessagePumpForUI::WaitForWork consistent with MessagePumpForUI::ProcessNextWindowsMessage The documentation doesn't require the MSG struct to be initialized when passed to PeekMessage(). WaitForWork() intends to make the same check as ProcessNextWindowsMessage and hence should be consistent with it. R=fdoray@chromium.org Change-Id: Ifcc6b49add569f95c9938c593bef4c5958564c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155180 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Alex Rudenko authored
A DevTools CL[1] updates the format that the ColorPicker uses for CSS colors. This change disables the related tests until the CL is merged. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2157041 Bug: 1072952 Change-Id: If3948599a5aac17aa52fa612271cad5576c22d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159465 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#760954}
-
danakj authored
Give WebTestRenderFrameObserver a direct pointer to its RenderView's BlinkTestRunner. Now BlinkTestRunner does not need to be a RenderViewObsever. R=avi@chromium.org Bug: 866140 Change-Id: If01187ce2db7fb41078319e571440ba40167a81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155049Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#760953}
-
Adrian Taylor authored
Change-Id: Ibd1899f11e3463de658394618471872e8f1f423d Bug: 1069271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157788 Auto-Submit: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
-
Fred Mello authored
Moved the implicit initialization of DFMs from a logger call into ChromeApplication. This is a no-op, but should help in debugging future startup issues with DFMs. Bug: 1022654 Change-Id: Ia3de76f033058d01468333fed10db108cfc8c316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156607 Commit-Queue: Fred Mello <fredmello@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#760951}
-
Maksim Moskvitin authored
This CL is a pure refactoring of sync tests. It splits encryption_helper into three pieces: 1) components/sync/nigori/nigori_test_utils*, which contains common Nigori logic for tests (like creation of keystore NigoriSpecifics) and can be used in both integration and unit tests. 2) components/sync/test/fake_server/fake_server_helper*, which contains utility functions to set Nigori in FakeServer and can be used in both desktop and Android integration tests. 3) chrome/browser/sync/test/integration/encryption_helper*, which contains Nigori-related state checkers usable only in desktop integration tests. Bug: 1046663 Change-Id: I88880dc2abdf070f8a6efc1c5b4b7f2001f88fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148599 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#760950}
-
Daniele Castagna authored
While profiling Chrome on CrOS, we noticed a significant amount of time is spent in Get{Vm,ArcSystem}ProcessList even if the task manager is not running. On a nocturne m3 we observed 2% total of the CPU used is spent in these two functions. This CL adds traces for those two functions. Capturing a trace confirms that we call those two functions every few seconds and they take about 80ms of CPU time each. Bug: b/154362057 Change-Id: Ie851643dc1093e400282aeb976c880b9901f3138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153827Reviewed-by:Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f9cd85317277..e30b9d80933d git log f9cd85317277..e30b9d80933d --date=short --first-parent --format='%ad %ae %s' 2020-04-21 treehugger-gerrit@google.com Merge "tp: add core and core_type breakdowns per process in CPU metric" Created with: gclient setdep -r src/third_party/perfetto@e30b9d80933d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9b805efa0ba48f4d06be546516fa31dc338f25ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159265Reviewed-by:
-
Olivier Robin authored
This will allow to add sections dependant on gn flags and ensure that flags and blank lines stay at the end. Bug: 1017434 Change-Id: Ia982cb84f4092631ba6dd7c0b14063290db773fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159243 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This is done by moving the code that terminates the request when the file should not to be scanned right after the file has been opened to read its content and compute its hash. This means unit tests with fake file names now need to use "real" files since Chrome will attempt to open them. Bug: 1061461 Change-Id: Ifa045f91c69f4501dd14b2888a82e622b6d5622f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151334Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#760946}
-
Robbie Gibson authored
The underlying issue is that the find_bar_mediator was observing navigation events and closing FIP when a navigation occurs. As the state for "show FIP" is a tab-level state, the observation should occur in the tab helper. Now, the tab helper observes the navigation in its own webstate. Alerting the UI that Find In Page has stopped is done through the FindInPageResponseDelegate. (This used to be the coordinator, but should really be the mediator, so that has changed too.) This is hooked up to the active mediator only when the UI is active. From the bug, the same issue occurs with Text Zoom, but Text Zoom is closed automatically on switching tabs, so that behavior was kept. Fixed: 1067603 Change-Id: Ic5b1fb61142ab3deadc8ef792642e880cf23ebea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157226 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#760945}
-
