GitLab

While 1+ incognito browser windows are opened, it'll have separate Files
app extension background and foreground scripts running. The ones in
the incognito context should only be visible by the file picker window
invoked by the browser, but should not show fullscreen app windows or
notifications.

This fix prevents opening a new Files app. window in incognito context
in these cases:
- When mounting a new zip file as a volume
- When reopening a zip file already mounted
  (which navigates the current window to it)

Bug: 800543
Test: manually
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib3deccef39a9db61e6ff4d035a6de19c7309d113
Reviewed-on: https://chromium-review.googlesource.com/888192Reviewed-by: Daichi Hirono <hirono@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533217}

Bug: 704339
Change-Id: Idce639d844d07252c2618ceb34a589964723ccc4
Reviewed-on: https://chromium-review.googlesource.com/891806Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533216}

Bug: 805445
Change-Id: I7051f519205e178db57e23320ab979f8fa9ce38b
Reviewed-on: https://chromium-review.googlesource.com/894782
Commit-Queue: David Vallet <dvallet@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533215}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/27e3a1f6..842d424d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I64c8d498b616f10713d94f18381595001960092d
Reviewed-on: https://chromium-review.googlesource.com/894225Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533214}

net_unittest failure on android_cronet due to missing test app dependency should no longer occur after this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/893681

First reland: https://chromium-review.googlesource.com/c/chromium/src/+/891302
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/887970

Bug:807283

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I622f074ad3d3ec89b78d754367285da52850e527
Reviewed-on: https://chromium-review.googlesource.com/893625Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Yixin Wang <wangyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533213}

Some default experiments were removed
- Accessibility inspection
- Log management
- Performance monitor

Bug: none
Change-Id: I97bc4ac1883cdb0001fb807f56009c54ca7773b3
Reviewed-on: https://chromium-review.googlesource.com/882312
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533212}

This method is declared and never implemented. It was to be removed in:
https://codereview.chromium.org/197873002.

TBR=alexmos@chromium.org

Bug: None
Change-Id: I887a300e1689c28e74699749be5769a38c3ef4bf
Reviewed-on: https://chromium-review.googlesource.com/890029Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533211}

This is a follow-up CL for https://chromium-review.googlesource.com/892557.
GeoNotifiers are in one_shots_ and watchers_. I forgot to support watchers_
in that CL.

Bug: 792604
Change-Id: I1421e14311de6c965cffc038892cfabdb63a4dbb
Reviewed-on: https://chromium-review.googlesource.com/894924Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533210}

This reverts commit 2181b01c.

Reason for revert: The offending test
(ContentVerifierTest.FailOnRead) has been taken care of in
CL: https://chromium-review.googlesource.com/c/chromium/src/+/888327

Original change's description:
> Revert "Fix extraneous call to ContentVerifyJob::DispatchFailureCallback."
>
> This reverts commit 6e548ee1.
>
> Reason for revert: DCHECK at content_verify_job.cc:192 occasionally fails (see crbug.com/806586).
>
> Original change's description:
> > Fix extraneous call to ContentVerifyJob::DispatchFailureCallback.
> >
> > If ContentVerifyJob receives hashes (ContentVerifyJob::OnHashesReady)
> > after the content is read (ContentVerifyJob::DoneReading), then it
> > was possible for DispatchFailureCallback to be called more than once.
> > This causes a DCHECK failure in DispatchFailureCallback
> > (DCHECK(!failed_)).
> >
> > Bail out early in OnHashesReady if call to ContentVerifyJob::BytesRead
> > leads to a ContentVerifyJob failure.
> >
> > Note that this isn't harmful in Release builds as
> > DispatchFailureCallback tests ContentVerifyJob::failure_callback_
> > before calling the callback, which is reset once it is called.
> > Nevertheless, this is incorrect behavior and this CL fixes that.
> >
> >
> > Bug: 804630
> > Test: See bug description for repro steps.
> > Change-Id: Icf3a5c8b4c0d01cb20e02de14b11aca4aeff03e5
> > Reviewed-on: https://chromium-review.googlesource.com/879961
> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> > Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#531755}
>
> TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 804630,806586
> Change-Id: Ia5c67f60e95ddb607cb364c745f31dde465d3c4f
> Reviewed-on: https://chromium-review.googlesource.com/893258
> Reviewed-by: vitaliii <vitaliii@chromium.org>
> Commit-Queue: vitaliii <vitaliii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532854}

TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org,vitaliii@chromium.org

Change-Id: I82988d836f49033e1d618125e06f0d45d1124071
Bug: 804630, 806586
Reviewed-on: https://chromium-review.googlesource.com/894824
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533209}

Split the provider in order to support Vision Framework [1] which is more
accurate and can detect more landmarks with computer vision techniques.
This proposal has been merged in Shape Detection specification [2].

Link Mac 10.13 build bots [3] and Face Detection demo[4] here.
Split original large CL[5] up in smaller subpatches including this CL.

[1] https://developer.apple.com/documentation/vision
[2] https://github.com/WICG/shape-detection-api/pull/38
[3] https://codepen.io/miguelao/pen/PmJWro
[4] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/
[5] https://chromium-review.googlesource.com/c/chromium/src/+/867651/10

BUG=799319

Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: I1910f572f83ae4def3d1f669af3fcd91d53b6305
Reviewed-on: https://chromium-review.googlesource.com/888478
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533208}

https://skia.googlesource.com/skia.git/+log/ac568a934f8f..70204ab029b5

$ git log ac568a934..70204ab02 --date=short --no-merges --format='%ad %ae %s'
2018-01-30 angle-skia-autoroll Roll skia/third_party/externals/angle2/ bd6ae4aa1..199f42941 (1 commit)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I089ca6bb1249eec1bbca72f34591d3564ab11cfd
Reviewed-on: https://chromium-review.googlesource.com/895185Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533207}

This fixes https://crrev.com/c/886829.

Bug: 777962
Change-Id: Ie8df07034375e8f1e5d5dfb8b821f178bb479b5f
Reviewed-on: https://chromium-review.googlesource.com/892490Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533206}

Bug: 805837
Change-Id: Ib24d46b9ed98b1264c0ff009ac40846ce254c44f
Reviewed-on: https://chromium-review.googlesource.com/887640Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533205}

We untentative CSSPositionValue tests. We also split happy and sad tests

Spec: https://drafts.css-houdini.org/css-typed-om-1/#positionvalue-objects

TBR=nainar@chromium.org

Bug: 774887
Change-Id: I33052e0dc6400f5de693da9449d769012919dee3
Reviewed-on: https://chromium-review.googlesource.com/894748Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533204}

This adds MerkleIntegritySourceStream class which decodes and validates
the "mi-sha256" content encoding [1]. This class will be used by
WebPackageLoader to verify integrity of message body.

[1] https://tools.ietf.org/html/draft-thomson-http-mice-02

Bug: 803774
Change-Id: I62353f594e30e90fa982a68374389267b39c21fe
Reviewed-on: https://chromium-review.googlesource.com/892844
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533203}

When screen readers traverse a <table role="presentation">, they need
generic container objects in place of the cells, to help them understand
and present formatted content. Specifically, this helps present the text
without jamming it together, as well as providing line breaks.

Bug: 787664
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I53b691f0ccae3f4090ca0f8ecfcbeb622bd3dfeb
Reviewed-on: https://chromium-review.googlesource.com/887599
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533202}

Since r522281, the Flash permission is always shown in the Page Info bubble.
This was a temporary measure to increase its discoverability after all
non-factory-default permissions were removed in r503089, but it isn't an ideal
solution - for example, it might imply that the site is using Flash when it
isn't.

Replace this with a more permanent solution - if the user has changed Flash
before on a particular site, always show Flash in that site's Page Info bubble.

Bug: 791142
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5bd7ee74cffeee8fe87743b9c0d7336021c52da0
Reviewed-on: https://chromium-review.googlesource.com/858245
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533201}

Generates an alternative runner script for each test target,
with a "_v2" suffix, e.g. run_base_unittests_v2.
The old-style generated runner scripts will still be without the
"_v2" suffix, but they will be deprecated and removed soon as part
of a followup CL.

The new scripts will bring up a new QEMU VM, a Zedboot physical
device, or continue to use an existing device that is currently
accepting SSH connections.

Once connected, the scripts push the package bits onto the device,
execute the package using SSH, extract the build logs and other
artifacts from the device, and finally clean up the state.

Other changes:
* Add DeviceTarget impl for deployment.
* Use relative paths in package archive manifests, for symbolization.
* Add logging statements everywhere, and a -v switch to turn them on.
* Add package cleanup teardown step, to avoid cluttering up long-running
  devices.
* Refactor symbolization as a stream filter object.


Bug: 799309
Change-Id: Iffaefd1d3a5ce919ba2dea4e29033987454c2eed
Reviewed-on: https://chromium-review.googlesource.com/882441
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533200}

R=asvitkine@chromium.org

Bug: 727984
Change-Id: I1ac800cce5cbfc7de67885ac6f9c3c6a715f25cb
Reviewed-on: https://chromium-review.googlesource.com/892323
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533199}

This CL adds a new animator, FullscreenForegroundAnimator that is sent
to FullscreenControllerObservers upon receipt of an application
foreground notification.  This CL also updates FullscreenUIElements
to show the toolbar using this animator.

Bug: 806694
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9470602d5535964ea0a054c949ccaba0225e5ed3
Reviewed-on: https://chromium-review.googlesource.com/894355
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533198}

Currently, there is a field on KeyboardController for enqueuing a
container type change. Eventually we want to support invoking a JS
callback to notify the extension when a keyboard mode changes.

This is the first step in that direction. Instead of persisting a
single enum value for the enqueued container behavior, it tracks both
the type and a callback handle. This QueuedContainerBehavior object
will invoke the callback once it goes out of scope.

Change-Id: Iea4e96259314a34d31661342024a23617a9f4b74
Bug: 806189
Reviewed-on: https://chromium-review.googlesource.com/888119
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533197}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I6da287c075108f37858f4d7d5d0e2f79dfcb111d
Reviewed-on: https://chromium-review.googlesource.com/894583Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533196}

BUG=none
TEST=none

Change-Id: I310a3b6ba78a2eebdc87ffe9a35df05f707b1277
Reviewed-on: https://chromium-review.googlesource.com/894299Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533195}

This is re-land of
https://chromium-review.googlesource.com/891043

Changed not to increase link parallelism for chrome on chromeos.

Bug: 807145
Change-Id: I11c49d215704556eaa709af08ffe7226c3df529d
Reviewed-on: https://chromium-review.googlesource.com/892779
Commit-Queue: Takuto Ikuta <tikuta@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533194}

Bug: b/72666690

Change-Id: Ia31ca2fd81d7fe2edb264da5b19ba899be1a3ce3
Reviewed-on: https://chromium-review.googlesource.com/892404Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com>
Cr-Commit-Position: refs/heads/master@{#533193}

Currently, tcmalloc is not supported on loongson, and the build
failed with use tcmalloc. This CL adds support for tcmalloc on
loongson, and resolves many compiler errors, bugs when test
base_unittests on loongosn.

Bug: 799810

R= wfh@chromium.org, thakis@chromium.org

Change-Id: I68bea09334cb9af02d083a24a94654aaf6c884c8
Reviewed-on: https://chromium-review.googlesource.com/853695Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: 汪 清 <wangqing-hf@loongson.cn>
Cr-Commit-Position: refs/heads/master@{#533192}

Change-Id: I922866e17652a3f202207a5e690e97d2da26065f
Reviewed-on: https://chromium-review.googlesource.com/879065Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533191}

Bug: 750526
Change-Id: Id8a2dd90b835279e6dc39de493e174c563bf7493
Reviewed-on: https://chromium-review.googlesource.com/892682
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533190}

BUG=803276

Change-Id: I2076d974810c247ec79ac36897a54dc58e80c4a9
Reviewed-on: https://chromium-review.googlesource.com/894884Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533189}

Bug: 636400
Change-Id: Ic4a49a72dcae73f1bd2d909a0e86439f7c075061
Reviewed-on: https://chromium-review.googlesource.com/779742Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533188}

The reply button should be white when the textfield is not empty, and should be transparent white when the textfield is empty.
However, when text is cut or pasted using mouse or finger and the textfield become empty or not, the reply button color does not change.
This CL resolved this bug.

Bug=803759

Change-Id: Ie307a924b41bddc88f60d9dc1b7ab230e639e0c7
Reviewed-on: https://chromium-review.googlesource.com/890843
Commit-Queue: Megumi Hattori <megumihattori@google.com>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533187}

This patch removes all call sites of DeprecatedDumpFrameTreeAsText, except
the only one in ChromeRenderFrameObserver, which is improper. This is
a preparation for fixing ChromeRenderFrameObserver without affecting
other code paths.

Bug: 803403
Change-Id: I1873f3759533873a3068b45cc55743b4bb9758d6
Reviewed-on: https://chromium-review.googlesource.com/891543Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533186}

BUG=784732
TEST=Ran trybot.

Change-Id: Icbb9c5596b045ca0c684cdad0343a2605d00dbb1
Reviewed-on: https://chromium-review.googlesource.com/856296Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533185}

Issue reported by canary dogfooder: the promise returned by
navigator.locks.query() would never resolve if no locks were held. In
debug builds, this would DCHECK. The code would early-exit without
running the callback in this case - a no-no.

Added fix (return empty arrays) and test case.

Bug: 807070
Change-Id: Ib4abd5d861c5ab259f7ea00355aebd006438508e
Reviewed-on: https://chromium-review.googlesource.com/891584
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533184}

Add a mechanism for allowing an autoresize frame to resize the
renderer's surface.

When in auto-resize, make BrowserCompositorMac not update its size
based on the NSView size.

Bug: 805774
Change-Id: Ibc0b8b14ec7c1f4bdef30ac815d759f5894ab315
Reviewed-on: https://chromium-review.googlesource.com/892288
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533183}

BigString uses BigBuffer internally to accomodate
large strings.

It maps to std::string and WTF::String and internally
converts data to UTF8 similary to regular string.

Bug: 776009
Change-Id: I05547f6f55f0a20dafd6a3d99e26b5cc2cbe2eed
Reviewed-on: https://chromium-review.googlesource.com/891980
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533182}

BUG=803706

Change-Id: I5c1d7476d27e9ce35e9bd758351e6ebc22e43771
Reviewed-on: https://chromium-review.googlesource.com/884008Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Wei Guan <weigua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533181}

This reverts commit 02e508ce.

Reason for revert: compile failure

https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder%20(dbg)/62497

../../ui/keyboard/keyboard_test_util.cc(99,17):  error: 'keyboard::TestKeyboardUI::TestKeyboardUI' redeclared without 'dllimport' attribute: 'dllexport' attribute added [-Werror,-Winconsistent-dllimport]
TestKeyboardUI::TestKeyboardUI(ui::InputMethod* input_method)

Original change's description:
> Use the centralized TestKeyboardUI instead of ash-test-specific ones
> 
> This is mostly duplicate code.
> 
> Bug: 
> Change-Id: Id152dc65ef53eac65d40ef38b6b9da3f962ae9ba
> Reviewed-on: https://chromium-review.googlesource.com/832295
> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Commit-Queue: Blake O'Hare <blakeo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533168}

TBR=oshima@chromium.org,yhanada@chromium.org,blakeo@chromium.org

Change-Id: I0e7fedec0f8d5de8eb069bb2cd85f86009a4d55e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/895084Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533180}

This change ensures that tests that are ready to be migrated into wpt/
will contain consistent formatting. This includes a test_desc constant
describing the test and consistent indentation.

BUG=509038

Change-Id: If04b5cdd796709b8080960550cf216297e8d38f6
Reviewed-on: https://chromium-review.googlesource.com/891989
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533179}

This reverts commit 58ab87ff.

Reason for revert: suspected for lsan browser_tests and mus_browser_tests failures since
https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/25937
 - AppBannerManagerBrowserTest.CheckOnLoadWithSufficientEngagementCancelBannerAfterPromptInHandler
 - AppBannerManagerBrowserTest.ExperimentalFlowWebAppBannerReprompt
 - AppBannerManagerBrowserTest.ExperimentalFlowWebAppBannerPromptNeedsGesture

(and others in later runs)> Possibly timeout related.

Original change's description:
> Consolidate app banner testing.
> 
> This CL removes several different app banner testing files, and replaces
> them by calling the necessary JavaScript setup code in one test file.
> For instance, all tests will no longer have the "appinstalled" title
> overwriting, as that will only be active when the appropriate setup
> JavaScript is run.
> 
> This allows future tests to be more easily added, and reduces collisions
> when manipulating the page title.
> 
> BUG=806923
> 
> Change-Id: Ia28837b8675a2e1fe329cb1df1be4798ddb03d02
> Reviewed-on: https://chromium-review.googlesource.com/892182
> Commit-Queue: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Matt Giuca <mgiuca@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532978}

TBR=mgiuca@chromium.org,dominickn@chromium.org

Change-Id: Ie030290324c689b3df616de9aa35b6e52e7584c5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 806923
Reviewed-on: https://chromium-review.googlesource.com/895024Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533178}