- 17 May, 2018 40 commits
-
-
Gauthier Ambard authored
The tools menu disabled elements had the standard blue color. This CL makes sure that they have the correct grey color. Bug: 843939 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iddbd9e8ea33d329cd5552d77d3acd54db9b5473a Reviewed-on: https://chromium-review.googlesource.com/1064050Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#559505}
-
chrome://histogramsMathieu Perreault authored
Now a WebUI message handler. Still keeps the same UI for now, but has potential to be more (see earlier patchsets) Bug: 809820, 788270 Change-Id: I9e2de72540f152ad367098d8255492378bbb28a3 Reviewed-on: https://chromium-review.googlesource.com/890627Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#559504}
-
Hajime Hoshi authored
This PR changes these functions to return TaskQueueWithTaskType - MainThreadSchedulerImpl::DefaultTaskRunner() - MainThreadSchedulerImpl::InputTaskRunner() - MainThreadSchedulerImpl::IPCTaskRunner() - IdleHelper::IdleTaskRunner() so that we can know the task types posted to these main-thread task queues, which didin't have any task-type information. Bug: 841172 Change-Id: I7c463437af1dd5478cbbfd39bdc1626ef2e5c3b3 Reviewed-on: https://chromium-review.googlesource.com/1063670Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559503}
-
Philip Jägenstedt authored
https://github.com/w3c/web-platform-tests/pull/10985 changed lint.py and wpt-importer is now failing because of it: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17652 chromium.patch did not apply cleanly, so the changes had to be rebased on the new wpt version. This was much easier within the wpt repo itself, so the patch is changed to apply within the repo. Bug: 843799, 843945 Change-Id: I1ed9895b2461243c38fea552706960a3b99db2b6 Reviewed-on: https://chromium-review.googlesource.com/1061458 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#559502}
-
Bruce Dawson authored
For Windows component builds it is necessary to explicitly share nested classes if those need to be visible outside of the DLL. This change adds such an export in order to get Chromium Windows builds with Perfetto enabled to build. Change-Id: Ia03383a641425e1eb690bb1f0a539473c83f9a32 Reviewed-on: https://chromium-review.googlesource.com/1063870 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#559501}
-
Olga Sharonova authored
Bug: 832666 Change-Id: I2f8104042ba7320998b306f7fdda05af9cf67086 Reviewed-on: https://chromium-review.googlesource.com/1064090Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#559500}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e50cee06e2ae..c594085d996e $ git log e50cee06e..c594085d9 --date=short --no-merges --format='%ad %ae %s' 2018-05-17 perezju [soundwave] Fix issue with timeseries with missing commit position 2018-05-16 perezju [soundwave] Log exceptions raised by workers Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I538e928e079d8048d30113dd21516f6b1099f036 Reviewed-on: https://chromium-review.googlesource.com/1063990 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559499}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/84d0e6526470..be1ac951607e $ git log 84d0e6526..be1ac9516 --date=short --no-merges --format='%ad %ae %s' 2018-05-15 yunlian Test ThinLTO on peach_pit 2018-05-16 dgarrett chromeos_config: Remove trybot_list. 2018-05-14 achuith cros_run_vm_test: Introduce Run() 2018-05-04 bmgordon cros_sdk_lib: Move chroot functions out of cros_build_lib Created with: roll-dep src/third_party/chromite BUG=chromium:None,chromium:None,chromium:828749,chromium:809634 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8d7668d4891451a613c52552f203a10c0dbc17f6 Reviewed-on: https://chromium-review.googlesource.com/1063991Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559498}
-
Max Morin authored
This allows us to test both "out of process audio service" and the current code on the waterfall. Bug: 843961 Change-Id: I2b20ffb821c6f1dc01ddbc45365f82e12a87a987 Reviewed-on: https://chromium-review.googlesource.com/1063753Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559497}
-
Finnur Thorarinsson authored
This reverts commit 02a5799e. Reason for revert: Consistent failure of zoom-foreignObject.svg test on Windows 7. See list: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win7/ Original change's description: > [ForeignObject] Paint foreign objects during the foreground phase of normal-flow > descendants. > > When <foreignObject> was made a stacking context, it also had the side-effect of > painting it at the same time as positioned elements. This is a change to painting > order and caused a regression. Instead, implement a new mechanism by which a > "replaced normal-flow stacking" element paints during the foreground phase > of the LayoutObject paint tree walk. > > This is used for now just for <foreignObject>, but may be applied to other > replaced elements such as iframes or embedded objects in the future. > > Bug:842668 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I450944986abfb6610084444abf2724e7406145cf > Reviewed-on: https://chromium-review.googlesource.com/1060333 > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Tien-Ren Chen <trchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559401} TBR=trchen@chromium.org,pdr@chromium.org,chrishtr@chromium.org Change-Id: I6742e134dae28a31bcb80fd13eccbc83d03ef332 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 842668 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1064150Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#559496}
-
David Bokan authored
To make implicit root scrollers promote and demote more reliably we need to separate the notion of being a valid candidate from being a valid root scroller. Currently, we build a list of candidates at layout that we restrict to only valid implicit root scrollers. When layout is finished we evaluate this list to determine which of the elements will be promoted. Those that are no longer valid are removed from the list. Unfortunately this doesn't work too well since validity can change for non-local reasons. For example, a parent may change its transform, making its child viewport-filling. Thus, to make this work we'd have to reevaluate candidates and validity everytime virtually anything on the page changes. This patch changes this method to make any currently scrollable element a valid candidate. The list of candidates is maintained by listening to PaintLayerScrollableAreas for when they become scrollable (allow scrolling and have overflow), rather than hooking into layout for every object. This list should be fairly small but it's more stable over the life of a page so we can be more confident it truly contains all the candidates we care about when we get to reevaluating which, if any, should be promoted. Bug: 838683 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6d5c3d876d885fec638b46e992f3026e418737b7 Reviewed-on: https://chromium-review.googlesource.com/1038648 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559495}
-
Ioana Pandele authored
The password export operation saves a temporary file containing passwords locally, in order to pass the data to the consumer app. There are cases in which the file is not removed when the export finishes. Deleting these temporary files when passwords are removed from local storage (keychain) ensures that they are not persisted on the device past their intended removal. Bug:842127 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0e965b41a726240714d209646a9394a35995f9e7 Reviewed-on: https://chromium-review.googlesource.com/1047869 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#559494}
-
Hiroki Nakagawa authored
This CL passes the "destination"[1] parameter through module loaders. This enables workers/worklets to specify a unique destination defined in each spec. Before this CL, any module scripts are loaded with the "script" destination. After this CL, top-level and descendant module scripts for dedicated workers are loaded with the "worker" destination, top-level and descendant module scripts for documents and dynamic import() are still loaded with the "script" destination though. Module scripts for worklets also must be loaded with their own destination defined in each worklet spec (e.g., "paintworklet"), but such destinations haven't been added yet and the "script" destination is still used. Shared workers and service workers haven't supported module loading yet. Subsequent CLs will address them. Regarding detailed changes, this CL adds the "destination" parameters to components for module loading, stops ScriptResource overriding the "destination", and uses the given "destination" instead. Note that, in Chrome, WebURLRequest::RequestContext enum[2] represents the "destination". [1] https://fetch.spec.whatwg.org/#concept-request-destination [2] https://chromium.googlesource.com/chromium/src/+/a204023d46bc02634f1c6f164cae99d327d53b86/third_party/blink/public/platform/web_url_request.h#73 Bug: 842566 Change-Id: Ib777fcc28de62e1c348ef5c79f97079e5399abaf Reviewed-on: https://chromium-review.googlesource.com/1058734 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#559493}
-
Patrik Höglund authored
The enable_webrtc gn variable has been removed, so ENABLE_WEBRTC is always true now; we may as well remove it. Bug: chromium:800653 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie739a5ddb740a87f434bb12f8a451cd1040596a5 Reviewed-on: https://chromium-review.googlesource.com/1059408 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559492}
-
Boris Sazonov authored
This CL updates personalized sign-in promos to show SigninActivity if UnifiedConsent feature is enabled. This CL also implements necessary sign-in flows in SigninFragmentBase and adds corresponding methods to SigninActivity and SigninFragment. Bug: 814728 Change-Id: I5d335bcea32834b358d2ca96901ff991691b0fb9 Reviewed-on: https://chromium-review.googlesource.com/1062605Reviewed-by:
-
Olga Sharonova authored
Do not instantiate AudioManager in BrowserMainLoop when running Audio service out of process. Audio service DD: https://docs.google.com/document/d/1s_Fd1WRDdpb5n6C2MSJjeC3fis6hULZwfKMeDd4K5tI/edit# Dry runs with out of process audio service are here: https://chromium-review.googlesource.com/c/chromium/src/+/1057807 Bug: 834666 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia957b6209007413faad575d2410bdbba3ded5728 Reviewed-on: https://chromium-review.googlesource.com/1057624 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559490}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8dba45a1c69f..84d0e6526470 $ git log 8dba45a1c..84d0e6526 --date=short --no-merges --format='%ad %ae %s' 2018-05-17 chrome-bot Update config settings by config-updater. Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I577ee8a39a77b3534a54e2da202a059123840bcd Reviewed-on: https://chromium-review.googlesource.com/1063565Reviewed-by:
-
Peter E Conn authored
Bug: 841178 Change-Id: I7aad6a4f8288941cb78231da010a972b4eafad06 Reviewed-on: https://chromium-review.googlesource.com/1059786Reviewed-by:
-
Marc Treib authored
When OnPrimaryAccountSet is called, that means that previously there was no primary (i.e. signed-in-to-Chrome) account, so we can't have created the SyncEngine yet. Bug: 842697 Change-Id: I9eb7e569e84e534e19495bed47e3ecb2e30b6a7f Reviewed-on: https://chromium-review.googlesource.com/1057333 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#559487}
-
Peter E Conn authored
Bug: 813104 Change-Id: I53b9abc17c9af393d6ffaa84203ab0b24ab7ecb9 Reviewed-on: https://chromium-review.googlesource.com/1061517Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Pérez authored
This reverts commit 61fc3569. Reason for revert: Test fails on KitKat Phone Tester (rel) Original change's description: > Add PrefetchItemFlow unittest > > This helps test the integration of tasks that make up the prefetch > pipeline. I found that this coverage was lacking when making a change > to a task. > > This CL also improves output of PrefetchItem and prefetch enums for tests. > > Change-Id: I719d815da3a6473c120f077f723c3c67a30e29cc > Reviewed-on: https://chromium-review.googlesource.com/1058169 > Commit-Queue: Dan H <harringtond@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559294} TBR=dewittj@chromium.org,harringtond@chromium.org Change-Id: I16a8d3160031802932e71a32938d6e463d9bc814 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1063791Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#559485}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b690905ad0c0..e50cee06e2ae $ git log b690905ad..e50cee06e --date=short --no-merges --format='%ad %ae %s' 2018-05-16 perezju [soundwave] Fix display of timeseries to fetch Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I962d50b09756c766fd8cceda1380502bd456607e Reviewed-on: https://chromium-review.googlesource.com/1063568Reviewed-by:
-
Makoto Shimazu authored
WebDataConsumerHandle::DidGetReadable is expected to be called when it "stops to wait for data". However, WebDataConsumerHandleImpl::DidGetReadable is called when it's "ready to be read". It caused excessive calls of DidGetReadable and results CPU hogging during streaming the data. Bug: 843811 Change-Id: I213f4b5cb7004b4ae21aaedda229a7bc16d0c68b Reviewed-on: https://chromium-review.googlesource.com/1062985Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#559483}
-
Vadym Doroshenko authored
On CL https://chromium-review.googlesource.com/c/chromium/src/+/1002847 unique ids were implemented for WebFormElement and WebFormControlElement. This CL adds them to FormData and propagates them to the browser process. Bug: 831123 Change-Id: Ibe63e5bc39b126e509508103d5725ccd91fc85dc Reviewed-on: https://chromium-review.googlesource.com/1055491Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#559482}
-
Gauthier Ambard authored
This CL adds an effect to make the "New Incognito Tab" row of the tools menu blink a selected state when the in product help requires it. Bug: 829344 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib2345a98f8ec284369b342d111cadf7f6a55adef Reviewed-on: https://chromium-review.googlesource.com/1057708 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559481}
-
Niels Möller authored
Bug: webrtc:9253 Change-Id: Ia94e71949d06c6638b809bca65bf4329e8062d91 Reviewed-on: https://chromium-review.googlesource.com/1059156Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
From using AtomicString (for 'mask', 'marker-*', 'fill' and 'stroke') or the string representation of SVGResources ('filter' and 'clip-path'), convert to using SVGResources. Add an implementation of SVGResourceClient (SVGElementResourceClient) and register it with the existing resources. Invalidation code is moved here. This makes the invalidation code slightly more homogeneous between the various code-paths. The new SVGResourceClient implementation is stored in SVGElementRareData as needed. The various computed style representations are converted to use the new StyleSVGResource, which is a ref-counted wrapper around an SVGResource and its underlying string representation (which is needed for serialization.) Style building is changed to produce this new wrapper (rather than an AtomicString.) A helper for serialization is added to ComputedStyleUtils. The kHasPendingResources flag is removed since it no longer used, and the hook in Element is removed. All LayoutSVGResource* subclasses are changed to take SVGResourceClients instead of LayoutObjects, and the |clients_| set is removed in favor of the set in SVGResource. A bunch of helpers are added for updating (adding/removing) the client registrations. The various LayoutSVG subclasses are updated to call these helpers. Changes on reland: LocalSVGResources are now tracked using WeakMember, and the associated IdTargetObservers are cleaned up when weak references are cleared. Bug: 769774 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie0b42471aea5ea5afb5d239662b4ba195281f764 Reviewed-on: https://chromium-review.googlesource.com/1057330 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:Justin Novosad <junov@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#559479}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ed1bb34fc59e..23a358764dd8 $ git log ed1bb34fc..23a358764 --date=short --no-merges --format='%ad %ae %s' 2018-05-17 ehmaldonado gclient: Fix for extra custom_deps. Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I293439d96cfef1bb45b25e3e989f591efce049fb Reviewed-on: https://chromium-review.googlesource.com/1063557Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559478}
-
Stephen Martinis authored
Change-Id: I755687754c62b2da8d20e48d5607f568c5bf47b1 Reviewed-on: https://chromium-review.googlesource.com/1033326 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#559477}
-
Sylvain Defresne authored
Mark the class as non-copyable/moveable to prevent against slicing and make the destructor public to allow destruction via pointer to base class (i.e. std::unique_ptr<Observer>). Bug: none Change-Id: I713262134cb61fdd37a4c11b20ef154aeed2f00f Reviewed-on: https://chromium-review.googlesource.com/1063770Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#559476}
-
Hans Wennborg authored
TBR=brucedawson Bug: none Change-Id: Ief0ae90da4d04abfb66e7ebca89849ed9003570f Reviewed-on: https://chromium-review.googlesource.com/1063836Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#559475}
-
Kinuko Yasuda authored
All/AutofillInteractiveIsolationTest.SimpleCrossSiteFill/1 is flaky. I wasn't able to find a good culprit, so let me disable this so that owners can figure out. TBR=estade@chromium.org Bug: 843935 Change-Id: I3e135fdd51b3b31cfb0fe4af4a031d62984377da No-Try: True Reviewed-on: https://chromium-review.googlesource.com/1063418Reviewed-by:
-
Benoit Lize authored
This reports the total size of source code size for all external scripts in a V8 isolate. As with other V8 code stats, this doesn't distinguish between live and dead objects and doesn't scan the young generation. Bug: 837659 Change-Id: I746729f3c167cbad847599b4b128fa517a116c7e Reviewed-on: https://chromium-review.googlesource.com/1032936Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#559473}
-
Max Morin authored
This CL adds the audio related switches which are used by the audio service to the whitelisted switches for utility processes. This is needed when running the audio service out of process. Also moves all the ifdefed switches to the bottom. Bug: 843103 Change-Id: I2172d02b28f5011a915c89d9509dd15ccb166950 Reviewed-on: https://chromium-review.googlesource.com/1059624 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
-
Bruce Dawson authored
This reverts commit 5a7f3c44. Reason for revert: this breaks v8's VC++ goma builds, reverting until goma is updated to support this compiler Original change's description: > Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK > > This change switches the VS 2017 package to use VS 2017 Update 7.1 while > using the 10.0.17134.12 SDK. The new SDK is needed to support new HDR > features, and to stop forcing external developers to install an old > ([Spring] Creators Update) SDK. This change will also bring in a new > linker and other build tools, but the version of clang-cl will be > unchanged. > > Packaging was done on a Windows Server 2016 VM, cleanly created for this > purpose. > > Compiler was packaged up by downloading VS 2017 Update 7.1, from > https://www.visualstudio.com/vs/, and then passing these parameters to > the installer: > > --add Microsoft.VisualStudio.Workload.NativeDesktop > --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended > --passive > > Then Add or Remove Programs was used to modify the 10.0.17134.0 SDK to add > the Debuggers package. > > Then the packaging script was run like this: > > python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.17134.0 > > Bug: 773476 > Change-Id: Ic819f3ae79d7e869227bf33fbb8d202e2f57039b > Reviewed-on: https://chromium-review.googlesource.com/1054027 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559033} TBR=thakis@chromium.org,dpranke@chromium.org,hubbe@chromium.org,brucedawson@chromium.org Change-Id: Ib8e84084a9717dafa6616f132b4824d93cbf39bf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773476 Reviewed-on: https://chromium-review.googlesource.com/1063810Reviewed-by:
-
François Beaufort authored
This reverts https://chromium-review.googlesource.com/1042290 since cc::Surfaces for video are now allowed to work with software compositing. Bug: 806249, 807840 Change-Id: Ie02c69d527b8e13235d744d3c2e98ea5b073f61d Reviewed-on: https://chromium-review.googlesource.com/1062745Reviewed-by:
-
Friedrich Horschig authored
This reverts commit 58e3dc5d. Reason for revert: The failed CrOS test doesn't seem affected by the newly introduced Android code. Original change's description: > Revert "Render Tabs into Bottom sheet" > > This reverts commit a4ae2e1f. > > Reason for revert: > All/AutofillInteractiveIsolationTest.SimpleCrossSiteFill/1 started > to fail on ChromeOS likely after this change. > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/8133 > https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5701 > > Original change's description: > > Render Tabs into Bottom sheet > > > > This CL shapes the role of a KeyboardAccessoryData.Tab element: > > It is an element that provides a specific benefit to the Manual UI by... > > ... providing data that is used by the bar to render a tab (upcoming) > > ... providing the content for a separate tab in the bottom sheet. > > > > This means, that the bottom sheet provides space for tabs and manages the > > general visibility and active states of tabs. > > The exact content of a tab doesn't matter to the AccessorySheetComponent. > > That way, it should become fairly straight forward to implement a new tab > > that is rendered into bottom sheet and accessory. > > > > The first concrete instance of a bottom sheet will follow soon: a > > bottom sheet that contains password related actions and data. > > (It's important to not mix this specific data into the AccessorySheet > > component as other upcoming sheets are already planned, like one for > > payments and one for address data.) > > > > Bug: 811747 > > Change-Id: Id8bd8c389496246166d26a6c298056a142c36566 > > Reviewed-on: https://chromium-review.googlesource.com/1047285 > > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#559180} > > TBR=bauerb@chromium.org,fhorschig@chromium.org > > Change-Id: I879e4e89c674d47562c662b5c2bbac3487546062 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 811747 > Reviewed-on: https://chromium-review.googlesource.com/1063732 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559463} TBR=kinuko@chromium.org,bauerb@chromium.org,fhorschig@chromium.org Change-Id: I17ef937cfed19aa4b3fe9b10220b77ac349ffb31 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 811747 Reviewed-on: https://chromium-review.googlesource.com/1063790Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/15f1761d9e8f..bd74e6a02ae0 $ git log 15f1761d9..bd74e6a02 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I3de11e8ce5e351b67eb545308d1f04348dbeaf40 Reviewed-on: https://chromium-review.googlesource.com/1063562Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559468}
-
Roman Sorokin authored
Currently ephemeral users are not stored into local state at all. It works bad in case Chrome crashes (or restarts) inside the session. E.g. Chrome could not find for which user session should be restored. This change puts data for ephemeral users into local state and wipes on logout. BUG=chromium:843163 TEST=TBD Change-Id: Ice425c63ca74a0d4862e5f05ff869de185da5e6e Reviewed-on: https://chromium-review.googlesource.com/1059785 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#559467}
-
Max Morin authored
This tests tells the audio manager to fail creating an audio stream, but accessing the audio manager directly isn't possible when running out of process. Thus, a command line switch is introduced. I ran the test 100 times for each combination of (in content streams, in process audio service streams, out of process audio service streams) and (tsan, release) to ensure it's not flaky in any way, but note that running it out of process requires updating the flag whitelist in content::UtilityProcessHost (next CL, since we'll need a few flags). Bug: 835742, 843103 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8a6a659523f39a1c66c3a9ed9d37de9eedbc8265 Reviewed-on: https://chromium-review.googlesource.com/1059594Reviewed-by:
-
