- 27 Feb, 2018 40 commits
-
-
Jacob Dufault authored
Bug: 809637 Change-Id: Id06bf1b73bed7e2338488b68a1702f13582331f0 Reviewed-on: https://chromium-review.googlesource.com/930242 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#539519}
-
Emil A Eklund authored
Bug: 772263 Test: Source/platform/LayoutUnitTest.cpp Change-Id: I470b0dd4ce654c777d178dba077e523d3748b926 Reviewed-on: https://chromium-review.googlesource.com/938850Reviewed-by:
Justin Schuh <jschuh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#539518}
-
Torne (Richard Coles) authored
This is no longer called; drop it as it's deprecated on the Android side (code should just check the version directly). Change-Id: I5e666435e0b3a3c60e0da0e3448bd6a988026e27 Reviewed-on: https://chromium-review.googlesource.com/938601Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#539517}
-
Menglu Huang authored
Bug: 816699 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9ef613d741418b2a66f96664438979aa3256c680 Reviewed-on: https://chromium-review.googlesource.com/938677Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#539516}
-
Lei Zhang authored
And add a header to IWYU in PDFiumEngine. Change-Id: I93198a22d80d252339f19328788ac2e6ec5a96f9 Reviewed-on: https://chromium-review.googlesource.com/939643Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#539515}
-
Xi Cheng authored
This .ver file in currently in Windows style (CR LF), which should be converted to Unix style (LF). Bug: 734095 Change-Id: I7560924f308ce2e7936c982b049e84e83f35231d Reviewed-on: https://chromium-review.googlesource.com/938966Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#539514}
-
gogerald authored
Bug: 735063 Change-Id: I90a87a01c2769316230716fd3c590dbe6c106801 Reviewed-on: https://chromium-review.googlesource.com/939581Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#539513}
-
Kevin Marshall authored
Switching to FVM will give us a functioning blobstore, a prerequisite for installing packages, and allows the Fuchsia team to follow through with bootfs deprecation. Also added a missing package reference to local-sdk.py that caused it to skip building the Fuchsia userspace. Bug: 802331 Change-Id: I6cfc45c51dae97bef3c9f7a202f74fff483d5c50 Reviewed-on: https://chromium-review.googlesource.com/919266 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#539512}
-
Emil A Eklund authored
Check for PrimaryFont in LayoutTextCombine::TransformToInlineCoordinates as it may be NULL in which case no coordinate transform is required. Bug: 814734 Change-Id: I9d637bc9956a3129cd294398e407023cc45e32ea Reviewed-on: https://chromium-review.googlesource.com/938661 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#539511}
-
Ken Rockot authored
The safe_browsing::mojom::PhishingDetectorClient interface appears to have been added to the wrong interface_provider_spec. This moves it to the correct one. Bug: 816892 Change-Id: If6421f57920a36fa9c2be351c5b451cedfd024cc Reviewed-on: https://chromium-review.googlesource.com/939538Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#539510}
-
Stephen McGruer authored
By the spec, a KeyframeEffect may be created with a null target, although unfortunately the spec doesn't then say what Document to use to resolve style/etc. This CL adds null-target handling, falling back to the Document extracted from the ScriptState if there is no target. In terms of changes to tests: - Three WPT tests no longer timeout (woo), but unfortunately they currently crash on a DCHECK for setting transform-box to 'border-box' and so are still disabled. See http://crbug.com/816534 - A number of tests for processing a keyframes argument start failing due to a bug in that code; previously this went unseen because the tests pass null for the element. Bug: 772014, 816534 Change-Id: I01502c82bf758a796fe83c87ed395c6b9f6c4e11 Reviewed-on: https://chromium-review.googlesource.com/934625 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539509}
-
Dominic Mazzoni authored
There are times when a node needs to be ignored, meaning it shouldn't be exposed as part of the accessibility tree, but its subtree should. A common example is role=none/presentation, but we also sometimes do this for extra wrapper divs and spans. Previously these ignored nodes were just never exposed by Blink, but that has led to problems when a node's ignored status changes. Instead, let's introduce the concept of ignored to AXNodeData and add support for walking the "unignored" tree to AXNode. When a node's ignored state changes, we should fire a Children Changed event on the first unignored parent. This change introduces a new state and some helper functions but doesn't actually use them. A follow-up change will start making use of this code. Bug: 651614 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ide93a65d5721c00e8c9d1780c8b524341b837f05 Tbr: tsepez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/936430 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#539508}
-
lgcheng authored
Add ArcUsbHostUiDelegate interface. Bug: 776476 Bug: b:24572867 Change-Id: I0ff523c24ebc1786f1fee3e77bbd36ebed72831e Reviewed-on: https://chromium-review.googlesource.com/903059 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#539507}
-
Robert Ma authored
This CL rebaselines WPT that fail on Mac 10.13 by: 1. Triggering mac10.13_blink_rel 2. Grep "external/wpt" in the list of failing tests 3. `webkit-patch rebaseline-cl` that list of tests Most of the changes are promoting mac-mac10.12/ to mac/ and then further consolidating some of them with win/ to the generic baselines. Bug: 774301 Change-Id: Ib50dcaaba5952a4e9ecbed710303041ca7f04013 Reviewed-on: https://chromium-review.googlesource.com/899785Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#539506}
-
Troy Hildebrandt authored
The assumption is currently that the URL bar displays URLs, so we always make a call to #scrollToTLD. This results in showing the end of a query, which is inconsistent with common SRP behaviour. This CL ensures that when we're displaying search terms, we scroll to the start of the text in an RTL friendly way. Bug: 776988 Change-Id: Ied926bd276f312a7e4ab18b9c45173d0ce15dbbe Reviewed-on: https://chromium-review.googlesource.com/935452 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#539505}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9b4d0c77152a..53a62911658d $ git log 9b4d0c771..53a629116 --date=short --no-merges --format='%ad %ae %s' 2018-02-27 agable Update windows bleeding-edge git to 2.16.2 Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I489178230fe31272df075eb94477a461562b9880 Reviewed-on: https://chromium-review.googlesource.com/939589Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539504}
-
Avi Drissman authored
This reverts commit e9c5d973. Reason for revert: There were clients depending on this confusion of invalid ID. It's not clear what broke, as tests are not reliable, so reverting to make sure that the 66 branch works. Original change's description: > Clean up SpeechRecognitionSessionContext. > > The correct "no process" id is not 0; use instead > content::ChildProcessHost::kInvalidUniqueID (-1). > > The correct "no view/frame" id is not 0; use instead > MSG_ROUTING_NONE (-2). > > In addition, guest_render_view_id is not actually used, > so remove it. > > BUG=390749 > > Change-Id: Iaf0510b00e8646f71d23eee2c9309e64f59e0903 > Reviewed-on: https://chromium-review.googlesource.com/922802 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Justin Schuh <jschuh@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537378} TBR=avi@chromium.org,jschuh@chromium.org,olka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 390749 Change-Id: Icceeb7ff0e609e9193ae4c3a88e7a69f537242fe Reviewed-on: https://chromium-review.googlesource.com/938723Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#539503}
-
sczs authored
- Creates TableViewTextItem - Creates TableViewTextCell - Adds it to the Cell Catalog. Screenshot: https://drive.google.com/open?id=1TVy-uclmwfIo32KfQmRrq_aff5_qPvfg Bug: 805149 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2708d458c06d245beab2cb35f78d1b13101548ff Reviewed-on: https://chromium-review.googlesource.com/938500 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#539502}
-
Max Morin authored
This CL adds an AudioOutputStream implementation for the audio service. Note that there isn't a separation between AudioOutputDelegate and AudioOutputStream like for content/media, since it isn't needed, and fewer layers are simpler. OutputStream has the same functionality as AudioOutputDelegateImpl, except for * mirroring: requires lots of refactoring to break content dependencies. * notifying content::MediaObserver. Will be done by the client in content/. CL with factory for this: https://chromium-review.googlesource.com/c/chromium/src/+/939179. Design doc: http://go/audio-service-streams-design Bug: 803102 Change-Id: Id660d08497b99fb0beba8201760d2b13d788ffb2 Reviewed-on: https://chromium-review.googlesource.com/908561Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539501}
-
Tim Brown authored
pkg-config currently specifies include directories using the -I flag, even for system libraries. This means that warnings in the included header files (for example when enabling -Wzero-as-null-pointer-constant) cause the build to fail. This change will make pkg-config include directories included using the -isystem flag instead, which will make the compiler not report warnings in the included header files. Bug: 816565 Change-Id: I441ddeee28f8031410ce95ae1712bd68b0b86a63 Reviewed-on: https://chromium-review.googlesource.com/938941Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Tim Brown <timbrown@chromium.org> Cr-Commit-Position: refs/heads/master@{#539500}
-
Jinho Bang authored
This patch is an initial implementation of the following spec change: - https://github.com/w3c/payment-handler/issues/246 - https://chromium-review.googlesource.com/c/chromium/src/+/533193 This feature is still behind runtime flag. Bug: 665949 Change-Id: Ied225b89c7aed3a39955e49e9af2e4e3866a92c2 Reviewed-on: https://chromium-review.googlesource.com/914661Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#539499}
-
Colin Blundell authored
The codebase is in the process of being incrementally converted from usage of //components/signin to usage of //services/identity/public/cpp. In the process of this conversion, IdentityManager can end up being instantiated in the context of browser_tests. IdentityManager has internal DCHECKs that verify that its view of the primary account is consistent with SigninManagerBase. As ChromeSessionManager sets signin information manually on SigninManager, these DCHECKs can fire. This CL modifies ChromeSessionManager so that it goes through IdentityManager to set the primary account info. Doing this sets the primary account information both in IdentityManager and also in SigninManagerBase. Note that one complexity is that this flow does not set the refresh token. In the long term we would ideally set the refresh token as part of this flow in order to unify this flow with other signin flows in the codebase. However, that is a behavioral change that is orthogonal to the change being made here. In this CL, we simply add a method to IdentityManager that allows for setting only the GAIA ID/email address but not the refresh token. https://crbug.com/814787 tracks the work required to remove this method and port this flow to use more mainstream Identity Service APIs. This change is concretely needed for an upcoming conversion to avoid tickling this issue :). Bug: 796544 Change-Id: I405a8883bef03c2aaa94b01ed7bebf5e41a1164d Reviewed-on: https://chromium-review.googlesource.com/931469 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#539498}
-
Evan Stade authored
MessageCenterImpl::OnBlockingStateChanged() was unsafe. On desktop, MarkSinglePopupAsShown removes/deletes that notification since there is no message center bubble. The function then references the notification again, via the |blocked| list. Instead of a list of weak Notification pointers, |blocked| should be a list of notification IDs. This bug was revealed by (although not directly caused by) removing the NotificationChangeQueue. Bug: 816374 Change-Id: I9ebc21ae95b18bf167c52911c7c0e1eacaf6e06d Reviewed-on: https://chromium-review.googlesource.com/938676Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#539497}
-
Sahel Sharify authored
The problem with Youtube page in oopif is that the Body element of the iframe is vertically scrollable by a few pixels (ClampScrollOffset doesn't shirnk the vertical scroll delta to zero) but UserInputScrollable(kVerticalScrollbar) is false for its scrollablearea. This cl uses the latter function in addition to ClampScrollOffset to calculate the clamped scroll delta in ScrollManager::CanScroll. Bug: 809621 Test: SitePerProcessBrowserTest.ScrollBubblingFromOOPIFWithBodyOverflowHidden Change-Id: Id7c722331bc4e65cf4808aa7bb18b3cbf3f71808 Reviewed-on: https://chromium-review.googlesource.com/905473Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#539496}
-
Owen Min authored
Bug: 803191 Change-Id: I04053d35036e05014c0ff8a670b774a7be5cb96c Reviewed-on: https://chromium-review.googlesource.com/939584Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539495}
-
John Z Wu authored
This will help in writing tests for CWVTranslationController. Bug: 770983 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8f0b67e14872e654fcf276f0fba20dab4289b6b9 Reviewed-on: https://chromium-review.googlesource.com/939045 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#539494}
-
John Chen authored
Add support of OOPIF (out-of-process iFrame) to ChromeDriver Change-Id: I0b936b21597d8970656029c3110bfe0f61ae9aa8 Reviewed-on: https://chromium-review.googlesource.com/934145 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#539493}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/efc0f3d4..687fceb2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If94d30c7437cf4ed518c3084927e014614faaaf5 Reviewed-on: https://chromium-review.googlesource.com/938596Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#539492}
-
Charles Harrison authored
We should never show the Ad block UI when devtools is the cause of the activation. This CL does that by using suppress_notification for forced activation. This messes up some logging, so we handle that by adding a new histogram at the //content layer. Bug: 812348 Change-Id: I16ae72cbb3342183a2067f2ad1698758425cd160 Reviewed-on: https://chromium-review.googlesource.com/919315 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#539491}
-
Sylvain Defresne authored
Bug: none Change-Id: Ie877b9c71a1851c5f663ecb3ef194391aa6bd9be Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/939173 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#539490}
-
Dominic Mazzoni authored
Bug: 812647 Test: manually tested bug 812647 with ChromeVox Change-Id: I9110c0d9e301dad9315cfbcdb9572a1c91c90a16 Reviewed-on: https://chromium-review.googlesource.com/938753 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#539489}
-
https://chromium.googlesource.com/catapult.git/+log/38e8eedc7bb6..47ca0db0bd96 $ git log 38e8eedc7..47ca0db0b --date=short --no-merges --format='%ad %ae %s' 2018-02-26 charliea Reland: Roll the new BattOr firmware and battor agent to the latest version 2018-02-26 nednguyen [Telemetry] Cap the limit of trace size in TimelineBasedMeasurement to 400 MiB 2018-02-26 charliea Fix remaining reference to bad host/arch strings in BattOr wrapper 2018-02-23 wvw Add clock state support 2018-02-23 wvw Add clk_set_rate support Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ia5e66c2348dd7c8dd9487451fca60c3643534749 Reviewed-on: https://chromium-review.googlesource.com/938364 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539488}
-
John Williams authored
https://chromium.googlesource.com/media_router.git/+log/8c27673ed823..270eb6c464d5 $ git log 8c27673ed..270eb6c46 --date=short --no-merges --format='%ad %ae %s' 2018-02-26 mfoltz Changed default values of MR compile-time constants. 2018-02-23 mfoltz Made logging settings easier for developers to discover. 2018-02-23 mfoltz Added device discovery via Slarti. Created with: roll-dep src/chrome/browser/resources/media_router/extension/src Change-Id: If6a3633e4a8702e46527a39b30215a9373d4019a Reviewed-on: https://chromium-review.googlesource.com/938565 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#539487}
-
Joshua Peraza authored
NewReports are being made classes, intended to be initialized only by a CrashReportDatabase (which is a friend). This makes mocking PrepareNewCrashReport and FinishedWritingCrashReport awkward, but a real CrashReportDatabase shouldn't be prohibitively heavyweight. Bug: crashpad:206 Change-Id: I085cacfc4fd4b3e51578973c9795a5a25c1c14dc Reviewed-on: https://chromium-review.googlesource.com/937982 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#539486}
-
Tarun Bansal authored
This CL introduces no functional changes, and only verifies the current behavior of client hints when only the Accept-CH header is specified in the response headers. Browser tests and Blink tests are added for cases where the origin has specified only the Accept-CH header in the response headers. The tests ensure that currently client hints are attached even if the origin does not have permission to run JavaScript. Additionally, the tests also ensure that the client hints are attached for third-party origins. The next CL will modify these behaviors, and prevent attaching of client hints when origin does not have permission to run scripts. The next CL would also prevent attaching of client hints to third-party origins. The tests added in this CL would be updated to match that behavior in the next CL. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I90d992cd456e62f36924243972430012639efde9 Bug: 816661 Reviewed-on: https://chromium-review.googlesource.com/938541 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#539485}
-
Francois Doray authored
This overload is no longer used. All callers use the overload that calls base::GetFieldTrialParams() directly. Bug: 810049 Change-Id: I0cde22bd6701b8b698b90aa7b39a10666fe7d32f Reviewed-on: https://chromium-review.googlesource.com/909296Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#539484}
-
https://skia.googlesource.com/skia.git/+log/c657fa6d44d3..db1e5c6474c1 $ git log c657fa6d4..db1e5c647 --date=short --no-merges --format='%ad %ae %s' 2018-02-27 kjlubick Port 3 API fuzzers to be oss-fuzz friendly 2018-02-27 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 6ae51611c..06a87ec83 (3 commits) 2018-02-27 angle-skia-autoroll Roll skia/third_party/externals/angle2/ b52fac03f..6ae51611c (1 commit) 2018-02-26 bsalomon Suppress CopySurface test on Nexus 7 Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I82764f84cf4d3d59e232caaedfd22c8d072c461f Reviewed-on: https://chromium-review.googlesource.com/939441 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539483}
-
Gauthier Ambard authored
This CL adds the new assets to be used for the UI refresh and use them. Bug: 807284 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6cd1d1132a4552296fdefbcd488652a7cfd59ca2 Reviewed-on: https://chromium-review.googlesource.com/939394 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#539482}
-
Dave Tapuska authored
Since the SynchronousCompositorProxy (base class of SynchronousCompositorMojo) holds onto a reference to the InputHandlerProxy it must be destroyed before the InputHandlerProxy is destroyed. BUG=816538 Change-Id: I990b5a427970b28219464267de41a28b1fabb5d0 Reviewed-on: https://chromium-review.googlesource.com/938485 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539481}
-
Hwanseung Lee authored
a patch[1] which is to fix jumbo build error was merged. but g_instance_for_testing still keep in memory_dump_manager.cc. that variable name looks like generic name which is some potential to make same issue. so it should be rename in order to void the same problem. [1]https://chromium-review.googlesource.com/938821 Bug: 775547 Change-Id: Id7f3fc30a8118fb6f24f0e920ab530f44a27fa82 Reviewed-on: https://chromium-review.googlesource.com/938803Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#539480}
-