GitLab

❆(੭ु ◜◡‾)੭ु⁾☃❆

BUG=557422
R=avi@chromium.org
TBR=dgozman@chromium.org

Review URL: https://codereview.chromium.org/1549363002

Cr-Commit-Position: refs/heads/master@{#366979}

❆(੭ु ◜◡‾)੭ु⁾☃❆

BUG=557422
R=avi@chromium.org
TBR=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/1549353002

Cr-Commit-Position: refs/heads/master@{#366978}

This CL is an attempt to ensure that input audio recording always works on Mac OS X.
It is a trivial change and I don't know if it has any real effect, hence it is speculative.
I am making this change since I have seen in examples that it is recommended to initialize
the AUHAL before using it. We can only hope that it has a positive effect.
More small changes are in the pipeline but my plan was to land them one by one to keep
the changes as simple as possible and easy to revert if needed.

Adding tommi@ as TBR since he is OOO and the change can be considered trivial. If we are lucky
it has a positive effect. If we are not, I don't expect any effect at all.

TBR=tommi
BUG=549021

Review URL: https://codereview.chromium.org/1551613002

Cr-Commit-Position: refs/heads/master@{#366977}

TBR=jam@chromium.org
BUG=561803
NOTRY=true

Review URL: https://codereview.chromium.org/1551553003

Cr-Commit-Position: refs/heads/master@{#366976}

InternalSettingsGenerated.h is included by V8InternalSettingsGenerated.h as
"../../../out/Release/gen/blink/core/testing/InternalSettingsGenerated.h".
And it was emitted to the depfile as
"gen/../../../out/Release/gen/blink/core/testing/InternalSettingsGenerated.h".
That confuses dependency analysis of Ninja and causes unneeded rebuild.

This CL converts it to the relative path to out/Release/gen/blink, so that
the include path is simplified to "core/testing/InternalSettingsGenerated.h".

BUG=531579

Review URL: https://codereview.chromium.org/1544373002

Cr-Commit-Position: refs/heads/master@{#366975}

BUG=

Review URL: https://codereview.chromium.org/1549303002

Cr-Commit-Position: refs/heads/master@{#366974}

Review URL: https://codereview.chromium.org/1539913002

Cr-Commit-Position: refs/heads/master@{#366973}

TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/1538613002

Cr-Commit-Position: refs/heads/master@{#366972}

Mostly this involves parameterizing the tab and new tab button drawing so they
can handle different desired sizes.  There should be no change in material
(non-hybrid) mode.

This also positions the new tab button vertically based on the distance below
the button instead of the distance above, since we want the gap between the
button and the toolbar to remain constant even as the tab and button heights
change, rather than having the button starting a fixed distance below the top of
the tabs.

BUG=519020
TEST=Run with --top-chrome-md=material-hybrid and check that the tabs and new tab button are larger than in material mode but still shaped correctly

Review URL: https://codereview.chromium.org/1541313002

Cr-Commit-Position: refs/heads/master@{#366971}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/951fd121..56ce1b39

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1549373002

Cr-Commit-Position: refs/heads/master@{#366970}

Search provider specified by preferences and by extensions have wrong
comments. This CL fixes it.

BUG=NONE

Review URL: https://codereview.chromium.org/1551543002

Cr-Commit-Position: refs/heads/master@{#366969}

* Uses layout constants for the tab height in all cases, not just material.
* Removes TAB_MAXIMUM_TITLE_WIDTH layout constant.  We really just want the total maximum tab width to be the same across all modes, so compute it that way directly in tab.cc.
* Adds a new GetLayoutSize() function, which currently is only used for the new tab button size.
* A few other tiny cleanups.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1543963002

Cr-Commit-Position: refs/heads/master@{#366968}

BUG=549021

Review URL: https://codereview.chromium.org/1487393003

Cr-Commit-Position: refs/heads/master@{#366967}

The unit tests were added as well.

BUG=567139

Review URL: https://codereview.chromium.org/1505773002

Cr-Commit-Position: refs/heads/master@{#366966}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/eae61813..951fd121

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1552543003

Cr-Commit-Position: refs/heads/master@{#366965}

The code wanted the difference between the height in a restored windows vs. a
maximized window, but instead used the height difference between the top of the
tabstrip and the top of the new tab button.

The effect of this is that when dragging a tab out of a maximized tabstrip, the
new window is created about 5 px higher (at 100% scale) than before.

This allows moving a public constant in TabStrip to become file-scope to the .cc
file.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1545863002

Cr-Commit-Position: refs/heads/master@{#366964}

BUG=327804

Review URL: https://codereview.chromium.org/1512843002

Cr-Commit-Position: refs/heads/master@{#366963}

Cr-Commit-Position: refs/heads/master@{#366962}

I realised that PSS::IsOAuthRefreshTokenAvailable is never called.
This change is to remove it and all references.

BUG=

Review URL: https://codereview.chromium.org/1549443002

Cr-Commit-Position: refs/heads/master@{#366961}

Cr-Commit-Position: refs/heads/master@{#366960}

BUG=

Review URL: https://codereview.chromium.org/1542623004

Cr-Commit-Position: refs/heads/master@{#366959}

BUG=138542
TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/1550063002

Cr-Commit-Position: refs/heads/master@{#366958}

BUG=

Review URL: https://codereview.chromium.org/1544343002

Cr-Commit-Position: refs/heads/master@{#366957}

❆(੭ु ◜◡‾)੭ु⁾☃❆

BUG=557422
R=avi@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1550693002

Cr-Commit-Position: refs/heads/master@{#366956}

Restore NeedsManualRebaseline and comment out Pass/Timeout instead.

BUG=569175,569514
TBR=yangguo

Review URL: https://codereview.chromium.org/1548243002 .

Cr-Commit-Position: refs/heads/master@{#366955}

https://chromium.googlesource.com/chromium/src/+/2e92c6870

BUG=571723
TBR=hyunjune.kim@samsung.com

Review URL: https://codereview.chromium.org/1546283002 .

Cr-Commit-Position: refs/heads/master@{#366954}

https://chromium.googlesource.com/chromium/src/+/aa8f96b14

BUG=545551
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/1551533002 .

Cr-Commit-Position: refs/heads/master@{#366953}

https://chromium.googlesource.com/chromium/src/+/73a178bda

BUG=569938
TBR=bratell@opera.com

Review URL: https://codereview.chromium.org/1544353002 .

Cr-Commit-Position: refs/heads/master@{#366952}

https://chromium.googlesource.com/chromium/src/+/5fe799b71

BUG=571905
TBR=reed@google.com

Review URL: https://codereview.chromium.org/1549253003 .

Cr-Commit-Position: refs/heads/master@{#366951}

https://chromium.googlesource.com/chromium/src/+/622e42ea0

BUG=327832
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/1546273002 .

Cr-Commit-Position: refs/heads/master@{#366950}

BUG=569175,569514
TBR=yangguo

Review URL: https://codereview.chromium.org/1549323002 .

Cr-Commit-Position: refs/heads/master@{#366949}

BUG=138542
TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/1550683003

Cr-Commit-Position: refs/heads/master@{#366948}

Revert of Make Rebaseline/NeedsRebaseline/NeedsManualRebaseline not conflict with Pass lines. (patchset #2 id:20001 of https://codereview.chromium.org/1412533002/ )

Reason for revert:
Interim fix for http://crbug.com/569175 until we can update script to not strip Pass/Failure lines for tests also matching NeedsRebaseline.

Original issue's description:
> Make Rebaseline/NeedsRebaseline/NeedsManualRebaseline not conflict with Pass lines.
>
> As per https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OI_gXMX7yUs.
>
> Committed: https://crrev.com/30fe1b01a50cefa35a0578311944e3b09cb27f38
> Cr-Commit-Position: refs/heads/master@{#357741}

TBR=dpranke@chromium.org,ojan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=569175

Review URL: https://codereview.chromium.org/1550703002

Cr-Commit-Position: refs/heads/master@{#366947}

BUG=138542
TBR=boxhall@chromium.org

Review URL: https://codereview.chromium.org/1549293002

Cr-Commit-Position: refs/heads/master@{#366946}

This allows us to diagnose through system tools unexpected sleep prevention until a more proper UI solution (such as in bug http://crbug.com/571426) is implemented.

BUG=571250

Review URL: https://codereview.chromium.org/1546253002

Cr-Commit-Position: refs/heads/master@{#366945}

❆(੭ु ◜◡‾)੭ु⁾☃❆

BUG=557422
R=avi@chromium.org
TBR=kinuko@chromium.org

Review URL: https://codereview.chromium.org/1546243002

Cr-Commit-Position: refs/heads/master@{#366944}

❆(੭ु ◜◡‾)੭ु⁾☃❆

BUG=557422
R=avi@chromium.org
TBR=brettw@chromium.org,rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/1544333002

Cr-Commit-Position: refs/heads/master@{#366943}

❆(੭ु ◜◡‾)੭ु⁾☃❆

BUG=557422
R=avi@chromium.org
TBR=yzshen@chromium.org

Review URL: https://codereview.chromium.org/1545333002

Cr-Commit-Position: refs/heads/master@{#366942}

BUG=138542
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1546223002

Cr-Commit-Position: refs/heads/master@{#366941}

❆(੭ु ◜◡‾)੭ु⁾☃❆

BUG=557422
R=avi@chromium.org
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/1547223002

Cr-Commit-Position: refs/heads/master@{#366940}