- 29 May, 2019 40 commits
-
-
Harald Alvestrand authored
This led to confusing error messages. Bug: chromium:966798 Change-Id: Ie47a56e4014fa8ae055bd1bdb405d9dc2c0cab69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635612 Commit-Queue: Harald Alvestrand <hta@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Auto-Submit: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664547}
-
Stephen Chenney authored
Add the First Contentful Paint time as a trigger for the initial commit. The rationale being that once we have painted something meaningful, we should commit it. Also add an UMA Enum Histogram to count the number of times we decide to commit for each potential reason. Bug: 805798 Change-Id: I64ff915d3b525a5c81f60381013426a005262b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627814Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#664546}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4e2aa897a424..ca41bc48d6f6 git log 4e2aa897a424..ca41bc48d6f6 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 thestig@chromium.org Get rid of CCodec_ModuleMgr::GetIccModule(). 2019-05-29 thestig@chromium.org Get rid of CCodec_ModuleMgr::GetJpxModule(). 2019-05-29 tsepez@chromium.org Add cheapo module visualization tool to repository. 2019-05-29 thestig@chromium.org Get rid of CCodec_ModuleMgr::GetFaxModule(). 2019-05-29 thestig@chromium.org Get rid of CCodec_ModuleMgr::GetBasicModule(). 2019-05-29 tsepez@chromium.org Remove circular includes from core/fpdfapi/cmaps. 2019-05-29 thestig@chromium.org Get rid of CCodec_ModuleMgr::GetFlateModule(). 2019-05-29 thestig@chromium.org Add component build bots to the default try job set. Created with: gclient setdep -r src/third_party/pdfium@ca41bc48d6f6 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Ic81c24e9e2eb550df1c602f22fb5bb5fe7353f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636490Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664545}
-
Eugene But authored
crrev.com/c/1632591 changed test behavior to wait until reload is finished for slim nav, which broke the test. This CL restores the original behavior, so the test does not wait until reload is finished. Added -[ChromeEarlGreyImpl reloadAndWaitForCompletion:] to compliment existing -[ChromeEarlGreyImpl loadURL:waitForCompletion:] Bug: 968296 Change-Id: I86d1d982424ee4f56c64ac4cae522f1070d116ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636570 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664544}
-
Wei-Yin Chen (陳威尹) authored
Frame rate and dirty time span in the Tab-to-Grid animation are measured for the following use cases: - From NTP - From live tab, with total number of tabs = {1, 10, 100} Bug: 964406 Change-Id: I2e181596c9f3145557257b7b060ffee4db6f8cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634395 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664543}
-
Marijn Kruisselbrink authored
Existing files are all fine because of a presubmit enforcing this, but setting gitattributes makes it easier to not trigger the presubmit in the first place. Bug: 832129 Change-Id: I3e82d89196d28d23c609e5e1ded56817505da0e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635868 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#664542}
-
Vladislav Kaznacheev authored
This CHECK should help determine the exact reason why GetProfileForNotifiers returns nullptr and causes a high frequency crash. Bug: 957121 Test: none Change-Id: I5a62a83eea0e768ad162fbec755411e32186ff16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635077 Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#664541}
-
Kenneth Russell authored
The following two tests are observed to flake in webgl2_conformance_gl_passthrough_tests : conformance/extensions/webgl-compressed-texture-s3tc.html conformance/extensions/webgl-compressed-texture-s3tc-srgb.html Bug: 963205 Change-Id: Ic9c8ae5b7099f5fc02d7ccab802edbcb912c0939 Tbr: jonross@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636229Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#664540}
-
Antoine Labour authored
Use an explicit shared image allocation for the intermediate texture that is used in both the source and destination GL contexts. Bug: 882547 Change-Id: Ibd37bb16a1a43860976c9b35feadd576e099df4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633530 Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#664539}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/740cc35145c0..72055b11beb9 git log 740cc35145c0..72055b11beb9 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8891f34d..2d1120f0 (664289:664417) Created with: gclient setdep -r src/third_party/webrtc@72055b11beb9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I757872174f1d5946e4f47f09e4121350dee52667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636210Reviewed-by:
-
Daniel McArdle authored
The problem this CL addresses is that several semantically-different messages are currently jammed into the response from OnCertificateRequested. For example, using nullptr for certificate and private key to signify that no certificate was selected. This CL eliminates the response from OnCertificateRequested and moves it into several different messages within the new ClientCertificateResponder interface. Bug: 946742 Change-Id: I49c63bdc0732a438336a02e558d4cca4d1202ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589995Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#664537}
-
Jinsuk Kim authored
Replaces Tab.notifyRendererPreferenceUpdate with a new API on WebContents. This CL addressed a TODO in Tab. Rather than exposing Java RenderViewHost which requires modification in already-deprecated native content::RenderViewHostImpl, the changes follows the direction recommended in the comment by updating WebContents for this page-specific function. Bug: 960746 Change-Id: I7bfe3c1d04a7a7ec2906e829912e7906ff30d937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630378 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#664536}
-
Justin DeWitt authored
The ExploreSites tile is a special one that can't be removed or used inside an incognito tab. Bug: 966024 Change-Id: Idf2340ee879575ffe1c0f3402a4d7725326df248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635853 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#664535}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3d62cb814853..e7866de4b1dc git log 3d62cb814853..e7866de4b1dc --date=short --no-merges --format='%ad %ae %s' 2019-05-29 pierremoreau@users.noreply.github.com Linker: Better type comparison for OpTypeArray and OpTypeForwardPointer (#2580) 2019-05-29 zoddicus@users.noreply.github.com Add compact ids to WebGPU <-> Vulkan transformations (#2639) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e7866de4b1dc The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I2cfa33eec1a62b01992ee8c2400f458726887e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636209Reviewed-by:
-
rbpotter authored
Rename print-preview-user-info to print-preview-user-manager and move management of user account state to print-preview-user-manager, instead of sharing this responsibility between user-info and print-preview-destination-settings. Remove cloudPrintState in favor of checking the activeUser and a single cloudPrintDisabled boolean. Finally, send user account updates from PrintPreviewHandler, instead of just sending reload-print-destinations event. This should not change any user visible behavior. Bug: 958767 Change-Id: I4ff2545f78b35537a8cc54a8a11bf0c5aed9ae07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628330 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#664533}
-
Peter K. Lee authored
Bug: 965958 Change-Id: I1658084e1542a646f2c40fd9a46e60a8773aede3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631752 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#664532}
-
Min Qin authored
DownloadDriverImpl::IsReady() checks for whether all downloads are loaded or kUseInProgressDownloadManagerForDownloadService is enabled. However, if the flag is not enabled, we should still allow download service to work in reduced mode. This CL changes the logic to just check whether SimpleDownloadManagerCoordinator is initialized, so that in reduced mode only in-progress download manager initialization is needed. BUG=942770 Change-Id: I556b5ccffabcabb710ef81891b59108906a1ac00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635773Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#664531}
-
Matt Mueller authored
The "Time" ASN.1 structure from RFC 5280 is used in CRL processing as well. Rename the function to ReadUTCOrGeneralizedTime since ReadTime seems a little too ambiguous for a public function name. Bug: 749276 Change-Id: Ia8703cf8c937c96680a6dad3e7650e23fb239470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628392 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#664530}
-
Jon Mann authored
bug: 966270 Change-Id: Ie9f86852341bfb06568634140d7639517b15fe77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628220Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#664529}
-
David Bertoni authored
Chrome style forbids complex inline constructors and destructors. Bug: 966655 Change-Id: I77c38d7af6a0f4d1193569eaff18e9ee8700aa2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633409Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#664528}
-
Nick Harper authored
The domain meets all automated requirements, as tested by the hstspreload commandline tool. Change-Id: I87bec8c39c797b5fd5dff67004cc5cfb3c185181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635774 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#664527}
-
Haiyang Pan authored
Change-Id: I275ba2cdbb901f4fff0651f11dab08eacdc8c46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635865 Commit-Queue: Haiyang Pan <hypan@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#664526}
-
Scott Little authored
Bug: 937980 Change-Id: I4f6ffcc27f426541f68aef875ae89d4b65d2dd3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633596 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#664525}
-
Xiaoqian Dai authored
According to the mock, change the string "Request tablet site" to "Request mobile site". Bug: 953577 Change-Id: Ie037b06466db3bb73cc28edd409d939fb46522e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634713Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#664524}
-
Nico Weber authored
See "Does anyone use the 32-bit asan runtime on Windows?" on chromium-dev for Windows. (We sadly still need the 32-bit profile library, so the build script doesn't get any simpler.) We haven't supported 32-bit builds on linux in a while, so those libs should be safe to remove as well. If anyone needs these, shout and we can add them back. Also use ' instead of " for strings added in my previous change. Linux package size: 48.73MB -> 47.49MB; main build 3924 -> 3526 build steps. Windows package size 43.49MB -> 41.56MB; 32-bit compiler-rt build 207 -> 18 build steps. Bug: 959966 Change-Id: I8c326dab4e07df69ee734f6390cda7291bfd7642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635410 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#664523}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/16e6fd53a125..b3f82dddfc61 git log 16e6fd53a125..b3f82dddfc61 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 egdaniel@google.com Reland "Remove call to copy in GrcontextPriv read/write pixel calls." 2019-05-29 brianosman@google.com Interpreter: Matrix/Vector multiplication 2019-05-29 brianosman@google.com Interpreter: Support component-wise ops for matrices 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-29 reed@google.com rm dead code 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-29 herb@google.com Compare pixels for TypefaceWithNoPaths test 2019-05-29 michaelludwig@google.com Make stencilRect() in GrRTCPriv more flexible. 2019-05-29 brianosman@google.com Avoid SkTMax in sksl 2019-05-29 robertphillips@google.com Use GrGLGpu::createTextureImpl from w/in GrGLGpu::createBackendTexture 2019-05-29 reed@google.com simplify api to make encoder, use swscale for faster rgb->yuv Created with: gclient setdep -r src/third_party/skia@b3f82dddfc61 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I89085b7b7d87dad40682c7bb5856ad621f198f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635973Reviewed-by:
-
Jinsuk Kim authored
This CL addresses a TODO left in TabBrowserControlsOffsetHelper. The method is deleted, and call site uses the method of ChromeFullscreenManager directly. Bug: 966272 Change-Id: If1bf007e33da38444361d303fe8fa734749268ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630081Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#664521}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2d287c02ed32..095baa6e3666 Created with: gclient setdep -r src-internal@095baa6e3666 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I5b6ba63a7255bca1d88a679ddf746782fab39ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636129Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664520}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/29364a0595bc..d5f462c6ab22 git log 29364a0595bc..d5f462c6ab22 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 hliatis@google.com Fire VkFence in vkAcquireImageANDROID 2019-05-29 hliatis@google.com Fix memory leak in vkDestroyImage Created with: gclient setdep -r src/third_party/swiftshader@d5f462c6ab22 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/133520634,chromium:133346002 TBR=swiftshader-team+autoroll@google.com Change-Id: I3ba73fa4f9a6c0d3796797c9463ad2c9932be477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635976Reviewed-by:
-
Matt Menke authored
The destructor was checking that |spdy_session_request_map_| is empty. This used to be true, as |spdy_session_request_map_| used to just contain SpdySessionRequests, which are cancelled on request destruction. However, it now also contains callbacks used to delay redundant H2 connection requests, which have no cancellation semantecs, so there may be pending callbacks when the SpdySessionPool is destroyed. This CL fixes the DCHECK by just checking that there are no pending SpdySessionRequests. Bug: 966991 Change-Id: I5f8e36d62850ffab83db38742250fae8b6eefff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635437 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#664518}
-
Kyle Milka authored
This test didn't work properly as it was waiting for the MV tiles to be initialized with a single default shortcut but if the feature is enabled there should be two default shortcuts. Bug: 968073, 962558 Change-Id: Id69c1c4c6748067eacd776550aa87cd160cf7656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636391Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#664517}
-
Jacob DeWitt authored
Bring frame rate on debug builds for the input-selection.html webxr sample page with 2 controllers connected and the gamepad data table sections expanded from ~10fps to ~40fps by doing the following: 1) Update tables in-place instead of re-creating them on each frame. 2) Only update table data if something changed since the last update (instead of unconditionally updating the innerHTML every frame). 3) Only update tables once every 10 frames instead of every frame. 4) Don't create or update gamepad tables unless the related sections on the page are expanded. Those sections start as minimized. Bug: 967844 Change-Id: Ifb10fa3f20a781c5f01632c6b1e1d62e2dd0c04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634725 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#664516}
-
Ian Vollick authored
Dino tests have been moved to a separate DinoActivityTest. I've also disabled the currently broken safe browsing test. See crbug.com/947232 Bug: 968239 Change-Id: I546a464580a6b0d13fe9d568572486ab89ea62db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634426 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#664515}
-
Sam Goto authored
Handle the following scenarios: - One origin making multiple calls serially AND concurrently. - Two origins making multiple calls and SMSes being received out of order - SMSes timing out - Receiving unexpected SMSes To handle these scenarios, we introduce an observer list in SmsProvider which notifies OnReceive() and OnTimeout(). We make the SmsManagerImpl implement the mojom interface and an SmsObserver interface, keeping track of individual GetNextMessage() requests as well as observing events in the SmsProvider. A visualization of the architecture can be found here: Design Doc: https://docs.google.com/document/d/1TG7BzAPdt2DWNOmephxNf09kdzDKYq8l6Z126oSif8I/edit#heading=h.s84nhvrqhwl3 Bug: 670299, 960878 Change-Id: I71a3818e23dc620a2a762ac8e5d0583dbcdf9e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604055 Commit-Queue: Sam Goto <goto@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#664514}
-
Wez authored
Non-main threads now inherit the PT_GNU_STACK size by default, so DAV1D should be able to run correctly on them. Bug: 930300 Change-Id: I17dd7476dee7f839d5fd0c9035df2120377c9c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635970Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#664513}
-
Collin Baker authored
The new TabGroupId is backed by a base::Token so it can be meaningful across different sessions. This will simplify the sessions code. A new class is used for the ID instead of just a base::Token to avoid mixing it up with other base::Tokens and to avoid similar mechanical changes later on. Bug: 930991 Change-Id: Ib0869730bff26fe182a4cb9398f1bb643547b1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629043 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#664512}
-
Xianzhu Wang authored
In, https://chromium-review.googlesource.com/c/chromium/src/+/1614448, I mistakenly removed the TransformAccumulation parameter when TransformState::ApplyTransform() calls TransformState::Move() for 2d translations Bug: 968112 Change-Id: I1c628f3884f89f726a9fdc757e8db78469545c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635864Reviewed-by:
-
Tomasz Wiszkowski authored
This change updates the looks of the Answer- and Entity suggestions to match the design: http://docs/presentation/d/1uB8QFlhYqQetxNgJxucpKn-Eolx7CiqL88jGES_sjFk?pli=1#slide=id.g45b058cd36_0_146 http://docs/presentation/d/1uB8QFlhYqQetxNgJxucpKn-Eolx7CiqL88jGES_sjFk?pli=1#slide=id.g3ce78ec162_0_50 Bug: 930349 Change-Id: I7fa62d6349ee7b30b44a4c28a4a0dfd82e1f33ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632902 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#664510}
-
Sorin Jianu authored
A few changes to WTL were made, as described in the README.Chromium file. The changes include fixing compile-time issues such as semi-colon after the end of a namespace definition (error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]) and unused results due to calling ATLVERIFY in a couple of places (error: expression result unused [-Werror,-Wunused-value]). Also, changes in the include order in Chromium code were made to make WTL code compile by including base/win/atl.h before the ATL/WTL headers. I am landing the change without presubmit checks, as WTL code does not pass our presubmit checks. NOPRESUBMIT=true BUG=965788 Change-Id: I181f838d0ea2953dcffa3929ee833d4a8936dde3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623506 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#664509}
-
Ryan Hansberry authored
Add crbug component OS>Systems>Network>Bluetooth. Bug: None Change-Id: I9bbb1d575d78b04a30db5123b8673bb34d0179dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629434Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#664508}
-
