- 23 Jan, 2020 40 commits
-
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Iaa2165aa1be6a10a4466c794c0b034d9c06b0942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015558Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#734298}
-
Fergal Daly authored
This is accessed in a bunch of places include in the constructor where it passes through an extra call to render_manager that seems to be redundant. This is a no-op refactor that just tidies things a little. I'm open to better naming and docs. Change-Id: I954e9ecf46a77de7ea9528eb527c1204b9ada3cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010462 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#734297}
-
Xinghui Lu authored
On focus and password reuse pings are launched in M79. Make them enabled by default after M81. Bug: 995926 Change-Id: I7946a3885ec46e0c51aa72f5f00cd9eae12246c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015561Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734296}
-
Liquan (Max) Gu authored
This CL adds the ExpandablePaymentHandler experiment to the field trial testing. Since this would be enable the Expandable PH in CCT PH tests, this CL also force CCT PH Tests to not pick up the ScrollToExpandPaymentHandler flag. Server side Finch config: https://critique.corp.google.com/#review/290647947 Bug: 1037646 Change-Id: I3e18fbaa34334487cdc84119a46dad73c0a2e8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011293 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#734295}
-
David Bienvenu authored
Bug: 813093 Change-Id: I5a4cc0dd3959d6165b3bb9f76e27b1fba3a46e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008613 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Auto-Submit: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#734294}
-
Lijin Shen authored
Update AdaptiveToolbarTest to test whether bottom toolbar shows/hides correctly in tab switcher mode and landscape mode. Update BottomToolbarTest to test whether bottom toolbar shows correct buttons on various variations. Bug: 1008212 Change-Id: Ib910622b7e1e4bd50c3805141af784e405639b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006485 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#734293}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7d45184d4baa..8247ae787cc4 git log 7d45184d4baa..8247ae787cc4 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 syoussefi@chromium.org Manually roll spirv-headers 2020-01-22 syoussefi@chromium.org Add support for layout(early_fragment_tests) in; 2020-01-22 syoussefi@chromium.org Row-major test: Clarify std140's stride calculation 2020-01-22 syoussefi@chromium.org Add support for non-float mix 2020-01-22 courtneygo@google.com Update expectations after dEQP test fixes Created with: gclient setdep -r src/third_party/angle@8247ae787cc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1044061 Tbr: timvp@google.com Change-Id: I00622f4eeeccb4864f0e6805347ce9657d2d0bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015143Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734292}
-
Kunihiko Sakamoto authored
We plan to introduce behavior change for "font-display: optional" (crbug.com/1040632). This histogram would be useful to estimate potential impact of the change in existing sites. Bug: 1043737 Change-Id: Ifc613698631af4fe519966920307ca584bd23c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012379 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#734291}
-
Jon Mann authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/938e6c463847..9d7cd6e7198b $ git log 938e6c463..9d7cd6e71 --date=short --no-merges --format='%ad %ae %s' 2020-01-09 victorhsieh Convert boot lockbox responses to simple message 2020-01-08 yichengli system_api: u2f: Rename VerificationType enum values 2020-01-14 jonmann shill: Add support for retrieving WiFi credentials. 2020-01-13 matterchen system_api: Add ip field for cicerone service proto Created with: roll-dep src/third_party/cros_system_api Bug: 966270 Change-Id: Ie974e7f2e243a392b331c1e3f55ddcffb85e58fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015610Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#734290}
-
Robbie McElrath authored
This reverts commit 4e314eae. Reason for revert: Likely cause of Variations.SeedFreshness spike in canary. Original change's description: > [AW] Keep the VariationsSeedServer running while handling seed requests. > > This CL makes the IVariationsSeedServer.getSeed implementation start > (via Context.startService) the VariationsSeedServer on each call, and > stop it when all pending calls have completed. > > Normally services would stay alive by being bound while handling IPCs, > but VariationsSeedLoader unbinds from the service immediately after > calling getSeed, so it's possible for Android to kill the service before > getSeed has finished executing. Starting the service effectively makes > it manage its own lifecycle and ensure it stays running until it has > finished its work. > See https://developer.android.com/guide/components/bound-services > > We have no evidence that the service is actually being killed > prematurely in the wild since we have no way of detecting it, but this > is still a potential bug that should be fixed. > > Test: out/aw/bin/run_webview_instrumentation_test_apk -f \ > Test: 'VariationsSeedHolderTest#*' > Bug: 1040625 > Change-Id: I5c5b0fdfa4deb43bf69b5d56edf0273073d4b1be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995768 > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732984} TBR=changwan@chromium.org,ntfschr@chromium.org,rmcelrath@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1040625 Bug: 1044789 Change-Id: I0bddb4f466b32c5a2e1ae1f0a0a7067955a34506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015779 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#734289}
-
James Cook authored
We're still targeting M82, but if it slips to M83 then we won't want to clean up the flag until M84. Bug: none Change-Id: I5bf721beb684161ecc327e1f02cc95ba8ea9c0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015671Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#734288}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5e97ac9b. With Chromium commits locally applied on WPT: 0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams jsbell@chromium.org: external/wpt/IndexedDB external/wpt/encoding jsbell@chromium.org, mek@chromium.org: external/wpt/webstorage kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc mcasas@chromium.org: external/wpt/mediacapture-record meade@chromium.org: external/wpt/web-animations mek@chromium.org: external/wpt/webmessaging mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy mlamouri@chromium.org: external/wpt/mediasession msisov@igalia.com: external/wpt/webvtt raphael.kubo.da.costa@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I9abe263b4533219c9fd919379163098db0d3b2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014781Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734287}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a216865467dd..c040c8f85051 git log a216865467dd..c040c8f85051 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 thestig@chromium.org Clean up CPDF_TextPage. 2020-01-22 thestig@chromium.org Rename FPDF functions in cpdf_formfield.h. 2020-01-22 thestig@chromium.org Rename CPDF_TextPage's enum values to kFoo. 2020-01-22 thestig@chromium.org Git rid of FPDFText_Direction. 2020-01-22 thestig@chromium.org Rename enum class FPDFText_MarkedContent. 2020-01-22 thestig@chromium.org Rename FPDF_CHAR_INFO class to CPDF_TextPage::CharInfo. 2020-01-22 tsepez@chromium.org Tidy cfde_wordbreak_data.cpp 2020-01-22 thestig@chromium.org Run coverage.py with --no-component-view. 2020-01-22 tsepez@chromium.org Bounds check in GetWordBreakProperty() Created with: gclient setdep -r src/third_party/pdfium@c040c8f85051 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1043510 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ife40755f9b64b19135628feae01f4884b5bb9830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015457Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734286}
-
Lukasz Anforowicz authored
Bug: 1042836 Change-Id: Iac94fb45d747101d393769a3cd2280dd7ef548e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005379 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#734285}
-
Andrew Xu authored
This CL does the job similar to https://crrev.com/c/1996268 but particularly for display centering alignment. It ensures that the active window is animated to the final icon bounds when the scrollable shelf follows the display centering alignment. Bug: 1030819 Change-Id: Idd81ef831e427a2f6328720193d8eb1585c0d77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015404Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734284}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ca0dacbce51..2ea20eae785f git log 4ca0dacbce51..2ea20eae785f --date=short --first-parent --format='%ad %ae %s' 2020-01-22 jlavrova@google.com Another attempt to aling ellipsis behavior with TxtLib 2020-01-22 awscreen@chromium.org Update font descriptor selection workaround 2020-01-22 michaelludwig@google.com Add GM reproducing perspective failures 2020-01-22 mtklein@google.com extend -O1 hack to avx2 code as well 2020-01-22 benjaminwagner@google.com Revert "Revert "Revert "Complete rewrite of the SkSL interpreter""" 2020-01-22 ethannicholas@google.com let's see what happens 2020-01-22 ethannicholas@google.com derp 2020-01-22 ethannicholas@google.com test change 2020-01-22 ethannicholas@google.com removed extraneous change 2020-01-22 ethannicholas@google.com maybe fixed? 2020-01-22 ethannicholas@google.com Revert "Revert "Complete rewrite of the SkSL interpreter"" Created with: gclient setdep -r src/third_party/skia@2ea20eae785f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1018581,chromium:224618 Tbr: benjaminwagner@google.com Change-Id: If4c8d39edf7dc394c111fcaf381cebab97ba20e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015455Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734283}
-
Travis Skare authored
Bug: 1010802 Change-Id: Iffda0c3a6b9534d2902bf59f637044d3409dc7c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931597 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#734282}
-
Ian Struiksma authored
Some autofill tests were disabled by removing them from interactive_ui_tests because they were causing oft-flaky failures on Win7 bots in the waterfall. We'd still like theses tests to run on other Windows instances (where they don't appear to be flaky) so adding them back but including filtering via --test-launcher-filter-file argument. This disables tests of: AutofillDynamicFormInteractiveTest AutofillInteractiveTest For bots: Win 7 Tests x64 (1) Win7 Tests (1) Win7 tests (dbg)(1) Bug: 967588 Change-Id: I5d3b49b8212bec3680108238291700ee6910d933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014147 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#734281}
-
Will Cassella authored
This follows the same pattern as "core/css/BUILD.gn". Since the "html" folder already has its own "BUILD.gn" file for regular sources, the tests should go there as well. I initially wasn't sure if "html" had any tests (I was a bit shocked), until I found them in the parent file. Change-Id: I3f1bf3517ed7bfcf3c7c155fe878ae8df7f5a378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015776Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#734280}
-
Henrique Nakashima authored
This is a common dependency that should be available to all modules. TBR=twellington@chromium.org Bug: 1041468 Change-Id: Idbd04924ced7ee17ebac68b127b2a9d064cf0db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015612Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#734279}
-
Adenilson Cavalcanti authored
Fix use of uninitialized memory reported by oss-fuzz (and confirmed by valgrind@aarch64) by properly setting deflate_state internal member (i.e. s->prev) to a valid value before use. For details, see: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11360 Bug: 1032721 Change-Id: I6c7b2e87e81b8ccc6c39298fd3c704befd797b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015667 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#734278}
-
Tommy Nyquist authored
The inline update experiment data has shown that we want to use the best effort version of the feature config to be able to reach as many users as possible. This changes the default configuration to be the version without notifications, and using best_effort. Bug: 884914 Change-Id: Iccecb804bf21501640170343584666a9c1a07c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013814 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#734277}
-
matterchen authored
We want the GuestOS to have access to the same fonts as ChromeOS. To achieve this, on TerminaVM startup we will ask Seneschal to share the fonts directory with the VM. Tremplin will then share this with the container. ChromeOS VM Container /usr/share/fonts --> /mnt/shared/fonts --> /mnt/chromeos/fonts Relies-on: CL:1975215 Bug: chromium:903631 Test: Verifies it shares the font directory, test will come later Change-Id: Idcc321e7b14ee1b4535d9a6e6cdaeb051d8cb98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973490 Commit-Queue: Matthew Chen <matterchen@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#734276}
-
Alan Cutter authored
This CL is a data dependency refactor that makes ThemeService::UsingDefaultTheme() based on the current CustomThemeSupplier rather than prefs. This is in preparation to make ThemeService::GetColor() based on any CustomThemeSupplier instead of just the currently installed one. See follow up CL: https://chromium-review.googlesource.com/c/chromium/src/+/1994026/15 Bug: 1020050 Change-Id: If3bd87e16f6ccf034f4c4909c7f7ca940ee2f838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007800Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#734275}
-
Arthur Wang authored
R=harringtond@chromium.org Bug: 1044242 Change-Id: I5e7cd4285891420db66af423257ce7ee974e63a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013261 Commit-Queue: Arthur Wang <wuwang@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#734274}
-
Kyle Horimoto authored
In [1], treib@ suggested moving this to settings pref instead of including it within sync prefs. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1977956 Change-Id: Ide9c1c4e8b1ede12e3324db96db44293bc8ec703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008302 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#734273}
-
liberato@chromium.org authored
This CL also plumbs ukm::SourceId through BeginObservation, instead of CompleteObservation so that default target values work. Change-Id: I46d65c7ca539e2b97aabd36e9667f886bda57f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006114 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#734272}
-
John Lee authored
Bug: 1027373 Change-Id: I53cfa85c279e39c38b262234a14cbad4ac284cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012525 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#734271}
-
sangwoo authored
Casting it into boolean makes it impossible to tell Showing from Hiding Bug: NONE Change-Id: Iaca2ee9aea0c033186ad0107b6734921d7fb87e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010235Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#734270}
-
Alex Danilo authored
Bug: 1027012 Change-Id: I2f7dc9648295808ff9ca2d74af28ab7eb0f1bcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014218Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#734269}
-
Stefan Zager authored
This implements a behavioral change as described in: https://github.com/w3c/IntersectionObserver/issues/372 If the 'root' argument to the IntersectionObserver constructor is a Document, then the observer will clip to the Document's root scroller. For the top Document, this is the same behavior as the implicit root. For an iframe Document, this is new behavior which is unobtainable by other means. BUG=1015183 Change-Id: I234bfce28ab954bb15b8d157bc22ee2d2469d5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003750Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#734268}
-
Vasiliy Telezhnikov authored
This CL splits kVizForWebView feature flag into kVizForWebView and kVizFrameSubmissionForWebView. As we made decision to try reuse old path for frame submission the code that implements it needs to be under different flag. Bug: 805739 Change-Id: I0040cc0af8305d75612315967afa3bbf3915456a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015496Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#734267}
-
Ben Pastene authored
So it can be referenced from other build files. Namely, CrOS's toolchain can use it to set proper defaults: crrev.com/c/2015822. Bug: 937821 Change-Id: I5136ebf3b8c91295b7732a1f0225067d79bead59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014801Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#734266}
-
Jesse McKenna authored
This change replaces any '.' characters in a PWA launcher's filename with '_' on Windows 7 to prevent launchers from having misleading or potentially unsafe file extensions, such as those in net::IsShellIntegratedExtension(). This is largely a just-in-case measure added because a PWA launcher on Windows 7 has no extension. This change also simplifies the logic for legitimizing a reserved filename on Windows by prepending '_' rather than appending it. On Windows, each Progressive Web App (PWA) must have its own launcher in order for the PWA to be able to register as a handler for file types. On Windows 7, the filename of this launcher is used as the PWA's display name in the Open With menu, because Windows 7 lacks an alternate way to set multiple custom display names for one executable (and PWA launchers are identical copies of chrome_pwa_launcher.exe). The launcher filename is based on the PWA's name, with modifications to ensure the resulting filename is legitimate. These modifications are as follows: * Replace illegal characters with '_' * If filename is reserved on Windows: - OLD: + Append '_' + Replace all '.' with '_'; this was necessary because Windows' logic for checking reserved filenames views characters after '.' as file extensions, and only the pre-file-extension portion is checked for legitimacy (e.g. "nul" is reserved; "nul_" is allowed, but "nul.a_" is not). - NEW: + Prepend '_' * NEW: On Windows 7, replace all '.' with '_' Change-Id: Ibb2a183a8f023e5cbd98adb143e95551c49a1218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002982 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#734265}
-
Philip Rogers authored
We do not need to query PaintLayerCompositor to find out the setting for accelerated compositing. Bug: 1044674 Change-Id: I1d31fd9ab8767ffb3d0528520fb52f4ce57c7fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015300 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734264}
-
Khushal authored
This reverts commit d196259f. The error here was trying to delete a shared image created using a context before a GPU process crash. The service side considers an erroneous shared image deletion command as a fatal error which in turn destroys the new GpuChannel. This change now depends on a patchset which ensures that shared images are automatically deleted once a context is deleted avoiding the need for explicit deletion from the user. TBR=klausw@chromium.org R=kbr@chromium.org Bug: 1042446,1042481,1036142 Change-Id: I886460b8b1a62617ae987a1c96e0626fc3eb6e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008076 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734263}
-
wutao authored
This cl fixes a bug to stop logo view animation when the view is not drawn. Bug: 1044320 Test: manual Change-Id: Ifa8b3f8ae1cf2c66b58ff2ff778599263ade7166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015608Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#734262}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1bcbb571..a2e07326 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibf3e44c60c5fa98f1b338c95789ec3ccb262c365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014782Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734261}
-
Takumi Fujimoto authored
Relanding crrev.com/c/1955086 with a fix for crbug.com/1043484. The only difference from the original patch is in media_notification_service.cc where we now call WebContentsPresentationManager::RemoveObserver() from MediaNotificationService::Session::~Session() before an early exit, so that it always gets called. Original message: When a Cast session is initiated from a web page and the page doesn't get rid of its media session, we generally get duplicate media notification items: one for the sender page and the other from the receiver. This CL hides the former in such cases. Bug: 1038447 Change-Id: I09a074ec4d08a1c19dc21de925c1974b5f9f47dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013631Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#734260}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/56d4671ce783..6589db968634 git log 56d4671ce783..6589db968634 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 eseckler@google.com Merge "build: Don't propagate public_configs of proto_library targets" Created with: gclient setdep -r src/third_party/perfetto@6589db968634 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I421c25c4fb1bd12aaf6792123cfdcc6764e6288d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015008Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734259}
-