- 01 Dec, 2011 40 commits
-
-
stevenjb@chromium.org authored
Change-Id: I77a05a62fa652a1f79a536761c037cffc2d318bb BUG=chromium-os:103821 TEST=Make sure all chromeos tests and autotests run Review URL: http://codereview.chromium.org/8670001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112405 0039d316-1c4b-4281-b951-d872f2087c98
-
rnk@chromium.org authored
The issue is that these tests call LaunchUrlWithDelegate(), which sets g_accept_requests to false unconditionally. This can cause other tests, such as AutocompleteInput.InputType, to fail if run with different sharding or different ordering. The solution is to call PermitLaunchUrl() from the TearDown method, which resets g_accept_requests to true. R=benwells@chromium.org BUG=105574 TEST=Run unit_tests.exe with three shards and watch the DrMemory bots Review URL: http://codereview.chromium.org/8763006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112404 0039d316-1c4b-4281-b951-d872f2087c98
-
dpapad@chromium.org authored
BUG=101457 TEST=Select "None" in the margins drop-down. The headers/footers option should disappear. Select 'Default' or 'Custom', it should reappear. Review URL: http://codereview.chromium.org/8395006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112403 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
BUG=105971 TEST=no Review URL: http://codereview.chromium.org/8760010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112401 0039d316-1c4b-4281-b951-d872f2087c98
-
kushi.p@gmail.com authored
- the respective nibs now use Single Line Mode for title entry - BookmarkModel has been updated (with test cases) to strip extra whitespace for folder/bookmark titles. BUG=100618 TEST=BookmarkModelTest.AddURLWithWhitespaceTitle, BookmarkModelTest.AddFolderWithWhitespaceTitle, BookmarkModelTest.SetTitleWithWhitespace Review URL: http://codereview.chromium.org/8598015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112400 0039d316-1c4b-4281-b951-d872f2087c98
-
varunjain@chromium.org authored
* Add tooltip functionality to aura_shell that can be access through aura client API * Provide an implementation of views::TooltipManager for aura (TooltipManagerAura) that views can use to display/update tooltips in aura * Remove the no longer needed TooltipManagerViews. BUG=97249 TEST=none Review URL: http://codereview.chromium.org/8747022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112399 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
BUG=79050 TBR=jam Review URL: http://codereview.chromium.org/8758015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112398 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=105933 TEST=see bug. Review URL: http://codereview.chromium.org/8761014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112397 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
we decided to show "duplicate" items in the recently closed menu because they may not actually be duplicates. For example, they may have different history even if the url and title for the tab is the same. BUG=105760 TEST=none Review URL: http://codereview.chromium.org/8764013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112396 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
BUG=104535 TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/8762018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112395 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@chromium.org authored
BUG=none TEST=unit tests R=jbates@chromium.org Review URL: http://codereview.chromium.org/8756001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112394 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@chromium.org authored
Note: another CL will attempt to free the command buffer as well. Also note: I didn't want to change the function signature of GLES2Implementation as that would have been a much larger change. So, the startup code in renderer_gl_context.cc still creates the initial transfer buffer and info about that is passed into GLES2Implementation. A cleaner approach would probably have been to let GLES2Implemetation allocate the initial buffer but that's a much larger change. TEST=unit tests and ran Chrome testing a few pages and stepping in debugger. BUG=103989 R=apatrick@chromium.org Review URL: http://codereview.chromium.org/8536045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112393 0039d316-1c4b-4281-b951-d872f2087c98
-
lambroslambrou@chromium.org authored
This also removes the curtain-mode hooks from DesktopEnvironment and ChromotingHost. Me2Me hosts will no longer show the Disconnect or Continue windows. It2Me hosts should be unaffected, except for the removal of curtain-mode (which will be added back in a later CL). BUG=104377 TEST=Manual and unittests Review URL: http://codereview.chromium.org/8725016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112392 0039d316-1c4b-4281-b951-d872f2087c98
-
rbyers@chromium.org authored
BUG=88782 TEST=X509UtilNSSTest Review URL: http://codereview.chromium.org/8537025 TBR=mattm@chromium.org Review URL: http://codereview.chromium.org/8764017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112391 0039d316-1c4b-4281-b951-d872f2087c98
-
stevet@chromium.org authored
BUG=105542 TEST=Start a new user so you see the sync promo page. Sign into Sync. Check about:histograms and ensure that SyncPromo.MessageDisplayed and SyncPromo.MessageOnSignIn both have the same enum value recorded. Review URL: http://codereview.chromium.org/8689006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112388 0039d316-1c4b-4281-b951-d872f2087c98
-
rbyers@chromium.org authored
Touch-specific builds are being retired. Instead we want to be able to enable touch-friendly UI dynamically. For now I'm adding a --touch-optimized-ui flag which can be used to enable the touch-optimized CSS tweaks we've made to WebUI. This undoes the tweak to use the non-ChromeOS language UI for touch_ui builds. The conditional HTML for the add-language-overlay-page is non-trivial to convert to something dynamic - I'll do something in a separate changelist. Also fix a number of issues where overrides of WebUI virtuals (like RenderViewCreated) weren't properly delegating back to their base class (or were delegating to WebUI instead of the immediate base ChromeWebUI). Also removes the Touch-specific User-Agent string. BUG=105315 TEST= Review URL: http://codereview.chromium.org/8695007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112387 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
BUG=88782 TEST=X509UtilNSSTest Review URL: http://codereview.chromium.org/8537025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112385 0039d316-1c4b-4281-b951-d872f2087c98
-
saintlou@chromium.org authored
BUG=101025 TEST=none Review URL: http://codereview.chromium.org/8762012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112384 0039d316-1c4b-4281-b951-d872f2087c98
-
sail@chromium.org authored
This leak was fixed in r112297. BUG=105864 TEST= Review URL: http://codereview.chromium.org/8766002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112383 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112382 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
TEST=unit-tests BUG=105577 Review URL: http://codereview.chromium.org/8736001 TBR=georgey@chromium.org Review URL: http://codereview.chromium.org/8762016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112381 0039d316-1c4b-4281-b951-d872f2087c98
-
alicet@chromium.org authored
BUG= TEST= Review URL: http://codereview.chromium.org/8761010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112380 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
Also, fix a bug in the proxy (also for audio input) -- it should fail if the callback provided is null. Review URL: http://codereview.chromium.org/8749017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112379 0039d316-1c4b-4281-b951-d872f2087c98
-
mihaip@chromium.org authored
For now (on GTK only), "shell" windows are not drawn with a frame at all. R=miket@chromium.org Review URL: http://codereview.chromium.org/8734016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112378 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
Use a real flash url instead of local URL. Looks like exception formatting for local urls has changed or removed. R=dennisjeffrey@chromium.org BUG=105632,100595 TEST=pyauto test: plugins.PluginsTest.testBlockPluginException Review URL: http://codereview.chromium.org/8757011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112377 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
BUG=105999 TEST= TBR=rsimha Review URL: http://codereview.chromium.org/8763015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112376 0039d316-1c4b-4281-b951-d872f2087c98
-
zea@chromium.org authored
BUG=105139 TEST=trigger an error during model association, inspect about:sync to ensure line numbers are displayed in error message. Review URL: http://codereview.chromium.org/8637023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112375 0039d316-1c4b-4281-b951-d872f2087c98
-
jwd@chromium.org authored
BUG=102135 TEST=Have multiple profiles created. Go to "Personal Stuff" options. Delete one of the profiles from the list of profiles. The avatar for the profile being deleted should appear in the dialog. Review URL: http://codereview.chromium.org/8715009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112374 0039d316-1c4b-4281-b951-d872f2087c98
-
jvoung@google.com authored
until all the private IDL files can generate the correct .h files. BUG= none TEST= ./generator.py && ./generator.py --wnone --cgen --range=start,end --include_private --out private/ppb_flash_fullscreen.idl R=noelallen@chromium.org,piman@chromium.org Review URL: http://codereview.chromium.org/8760016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112373 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@chromium.org authored
shutting down if StartupTimeBomb is still Arm'ed. BUG=105475 R=jar TEST=browser unit tests Review URL: http://codereview.chromium.org/8728035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112372 0039d316-1c4b-4281-b951-d872f2087c98
-
sail@chromium.org authored
The sync confirmation bubble would show multiple times. Fix was to clear the NTP resource cache after the bubble was shown. BUG=103699 TEST=Verfied that without my patch the sync confirmation bubble would show up multiple times. Applied my patch and verified that the confirmation bubble only showed once. Review URL: http://codereview.chromium.org/8698010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112371 0039d316-1c4b-4281-b951-d872f2087c98
-
dpapad@chromium.org authored
BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/8662049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112370 0039d316-1c4b-4281-b951-d872f2087c98
-
sque@chromium.org authored
Part of libcros removal -- removing chromeos_screen_lock BUG=chromium-os:16559 TEST=Make sure screen lock/unlock works Signed-off-by:
Simon Que <sque@chromium.org> R=satorux@chromium.org,stevenjb@chromium.org Review URL: http://codereview.chromium.org/8664014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112369 0039d316-1c4b-4281-b951-d872f2087c98
-
sail@chromium.org authored
BUG=91241 TEST= Review URL: http://codereview.chromium.org/8743007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112368 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
Not sure what happened here, but I felt dirty when I checked that crx in the first time, so just removed it. BUG=105728 Review URL: http://codereview.chromium.org/8741004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112367 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
remove unused strings, and in one case start using an unused string (most visited delete tooltip) a couple of the strings may still used by touch ntp and in the bookmarks pane, but both of these are getting removed quite soon BUG=none TEST=compile and visual inspection Review URL: http://codereview.chromium.org/8746007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112366 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=98716 Review URL: http://codereview.chromium.org/8760012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112365 0039d316-1c4b-4281-b951-d872f2087c98
-
bbudge@google.com authored
requests don't fail. Re-enable cross-origin tests. BUG=103690 TEST=ui_tests, --gtest_filter=PPAPITest.URLLoader* Review URL: http://codereview.chromium.org/8692015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112364 0039d316-1c4b-4281-b951-d872f2087c98
-
ajwong@chromium.org authored
BUG=none TEST=existing Review URL: http://codereview.chromium.org/8537029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112363 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
BUG=none TEST=none R=groby@chromium.org Review URL: http://codereview.chromium.org/8734017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112362 0039d316-1c4b-4281-b951-d872f2087c98
-