- 06 Mar, 2019 40 commits
-
-
Kush Sinha authored
It was required that |IdentityManager::LegacySeedAccountInfo| be called before calling |chromeos::AccountManager::UpsertAccount| because Chrome OS Account Manager's |Observer|s needed to translate |chromeos::AccountManager::AccountKey| to other formats (raw email and canonical email) and relied on |AccountTrackerService| / |AccountMapperUtil| for doing so. This is no longer required: - Chrome OS Account Manager can now maintain the mapping from AccountKey to email id by itself (https://crrev.com/c/1452003) and can notify its |Observer|s about this information (https://crrev.com/c/1477691). All new account additions to Chrome OS Account Manager are now guaranteed to have an email id associated with them in Account Manager itself. - AccountMapperUtil has now been deleted (https://crrev.com/c/1483024). Hence, remove the temporal coupling between |IdentityManager::LegacySeedAccountInfo| and |chromeos::AccountManager::UpsertAccount| in all production call-sites. This seeding of AccountInfo will now be handled within |ChromeOSOAuth2TokenServiceDelegate::OnTokenUpserted|, just after the account gets added to |chromeos::AccountManager|. Bug: 922026 Change-Id: I77cdaa93ef34fc400f00a09aee8d9d847ef0fc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495551Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#638096}
-
Bryan McQuade authored
This implements support for tracking performance metrics for AMP documents loaded in subframes. This is something we'd wanted to implement but weren't sure how to implement. After discussion with AMP team we determined that we should take the following approach: * whenever the main frame URL gets updated with an AMP viewer URL (e.g. https://www.google.com/amp/...), we track that in OnCommitSameDocumentNavigation. we use the time of the main frame URL update as the baseline time from which the user-perceived performance metrics like FCP are computed. * whenever an iframe AMP document is loaded, we track that in OnDidFinishSubFrameNavigation. we also keep track of the performance timing metrics such as FCP reported in the frame. * we associate the main frame AMP navigation with its associated AMP document in an iframe by comparing URLs between the main frame and the iframe documents. * we record AMP metrics at the times when an AMP viewer URL is navigated away from. when a user swipes to change the AMP document, closes a tab, types a new URL in the URL bar, etc, we will record AMP metrics for the AMP doc in an iframe that the user is navigating away from. Change-Id: I08c36148907145ea89aa24652ed7efc9ed863757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500202 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638095}
-
Yi Su authored
This CL moves helper function "PreferredFontForTextStyleWithMaxCategory" from uikit_ui_util.mm to dynamic_type_util.mm, and adds some unittests. Change-Id: I08620274827845d58a9a4cced1c91b849c5da91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496857 Commit-Queue: Yi Su <mrsuyi@chromium.org> Auto-Submit: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#638094}
-
Ben Wagner authored
This allows gn to check FreeType includes. Change-Id: If9fe723e876e88164fa95191f8384d6805056b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504235 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#638093}
-
Boris Sazonov authored
If Mirror header has a service type GAIA_SERVICE_TYPE_SIGNUP or GAIA_SERVICE_TYPE_ADDSESSION, start an activity to add an account to the device. Bug: 938554 Change-Id: Ib2d77afaa3434941c0597026211fa3d03292e456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504016 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#638092}
-
Gyuyoung Kim authored
As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/scheduler with the macros of Allocator. After some analyzes, it was concluded that for the case of BudgetPool, DeadlineTaskRunner, FrameTaskQueueController, PageLifecycleStateTracker, RenderWidgetSignals, UserModel, Thread, PauseHandle, Builder, ThreadManager, Task, and ThreadPoolManager classes, they make sense to use USING_FAST_MALLOC because they have been used as a member variable with new() or smart pointers. In CancelableClosureHolder, ThreadLoadTracker, Policy, PendingUserInput, Monitor, PrioritizeCompositingAfterInputExperiment, QueueingTimeEstimator, RunningAverage, Calculator, TaskHandle, and SequenceManagerFuzzerProcessor classes, they make sense to use DISALLOW_NEW because they're used as member variable with a reference type. Lastly, the rest of classes this CL annotates make sense to use STACK_ALLOCATED. Bug: 919389 Change-Id: I0cd6908ae98b372ebf458bc94a5536f6f82c369d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504666 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#638091}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3e8a733a..79ffd9b5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I54fc5a30b14dd64e3685dbd88a12f3f7db4376da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504780Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638090}
-
v.paturi authored
The function ContainingNGBlockFlow() might return a nullptr. So add a null check before dereferencing the pointer returned by it. Bug: None Change-Id: Ib4c3f84166654ec7af3bc187190714f2c3ab2bee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505352Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#638089}
-
Raphael Kubo da Costa authored
Per the C++ standard, uintptr_t comes from <stdint.h>, so include it rather than relying on the header coming in implicitly. This fixes base_unittests's build with libstdc++, which was failing with errors such as In file included from ../../base/containers/vector_buffer.h:14, from ../../base/containers/vector_buffer_unittest.cc:5: ../../base/containers/util.h:13:15: error: ‘uintptr_t’ does not name a type; did you mean ‘u_int64_t’? static inline uintptr_t get_uintptr(const T* t) { ^~~~~~~~~ u_int64_t Bug: 819294 Change-Id: I68e8d5aac3918044a39b6f16fda4800a18ce74a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505554 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#638088}
-
Yi Su authored
This CL enables dynamic number of tiles per row for NTP. Now it will calculate the number of tiles per row based on the collectionView's width, the spacing between tiles, and the tile view's size which is decided by the font size. This CL also moves all tile view layout related helper functions to ios/chrome/browser/ui/ntp_tile_views/ntp_tile_layout_util.h&mm, so that they can be reused by omnibox pop shortcuts. Bug: 893523 Change-Id: I5be280f2adf2fd7c413f7e4e4bc34a84b5cc0b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499544Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#638087}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0b1b7431ea96..31e0aecb035f Created with: gclient setdep -r src-internal@31e0aecb035f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I14e6b3acf4c4cedf82aa8a0b1e7f9dc69ed347f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504986Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638086}
-
Jordan Demeulenaere authored
Change-Id: I89b17d286c9790912ecfa107bd4de0a6fb0ca65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503328 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#638085}
-
Lukasz Suder authored
* Updates Details with latest mocks * Fixes and enables missing placeholder animations Before: https://screenshot.googleplex.com/jChmwed1MXK.png After: https://screenshot.googleplex.com/oFbYWvbQPOd.png Bug: 806868 Change-Id: Ica15073b30e3ff4fbd959fa6e79f4defaba073d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503317 Commit-Queue: Lukasz Suder <lsuder@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#638084}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I11ddeb833b134c683193b4a1940ed3f730d8fd20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504984Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638083}
-
Marc Treib authored
It was already enabled by default; time to get rid of the old code. This also lets us remove many tests which were duplicated to cover both the enabled and disabled case. Bug: 935908 Change-Id: I274e86189637207cc72267a7ace4f1a911de2470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1430089 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638082}
-
Takashi Toyoshima authored
This is a follow-up for my last patch to modify how the class generate console logs, refs/heads/master@{#637638}. Bug: 936937 Change-Id: I74db0198180a222ab39ed347f1b9b3a5285540c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504659 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#638081}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/eb748c338927..c854c371c89b git log eb748c338927..c854c371c89b --date=short --no-merges --format='%ad %ae %s' 2019-03-06 fmayer@google.com Merge "E2E test in both fork and central mode." Created with: gclient setdep -r src/third_party/perfetto@c854c371c89b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iaff4fa0212f0f3f8559f3b560835d5c9421136d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504985Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638080}
-
Gauthier Ambard authored
Instead of setting the Mime type in decidePolicyForNavigationResponse, set it in didCommitNavigation. This is because the URL passed in the navigation response might not be the same as the pending one. Bug: 936750 Change-Id: I9b1dfcc78e1c5ab9265b2cec653c502e5d012d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503432Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#638079}
-
Abhijeet Kandalkar authored
blink::mojom::ConsoleMessageLevel and blink::MessageLevel are essentially the same enums and represent same values for logging. This CL replace use of blink::MessageLevel with blink::mojom::ConsoleMessageLevel. Bug: 937184 Change-Id: Ibc029cc89f4178b9be13d32bcda2bd83c1a59b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502315 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#638078}
-
Olya Kalitova authored
Bug: 938252 Change-Id: I34600b86d73a1bc8c1db04af717216e406e02af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503453Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#638077}
-
Gauthier Ambard authored
This CL format CRWWebController, cleaning up the pragma, make sure that the pragma for protocol are correctly named. It also removes the UIGestureRecognizerDelegate protocol which wasn't used and unnecessary synthesizes. Bug: 938255 Change-Id: I7e24a1b6545bd16cad22d93841bbb8701cc670e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503433Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#638076}
-
Matthew Cary authored
The previous registration in SetupMobileFieldTrials was too early; the g_browser_process is not initialized yet. This registration works. Bug: 932578 Change-Id: If45b6b88c1be4c1025f9ecd6ee8e5efc5685bc9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1473174Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Auto-Submit: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#638075}
-
Yoav Weiss authored
This CL is a refactor only with no functional change. It changes the finish_time variable into response_end to make it closer the what that value represents as part of the ResourceTiming entry. Change-Id: Ieca7843fcf1570b9a1ea3ba89ea6d3751529bae0 BUG: 938798 Change-Id: Ieca7843fcf1570b9a1ea3ba89ea6d3751529bae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503462 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#638074}
-
Jérôme Lebel authored
Bug: 889470 Change-Id: Id2d9309af28a82274c5041643763fce368fd26ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503756 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#638073}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/233178a15e11..0b1b7431ea96 Created with: gclient setdep -r src-internal@0b1b7431ea96 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I9315810656a28acc02498763ff16ff1e6a0928bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504983Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638072}
-
Olivier Robin authored
As a consequence of WebFrameMessaging, the initial processing of frames is asynchronous. Wait for it to happen in tests. Bug: 938837 Change-Id: I05a759ea17944f316a9a19999afd1cab4fe5a59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505532 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#638071}
-
dstockwell authored
Bug: 902646 Change-Id: If6f594535a1d1cdff19e441d0995d1ef57e22885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504670 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#638070}
-
Pavel Shmakov authored
Crash 1: https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BAndroid+Java+Exception%5D+java.lang.RuntimeException+at+org.chromium.chrome.browser.ChromeActivity.getFullscreenManager%28ChromeActivity.java%29%27+AND+product_name%3D%27Chrome_Android%27#-propertyselector,productname:1000,productversion:100,magicsignature:50,magicsignature2:50,stablesignature:50,magicsignaturesorted:50 Crash 2: https://crash.corp.google.com/browse?q=product_name%3D%27Chrome_Android%27+AND+product.version%3D%2773.0.3683.37%27+AND+expanded_custom_data.ChromeCrashProto.channel%3D%27beta%27+AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BAndroid+Java+Exception%5D+java.lang.IllegalStateException+at+org.chromium.chrome.browser.ChromeActivity.getFullscreenManager%28ChromeActivity.java%29%27 Plus potential similar crash in TWAs Bug: 938212 Change-Id: Icd183741ea042f7d4c491a4755acc7fd4aff5050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503256Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#638069}
-
Alex Clarke authored
We no longer need to split the lock in TaskQueueImpl. Change-Id: I05d1bc597f34fbe4a1a10ffc3a95fc451b72abc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504017 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638068}
-
Sylvain Defresne authored
Replace usage to instead use JSONReader::Read that returns a base::Optional<base::Value>. Bug: 925165 Change-Id: I31077cd95a605796ef5b08a7e6d1a963afdb1dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503752 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#638067}
-
Christian Dullweber authored
Describe which data types can be filtered by origin and how filtering works for cookies. Add an example of clearing all cookies and site data for a specific origin. Bug: 78093, 113621, 924113 Change-Id: Ib93e2ca9f8bf4a44893a9933f0b111ebc0560358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1451881 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Meggin Kearney <mkearney@chromium.org> Cr-Commit-Position: refs/heads/master@{#638066}
-
dstockwell authored
Bug: 902646 Change-Id: I8b7bb960a2cdc0a386b3a8518d20a9514c4d1eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501236 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#638065}
-
Robbie Gibson authored
There is now a shared class in ios/chrome/common (somewhere extensions can access) that does the same thing as CreateSameConstraints. We should use that instead. Also, we can get rid of unnecessary @synthesize and method prototypes. Bug: 938317 Change-Id: I54b7a3b855015c377ebdbb8c0be2d0e47698a811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503417 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638064}
-
Sylvain Defresne authored
Replace usage to instead use JSONReader::Read that returns a base::Optional<base::Value>. Also rename PaymentResponseToDictionaryValue after changing the return type to base::Value (to use the new API). Bug: 925165, 646113 Change-Id: Ie88068c76f810dff08e8ec36230d0154c6f9effa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503329 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#638063}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9384947f47f2..ed5dc24c07a3 git log 9384947f47f2..ed5dc24c07a3 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 tsepez@chromium.org Spin in CFGAS_FormatString::ParseNum. 2019-03-05 tsepez@chromium.org Make members private in CXFA_LayoutItem, adding accessors. 2019-03-05 thestig@chromium.org Minimize simple_xfa.pdf. 2019-03-05 thestig@chromium.org Fix error in testing/resources/xfa_catalog_1_0.fragment. 2019-03-05 tsepez@chromium.org Tidy cxfa_itemlayoutprocessor.h 2019-03-05 tsepez@chromium.org ExtractLayoutItem() breaks when current item found in old list. 2019-03-05 rycsmith@google.com Add GetNumberValue function to fpdf_annot. 2019-03-05 thestig@chromium.org Fail early for data matrix barcode input that is too long. 2019-03-05 thestig@chromium.org Add CBC_DataMatrixWriterTest tests for encoding limits. 2019-03-05 thestig@chromium.org Avoid nullptr crash in CJS_App::get_active_docs(). 2019-03-05 bungeman@google.com Roll third_party/freetype/src/ 6d65c60fc..31757f969 (2 commits) 2019-03-05 thestig@chromium.org Speed up DetermineConsecutiveDigitCount() in debug builds. 2019-03-05 manojb@microsoft.com Add tests for device to page and page to device coordinate conversions 2019-03-04 thestig@chromium.org Update Skia owner in the OWNERS file. 2019-03-04 thestig@chromium.org Roll tools/clang/ b23f5a073..257c91cc4 (9 commits) Created with: gclient setdep -r src/third_party/pdfium@ed5dc24c07a3 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:937799,chromium:b/127345911,chromium:930394,chromium:930394,chromium:937572,chromium:930394 TBR=dsinclair@chromium.org Change-Id: I08e30b280eab683713d0b33c0973e38ae8ef631e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504801Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638062}
-
Robbie Gibson authored
Bug: 938239 Change-Id: I8224e85f8c29d9610975fad88ae1cd7488c9d650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503316 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638061}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d36c08623d90..be7af9399ceb git log d36c08623d90..be7af9399ceb --date=short --no-merges --format='%ad %ae %s' 2019-03-06 yvesg@webrtc.org Add dsymutil as a mac cipd dependency. 2019-03-05 steveanton@webrtc.org Use metrics::Samples in a couple pc/ tests 2019-03-05 amithi@webrtc.org Adding metrics to measure usage of simulcast API. 2019-03-05 jakobi@webrtc.org Reland "Remove field trial include from decision logic." 2019-03-05 danilchap@webrtc.org Merge rtc_task_queue(_api|_impl)? build targets into one 2019-03-05 jakobi@webrtc.org Add relative_packet_arrival_delay and jitter_buffer_packets_received statistics. 2019-03-05 danilchap@webrtc.org Replace all usage of rtc::NewClosure with webrtc::ToQueuedTask 2019-03-05 steveanton@webrtc.org Add metrics::Samples to facilitate easier testing Created with: gclient setdep -r src/third_party/webrtc@be7af9399ceb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:780980,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icb740edb33b449f8c9e858eb79dd2b5fed2e851e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504734Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638060}
-
Vadym Doroshenko authored
This reverts commit 50b4e186. Reason for revert: It was incorrect suspicion, bot became green w/o this revert Original change's description: > Revert "[blink] Remove old script streamer thread" > > This reverts commit 96c748b0. > > Reason for revert: it's suspect in failures > https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/88931 > > Original change's description: > > [blink] Remove old script streamer thread > > > > The script streamer thread has now been replaced with posting tasks to > > the scheduler, so remove the flag picking between the two options and > > the dedicated streaming thread itself. > > > > Also, remove the streaming task re-posting now that the blocking/ > > non-blocking worker pools are merged. > > > > Bug: 874080 > > Change-Id: Ib9dabb91deddcc616d4edfe5efb13d8e584c0691 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503420 > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Reviewed-by: Steven Holte <holte@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#638031} > > TBR=kinuko@chromium.org,haraken@chromium.org,holte@chromium.org,mlippautz@chromium.org,leszeks@chromium.org > > Change-Id: Ia67f3fcfbff3155f9da4b53f371115f3dfd0089c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 874080 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505412 > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638055} TBR=kinuko@chromium.org,haraken@chromium.org,holte@chromium.org,dvadym@chromium.org,mlippautz@chromium.org,leszeks@chromium.org Change-Id: Ic4eb793dacdaa7565e92ba1b908162f5d3e02e15 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505552Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#638059}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7e11060d2bb..233178a15e11 Created with: gclient setdep -r src-internal@233178a15e11 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I7e20783971a127e219b9d9aa2356f2daca6590ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504802Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638058}
-
Clemens Arbesser authored
Before: https://screenshot.googleplex.com/TT263fQ8F11.png After: https://screenshot.googleplex.com/1scfPRBzvHn.png Bug: 806868 Change-Id: Ida45b7b36526ebfb4e4abf18876106c47324fbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503313Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#638057}
-