GitLab

BUG=466598

Review URL: https://codereview.chromium.org/1003113003

Cr-Commit-Position: refs/heads/master@{#320722}

Many methods in PasswordStore and its backends have a ScopedVector of password forms as an out-argument, into which they put retrieved credentials.
Ideally, those methods would return that vector instead, but that is often not possible, because they already return a bool flag of success.
Keeping the out-argument has one bad consequence: it is not clear, if the retrieved credentials are appended to the vector, or if they replace the contents of the vector.

It looks like those methods are fed empty vectors anyway, so it is natural to make that explicit. This CL adds comments stating that the vectors are erased before anything new is added to them, and also modifies the code to make sure that they are indeed erased, even in failure cases.

The CL also contains some related clean-ups, like moving static methods to anonymous namespace etc.

BUG=324291

Review URL: https://codereview.chromium.org/906973007

Cr-Commit-Position: refs/heads/master@{#320721}

This CL adds handling of the PageActionNotSupported exception for the
test to pass on systems with older browser versions, which does not
support drag gesture yet.

BUG=467090

Review URL: https://codereview.chromium.org/1007953002

Cr-Commit-Position: refs/heads/master@{#320720}

Cr-Commit-Position: refs/heads/master@{#320719}

BUG=467514
TBR=hcarmona@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1011753002

Cr-Commit-Position: refs/heads/master@{#320718}

Revert of Revert of Add WebSocketDispatcherHostTest.InvalidScheme (patchset #1 id:1 of https://codereview.chromium.org/1007263002/)

Reason for revert:
The breakage still persists https://crbug.com/467471 after the original CL was reverted.

Original issue's description:
> Revert of Add WebSocketDispatcherHostTest.InvalidScheme (patchset #3 id:40001 of https://codereview.chromium.org/1000883004/)
>
> Reason for revert:
> Speculatively revert for https://crbug.com/467471
>
> Original issue's description:
> > Add WebSocketDispatcherHostTest.InvalidScheme
> >
> > This is a regression test for
> > https://codereview.chromium.org/998173003/.
> >
> > BUG=466335
> >
> > Committed: https://crrev.com/6a8de59ae3ecd7b04bee2ddec89eb7075fbd1871
> > Cr-Commit-Position: refs/heads/master@{#320262}
>
> TBR=ricea@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=466335
>
> Committed: https://crrev.com/725e3aed98c2b8a22c17bfef078b9c7a20709e49
> Cr-Commit-Position: refs/heads/master@{#320704}

TBR=ricea@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466335

Review URL: https://codereview.chromium.org/1013663002

Cr-Commit-Position: refs/heads/master@{#320717}

Revert of Revert of Fix use-after-free in WebSocketHost::AddChannel() (patchset #1 id:1 of https://codereview.chromium.org/1006293002/)

Reason for revert:
The breakage still persists https://crbug.com/467471 after the original CL was reverted.

Original issue's description:
> Revert of Fix use-after-free in WebSocketHost::AddChannel() (patchset #3 id:40001 of https://codereview.chromium.org/998173003/)
>
> Reason for revert:
> Speculatively revert for https://crbug.com/467471
>
> Original issue's description:
> > Fix heap-use-after-free in WebSocketHost::AddChannel()
> >
> > WebSocketHost can be deleted in channel_->SendAddChannelRequest() and this
> > caused heap-use-after-free when |pending_flow_control_quota_| is accessed in
> > WebSocketHost::AddChannel().
> > This CL fixes it by posting OnFlowControl() with WeakPtr instead of calling
> > SendFlowControl() directly in WebSocketHost::AddChannel().
> >
> > BUG=466335
> >
> > Committed: https://crrev.com/d3a1d188162e45f75c87a218a70681c5d92139a8
> > Cr-Commit-Position: refs/heads/master@{#320260}
>
> TBR=ricea@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=466335
>
> Committed: https://crrev.com/4f078b9b59cbf2c1ea7098835c6488fa32d46474
> Cr-Commit-Position: refs/heads/master@{#320703}

TBR=ricea@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466335

Review URL: https://codereview.chromium.org/1014543002

Cr-Commit-Position: refs/heads/master@{#320716}

Revert of Revert of Per-renderer WebSocket throttling (patchset #1 id:1 of https://codereview.chromium.org/1009303002/)

Reason for revert:
The breakage still persists https://crbug.com/467471 after the original CL was reverted.

Original issue's description:
> Revert of Per-renderer WebSocket throttling (patchset #13 id:300001 of https://codereview.chromium.org/972963002/)
>
> Reason for revert:
> Suspected to have caused WebSocket breakage.
> Failure seen on apprtc.appspot.com and in browser_tests.  Run the manual MANUAL_WorksWithAppRTC test for repro.
>
> See https://code.google.com/p/chromium/issues/detail?id=467471&thanks=467471&ts=1426498439 for details.
>
> Original issue's description:
> > Per-renderer WebSocket throttling
> >
> > Design Doc:
> > https://docs.google.com/document/d/1aw2oN5PKfk-1gLnBrlv1OwLA8K3-ykM2ckwX2lubTg4/edit?usp=sharing
> >
> > BUG=459377
> >
> > Committed: https://crrev.com/58d344316cf2b2cc110619c0fea4979ef143b3a9
> > Cr-Commit-Position: refs/heads/master@{#320074}
>
> TBR=ricea@chromium.org,hiroshige@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=459377
>
> Committed: https://crrev.com/3464a08a0c157c57ea02881687f10058303de8ea
> Cr-Commit-Position: refs/heads/master@{#320705}

TBR=ricea@chromium.org,henrika@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459377

Review URL: https://codereview.chromium.org/1011743002

Cr-Commit-Position: refs/heads/master@{#320715}

Adobe test fails, Github test passes.

BUG=369521

Review URL: https://codereview.chromium.org/1007883002

Cr-Commit-Position: refs/heads/master@{#320714}

It can be flaky in other configurations as well

BUG=467483
TBR=nasko

Review URL: https://codereview.chromium.org/1007293002

Cr-Commit-Position: refs/heads/master@{#320713}

BUG=430400
TBR=enne@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1014533002

Cr-Commit-Position: refs/heads/master@{#320712}

When calling an sync method in a test, you need to wrap the passed
callback in continueTest that will call testDone if the callback stops
aunexpectedly. This makes developing easier since the tests report
immediately instead of having to wait for a timeout.

R=dtseng@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/938623003

Cr-Commit-Position: refs/heads/master@{#320711}

BUG=465863
TBR=noms@chromium.org, cpu@chromium.org

Review URL: https://codereview.chromium.org/1013613002

Cr-Commit-Position: refs/heads/master@{#320710}

TEST=run vaapi_h264_decoder_unittest on ozone/freon
BUG=none

Review URL: https://codereview.chromium.org/978263002

Cr-Commit-Position: refs/heads/master@{#320709}

When the tests determine, whether Chrome displayed a "save password" prompt appropriately (or saved automatically in the setting skipping the UI), it scrapes the password internals page for the corresponding ASK/SAVE message.

There is a delay between a new page loads and this message appears. Currently the tests wait max. 3 seconds until giving up. That breaks often.

This CL changes that to 15 seconds, curing some of the tests. Note that if the message is received earlier, the tests don't wait for the rest of the timeout, so this should not make the test duration unnecessarily longer.

BUG=369521
R=battre@chromium.org

Review URL: https://codereview.chromium.org/1009573003

Cr-Commit-Position: refs/heads/master@{#320708}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/59c7666..1ab2b16

TBR=

Review URL: https://codereview.chromium.org/1009863002

Cr-Commit-Position: refs/heads/master@{#320707}

Adding test for Vkontakte. Test passes.
Credential description string: test account for vk.com.

BUG=369521
R=vabr@chromium.org

Review URL: https://codereview.chromium.org/1005043002

Cr-Commit-Position: refs/heads/master@{#320706}

Revert of Per-renderer WebSocket throttling (patchset #13 id:300001 of https://codereview.chromium.org/972963002/)

Reason for revert:
Suspected to have caused WebSocket breakage.
Failure seen on apprtc.appspot.com and in browser_tests.  Run the manual MANUAL_WorksWithAppRTC test for repro.

See https://code.google.com/p/chromium/issues/detail?id=467471&thanks=467471&ts=1426498439 for details.

Original issue's description:
> Per-renderer WebSocket throttling
>
> Design Doc:
> https://docs.google.com/document/d/1aw2oN5PKfk-1gLnBrlv1OwLA8K3-ykM2ckwX2lubTg4/edit?usp=sharing
>
> BUG=459377
>
> Committed: https://crrev.com/58d344316cf2b2cc110619c0fea4979ef143b3a9
> Cr-Commit-Position: refs/heads/master@{#320074}

TBR=ricea@chromium.org,hiroshige@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459377

Review URL: https://codereview.chromium.org/1009303002

Cr-Commit-Position: refs/heads/master@{#320705}

Revert of Add WebSocketDispatcherHostTest.InvalidScheme (patchset #3 id:40001 of https://codereview.chromium.org/1000883004/)

Reason for revert:
Speculatively revert for https://crbug.com/467471

Original issue's description:
> Add WebSocketDispatcherHostTest.InvalidScheme
>
> This is a regression test for
> https://codereview.chromium.org/998173003/.
>
> BUG=466335
>
> Committed: https://crrev.com/6a8de59ae3ecd7b04bee2ddec89eb7075fbd1871
> Cr-Commit-Position: refs/heads/master@{#320262}

TBR=ricea@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466335

Review URL: https://codereview.chromium.org/1007263002

Cr-Commit-Position: refs/heads/master@{#320704}

Revert of Fix use-after-free in WebSocketHost::AddChannel() (patchset #3 id:40001 of https://codereview.chromium.org/998173003/)

Reason for revert:
Speculatively revert for https://crbug.com/467471

Original issue's description:
> Fix heap-use-after-free in WebSocketHost::AddChannel()
>
> WebSocketHost can be deleted in channel_->SendAddChannelRequest() and this
> caused heap-use-after-free when |pending_flow_control_quota_| is accessed in
> WebSocketHost::AddChannel().
> This CL fixes it by posting OnFlowControl() with WeakPtr instead of calling
> SendFlowControl() directly in WebSocketHost::AddChannel().
>
> BUG=466335
>
> Committed: https://crrev.com/d3a1d188162e45f75c87a218a70681c5d92139a8
> Cr-Commit-Position: refs/heads/master@{#320260}

TBR=ricea@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466335

Review URL: https://codereview.chromium.org/1006293002

Cr-Commit-Position: refs/heads/master@{#320703}

PermissionMessageProvider:
- add GetPermissionMessageStrings which calls either the old or the new system, based on a field trial
- rename GetWarningMessages/GetWarningMessagesDetails to *Legacy*
- replace GetPermissionMessages by GetLegacyPermissionMessageIDs -> remove the old PermissionMessages type from the interface

Callers have *not* been updated to use the new GetPermissionMessageStrings yet.

TBRing trivial change in ephemeral_app_launcher.cc
TBR=asargent@chromium.org

BUG=398257

Review URL: https://codereview.chromium.org/1006453002

Cr-Commit-Position: refs/heads/master@{#320702}

Cr-Commit-Position: refs/heads/master@{#320701}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c76ff46..59c7666

TBR=

Review URL: https://codereview.chromium.org/1010683002

Cr-Commit-Position: refs/heads/master@{#320700}

Add a new method to the QuicUnackedPacketMap to stop retransmitting
stream frames for a given stream.

Will be wired up so that data will not be restransmitted for a stream
that is reset. No behavior changes in this CL.

Merge internal change: 88162937
https://codereview.chromium.org/1008593005/

Create a TcpCubicSender in QUIC that tracks the congestion window in
bytes, instead of packets.

Merge internal change: 88159377
https://codereview.chromium.org/1009023002/

Remove FLAGS_quic_enable_pacing flag now that pacing is on by default
globally.

Merge internal change: 88152071
https://codereview.chromium.org/1006113002/

Plumb through sent/received CachedNetworkParamaters to populate
TransportConnectionStats.

Merge internal change: 88144945
https://codereview.chromium.org/1010463002/

QUIC - Initialize QuicConfig's negotiated_value_ to 0. IMO, it is not
necessary to initialize it (could calm some compiler warnings??).

Minor change to fix compiler warnings in chromium.

Merge internal change: 88129037
https://codereview.chromium.org/1008473003/

Create a QUIC connection option to set the min CWND to 1 packet instead
of 2 in TcpCubicSender.

Merge internal change: 88045604
https://codereview.chromium.org/1001933003/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/1014433002

Cr-Commit-Position: refs/heads/master@{#320699}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/86da700..c76ff46

TBR=

Review URL: https://codereview.chromium.org/997873006

Cr-Commit-Position: refs/heads/master@{#320698}

Depends on https://codereview.chromium.org/914363003/

BUG=260022, 350202

Review URL: https://codereview.chromium.org/959013002

Cr-Commit-Position: refs/heads/master@{#320697}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4ccc888..86da700

TBR=

Review URL: https://codereview.chromium.org/1013563003

Cr-Commit-Position: refs/heads/master@{#320696}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1615271..4ccc888

TBR=

Review URL: https://codereview.chromium.org/1012563002

Cr-Commit-Position: refs/heads/master@{#320695}

readability.

This also replaces the CryptoUtils::Perspective enun.

Merge internal change: 88006458

R=rch@chromium.org

Review URL: https://codereview.chromium.org/1009543004

Cr-Commit-Position: refs/heads/master@{#320694}

This is a prerequisite for the Blink-side CL:
  https://codereview.chromium.org/1012473002/

R=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/1009763002

Cr-Commit-Position: refs/heads/master@{#320693}

This is a useful class in media playback tests.

BUG=147963

Review URL: https://codereview.chromium.org/985863003

Cr-Commit-Position: refs/heads/master@{#320692}

This CL adds a new parameter to WebContents::DownloadImage() to indicate
whether the request should bypass the cache.

BUG=455383
TEST=FaviconTabHelperTest.ReloadIgnoringCache

Review URL: https://codereview.chromium.org/934693002

Cr-Commit-Position: refs/heads/master@{#320691}

Currently, if a RenderFrame is deleted before the
ExchangeServiceProviders message is received in the renderer, the
message pipe handles contained in that message are retained, waiting for
a RenderFrame that has already been deleted. This changes
RenderThreadImpl::PendingRenderFrameConnect to detect when the browser
closes its handles to those message pipes and clean itself up when that
occurs.

BUG=457722

Review URL: https://codereview.chromium.org/1005893002

Cr-Commit-Position: refs/heads/master@{#320690}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8c6a977..19c25f1

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/997873005

Cr-Commit-Position: refs/heads/master@{#320689}

BUG=392620

Review URL: https://codereview.chromium.org/1003063003

Cr-Commit-Position: refs/heads/master@{#320688}

BUG=
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1012533002

Cr-Commit-Position: refs/heads/master@{#320687}

WebRTC 8699:8724
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/44373d2..bccd5aa

Libjingle 8700:8725
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/226ac7b..98747d0

TBR=

Review URL: https://codereview.chromium.org/1011573003

Cr-Commit-Position: refs/heads/master@{#320686}

This CL lands the test images for https://codereview.chromium.org/934693002/

BUG=455383
TEST=None
TBR=sky

Review URL: https://codereview.chromium.org/1005403002

Cr-Commit-Position: refs/heads/master@{#320685}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dd1bddd..1615271

TBR=

Review URL: https://codereview.chromium.org/1008223002

Cr-Commit-Position: refs/heads/master@{#320684}

Cr-Commit-Position: refs/heads/master@{#320683}