GitLab

When downloading a url, the state of the BackgroundDownloader must be
reset.

A better solution later on would be implementing a BitsFetcher that can
only do one download, similar to UrlFetcher. This avoids the situation
when dirty state post-download is carried over to a subsequent
download.

BUG=304354

Review URL: https://codereview.chromium.org/102993014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242108 0039d316-1c4b-4281-b951-d872f2087c98

Accidentally didn't check in the latest patch of this changeset.

> Omnibox: Bug Fixes for Shortcuts Inlining
> 
> Precisely, fixes up URL-like inputs before comparing to the shortcuts
> fill_into_edit in order to better determine inlineability.
> 
> This is especially useful for inputs such as about: which need to have
> their scheme fixed up to be recognized as comparable to chrome://
> shortcuts.
> 
> BUG=328220
> 
> Review URL: https://codereview.chromium.org/108643003

TBR=mpearson@chromium.org

Review URL: https://codereview.chromium.org/106573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/106793011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=261628

Review URL: https://codereview.chromium.org/98643008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242100 0039d316-1c4b-4281-b951-d872f2087c98

This adds a new enum value to Policy.AssociationState, indicating that
the server side dropped the client from management. The association
state is now also surfaced in the Status line in about:policy.

BUG=chromium:329834

Review URL: https://codereview.chromium.org/117253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242099 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=329295

Review URL: https://codereview.chromium.org/113203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242096 0039d316-1c4b-4281-b951-d872f2087c98

The reasons for the move are:

- it's actually a blink embedder, so it can't use blink/wtf types
- it can't use base either
- we want to replace CppBoundClass with gin::Wrappable, not possible in blink

In the first step, this is mostly a 1:1 copy (except for include paths).
Follow-up CLs will move the test plugin and layout tests helpers and
clean up the coding style

BUG=324658
R=abarth@chromium.org, maruel@chromium.org, torne@chromium.org, jam@chromium.org
TBR=torne@chromium.org

Review URL: https://codereview.chromium.org/110533009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242095 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313751
R=glider@chromium.org
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/105213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242093 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242092 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/107803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242091 0039d316-1c4b-4281-b951-d872f2087c98

DialServiceImpl now binds to all ipv4 interfaces instead of just the first ipv4 found. Dedup is done using address family + interface index.
It now also checks if there are any other open sockets when notifying observers on error and sends a different error code (DIAL_SERVICE_NO_INTERFACES instead of the usual DIAL_SERVICE_SOCKET_ERROR) if there are no other open sockets. The error codes are treated the same upstream currently. Later we should make sure DIAL_SERVICE_SOCKET_ERROR doesn't clear the device list.

Added unit tests for multiple interfaces and open sockets checking.

TEST=unit tests, did some manual testing at the lab.

Review URL: https://codereview.chromium.org/117853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242090 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242089 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318770, 313751
R=glider@chromium.org,thakis@chromium.org,bradnelson@chromium.org,darin@chromium.org,phajdan@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240682

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241574

Review URL: https://codereview.chromium.org/75213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242088 0039d316-1c4b-4281-b951-d872f2087c98

See the associated BUG for the detailed reproducing steps. This CL is to
stop handling such shared files as errors and starts storing them in
local metadata.

BUG=326043

Review URL: https://codereview.chromium.org/119823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242087 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242086 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164197:164221&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/117763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242085 0039d316-1c4b-4281-b951-d872f2087c98

Fixed the incorrect referrer handling in r242082

> Revert 241876 "Add a check that we don't send a secure referrer ..."
> 
> This change looks like it broke ReferrerPolicyTest.History
> 
> > Add a check that we don't send a secure referrer to an insecure URL
> > 
> > Unless one of the non-default referrer policies is set, this should
> > never happen.
> > 
> > BUG=none
> > R=mef@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/115803003
> 
> TBR=jochen@chromium.org
> 
> Review URL: https://codereview.chromium.org/118473005

TBR=courage@chromium.org

Review URL: https://codereview.chromium.org/118293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242084 0039d316-1c4b-4281-b951-d872f2087c98

The context menu of applist button should create by its ShelfItemDelegate.

R=jamescook@chromium.org
BUG=NONE
TEST=manual test

Review URL: https://codereview.chromium.org/119643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242083 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=kouhei@chromium.org

Review URL: https://codereview.chromium.org/119083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242082 0039d316-1c4b-4281-b951-d872f2087c98

ChangeListLoader::LoadIfNeeded()'s only user in the production code is FileSystem::LoadDiretoryIfNeeded().
It means that only test related code is passing empty DirectoryFetchInfo for LoadIfNeeded().

Move FileSystem::LoadDirectoryIfNeeded() to ChangeListLoader.
Merge LoadIfNeeded() to LoadDirectoryIfNeeded().
Add LoadForTesting() for the sake of test code.

BUG=260526
TEST=unit_tests

Review URL: https://codereview.chromium.org/118993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242081 0039d316-1c4b-4281-b951-d872f2087c98

Run these tests with both hardware and software compositing. When
software compositing is enabled for a browser test, it also sets
appropriate command line flags to ensure the renderer is software
composited and the ui compositor is single-threaded.

R=piman@chromium.org
BUG=327508

Review URL: https://codereview.chromium.org/116893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242080 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes it possible to build libwebp without runtime neon detection/usage.

Review URL: https://codereview.chromium.org/95873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242079 0039d316-1c4b-4281-b951-d872f2087c98

This also updates the base GN build to stay in sync with the GYP one.

Review URL: https://codereview.chromium.org/115723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242078 0039d316-1c4b-4281-b951-d872f2087c98

We can use a WebContent to open a new tab instead of a Browser.

TEST=unit_tests --gtest_filter=TranslateBubbleViewTest.*

Review URL: https://codereview.chromium.org/106793006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242077 0039d316-1c4b-4281-b951-d872f2087c98

Previously the animation of progress items is broken and sometimes we cannot
detect the end of animation. This causes to remain the completed progress item.

The root cause is the progress track's width becomes 100% before the animation
starts. The ProgressCenterPanel is passed the reference of ProgressItem, and
refers it in a callback function, where the item value can be updated.

This CL make the ProgressCenterPanel save the item value in a local variable and
refer the variable in a callback function.

BUG=329400
TEST=Create 5 file and 5 directory, delete them in debug build.

Review URL: https://codereview.chromium.org/93633009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242076 0039d316-1c4b-4281-b951-d872f2087c98

ChangeInputMethodInternal called by EnableLayouts checks if component_extension_ime_manager_ is initialized or not.  When it is not initialized, active_input_method is not updated even if the new input method is a keyboard layout.

This patch checks if the new input method is a keyboard layout or not too.

BUG=329061

Review URL: https://codereview.chromium.org/118273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242075 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329832

Review URL: https://codereview.chromium.org/113673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242074 0039d316-1c4b-4281-b951-d872f2087c98

R=jochen@chromium.org
BUG=324225

Review URL: https://codereview.chromium.org/107083006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242073 0039d316-1c4b-4281-b951-d872f2087c98

This renames *OnFileThread methods to *OnFileTaskRunner because now they run
not on FILE thread but on file_task_runner. And also adds some DCHECK for
checking valid task_runner into SandboxFileSystemBackendDelegate.


BUG=n/a
TEST=n/a
TBR=michaeln@chromium.org,phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/101393006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242072 0039d316-1c4b-4281-b951-d872f2087c98

DevTools window: split width and height are gone, and instead
contents insets are introduced. These insets are used for layout
in browser window. Having insets instead of rect allows for faster
regular-case resize occuring immediately in layout:
we keep DevTools of the same size and resize the page contents.

Views: removed SplitView and ContentsContainer, but instead added
ContentsLayoutManager which layouts DevTools and page contents taking
insets into account. It also supports active top margin, moved from
ContentsContainer.

Mac: removed NSSplitView, but instead added DevToolsContainerView
which resizes subviews manually taking page insets into account.

Gtk: removed both contents_vsplit and contents_hsplit, but instead
added devtools_floating_container which positions page contents
taking insets into account.

Next step will remove dock side knowledge from the browser, and leave it
on frontend only.

BUG=318751

Review URL: https://codereview.chromium.org/63173016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242071 0039d316-1c4b-4281-b951-d872f2087c98

Plugin windows are redrawn after EndDeferWindowPos call anyway.
Redrawing in SetWindowRgn causes plugin windows to be drawn on browser chrome.

BUG=

Review URL: https://codereview.chromium.org/118163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242070 0039d316-1c4b-4281-b951-d872f2087c98

This is the first part of the CL that will enable re-sending feedback reports that were sent when the user was offline, across sessions.

R=jcivelli@chromium.org, zork@chromium.org
BUG=249853

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241962

Review URL: https://codereview.chromium.org/116863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242069 0039d316-1c4b-4281-b951-d872f2087c98

Fix some tests that fail when it is enabled.

BUG=326832

Review URL: https://codereview.chromium.org/110913009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242068 0039d316-1c4b-4281-b951-d872f2087c98

Update CRAS unittests to pass the new audio log factory argument introduced
to AudioManager's constructor to make media_unittests compile again.

BUG=None
TEST=Build media_unittests for CrOS, run CRAS tests.

Review URL: https://codereview.chromium.org/116653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242067 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329978
TEST=none
R=aedla@chromium.org,palmer@chromium.org

Review URL: https://codereview.chromium.org/115733009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242066 0039d316-1c4b-4281-b951-d872f2087c98

We use a custom state machine to handle animations during drag and drop. The
state machine expects continuous callbacks from the NSDraggingDestination, even
if the mouse isn't moving. We were not providing continuous callbacks.

BUG=132850
TEST=manual

Review URL: https://codereview.chromium.org/109693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329756
TEST=Verified in sandbox.

Review URL: https://codereview.chromium.org/103163009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242064 0039d316-1c4b-4281-b951-d872f2087c98

HttpByteRange by its nature represents ranges in inclusive format.
We should avoid using it during computation that might involve
empty ranges. In the old code, [0-*].ComputeBounds(0) was failing.

BUG=329328

Review URL: https://codereview.chromium.org/93883006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242063 0039d316-1c4b-4281-b951-d872f2087c98

This is an attempt to fix flaky page scroll unittests in win aura.

BUG=328970
BUG=323249
BUG=297960

Review URL: https://codereview.chromium.org/117333006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242062 0039d316-1c4b-4281-b951-d872f2087c98

Activity in Native Client plugins results in IPC messages 
sent to the BrowserPpapiHostImpl and routed to call 
extensions::ProcessManager::KeepaliveImpulse. 

Testing patch, builds on implementation. See: 
https://codereview.chromium.org/61063003/ Implementation.
https://codereview.chromium.org/105873003/ Cumulative patch. 

Design doc: 
https://docs.google.com/a/chromium.org/document/d/1mI0lS1rfAf-BAGLmWAEcWy37Xq9dOvgfMx8OqeUMXts/edit# 

BUG=298339

Review URL: https://codereview.chromium.org/111563006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242061 0039d316-1c4b-4281-b951-d872f2087c98