GitLab

TBR=satorux@chromium.org
BUG=chromium-os:32464
TEST=

Review URL: https://chromiumcodereview.appspot.com/10736023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146053 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=ran chromeos_unittests


Review URL: https://chromiumcodereview.appspot.com/10704118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146052 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE


Review URL: https://chromiumcodereview.appspot.com/10413036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146051 0039d316-1c4b-4281-b951-d872f2087c98

Original codereview at http://codereview.chromium.org/10766016/

[Sync] Add location parameter to SyncChange in Sync API.

SyncChanges now require the location they were created as a parameter. This
is then used in the case that the change violates and invariant. We display
the location and type of erroneous change in about:sync, in addition to
disabling the offending datatype.

TBR=stevet@chromium.org, rlarocque@chromium.org
BUG=135108
TEST=unit_tests


Review URL: https://chromiumcodereview.appspot.com/10690128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146050 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146049 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10698143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146048 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10692150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146047 0039d316-1c4b-4281-b951-d872f2087c98

gdata: Move GDataFileSystem::AddUploadedFile() call out of uploader and into GDataDownloadObserver class.

The async GDataFileSystem::AddUploadedFile() call causes the file to be moved to the gdata cache. This must be invoked after DownloadObserver receives the COMPLETE status notification.

BUG=136435
TEST=unit_tests, lumpy

Review URL: https://chromiumcodereview.appspot.com/10759007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146046 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136474
TEST=./build/android/run_tests.py -s out/Release/base_unittests_apk/base_unittests-debug.apk -e 1


Review URL: https://chromiumcodereview.appspot.com/10692132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146045 0039d316-1c4b-4281-b951-d872f2087c98

It's possible client returns buffer after cached_dibs_ are freed.
Also fix a copy&paste error.

BUG=133096
TEST=the pages in bug 133096 do not crash.
Review URL: https://chromiumcodereview.appspot.com/10748018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146044 0039d316-1c4b-4281-b951-d872f2087c98

Contributed by fengx.dai@intel.com

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10695095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146043 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10703130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146042 0039d316-1c4b-4281-b951-d872f2087c98

The MessagePumpLibeventTest.StopWatcher and MessagePumpLibeventTest.DeleteWatcher
use fd 0, which is not permitted in apk test while calling 'epoll_ctl', and cause
failure on Android. Fix this by using fd created from pipe.

Also remove them from Android disabled case list.

BUG=None
TEST=base_unittests


Review URL: https://chromiumcodereview.appspot.com/10698112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146041 0039d316-1c4b-4281-b951-d872f2087c98

Favicon updates are per-url, and originate from a different thread. It's possible
by the time we receive an update notification we've already deleted that bookmark,
and should handle that situation gracefully.

BUG=121587
TEST=


Review URL: https://chromiumcodereview.appspot.com/10696163

TBR=zea@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10694126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146040 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
Review URL: https://chromiumcodereview.appspot.com/10545021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146039 0039d316-1c4b-4281-b951-d872f2087c98

Make eventArgumentMassagers asynchronous so custom bindings don't need to override chrome.Event.prototype.dispatch.


BUG=121479


Review URL: https://chromiumcodereview.appspot.com/10704073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146038 0039d316-1c4b-4281-b951-d872f2087c98

It turns out we had two bugs in our non-HTTP code path:
  1) Connection retries used the wrong start callback, which caused the loader to never get created
  2) The start position for non-HTTP resources is kPositionNotSpecified, which caused us to report [-1, file size) instead of [0, file size) for buffered status

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10698139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146035 0039d316-1c4b-4281-b951-d872f2087c98

Complete the TODO for native unittests apk to place used
jars into ${out.dir}/java/libs. Add the conditional check
if there is no jar in that directory.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10701113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146034 0039d316-1c4b-4281-b951-d872f2087c98

Use this flag for the period of migration from Document List API
to Drive v2 API for file browser / filesystem APIs etc.
Code for using this flag will follow separately.

BUG=chromium:127728
TEST=compile

Review URL: https://chromiumcodereview.appspot.com/10753024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146033 0039d316-1c4b-4281-b951-d872f2087c98

Favicon updates are per-url, and originate from a different thread. It's possible
by the time we receive an update notification we've already deleted that bookmark,
and should handle that situation gracefully.

BUG=121587
TEST=


Review URL: https://chromiumcodereview.appspot.com/10696163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146032 0039d316-1c4b-4281-b951-d872f2087c98

Rename it so it can contain code to set other power manager settings,
not just for screen locker.

BUG=chromium-os:32240
TEST=Build successfully.

Change-Id: I412b775c8679386262791e84e0b2575fe182872a
Signed-off-by: Simon Que <sque@chromium.org>

R=stevenjb@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10689101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146031 0039d316-1c4b-4281-b951-d872f2087c98

ShutdownTest.SimpleWindowClose

BUG=136644
TEST=
TBR=ananta

Review URL: https://chromiumcodereview.appspot.com/10703136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146030 0039d316-1c4b-4281-b951-d872f2087c98

On android, ENABLE_THEMES and ENABLE_PROTECTOR_SERVICE are not defined.
This fixes some link errors for unit_tests.

BUG=117407
TEST=

Review URL: https://chromiumcodereview.appspot.com/10704148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146028 0039d316-1c4b-4281-b951-d872f2087c98

Previous fix r144228 does not fix the crash. It seems the crash is more likely
to be caused by user closing the app window in a nested message that runs by
synchronous session restore. Add an WebContentsCloseObserver to monitor the app
contents and skip focusing logic if it is closed.

BUG=134478
TEST=Verify the crash in 134478 no longer happens.


Review URL: https://chromiumcodereview.appspot.com/10700145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10690081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146026 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10692146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146025 0039d316-1c4b-4281-b951-d872f2087c98

If we call DoSeek() without a demuxer we've clearly got issues as we shouldn't be seeking without a demuxer so crashing is preferable.

BUG=none
TEST=none
TBR=acolwell

Review URL: https://chromiumcodereview.appspot.com/10694125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135487
TEST=alt [ and alt ] won't do anything in fullscreen mode.


Review URL: https://chromiumcodereview.appspot.com/10700151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146023 0039d316-1c4b-4281-b951-d872f2087c98

Bug=None
Test=Compiles
R=ben,oshima
TBR=sadrul

Review URL: https://chromiumcodereview.appspot.com/10696130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146022 0039d316-1c4b-4281-b951-d872f2087c98

remove autofill impl from upstream

Autofill involves calls to native view, so the dependency is not correct.
If we want to upstream autofill_external_delegate_android, we have to introduce another delegate.
Remove the code from upstream for now.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10701058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134821, 134820
TEST=both base_unittests:FileUtilTest.*, VerifyPathControlledByUserTest.* and unit_tests:Gdata* pass

Review URL: https://chromiumcodereview.appspot.com/10756020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146020 0039d316-1c4b-4281-b951-d872f2087c98

This removes the dependency in chrome/browser/ui/views/web_dialog_view.h from
chromeos.

BUG=125846
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10695122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146019 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125875
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10758015

TBR=varunjain@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10694121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146018 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146017 0039d316-1c4b-4281-b951-d872f2087c98

We were expecting to receive GTK+ events in the following order:
  drag-motion
  drag-data-received
  drag-leave
but in some cases, we don't get the drag-data-received event (e.g.,
if the user is moving the mouse quickly). If that happens, don't send
a DragLeave event to the renderer since it doesn't think we're in a
drag.

BUG=129446
TEST=Open 2 chrome windows, quickly drag a file from the desktop over both
  windows. This should not crash.


Review URL: https://chromiumcodereview.appspot.com/10704144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146016 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10695135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146015 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10681003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146014 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10689149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146013 0039d316-1c4b-4281-b951-d872f2087c98

The crashes that it was hoped this patch would prevent didn't stop, and the actual bug was fixed in r145842.

BUG=136232
TBR=kalman@chomium.org

Review URL: https://chromiumcodereview.appspot.com/10701134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146012 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125875
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10758015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146011 0039d316-1c4b-4281-b951-d872f2087c98