GitLab

These are designed to give us more information about production-only
crashes occurring in ChromeAppSorting. These checks should help narrow
down the times at which extension_scoped_prefs_ is null.

Added TODOs to remove most of the checks later (although I plan to leave
one in as a safeguard).

BUG=476648

Review URL: https://codereview.chromium.org/1055453007

Cr-Commit-Position: refs/heads/master@{#326746}

In the PasswordFormManager::OnRequestDone method, I found some usage of
raw pointers to elements of a ScopedVector with confusing ownership over
a lot of code. Rewrote the code to use scoped_ptrs so that the ownership
is always clear, and nothing needs to be manually deleted.

BUG=451018

Review URL: https://codereview.chromium.org/1094013002

Cr-Commit-Position: refs/heads/master@{#326745}

This is possible now that the data deps handling bug has been rolled.

BUG=477104

Review URL: https://codereview.chromium.org/1095873003

Cr-Commit-Position: refs/heads/master@{#326744}

These strings should only be included if enable_media_router is true.

Review URL: https://codereview.chromium.org/1105663003

Cr-Commit-Position: refs/heads/master@{#326743}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d641e95..2de4669

TBR=rjwright@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1099963005

Cr-Commit-Position: refs/heads/master@{#326742}

In Async readback if the requested readback format is not supported.
Then fallback to RGBA_8888 format.

Removed RenderWidgetHostViewAndroid::PreferredReadbackFormat() API

Review URL: https://codereview.chromium.org/1095993002

Cr-Commit-Position: refs/heads/master@{#326741}

- Remove unused friendliness
- Remove DCHECK and if-statement combination forbidden by our coding standard
http://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED-
- Make some instance variables const

BUG=n/a
TEST=n/a

Review URL: https://codereview.chromium.org/1100003005

Cr-Commit-Position: refs/heads/master@{#326740}

This makes it explicit why server_ip is blank when the connection was
proxied, so we can tell when it's blank because of a bug instead.

BUG=

Review URL: https://codereview.chromium.org/1088933007

Cr-Commit-Position: refs/heads/master@{#326739}

BUG=475699
TEST=None

Review URL: https://codereview.chromium.org/1085703002

Cr-Commit-Position: refs/heads/master@{#326738}

BUG=none
TEST=run closure compiler

Review URL: https://codereview.chromium.org/1104463004

Cr-Commit-Position: refs/heads/master@{#326737}

Fix bugs related to the latest GN roll.

1) the new GN binary will return an error if you pass it
a file it doesn't know anything about in 'gn refs'.

2) for some reason with the new GN binary we're triggering a
code path in gyp_flag_compare.py that wasn't running before,
and that code path was busted.

TBR=brettw@chromium.org
BUG=
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_rel

Review URL: https://codereview.chromium.org/1109453002

Cr-Commit-Position: refs/heads/master@{#326736}

No behavioral change.

BUG=none

Review URL: https://codereview.chromium.org/1104543006

Cr-Commit-Position: refs/heads/master@{#326735}

BUG=466848

Review URL: https://codereview.chromium.org/1060033003

Cr-Commit-Position: refs/heads/master@{#326734}

BUG=466848

Review URL: https://codereview.chromium.org/1101593003

Cr-Commit-Position: refs/heads/master@{#326733}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bbf1039..d641e95

TBR=rjwright@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1102853002

Cr-Commit-Position: refs/heads/master@{#326732}

BUG=480534

TBR=sievers@chromium.org

Review URL: https://codereview.chromium.org/1097153003

Cr-Commit-Position: refs/heads/master@{#326731}

Exclude MSE_ClearKey/EncryptedMediaTest.Playback_AudioClearVideo_WebM/0 under DrMemory for flakiness.

BUG=480750
TBR=prabhur@chromium.org

Review URL: https://codereview.chromium.org/1105793003

Cr-Commit-Position: refs/heads/master@{#326730}

BUG=480521

Review URL: https://codereview.chromium.org/1102793003

Cr-Commit-Position: refs/heads/master@{#326729}

BUG=478340
TEST=manually

Review URL: https://codereview.chromium.org/1101843003

Cr-Commit-Position: refs/heads/master@{#326728}

This converts the PrefSyncStatus enum which is passed at registration time of
a syncable pref into a more general "registration flags" mechansim for prefs.
PrefRegistrationFlags is an enum used in a bitmask to indicate different
options which can be passed when registering a pref.

Subclasses of PrefRegistry can use the first 8 bits of PrefRegistrationFlags
to specify their own flags. These are used by PrefRegistrySyncable to
specify whether or not the pref is syncable.

In a subsequent CL we plan to add a flag to indicate whether the pref is
"lossy" (see the bug linked).

BUG=476800

Review URL: https://codereview.chromium.org/1096833003

Cr-Commit-Position: refs/heads/master@{#326727}

BUG=474195
TEST=manually

Review URL: https://codereview.chromium.org/1071283003

Cr-Commit-Position: refs/heads/master@{#326726}

TBR=reveman@chromium.org
BUG=480741

Review URL: https://codereview.chromium.org/1093693007

Cr-Commit-Position: refs/heads/master@{#326725}

1. Initialize |next_keyframe_at_| to 0, so that the expected sequence will be i * |keyframe_period_|.
2. Update |next_keyframe_at_|, when a key frame is arrived at the requested window. Other key frames should be ignored.

BUG=470775
TEST=Run the binary on Samus and Peach-Pit

Review URL: https://codereview.chromium.org/1056133009

Cr-Commit-Position: refs/heads/master@{#326724}

An apk may provide instrumentation for itself or another apk. When
providing instrumentation for another apk, the target for that apk
should be added to the android_apk() target as apk_under_test. This
ensures that the instrumentation apk is built correctly.

TBR=yfriedman@chromium.org
BUG=359249

Review URL: https://codereview.chromium.org/1072193011

Cr-Commit-Position: refs/heads/master@{#326723}

R=phajdan.jr@chromium.org
BUG=479509

Review URL: https://codereview.chromium.org/1061983006

Cr-Commit-Position: refs/heads/master@{#326722}

BUG=480340
TEST=manually

Review URL: https://codereview.chromium.org/1101073002

Cr-Commit-Position: refs/heads/master@{#326721}

R=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/1109443002

Cr-Commit-Position: refs/heads/master@{#326720}

This prevents unit tests from finishing earlier than they are supposed to.

BUG=480657

Review URL: https://codereview.chromium.org/1079483006

Cr-Commit-Position: refs/heads/master@{#326719}

Make sure the expiration value of an SSL certificate is correctly
displayed in an interstitial.

BUG=476758

Review URL: https://codereview.chromium.org/1072913003

Cr-Commit-Position: refs/heads/master@{#326718}

ActionBarActivity was deprecated in AppCompat 22.1.0.
This CL renames all usages of ActionBarActivity in Chrome.

BUG=479858

Review URL: https://codereview.chromium.org/1095553005

Cr-Commit-Position: refs/heads/master@{#326717}

Revert of Roll GN (via buildtools) 321178:326666 (patchset #2 id:20001 of https://codereview.chromium.org/1082813004/)

Reason for revert:
Caused gyp_flag_compare failure on Linux GN bots.

BUG=480739

Original issue's description:
> Roll GN (via buildtools) 321178:326666
>
> This picks up the changes for 'gn help all' and
> the markdown docs, fixes a bug related to the
> transitive propagation of public_deps across
> shared objects, and includes a speculative fix
> for the WriteFile() failures we're seeing on
> Windows.
>
> TBR=brettw@chromium.org
>
> Committed: https://crrev.com/a21c4f2acc0b7b97a65c3c145361aed55c53f769
> Cr-Commit-Position: refs/heads/master@{#326704}

TBR=brettw@chromium.org,dpranke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1095553006

Cr-Commit-Position: refs/heads/master@{#326716}

This regressed after switching the PDF plugin to be a BrowserPlugin. It is safe
to open files that load in BrowserPlugin plugins because they are all sandboxed.

BUG=479049

Review URL: https://codereview.chromium.org/1095083003

Cr-Commit-Position: refs/heads/master@{#326715}

R=thestig@chromium.org
BUG=none
TEST=no unsafe way to use base::File

Review URL: https://codereview.chromium.org/1103733002

Cr-Commit-Position: refs/heads/master@{#326714}

Revert of Fetch OAuth2 tokens prior to profile creation. (patchset #7 id:140001 of https://codereview.chromium.org/1097663003/)

Reason for revert:
Caused browser_tests failure.

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/1403/steps/browser_tests

Original issue's description:
> Fetch OAuth2 tokens prior to profile creation.
>
> BUG=470984
> TEST=
>
> Committed: https://crrev.com/163a4a63af5e56801395eed067a69e501e7b51a5
> Cr-Commit-Position: refs/heads/master@{#326691}

TBR=xiyuan@chromium.org,nkostylev@chromium.org,achuith@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=470984

Review URL: https://codereview.chromium.org/1102863002

Cr-Commit-Position: refs/heads/master@{#326713}

Since PermissionsData was returning a const & to a scoped_refptr in the
permission accessors, the auto lock wasn't sufficient. Adjust so that a regular
scoped_refptr is returned.

BUG=465185

Review URL: https://codereview.chromium.org/1057753003

Cr-Commit-Position: refs/heads/master@{#326712}

BUG=480721
TBR=amistry@chromium.org

Review URL: https://codereview.chromium.org/1108493002

Cr-Commit-Position: refs/heads/master@{#326711}

These conditions are coming from windows.update API.
- minimized with 'focused'.
- maximized, fullscreen with 'not-focused'
- Having bounds with minimized, maximized, fullscreen state.
- panel type with minimized, maximized, fullscreen state.

BUG=459841
TEST=browser_tests --gtest_filter=ExtensionWindowCreateTest.*

Review URL: https://codereview.chromium.org/1055933009

Cr-Commit-Position: refs/heads/master@{#326710}

GetKnownTimezoneOrNull() is supposed to find a matching timezone entry
to an input tz id in the CrOS tz list.  When looking for a match, the
canonical ids have to be taken into account.

Note: This CL started as a speculative fix to bug 466014, but
I couldn't verify that it fixes the bug on CrOS. It does fix the bug
when I tested 'Chrome with cros=1' on Linux (i.e. stub implementation.)
with tz changed on Linux.

BUG=466014
TEST=manual: see the bug

Review URL: https://codereview.chromium.org/1082323003

Cr-Commit-Position: refs/heads/master@{#326709}

Revert of mac: Weakly link against the CoreBluetooth framework. (patchset #2 id:80001 of https://codereview.chromium.org/1101513003/)

Reason for revert:
The GN file wasn't formatted correctly.

http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/8764/steps/compile/logs/stdio

Original issue's description:
> mac: Weakly link against the CoreBluetooth framework.
>
> In the OSX 10.10 SDK, CoreBluetooth became a top level framework. Previously,
> it was nested in IOBluetooth. In order for Chrome to run on OSes older than OSX
> 10.10, the top level CoreBluetooth framework must be weakly linked.
>
> BUG=463170
>
> Committed: https://crrev.com/9fde3e00865650009c7e85fcb7157719372b97a8
> Cr-Commit-Position: refs/heads/master@{#326705}

TBR=rsesek@chromium.org,keybuk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=463170

Review URL: https://codereview.chromium.org/1065453003

Cr-Commit-Position: refs/heads/master@{#326708}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5e6fb43..bbf1039

TBR=rjwright@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1094743004

Cr-Commit-Position: refs/heads/master@{#326707}