GitLab

This patch changes |SetSelectionToDragCaret()| to utilize early-return style
to reduce indentation for improving readability.

This is 3/3 of series of patches:
 1. http://crrev.com/c/This patch
 2. http://crrev.com/c/1153070
 3. This patch

Change-Id: Ib8c95fc4d027ce7633c9d69ef7bef0554503744c
Reviewed-on: https://chromium-review.googlesource.com/1153071
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579677}

Bug: 869240
Change-Id: Ie5350b73b21bf94912fea292261b4dea7382c511
Reviewed-on: https://chromium-review.googlesource.com/1157728
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579676}

Fix links to *.{h,cc} files.

TBR=rakina

Bug: 742715
Change-Id: I13df9ba392405dfdba37d12279b98dccc35be1a2
Reviewed-on: https://chromium-review.googlesource.com/1157736Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579675}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1aefad2a5982..6f812e132d25


git log 1aefad2a5982..6f812e132d25 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 ehmaldonado@chromium.org metrics: Separate metrics collection and print notice logic.


Created with:
  gclient setdep -r src/third_party/depot_tools@6f812e132d25

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:868280
TBR=agable@chromium.org

Change-Id: I2372686119cd531c28d4aa1c947f20242b5493ba
Reviewed-on: https://chromium-review.googlesource.com/1157485Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579674}

This reverts commit 2dbd1cd1.

Reason for revert: The crash still exists with or without the workaround on M70. Re-adding the workaround brings M69 and M70 to the same code, so that the future fix in M70 will be easy to merge to M69.

Original change's description:
> service worker: Remove workaround for ServiceWorkerObjectHost crash.
> 
> Since issue 864731 was fixed in r576288, this workaround is no longer
> needed.
> 
> Bug: 854993
> Change-Id: I789dfb18cdb82ec51aa0ce5185586163c92269ec
> Reviewed-on: https://chromium-review.googlesource.com/1147889
> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
> Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577435}

TBR=falken@chromium.org,bashi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 854993
Change-Id: Idb68e5d11c8b14da4dfee6d2fb484cc13be72501
Reviewed-on: https://chromium-review.googlesource.com/1157665Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579673}

This is for more than 30 mins compile steps like below builds.

3098s https://ci.chromium.org/b/8939533321978115792
2795s https://ci.chromium.org/b/8939589875030577488
2665s https://ci.chromium.org/b/8939589087341023936
2577s https://ci.chromium.org/b/8939542011766010016

Bug: 804251
Change-Id: I54121207009b07e65686c9415c0bc7f31e929e6c
Reviewed-on: https://chromium-review.googlesource.com/1155277Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579672}

Add "Slots and node assignments" section.

TBR=rakina

Bug: 742715
Change-Id: I4e5ad0da310c186643ce42695459a17d1a853654
Reviewed-on: https://chromium-review.googlesource.com/1157732Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579671}

This reverts commit 1edc413f.

Reason for revert: the test added by this (CustomFrameViewAshTest.ActiveStateOfButtonMatchesWidget)
has been super flaky on linux-chromeos-rel right after this was added.

Some builds:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11360
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11361
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11363

Original change's description:
> OopAsh: port/enable some more browser tests.
> 
> Bug: 854704
> Change-Id: Ic3dcef42f108beb02a398302f3ecd70dd72c0f2d
> Reviewed-on: https://chromium-review.googlesource.com/1153777
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579476}

TBR=sky@chromium.org,estade@chromium.org

Change-Id: I33d224561923905ceaabe67a57cec6c78c0b104c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 854704
Reviewed-on: https://chromium-review.googlesource.com/1157844Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579670}

Looks like they're flaky (in viz_content_browsertests).

TBR=niklase

Bug: 869723
Change-Id: I8c2ea517fddfddb3f664107d0dc237fc3579c704
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1157733
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579669}

This is to generate reproducible binary between commits for Linux by giving use_dummy_lastchange=true in args.gn.

This CL makes binaries independent from commit hash at least for below (time consuming) targets on Linux.
* content_unittests
* interactive_ui_tests
* content_shell (for webkit_layout_tests)
* content_browsertests
* browser_tests

If we can generate deterministic binary, test execution on build bot can be cached. And it will improve CQ cycle time.
But we don't know how often we make changes not introducing functional change in binaries.
So this CL is mainly for getting some stats from test on Linux buildbot and evaluate whether it is better to go forward or not for other platforms.

See more backgrounds here.
https://docs.google.com/document/d/16dalG0ssugZlwc7BBzUoBQUmuqM0S_gwtG2uxL0htdw/edit#

TBR: pfeldman@chromium.org
Bug: 869348
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1b351b2135fd5e749ed575484b2182e847a420c9
Reviewed-on: https://chromium-review.googlesource.com/1151169
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579668}

https://webrtc.googlesource.com/src.git/+log/68be5dab98f6..1a9c02850686


git log 68be5dab98f6..1a9c02850686 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 buildbot@webrtc.org Roll chromium_revision 19a9e3bb..bf3721ae (579465:579581)


Created with:
  gclient setdep -r src/third_party/webrtc@1a9c02850686

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I4ba5b0467dea560766a281ba38510f19055a8c64
Reviewed-on: https://chromium-review.googlesource.com/1157624Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579667}

LayoutSelection::ClearSelection() is called while
LayoutObject::RemoveChildNode() to clear LayoutObject references in
LayoutSelection and selection painting.
However, my preceding patch(crrev.com/c/1125709) changed the selection algorithm
where LayoutSelection didn't keep the references and the function now
do nothing.

This patch simply removes relevant function calls.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I74b15b6139959b26f2a00ab5402c53f19f22be3a
Reviewed-on: https://chromium-review.googlesource.com/1154777
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579666}

The builders have been renamed, so we can remove all the references to
the old names.

Bug: 867725
Change-Id: I30e93d563348d297e4916d1268adeb1c7cdae307
Reviewed-on: https://chromium-review.googlesource.com/1157344Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579665}

Account for file changes in tcmalloc 2.7.

BUG=724399,b:70905156

Change-Id: I7a831684d5ddbd26f9906876e8df2a412a482454
Reviewed-on: https://chromium-review.googlesource.com/1130775Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579664}

In this CL updating:
 - chrome://history
 - chrome://print
 - chrome://settings

This adds some additional size to the binary, since both Polymer 1 and 2 HTML
bundles are included. This is temporary and the Polymer 1 version will be
removed once the migration is completed

Bug: 862472
Change-Id: Ia77a01b730630ab04a34483c7f0a53358501ceed
Reviewed-on: https://chromium-review.googlesource.com/1155834
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579663}

The containing block of a float is the containing *block*,
meaning that it is an actual block and therefore does not include
inlines. This means that floats and positioned elements can have
mutually inconsistent containing block chains. Example:

<div id=root>
  <span style='position: relative'>
    <div style='float: left'>
       <span style='position: absolute'></span>
    </div>
  </span>
</div>

In this example, the containing block of the abs-pos span
is the rel-pos span. However, the containing block of the float
is the root element. Therefore the containing block chains
mutually cross each other.

Other than floats, containing blocks do not have this behavior.
IOW if there are no floats, and ContainingBlock(A) = B, then
for any element C between A and B in the DOM parent chain, B is
in its containing block chain.

Bug: 823748

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4038aa6db33af53b04721760d6ee32904ac7a727
Reviewed-on: https://chromium-review.googlesource.com/1156136Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579662}

In this CL updating:
 - chrome://bookmarks
 - chrome://downloads
 - chrome://extensions

This adds some additional size to the binary, since both Polymer 1 and 2 HTML
bundles are included. This is temporary and the Polymer 1 version will be
removed once the migration is completed

Bug: 862472
Change-Id: I55e0edbd4e9269432e2494aadb3d0abae146b43b
Reviewed-on: https://chromium-review.googlesource.com/1155827
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579661}

To support deprecating the AudioParam value setter in favor of
setValueAtTime, some methods were added.  The deprecation has happened
and these are no longer needed.

Bug: 764396
Test: 
Change-Id: I6e296e17582a078cacc01f91fb56af812079db38
Reviewed-on: https://chromium-review.googlesource.com/1157213Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579660}

https://skia.googlesource.com/skia.git/+log/f107a2fd014c..c1de8bd2ba3b


git log f107a2fd014c..c1de8bd2ba3b --date=short --no-merges --format='%ad %ae %s'
2018-07-31 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-07-31 reed@google.com remove conditional flags for sksg -- not needed for a module
2018-07-31 ccameron@google.com Revert "Disable GPU clip masks"
2018-07-31 bungeman@google.com Remove SK_IGNORE_SUBPIXEL_EMOJI_FIX.
2018-07-31 bbaren@google.com Set `-Wno-implicit-fallthrough` when building for iOS
2018-07-31 herb@google.com Move path leaf loop to drawer
2018-07-31 jcgregorio@google.com Use a larger machine for our cloud build.


Created with:
  gclient setdep -r src/third_party/skia@c1de8bd2ba3b

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I4837df136528e38677251f555a51eaaeedc6a663
Reviewed-on: https://chromium-review.googlesource.com/1157625Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579659}

https://chromium.googlesource.com/angle/angle.git/+log/8c1508bc0b4f..ac43aaa2c2e1


git log 8c1508bc0b4f..ac43aaa2c2e1 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 jmadill@chromium.org Refactor client check from ValidateDrawAttribs.


Created with:
  gclient setdep -r src/third_party/angle@ac43aaa2c2e1

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: Ib8a9f08bd794a1b3b01de79e2e8f484cee7d2305
Reviewed-on: https://chromium-review.googlesource.com/1157487Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579658}

This patch may have been leading to regressions in memory on Windows.
Temporarily disabling mip map generation to test whether this is the
culprit.

R=khushalsagar

Bug: 867468
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I74467e2f620ecb15af86a6a82c6b772d03c739d1
Reviewed-on: https://chromium-review.googlesource.com/1157273Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579657}

Framebuffers are a DRM-master specific object, so move them out out of
GbmBuffer. This makes GbmBuffer independent enough of the DRM modesetting
code that we can merge it with GbmBoWrapper.

Bug: 869206

Change-Id: I4ae6e1191ef115a4aa58b1c7ccb9f19e06de28aa
Reviewed-on: https://chromium-review.googlesource.com/1155918
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579656}

Bug: 868117
Change-Id: I15aae661ae200ec858e6886be718eaa55ff3266a
Reviewed-on: https://chromium-review.googlesource.com/1152231
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579655}

Introduces the mojo IDL and implementation "glue" to be able to create
overlays to be rendered on top of each video frame captured by a
FrameSinkVideoCapturer. This allows for use cases like mouse cursor
rendering and debug status displays. Also, the new overlay APIs have
been added to ClientFrameSinkVideoCapturer (a client-side wrapper that
handles the auto-reconnecting-to-VIZ after a VIZ process crash).

Bug: 810133
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I963b6a1d736e1510618a723694f3b22ac0bf1589
Reviewed-on: https://chromium-review.googlesource.com/1150929
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579654}

extensions::ContentVerifyJob is ref counted, and its first reference may
be implicitly created in ContentVerifyJob::Start through base::BindOnce.
However, after an upcoming change to base::Bind, it starts rejecting to
make the implicit first reference to a ref-counted object, as this is
an error prone pattern.

This CL updates callers of ContentVerifyJob::Start to hold to hold the
first reference, before Start() is called.

Bug: 866456
Change-Id: Ib3a70973ac789f60a75e636db03f4e4d66e12603
Reviewed-on: https://chromium-review.googlesource.com/1156704Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579653}

Using wpt-import in Chromium f4d53fb3.
With Chromium commits locally applied on WPT:
7dad0f17 "Added new Sec-Metadata Web Platform Tests."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22183

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I1a710e023cc5268ad365820e61d5a1f5cf453a2b
Reviewed-on: https://chromium-review.googlesource.com/1157346
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579652}

These optional values should have been filled when PopulatePreviousEventData is
called. We now add the checks before using them. Also add metrics to record any
unexpected events.

Bug: 869127
Change-Id: I645c3c2242961fe055f6043b7541e36c01caa892
Reviewed-on: https://chromium-review.googlesource.com/1156105Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579651}

This is a reland of b166ec24

I dropped the change for build flags from this.

Original change's description:
> Reland "Fix to remove /wd4018 (-Wno-sign-compare) for /build/config"
>
> This is a reland of 1f75f99f
>
> Original change's description:
> > Fix to remove /wd4018 (-Wno-sign-compare) for /build/config
> >
> > This is a part of effort to remove /wd4018 warning suppression.
> >
> > Master CL is
> > https://chromium-review.googlesource.com/c/chromium/src/+/1152755
> >
> > This CL was uploaded by git cl split.
> >
> > R=dpranke@chromium.org
> >
> > Bug: 868248, 588506
> > Change-Id: I3c31dc8f72266eda85904c4a860e156fadb2a76e
> > Reviewed-on: https://chromium-review.googlesource.com/1152840
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#579311}
>
> Bug: 868248, 588506
> Change-Id: Ic673677dfc0800b361d97f6516ee61887635d9d4
> Reviewed-on: https://chromium-review.googlesource.com/1156164
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579401}

Bug: 868248, 588506
Change-Id: I41148bf02e6f5d1998b88f38e26022888a3b8623
Reviewed-on: https://chromium-review.googlesource.com/1157664
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579650}

Create a new class use-theme for the most-visited iframe to
differentiate whether is custom-background or use theme. Apply pill
under MD icons text only on when using theme but not for the
custom-background.

Screenshot:
https://screenshot.googleplex.com/Et8oFFtMgXb.png
https://screenshot.googleplex.com/ix4meSKVW5W.png

Bugs: 850718
Change-Id: I9416a44d9e2fc3dfd64fcf4198139d1f388ae9c3
Reviewed-on: https://chromium-review.googlesource.com/1156062
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579649}

This CL Sets up the newly migrated pref to enable the Android Messages
feature to be toggled by a feature toggle in the settings subpage by a
newly added feature item. In addition to the toggle, the feature item
has an icon and a button to start the verification flow for the feature
once that is built. For the moment, the button just turns on the pref
(which is not used elsewhere so there's no security issue) and then is
replaced by a toggle.

Change-Id: I23108a2cfc540a6600c89605c953ada31cfeb914
Bug: 824568
Reviewed-on: https://chromium-review.googlesource.com/1145890Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579648}

Bug: 864736
Change-Id: Icc73f375e3fa4773c0fecc3d38acf61dfb828e81
Reviewed-on: https://chromium-review.googlesource.com/1152210Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579647}

This change introduces a config number to bound the number of migrations on write error per network.

Bug: 868132
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib519f80cd24d282522ccd01a2a4add0902a93298
Reviewed-on: https://chromium-review.googlesource.com/1154031
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579646}

Since we're not painting list marker selection, such code is unnecessary.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id61ef0e9abbb4dd8f9aa60a589ac4fd188f5e0cd
Reviewed-on: https://chromium-review.googlesource.com/1155281Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579645}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I0207633b22a22440929fa6e64ddaffd845abde87
Reviewed-on: https://chromium-review.googlesource.com/1157557
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579644}

BUG=866721

Change-Id: I90a280e0d59fbc9d258e3c42a7227348b06f1ef2
Reviewed-on: https://chromium-review.googlesource.com/1150527Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579643}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/15016c7f..3895ea2a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I8fbeb5565f253119179b2988c0d53a21a4e520df
Reviewed-on: https://chromium-review.googlesource.com/1156919Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579642}

It's possible for SkTextBlob::Deserialize
to return nullptr if we hit this line:
https://cs.chromium.org/chromium/src/third_party/skia/src/core/SkTextBlob.cpp?l=742

This happens in a particular test case found by clusterfuzz and
leads to a segfault during serialization.

There appears to be code in skia that handles
the possibility of an SkTextBlob being null, e.g.
https://cs.chromium.org/chromium/src/third_party/skia/src/core/SkCanvas.cpp?l=25

However, there already seems to be an assumption within cc
that a DrawTextBlob's SkTextBlob is non-null, e.g.
https://cs.chromium.org/chromium/src/cc/paint/paint_op_buffer.cc?l=1952
https://cs.chromium.org/chromium/src/cc/paint/paint_op_buffer.cc?l=1722

So this patch causes the deserializer to reject null SkTextBlobs
within DrawTextBlobs.

Bug: 868968
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iec29d2fc111f6c23f388e36b841fee27b37b06a9
Reviewed-on: https://chromium-review.googlesource.com/1157424Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579641}

BUG=459827

Change-Id: I93efa9cf7bf850326046c857121c978d8441e6c1
Reviewed-on: https://chromium-review.googlesource.com/1157486Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579640}

Add "Add new services" menu item to Files app "gear menu" and change
the behavior to:

1. Go directly to Webstore in case there isn't any provider/FSP
installed.
2. Open "providers menu" when there is at least one provider/FSP
installed, which is the old behaviour.

Add a new command "new-service" to display the providers menu to be
able open it from the gear menu.

Change the gear menu item label to be "Add new service".

Fix My files tests because "Add new services" isn't displayed on
directory tree anymore.

Bug: 682356, 869240
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie9bf211c42a18b3717a72f40e57ceaade5958281
Reviewed-on: https://chromium-review.googlesource.com/1139944Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579639}

OfflinePages are now saved to a public directory "/sdcard/Download/".
However, the saving sometimes fails when the directory doesn't exist.
This change checks for the existence of the directory, and creates
it before the publish step.

Bug: 869182

Change-Id: I3e0105c5ddb2df7a5fa9b57a5bf3ba7478af3b09
Reviewed-on: https://chromium-review.googlesource.com/1150406Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Yafei Duan <romax@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579638}