- 10 Jul, 2014 25 commits
-
-
jamesr@chromium.org authored
DelegatedRendererLayerImpl computes an inverse device scale factor when receiving frame data so it can map from the delegating renderer's physical space to DIP space and then remap the quads from its renderer's DIP space to physical again. When using impl side painting, the frame is received by the DRLI on the pending tree. We need to push this factor to the active tree when pushing the passes so we can produce the correct quads from the active tree. BUG=382967 Review URL: https://codereview.chromium.org/385433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282208 0039d316-1c4b-4281-b951-d872f2087c98
-
gcasto@chromium.org authored
Specifically, how often do users save these accounts and how often are they used. TBR=rogerta@chromium.org BUG=386403 Review URL: https://codereview.chromium.org/355143006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282207 0039d316-1c4b-4281-b951-d872f2087c98
-
newt@chromium.org authored
NOTRY=true BUG=375379 Review URL: https://codereview.chromium.org/378043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282206 0039d316-1c4b-4281-b951-d872f2087c98
-
skobes@chromium.org authored
This is a first pass at smooth scrolling on the compositor thread. It adds LayerTreeHostImpl::ScrollAnimated, which kicks off a scroll offset animation through the layer animation controller. When the --enable-smooth-scrolling flag is present, InputHandlerProxy will call ScrollAnimated for composited wheel scrolls. Once this is in the next steps are: (1) Update the animation curve to aim at a new target when a wheel event comes in while a scroll animation is in progress. (For now we just drop the event.) (2) Unify the behavior with WebCore::ScrollAnimatorNone. We should be able to share a lot of logic since cc::ScrollOffsetAnimationCurve is already exposed to Blink through compositor bindings (for http://crbug.com/243871). BUG=575 Review URL: https://codereview.chromium.org/361143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282205 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
Round point-based Pango font sizes to the nearest pixel. Otherwise, we can end up with smaller UI fonts than GTK+ 2.0 apps in some cases. This seems to be in line with what get_scaled_size() does in Pango's pango/pangofc-fontmap.c, and gives me identically sized text in Gimp 2.6.12 and Chrome when I set the Gtk/FontName XSETTINGS property to "Arial 10". Note that Chrome doesn't currently honor additional fine-grained configuration performed via FontConfig, like disabling antialiasing for fonts of a certain size. That'll happen in a separate change. BUG=375824 Review URL: https://codereview.chromium.org/377413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282204 0039d316-1c4b-4281-b951-d872f2087c98
-
tsepez@chromium.org authored
This prevents a MSAN warning. BUG=390973 R=piman@chromium.org Review URL: https://codereview.chromium.org/362353004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282203 0039d316-1c4b-4281-b951-d872f2087c98
-
ttuttle@chromium.org authored
Add a basic diagnostic page for Domain Reliability at chrome://domain-reliability-internals/. BUG= Review URL: https://codereview.chromium.org/357103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282202 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282201 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=392573 NOTRY=true Review URL: https://codereview.chromium.org/377383004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282200 0039d316-1c4b-4281-b951-d872f2087c98
-
tomfinegan@google.com authored
Not all affected 444 tests disabled. > Roll libvpx 280676:281854 > > Disable VP9 444 tests. > B=392309 > > https://codereview.chromium.org/375983002 > https://codereview.chromium.org/376873009 > > R=scherkus@chromium.org, tomfinegan@chromium.org > > Review URL: https://codereview.chromium.org/380493002 TBR=johannkoenig@chromium.org Review URL: https://codereview.chromium.org/379293004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282198 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
Manually modify a SQLite database to have the problem described by the bug, then test that it can be recovered. Also, infrastructure to introduce testing data to sql/ tests. BUG=387868 Review URL: https://codereview.chromium.org/355093003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282197 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
Or it may be just for arm, not sure which setting is triggering the compile error. BUG=none TEST=none R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/355263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282196 0039d316-1c4b-4281-b951-d872f2087c98
-
eugenebut@chromium.org authored
iOS 7 does not call any code at the "end" of an app so flushing should be performed manually. BUG=392265 Review URL: https://codereview.chromium.org/375033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282195 0039d316-1c4b-4281-b951-d872f2087c98
-
mpearson@chromium.org authored
This likely won't affect metrics much, but someone asked me to do it so I am. It's easy. BUG=350200 Review URL: https://codereview.chromium.org/245993002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282194 0039d316-1c4b-4281-b951-d872f2087c98
-
lambroslambrou@chromium.org authored
Also added unittests for client code. TEST=unittests Review URL: https://codereview.chromium.org/320403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282193 0039d316-1c4b-4281-b951-d872f2087c98
-
haven@chromium.org authored
BUG=384426 Review URL: https://codereview.chromium.org/362903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282192 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
BUG=391943 TBR=nduca@chromium.org Review URL: https://codereview.chromium.org/377343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282191 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
BUG=391943 TBR=nduca@chromium.org Review URL: https://codereview.chromium.org/379913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282190 0039d316-1c4b-4281-b951-d872f2087c98
-
satyanarayana@google.com authored
Review URL: https://codereview.chromium.org/379443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282189 0039d316-1c4b-4281-b951-d872f2087c98
-
dnicoara@chromium.org authored
For Ozone, there is no default platform. Since the unittests use their own delegates this simplifies things by not requiring an Ozone platform when executing the unittests. BUG=none Review URL: https://codereview.chromium.org/383463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282188 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
Mostly cosmetic API changes. The guts of TimeDeltaInterpolator were spruced up a bit. BUG=370634 Review URL: https://codereview.chromium.org/376013003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282186 0039d316-1c4b-4281-b951-d872f2087c98
-
tdanderson@chromium.org authored
Define the hit test mask for NewTabButton by implementing MaskedTargeterDelegate instead of overriding View::HasHitTestMask() and View::GetHitTestMaskDeprecated(). BUG=388838 TEST=none Review URL: https://codereview.chromium.org/362843003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282185 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
R=davemoore@chromium.org Review URL: https://codereview.chromium.org/382553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282184 0039d316-1c4b-4281-b951-d872f2087c98
-
hansmuller@chromium.org authored
BUG=390949 Review URL: https://codereview.chromium.org/377713004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282182 0039d316-1c4b-4281-b951-d872f2087c98
-
weiliangc@chromium.org authored
Instead of calling DQ::Create() function and then push it into RenderPass in unittest, use RenderPass's function call to create and append a DQ while only pass out a raw pointer instead of ownership. Follow CL 369623002. BUG=344962 TEST=cc_unittests, content_unittests Review URL: https://codereview.chromium.org/368403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282179 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Jul, 2014 15 commits
-
-
eakuefner@chromium.org authored
For outputting Telemtry results as JSON, we will want to be able to refer to a Page by an ID that uniquely identifies it within a page set. This CL puts that machinery in place. R=nduca, dtu BUG=375541 Review URL: https://codereview.chromium.org/384483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282178 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
This pref is currently registered in different places for Mac and toolkit-views, resulting in problems for toolkit-views on Mac (i.e. it gets registered twice). The views pref moved into extension_prefs.cc in r183799. This moves the mac pref to the same place for increased code cohesion, simplifying a lot of things. BUG=155525, 390755 Review URL: https://codereview.chromium.org/378153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282177 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
This fixes a place where the wrong URL is used for the ld process when performing PNaCl translation. I don't believe the effect of this is severe, though it will cause the wrong url to be displayed when it's running. This also removes an unnecessary string constant usage in the trusted plugin. BUG= Review URL: https://codereview.chromium.org/373003005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282176 0039d316-1c4b-4281-b951-d872f2087c98
-
dgrogan@chromium.org authored
Probably broke Win7 Tests (dbg)(6). http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%286%29/builds/27654/steps/browser_tests/logs/SendQuery [ RUN ] GcdPrivateAPITest.SendQuery [4036:2900:0709/150928:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread! [956:2412:0709/150928:WARNING:extension_apitest.cc(282)] Workaround for 177163, prematurely returning c:\b\build\slave\win_builder__dbg_\build\src\chrome\browser\extensions\api\gcd_private\gcd_private_apitest.cc(276): error: Actual function call count doesn't match EXPECT_CALL(*test_service_discovery_client_, OnSendTo(std::string(reinterpret_cast\u003Cconst char*>(kQueryPacket), sizeof(kQueryPacket))))... Expected: to be called twice Actual: never called - unsatisfied and active [ FAILED ] GcdPrivateAPITest.SendQuery, where TypeParam = and GetParam() = (5746 ms) Revert 282099 "Add API stubs for GCD device commands." > Add API stubs for GCD device commands. > Changed registration API to work for one network at once. > Fixed comments. > Replaced argument GCDDevice with just string id. > > BUG=383167 > R=alexsemenov@chromium.org, asargent@chromium.org, asvitkine@chromium.org, noamsml@chromium.org > > Review URL: https://codereview.chromium.org/363883002 TBR=vitalybuka@chromium.org Review URL: https://codereview.chromium.org/385483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282175 0039d316-1c4b-4281-b951-d872f2087c98
-
enne@chromium.org authored
This is two-sided prerequisite for https://codereview.chromium.org/134623005/. Once this lands, then SetDeferCommits can be called regardless of threaded mode in WebViewImpl. This patch will make that not explode on NOTREACHED. BUG=none Review URL: https://codereview.chromium.org/380853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282173 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282171 0039d316-1c4b-4281-b951-d872f2087c98
-
dgrogan@chromium.org authored
Revert of Update smoothness_controller to use results.AddValue(...) (https://codereview.chromium.org/380803002/) Reason for revert: Possibly caused Android Tests failures. See http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14520/steps/telemetry_perf_unittests/logs/stdio E.g. Traceback (most recent call last): _RunPage at tools/telemetry/telemetry/page/page_runner.py:534 test.RunPage(page, page_state.tab, results) RunPage at tools/telemetry/telemetry/page/page_test.py:247 self.ValidatePage(page, tab, results) ValidatePage at tools/telemetry/telemetry/page/page_measurement.py:60 self.MeasurePage(page, tab, results) MeasurePage at tools/perf/measurements/smoothness.py:36 self._smoothness_controller.AddResults(tab, results) AddResults at tools/perf/measurements/smoothness_controller.py:100 results.current_page, r.name, r.unit, r.value)) __init__ at tools/telemetry/telemetry/value/scalar.py:19 assert isinstance(value, numbers.Number) AssertionError Original issue's description: > Update smoothness_controller to use results.AddValue(...) > > BUG=391943 > TBR=nduca@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282131 TBR=nduca@chromium.org,nednguyen@google.com NOTREECHECKS=true NOTRY=true BUG=391943 Review URL: https://codereview.chromium.org/382673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282170 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/377783004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282169 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
I really managed to botch it. Surprisingly, the tests were all still okay. R=darin@chromium.org Review URL: https://codereview.chromium.org/382633003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282168 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
Review URL: https://codereview.chromium.org/381663003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282167 0039d316-1c4b-4281-b951-d872f2087c98
-
haven@chromium.org authored
Some drives do not report themselves as removable despite appearing to a user to be a removable drive. Particularly this is the case for some USB sticks. We are fixing this by changing the device listing to list all drives that are either removable or attached via USB. We have already done a similar change for Chrome OS due to some SD card readers listing themselves as non-removable. Chrome OS lists all SD or USB drives. However, we do not have a reliable way to detect SD cards on Windows and Mac so we will continue to use the removable flag. BUG=391998 Review URL: https://codereview.chromium.org/375703004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282166 0039d316-1c4b-4281-b951-d872f2087c98
-
wolenetz@chromium.org authored
This change collects contiguous processed frames for each track buffer and appends them to track buffers' streams as groups of frames rather than inefficiently appending each frame one at a time. One at a time appends are still possible in the worst case, since collected processed frames are appended at the end of ProcessFrames() and also prior to any NotifyNewMediaSegmentStarting(). R=acolwell@chromium.org, damienv1@chromium.org BUG=371197 TEST=no media_unittest, MSE layout test, or YT conformance unit test regression locally on Linux Review URL: https://codereview.chromium.org/381443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282165 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282164 0039d316-1c4b-4281-b951-d872f2087c98
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia/+log/874a62acef5ec2ecccdbb99ec4d86402a3341e6a..1c577cd3ee331944b9061ee0eec147b211ee563c CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel TBR=jcgregorio@google.com BUG= Review URL: https://codereview.chromium.org/375423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282163 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282162 0039d316-1c4b-4281-b951-d872f2087c98
-