GitLab

R=haraken
BUG=393913
NOTRY=true

Review URL: https://codereview.chromium.org/662633002

git-svn-id: svn://svn.chromium.org/blink/trunk@183814 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The glasspane should be a component-root so that it inherits all the
basic styling.

R=pfeldman

Review URL: https://codereview.chromium.org/659043002

git-svn-id: svn://svn.chromium.org/blink/trunk@183813 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183802

BUG=397902
TBR=kouhei@chromium.org

Review URL: https://codereview.chromium.org/664503002

git-svn-id: svn://svn.chromium.org/blink/trunk@183812 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=393913
R=pfeldman@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/657063002

git-svn-id: svn://svn.chromium.org/blink/trunk@183810 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch prevents ElementTreeELements from selecting if they have
inner inplace editor.

BUG=423720

Review URL: https://codereview.chromium.org/663453003

git-svn-id: svn://svn.chromium.org/blink/trunk@183809 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=423737

Review URL: https://codereview.chromium.org/655273002

git-svn-id: svn://svn.chromium.org/blink/trunk@183808 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Section 10.4 of the specs forces us to ignore items spanning tracks with
flex sizing functions when resolving the content-based track sizing
functions. Items with span < 2 are not affected by this rule (as they will
belong to a single track). This way the algorithm ensures that min-content
and max-content restrictions are fulfilled before distributing the extra
space.

BUG=392200

Review URL: https://codereview.chromium.org/448993002

git-svn-id: svn://svn.chromium.org/blink/trunk@183807 bbb929c8-8fbe-4397-9dbb-9b2b20218538

the current stacking context.

If a stacking context element has descendants with blend mode, it should
create a new transparency layer, so that blending descendants will blend
only with the content within this stacking context (stacking context
will isolate blending).

With this CL, hasDescendantWithBlendMode will be set only if
the descendant is right inside the current stacking context, without
looking into nested stacking context elements. It also renames
hasDescendantWithBlendMode to hasNonIsolatedDescendantWithBlendMode,
which is more self-explanatory.

This change is necessary after https://codereview.chromium.org/466193002
(Disentangle blend mode from updateDescendantDependentFlags).

The "isolating" state used to be tested with DRT, but this property has
been removed with https://codereview.chromium.org/466943002/
(Remove isolatesBlending from render tree dumps).

We cannot test this change using layout tests. The effect is that
RenderLayer doesn't create any aditional and unnecessary skia
transparency layers.

Review URL: https://codereview.chromium.org/478333002

git-svn-id: svn://svn.chromium.org/blink/trunk@183806 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When I shipped marquee-in-JS, it increased UseCounters for Web Animation APIs because the marquee-in-JS uses the Web Animation APIs. This was an unexpected outcome because what we want to count is the number of JS APIs used by web developers, not the number of JS APIs used internally (i.e., private scripts).

Given the above, this CL adds UseCounter::countIfNotPrivateScript() and uses it in a binding layer so that we can count only the number of JS APIs used by web developers.

BUG=341031

Review URL: https://codereview.chromium.org/656693002

git-svn-id: svn://svn.chromium.org/blink/trunk@183805 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Current WebGL relies on glDiscardFramebufferExt() to clear FBO, but the API
doesn't guarantee clearing FBO.

TEST=fast/canvas/webgl/draw-webgl-to-canvas-2d.html,
fast/canvas/webgl/webgl-composite-modes-repaint.html
BUG=423674

Review URL: https://codereview.chromium.org/656053002

git-svn-id: svn://svn.chromium.org/blink/trunk@183804 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=420005
R=sergeyv, pfeldman

Review URL: https://codereview.chromium.org/653413002

git-svn-id: svn://svn.chromium.org/blink/trunk@183803 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, SVGFitToViewBox::parseAttribute handled negative width, height
errors inline. To migrate parsing to property map (crbug.com/397902), we want
to delegate this to SVGAnimatedProperty::setBaseValueToString implementation.

This CL introduces SVGAnimatedViewBoxRect which is a SVGAnimatedRect implements
handling of negative width/height.

TEST=svg/custom/viewbox-syntax.svg
BUG=397902

Review URL: https://codereview.chromium.org/664433002

git-svn-id: svn://svn.chromium.org/blink/trunk@183802 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When checking 'frame-ancestor', we end up asking for the SecurityOrigin
of the protected resource before we actually have a protected resource
whose origin we could ask for. This, unsurprisingly, crashes.

This patch adds a protocol property to the ContentSecurityPolicy object
so that we can perform all the checks for source expressions that don't
specify protocols without crashing the renderer.

BUG=424074
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/658073002

git-svn-id: svn://svn.chromium.org/blink/trunk@183801 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[WillBeGarbageCollected] is already inherited from the parent EventTarget.

R=haraken
BUG=

Review URL: https://codereview.chromium.org/653263006

git-svn-id: svn://svn.chromium.org/blink/trunk@183800 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's easy to miss adding USING_GARBAGE_COLLECTED_MIXIN macros to classes
that inherit from GarbageCollectedMixin. To avoid the programming error,
this CL adds a pure virtual method to the GarbageCollectedMixin class.
If we miss the USING_GARBAGE_COLLECTED_MIXIN macro, we'll hit a compile error.

This CL also fixes existing programming errors.

BUG=420515

Review URL: https://codereview.chromium.org/659953002

git-svn-id: svn://svn.chromium.org/blink/trunk@183799 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=126902
TEST=None

Review URL: https://codereview.chromium.org/637873006

git-svn-id: svn://svn.chromium.org/blink/trunk@183798 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews,haraken
BUG=355467
NOTRY=true

Review URL: https://codereview.chromium.org/660723003

git-svn-id: svn://svn.chromium.org/blink/trunk@183797 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1) Fix "estimated" row height.
2) Make "time" column sortable.
3) Make table stick to bottom.
4) Add new frames as they arrive.

BUG=142280

Review URL: https://codereview.chromium.org/643873003

git-svn-id: svn://svn.chromium.org/blink/trunk@183796 bbb929c8-8fbe-4397-9dbb-9b2b20218538

::-webkit-scrollbar-back and ::-webkit-scrollbar-forward had PseudoType
constants, but the strings were not recognized and no other code for
handling them present.

Review URL: https://codereview.chromium.org/659833002

git-svn-id: svn://svn.chromium.org/blink/trunk@183795 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There is no behavioral change.

BUG=n/a
TEST=should pass all existing tests

Review URL: https://codereview.chromium.org/660723002

git-svn-id: svn://svn.chromium.org/blink/trunk@183794 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/657493002

git-svn-id: svn://svn.chromium.org/blink/trunk@183793 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=400937
R=eustas, pfeldman

Review URL: https://codereview.chromium.org/657873002

git-svn-id: svn://svn.chromium.org/blink/trunk@183790 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=363099,371084
TBR=mkwst@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/659013002

git-svn-id: svn://svn.chromium.org/blink/trunk@183789 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL more or less rewrites the parser with the goal of improving our
adherence to the spec. We now have reasonable error messages for parse
failures, and have tests for the individual components of the parser
(algorithms and digests). We also now correctly require 'ni:///' as the
URL prefix (we were previously ignoring the last '/').

BUG=355467

Review URL: https://codereview.chromium.org/656063002

git-svn-id: svn://svn.chromium.org/blink/trunk@183788 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We started sending accessibility events to the frame client instead of
the view client, to prepare for site isolation. However, a single
AXObjectCache still spans all *local* frames, so accessibility events
should be fired on the axObjectCacheOwner's frame, not on the event
target's frame.

BUG=424046

Review URL: https://codereview.chromium.org/637223005

git-svn-id: svn://svn.chromium.org/blink/trunk@183787 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bindings gyp files support but gn files are old and doesn't support binding modularization. e.g.
- create WindowCoreConstructors.idl and WindowModulesConstructors.idl instead of WindowConstructors.idl,
- ditto (SharedWorkderGlobalScope, DedicatedWorkerGlobalScope, ServiceWorkerGlobalScope).

BUG=358074

Review URL: https://codereview.chromium.org/633913002

git-svn-id: svn://svn.chromium.org/blink/trunk@183786 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=424021
NOTRY=true

Review URL: https://codereview.chromium.org/658043002

git-svn-id: svn://svn.chromium.org/blink/trunk@183785 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This uncheck causes crash when selecting inside HTMLTextFormElement and either start 
or end node element doesn't have a renderer.

BUG=404560

Review URL: https://codereview.chromium.org/610323003

git-svn-id: svn://svn.chromium.org/blink/trunk@183784 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=machenbach@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/659933002

git-svn-id: svn://svn.chromium.org/blink/trunk@183783 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=399090

Review URL: https://codereview.chromium.org/657243002

git-svn-id: svn://svn.chromium.org/blink/trunk@183782 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To be compliant to the WHATWG Encoding spec (living standard), we should
treat ISO-8859-1 and windows-1252 synonymously. Moreover, windows-1252
is the canonical encoding name.

Update TextCodecLatin1 to list only aliases specified in the encoding
spec.

See https://codereview.chromium.org/598383002 (ICU update) and
    https://codereview.chromium.org/649413002 (roll ICU with necessary
    test/pref/UI changes in Chrome).

BUG=412053
TEST=fast/encoding/*
TEST=http/tests/misc/char*
R=jochen@chromium.org, jsbell@chromium.org

Review URL: https://codereview.chromium.org/655083002

git-svn-id: svn://svn.chromium.org/blink/trunk@183781 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds an update scope and instruments call sites which require an up-to-date
current time or modify the play state. Tracing now displays spans for the pending
and running phases.

BUG=351446

Review URL: https://codereview.chromium.org/638313002

git-svn-id: svn://svn.chromium.org/blink/trunk@183780 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183777

BUG=422050
TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/644323004

git-svn-id: svn://svn.chromium.org/blink/trunk@183779 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In this CL https://codereview.chromium.org/652663003/ MeterRole is not added to
computeAccessibilityIgnored().
So, adding that change in this CL.

BUG=421376

Review URL: https://codereview.chromium.org/653283003

git-svn-id: svn://svn.chromium.org/blink/trunk@183778 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Test is reporting PASS on the Mac 10.6 try bot.

TBR=dstockwell@chromium.org
NOTRY=true
BUG=422050

Review URL: https://codereview.chromium.org/661643003

git-svn-id: svn://svn.chromium.org/blink/trunk@183777 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The clients/callers of updateGraphicsContext(...) already independently
compute the same transform as computeResourceSpaceTransform(...). This
means that we can get rid of the latter in favor of the computations in the
callers - who just need to set up an AffineTransform and pass to
updateGraphicsContext(...).
This allows getting rid of the ApplyToTextMode resource-mode flag, and
doing so allows converting the RenderSVGResourceMode enum to a non-bitmask
such - and remove RenderSVGResourceModeFlags.

BUG=420022

Review URL: https://codereview.chromium.org/655263002

git-svn-id: svn://svn.chromium.org/blink/trunk@183776 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=ojan@chromium.org, jparent@chromium.org, iannucci@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_rel,linux_chromium_rel_swarming

Review URL: https://codereview.chromium.org/657233003

git-svn-id: svn://svn.chromium.org/blink/trunk@183775 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For compositng mode that are known as "full canvas compositing modes",
i.e. modes that affect pixels outside of the primitive, we
need to draw to a temporary buffer, and composite it back to the
canvas.  In cases where shadows are being painted, it is important
to composite the shadow independently of the foreground to
produse spec-compliant behavior.

BUG=411316
TEST=layout test fast/canvas/canvas-shadow-source-in.html

Review URL: https://codereview.chromium.org/658603002

git-svn-id: svn://svn.chromium.org/blink/trunk@183774 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Share a bit more code between LocalFrame and RemoteFrame, including moving the detach-time client notification down to FrameClient.

Move the max frame counter to FrameHost instead of Page.

Move detach logic from FrameLoader to LocalFrame, unless it manipulates FrameLoader members.

BUG=

Review URL: https://codereview.chromium.org/645623004

git-svn-id: svn://svn.chromium.org/blink/trunk@183773 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Assorted tweaks:

* Both drawConvexPolygon() clients (ObjectPainter::drawSolidBoxSide
  & RenderThemeChromiumMac::paintMenuListButton) turn off stroking,
  so we're always in fill-only mode. Update the method to reflect
  this limited scope, and stop mutating the global stroke style.
* Take an explicit color param to avoid changing (and leaking in
  the case of drawSolidBoxSide) the global fill color.

(because of the above, drawSolidBoxSides no longer dirties the GC paint
state in the common case => reduced pressure for committing deferred
paint saves).

* All drawConvexPolygon & clipConvexPolygon callers except
  RenderThemeChromiumMac pass in four points (quads), and per comments
  in setPathFromConvexPoints we don't assume convexity in this common
  case => update the method names to reflect this reality.

R=schenney@chromium.org,senorblanco@chromium.org

Review URL: https://codereview.chromium.org/657023006

git-svn-id: svn://svn.chromium.org/blink/trunk@183772 bbb929c8-8fbe-4397-9dbb-9b2b20218538