- 12 Jun, 2017 40 commits
- 
- 
magjed authoredRTCVideoEncoder.SupportsNativeHandle() means it can handle frames of type kNative, which in Chromium represents wrapped media::VideoFrames. Also, before accessing I420 data, i.e. DataY/U/V or StrideY/U/V, the function ToI420 should be called on webrtc::VideoFrameBuffer (these I420 functions will be removed from webrtc::VideoFrameBuffer soon). BUG=732345,732418 Review-Url: https://codereview.chromium.org/2939493002 Cr-Commit-Position: refs/heads/master@{#478769} 
- 
rsleevi authoredThis fully removes trust in WoSign and StartCom, as announced at https://security.googleblog.com/2016/10/distrusting-wosign-and-startcom.html BUG=731838 Review-Url: https://codereview.chromium.org/2927383002 Cr-Commit-Position: refs/heads/master@{#478768} 
- 
afakhry authoredAdds the Night Light automatic schedule settings. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=705816#c15 BUG=705816 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2915753003 Cr-Commit-Position: refs/heads/master@{#478767} 
- 
fsamuel authoredA world with the display compositor in the GPU process is a world without GpuProcessTransportFactory and ImageTransportFactory. ImageTransportFactory is a singleton. This CL makes FrameSinkManagerHost owned by BrowserMainLoop that can be accessed from both content/ and ui/ and does not depend on ImageTransportFactory/GpuProcessTransportFactory. BUG=730193 Review-Url: https://codereview.chromium.org/2932893002 Cr-Commit-Position: refs/heads/master@{#478766} 
- 
jbauman authoredThe new functions process individual quads into overlays or underlays. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2931833005 Cr-Commit-Position: refs/heads/master@{#478765} 
- 
huayinz authoredBefore: info menu item shows when user clear edit text in search mode Now: info menu item does not show in search mode BUG=732516 Review-Url: https://codereview.chromium.org/2939523002 Cr-Commit-Position: refs/heads/master@{#478764} 
- 
updowndota authored- Voice interaction keyboard shortcut should bring up voice interaction value prop screen if voice interaction is disabled. - If playstore is already set up, start voice interaction setup wizard. - Otherwise show playstore terms, and start voice interaction setup wizard afterwards if user accept. BUG=b/38263948 Review-Url: https://codereview.chromium.org/2929963002 Cr-Commit-Position: refs/heads/master@{#478763} 
- 
Fernando Serboncini authoredThis allows FontBuilder to work without a Document, as it was designed to. Bug: 730692 Change-Id: I43d3a67a2565ca7b4c199685f5c2b0bdcc42b79d Reviewed-on: https://chromium-review.googlesource.com/531666Reviewed-by: Justin Novosad <junov@chromium.org> Reviewed-by: Rune Lillesveen <rune@opera.com> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#478762} 
- 
palmer authoredAdd a counter to see how often we successfully resolve hostnames, tracking whether or not |net::IsValidHostLabelCharacter| returns true for all characters in all labels in the name. BUG=695474 Review-Url: https://codereview.chromium.org/2921553002 Cr-Commit-Position: refs/heads/master@{#478761} 
- 
Etienne Bergeron authoredThis is a new version of the benchmark used to find memory leaks in the browser process. The browser process stay alive for the whole duration of the benchmark. A memory dump using memory-infra is periodically taken. An external diff tool is used to find remaining objects allocated between two memory dumps. see: https://docs.google.com/a/google.com/document/d/1ULZRYBElYmBDGswF3f4yYpl77SD9sa0RgFNfl1FueWU/edit?usp=sharing https://codereview.chromium.org/2906113002/ CC: erikchen@chromium.org R: perezju@chromium.org, primiano@chromium.org Bug: 705656 Change-Id: I697892a6df881d19e3aace5a44e8a395717767c0 Reviewed-on: https://chromium-review.googlesource.com/530527Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#478760} 
- 
v8-autoroll authoredSummary of changes available at: https://chromium.googlesource.com/v8/v8/+log/de09009b..c7d2d216 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2935803002 Cr-Commit-Position: refs/heads/master@{#478759} 
- 
jdufault authoredThis CL primarily adds test support code; the password view is still WIP. BUG=719015 Review-Url: https://codereview.chromium.org/2896533002 Cr-Commit-Position: refs/heads/master@{#478758} 
- 
Jay Civelli authoredWebApkSandboxedProcessService accesses ChildProcessServiceImpl (which is in content) through reflection and needs to be exposed to WebAPK. Introducting a new chrome class that exposes this and forwards to ChildProcessServiceImpl. This also prepares for the move of ChildProcessServiceImpl to base where more work will need to be done when creating a ChildProcessServiceImpl. BUG=702316 Change-Id: Ib70f72c430a8a48b8ee84db5c6359f4c6f6dddfb Reviewed-on: https://chromium-review.googlesource.com/528669Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#478757} 
- 
skym authoredWhen an entry on the history page is deleted, we create history deletion directives that are sent through sync. These are required to support offline history deletions, and make sure these are properly propagated. However, these deletion directives rely on exact matches in timestamps, which are in microseconds since the epoch. The History page on Android converted microsecond timestamps to millisecond timestamps for Java compatibility, but when these timestamps were handed to the logic that created history deletion directives, they were now slightly off. This change simply plumbs through microsecond timestamps through the java code and back. BUG=729020 Review-Url: https://codereview.chromium.org/2935783002 Cr-Commit-Position: refs/heads/master@{#478756} 
- 
rlanday authoredI'm adding support in Chrome for the Android spellcheck menu in https://codereview.chromium.org/2931443003. When a user taps on a misspelled word, I need to highlight the word in a color based on the color of the spellcheck underline (we add some transparency). We're trying to avoid hard-coding the spellcheck color in editing code. Therefore, we think it makes sense to move the colors for spelling/grammar markers out of InlineTextBoxPainter into LayoutTheme, so other code can make use of them. BUG=715365 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2932913002 Cr-Commit-Position: refs/heads/master@{#478755} 
- 
Peter Wen authoredAdd a section about binary size sheriffing. Bug: None Change-Id: I1bca09d9c3148395c896b406ecbb9bff217988a7 Reviewed-on: https://chromium-review.googlesource.com/531565 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#478754} 
- 
Shimi Zhang authoredThis CL: 1) Set page count to unknown for PrintDocumentInfo in onLayout stage since we don't need to report pages count of a file. Android framework will get page count from the file produced from onWrite stage. This change will fix crbug/593387. 2) Removed printing jobs started from onLayout. We don't need to report pages count of the file at that stage, hence no need to start printing jobs from onLayout. As a replacement, starting all printing jobs from onWrite. It is related to crbug/612315, but crbug/612315 is not really true about saving file generating time since we didn't generate a file twice. 3) With other cleanup because variables such as mLastKnownMaxPages is not useful anymore. Bug: 593387, 612315 Change-Id: Ic52d9aa12b4aeb659156e1e2eb21f2f11afbd60c Reviewed-on: https://chromium-review.googlesource.com/521205 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#478753} 
- 
pnoland authoredBUG=672225 R=skym@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2920853004 Cr-Commit-Position: refs/heads/master@{#478752} 
- 
Uttam Thakore authoredInclude host IP address and port and net_error for requests in callbacks for PageLoadMetricsObservers Currently, the ChromeResourceDispatcherHostDelegate does not pass a request's host IP address and port or network error status to the MetricsWebContentsObserver for use by PageLoadMetricsObservers. We are trying to write an observer that examines local network requests from non-local pages and would need the host IP address and port and error status to collect our metrics. The GURL object passed to the MetricsWebContentsObserver contains the hostname as a domain name, but the domain name is insufficient for distinguishing between local network and public requests without additional network calls to a DNS server. The host IP address and error status information we pass could also potentially be useful for other page load metrics observers. This CL refactors ChromeResourceDispatcherHostDelegate, MetricsWebContentsObserver, and PageLoadMetricsObserver::ExtraRequestCompleteInfo to include the HostPortPair for the hostname and port for completed requests. The hostname and port for completed requests are taken from URLRequest.GetSocketAddress() if the request was successful, and from URLRequest::GetRemoteEndpoint if URLRequest::GetSocketAddress returns an empty value, which can happen if the request failed or was canceled. This CL also updates all unit tests and test harnesses that create mock ExtraRequestCompleteInfo objects and/or invoke the request complete callbacks in ChromeResourceDispatcherHostDelegate or MetricsWebContentsObserver. BUG= Change-Id: I56be75c23cba543ff82f16e639676e5e112c61a8 Reviewed-on: https://chromium-review.googlesource.com/526478 Commit-Queue: U Thakore <uthakore@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#478751} 
- 
Scott Graham authoredTo fix base_unittests in https://build.chromium.org/p/chromium.fyi/builders/Fuchsia%20(dbg) Bug: 706592 Change-Id: I22a305103dc54f2a5fde3e4d8e903db1586d8941 Reviewed-on: https://chromium-review.googlesource.com/528542Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#478750} 
- 
kylechar authoredLayerTreeHost didn't keep track of the number of surface layers for each SurfaceId. When there are multiple SurfaceLayers for the same SurfaceId both SurfaceLayerIds() and needs_surface_ids_sync() were potentially wrong. Make LayerTreeHost track the number of layers for each SurfaceId. Also add tests for this case. Bug: 731263 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifd6efe1b02c9ec4f728490b4487756b5319b681f Reviewed-on: https://chromium-review.googlesource.com/529566Reviewed-by: enne <enne@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#478749} 
- 
Oliver Chang authoredThis will need to be reimplemented later using __sanitizer_cov_trace_pc_guard. BUG=728684,729822 Change-Id: I1f979b3ceac8a59e27f96428b77ec1d983ac4cef Reviewed-on: https://chromium-review.googlesource.com/529972Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#478748} 
- 
Hans Wennborg authoredBug: 728324 Change-Id: Id007d43ea6468ce3ed8601c4e848861c224ef578 Reviewed-on: https://chromium-review.googlesource.com/529684 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#478747} 
- 
skia-deps-roller@chromium.org authoredhttps://skia.googlesource.com/skia.git/+log/ffaa47e0fe5f..7a8c84c6c925 $ git log ffaa47e0f..7a8c84c6c --date=short --no-merges --format='%ad %ae %s' 2017-06-12 ericrk Reland DeferredTextureImageData low-bit-depth/dithering support 2017-06-12 msarett Revert "Revert "Disable F16-nullptr sources"" 2017-06-12 mtklein fix f16 encoding 2017-06-12 csmartdalton Convert SkClassifyCubic to double precision 2017-06-12 senorblanco GrTessellator: fix two NaN issues. 2017-06-12 benjaminwagner [infra] Isolate tasks don't need compile task. 2017-06-12 reed enable rasterpipeline for android Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I343d7c3cbe318abc3deb57ee0df53931ab90397d Reviewed-on: https://chromium-review.googlesource.com/531800Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#478746} 
- 
luoe authoredBUG=726972 Review-Url: https://codereview.chromium.org/2924413002 Cr-Commit-Position: refs/heads/master@{#478745} 
- 
Geoff Lang authoredThis allows us to enable and disable the passthrough command decoder globally with small changes. BUG=602688 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I56c9cdea929f62748575fc67016e6de8fa03ac5f Reviewed-on: https://chromium-review.googlesource.com/531344Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#478744} 
- 
sebsg authoredBug: 732474 Change-Id: Ibe686ac089ec53cda5b4a21705e2006445eabbb6 Reviewed-on: https://chromium-review.googlesource.com/531854Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org> Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#478743} 
- 
rdevlin.cronin authoredCurrently, in JS bindings, we pass the event filter to JS, and then pass it back to C++ to find matching event listeners. This can cause problems because the object could be tweaked by monkey-patching, and we aren't correctly checking. Instead of updating the checks to safely interact with the object, just avoid passing it to JS altogether. Instead, pass the ids of the relevant listeners directly to JS. This avoids the security issue and is also more performant. Add a regression test. BUG=702946 Review-Url: https://codereview.chromium.org/2924683002 Cr-Commit-Position: refs/heads/master@{#478742} 
- 
alito authoredBUG=730073 Review-Url: https://codereview.chromium.org/2929483002 Cr-Commit-Position: refs/heads/master@{#478741} 
- 
mmenke authoredThis will allow it to be shared with the network service, and makes it easy to pass all relevant arguments to the network service as well. May add handling for command line arguments that affect more than just the HttpNetworkSession::Params there as well in a future CL, to enable further code sharing. TBR=lcwu@chromium.org,rkc@chromium.org BUG=727812 Review-Url: https://codereview.chromium.org/2914893002 Cr-Commit-Position: refs/heads/master@{#478740} 
- 
marq authoredAutomatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2933123002 Cr-Commit-Position: refs/heads/master@{#478739} 
- 
ryansturm authoredWhen a user is in the holdback experiment, data saver's proxy server is not actually used, so a pingback was not actually sent to the server in that case. However, for sake of comparing similar page loads, a pingback should now be sent for the holdback user when it is likely they would have used data reduction proxy. The pingback also needs to indicate that the specific page load is a holdback experiment page load. BUG=731180 Review-Url: https://codereview.chromium.org/2934543002 Cr-Commit-Position: refs/heads/master@{#478738} 
- 
dimu authoredCr-Commit-Position: refs/heads/master@{#478737}
- 
marq authoredAutomatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2933823002 Cr-Commit-Position: refs/heads/master@{#478736} 
- 
xiyuan authoredThe fallback logic in GetActiveUserOrOffTheRecordProfileFromPath should cover the case when the user profile loading has not started. So that it does not creates/loads user profile accidentally without going through UserSessionManager. BUG=728683,718734 TEST=ProfileManagerTest.UserProfileLoading Review-Url: https://codereview.chromium.org/2918203002 Cr-Commit-Position: refs/heads/master@{#478735} 
- 
tedchoc authoredBUG=729106 Review-Url: https://codereview.chromium.org/2928653003 Cr-Commit-Position: refs/heads/master@{#478734} 
- 
chaopeng authoredThe issue (crbug.com/719011) indicate that it is hard to interact with the content under the the scrollbar because the scrollbar will fade in while mouse moves in the hover fade in region of scrollbar. In this patch, we prevent fade in overlay scrollbar when user mouse down. 3 behaviors changed: 1. When mouse move in hover fade in region of scrollbar with mouse press, we don't trigger delay fade in. 2. When mouse down after a delay fade in triggered, cancel the delay fade in. 3. When mouse up in hover fade in region of scrollbar, trigger a delay fade in. BUG=719011 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2931703002 Cr-Commit-Position: refs/heads/master@{#478733} 
- 
Quinten Yearsley authoredBug: 732432 Change-Id: Id9b1ef6f89c03b3bddc2d3b5a4a8ed1d901dae98 Reviewed-on: https://chromium-review.googlesource.com/531664 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#478732} 
- 
lukasza authoredMost callers already call through WebLocalFrame (sometimes without realizing this, so the CL changes types to WebLocalFrame in a few places). The only exception is in CapturePixelsForPrinting function in content/shell/test_runner/pixel_dump.cc - the CL adds a CHECK to verify that layout tests do not run into a scenario unsupported by the current layout tests harness. Additionally this CL renames PrintPagesWithBoundaries method into PrintPagesForTesting. No intended behavior change. BUG=416660 Review-Url: https://codereview.chromium.org/2923343005 Cr-Commit-Position: refs/heads/master@{#478731} 
- 
rsleevi authoredSHA-1 was successfully disabled by default in M56 for publicly trusted CAs. Remove the metrics that measured the impact of that disabling. BUG=703458 Review-Url: https://codereview.chromium.org/2931313003 Cr-Commit-Position: refs/heads/master@{#478730} 
 
-