- 22 Feb, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/509f53e8e4d4..4a8ea42840ca Created with: gclient setdep -r src-internal@4a8ea42840ca The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I81891f574e2784a397c48979238be1e3913bb724 Reviewed-on: https://chromium-review.googlesource.com/c/1482616Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634587}
-
Yutaka Hirano authored
Bug: 934636 Change-Id: Ica9965dc176845f7f90aa6950eda3b25063126ce Tbr: mkwst@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1482292 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#634586}
-
Yutaka Hirano authored
The test calls 'fetch()' and waits for a request to finish. Strictly speaking, the request may not complete unless you read the response body. I'm going to land a change that makes the behavior more explicit, so this CL fixes the test beforehand. Bug: 894819 Change-Id: Id8edd93bcad47df2a1907892f231be094f789e02 Reviewed-on: https://chromium-review.googlesource.com/c/1478325Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#634585}
-
Sammie Quon authored
Use floats instead of ints for the overview item bounds calculation pipeline. The pipeline consists of multiple levels which all do rounding which results in some jank. Use bounding_box_f. Mouse will be handled using the newly added coordinate conversion functions in a separate cl (there seems to be an offset, it was non-trivial). Mouse drag is also much less common. This patch also changes the regular dragging calculations. Previously used and offset from previous bounds. This now calculates the new centerpoint based on the location and the initial distance from event to bounds centerpoint. Test: manual Bug: 927405, 871355 Change-Id: I9c6f96c04aab0a44ab0a5ca177bee58aa4d9ed77 Reviewed-on: https://chromium-review.googlesource.com/c/1471513 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#634584}
-
Jakob Ivarsson authored
Add WebRTC-Audio-NewOpusPacketLossRateOptimization to field trial testing config and remove WebRTC-Audio-OpusMinPacketLossRate. Bug: 932093 Change-Id: I2a0ad3882b8acfb6a66e41230090e7f9eedf6272 Reviewed-on: https://chromium-review.googlesource.com/c/1479960Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jakob Ivarsson <jakobi@google.com> Cr-Commit-Position: refs/heads/master@{#634583}
-
Yuki Shiino authored
Converts PaintWorkletGlobalScope.registerPaint's second argument |paintCtor| into IDL callback function type. Also, makes Paint Worklet use |PaintCallback| of callback function type. Change-Id: I6706499705a116c85f5c092a46309854db88708c Reviewed-on: https://chromium-review.googlesource.com/c/1478850Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#634582}
-
Yutaka Hirano authored
This reverts commit 9405f035. Reason for revert: TranslateManagerBrowserTest.AppCacheInteraction is failing on some bots: see https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/20438 for example. Original change's description: > [reland] Making Google Translate compatible with |request_initiator_site_lock|. > > This is a reland of https://crrev.com/c/1441277 that > - Trims the test down in a speculative attempt to avoid test flakiness > (I verified that the test still fails without the corresponding > changes in TranslateHelper::Translate) > - Adds logging statements to the test, to help in case trimming of the > test doesn't address the flakiness. > The original CL description follows below. > > Google Translate executes its scripts inside "isolated worlds". This is > quite similar to how extension content scripts execute and has a > consequence of using |request_initiator| set to the origin of the > isolated world (rather than to the origin of the page where the script > was injected). This is problematic for 2 reasons: > 1. It leads to renderer kills, when an AppCache verifies > |request_initiator| using CPSPI::CanAccessDataForOrigin. > 2. It leads to incompatibility between |request_initiator| and > |request_initiator_site_lock| which can also cause wrong/harsh > security decisions (e.g. CORB blocking of otherwise benign requests). > > This CL addresses the problems above, by making sure that requests > initiated by the Translate's "isolated worls" will use a separate > URLLoaderFactory. > - For injecting and selecting the factory on the renderer side, the same > mechanism is used as for extension content scripts (i.e. > URLLoaderFactoryBundleInfo::initiator_specific_factory_infos is > populated for the origin associated with the "isolated world"). > - For simplicity and to avoid races, the separate URLLoaderFactory is > sent from the browser to the renderer process in the same, single IPC > that triggers script injection into an isolated world (i.e. in > translate::mojom::Page::Translate method). > > As a side effect, this CL also causes Translate's requests to go > directly to the NetworkService (rather than to the AppCache's > AppCacheSubresourceURLFactory). This seems desirable. > > Bug: 925457 > Tbr: John Abd-El-Malek <jam@chromium.org> > Tbr: Daniel Cheng <dcheng@chromium.org> > Change-Id: If03198d98a3c78031718eecb21ec1ae39db5530f > Reviewed-on: https://chromium-review.googlesource.com/c/1481535 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: anthonyvd <anthonyvd@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634432} TBR=dcheng@chromium.org,jam@chromium.org,anthonyvd@chromium.org,lukasza@chromium.org Change-Id: I02c798f40caa942c3a3f801ff83529e138a54057 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 925457 Reviewed-on: https://chromium-review.googlesource.com/c/1482439Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#634581}
-
Findit authored
This reverts commit 8af85474. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 634467 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOGFmODU0NzQ4ZjIyNmE5OWRkY2QzYjA5ZTU1ZTQyNDE0ZWMwMmVlZgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/11425 Sample Failed Step: non_single_process_mash_browser_tests Sample Flaky Test: NetworkChangeManagerClientBrowserTest.DISABLE_ReconnectToNetworkService Original change's description: > Disable NetworkChangeManagerClientBrowserTest.ReconnectToNetworkService > > This test is flaky on ChromeOS when the network service is enabled. > > Bug: 934583 > Change-Id: Ib0a37e995a69555b5a5381bdef24f92fd19c12d9 > Reviewed-on: https://chromium-review.googlesource.com/c/1482005 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634467} Change-Id: Ia976e39e8c7307ab85c208c644e9fc3faf36a6c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934583 Reviewed-on: https://chromium-review.googlesource.com/c/1482598 Cr-Commit-Position: refs/heads/master@{#634580}
-
Nate Fischer authored
This refactors how we plumb args.platform through run_cts.py, and provides clearer error output: * If your device is higher than the supported platform range, we recommend using the max supported platform * If your device is lower than the supported platform range, explain that we don't support this because WebView is not updatable * If we auto-select a platform, this writes an info log to explain what platform we chose (useful for debugging) This renames --platform to --cts-release, since "--platform" was a bit unclear, and improves the --help description to better explain how to use this. This also adds unit tests for the logic behind the actionable exceptions. Bug: 934170 Test: vpython android_webview/tools/run_cts_test.py Change-Id: I4574ebf1a760c47e6ae09389ebb73b7ece1967d5 Reviewed-on: https://chromium-review.googlesource.com/c/1481076Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#634579}
-
Aleks Totic authored
Bug: 635619 Change-Id: Id3063b1b1c5f31bb3678c30ecca792333424cee1 Reviewed-on: https://chromium-review.googlesource.com/c/1482595 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#634578}
-
Gyuyoung Kim authored
BlinkMemoryMgt: Annotate the classes of svg and testing of renderer/core with the macros of Allocator The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, the some classes of //blink/renderer/core/svg and //blink/renderer/core/testing have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of the Commands, and SimPage classes, they make sense to use DISALLOW_NEW because they have been used as a member variable with a reference. In SVGPathQuery class case, they make sense to use STACK_ALLOCATED because they have been used in function without new allocation or smart pointers. Bug: 919389 Change-Id: I1230ae019a0ce9f6548c4d71deba5c1da4ae60f3 Reviewed-on: https://chromium-review.googlesource.com/c/1481149 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
Rakina Zata Amni authored
<wbr> elements indicate to the browser that a long string might be broken into lines, for example in long URLs. Since most of the time the line is not broken on the <wbr> elements, users expect to be able to find-in-page text that have <wbr> in between. This CL makes it so that when we encounter <wbr> in find-in-page, we ignore it (so we combine the text before and after the wbr) and not add an object replacement character like we previously do. Bug: 933684 Change-Id: I8593225016e5a0bd8f7436c64a8fe099963c90bb Reviewed-on: https://chromium-review.googlesource.com/c/1482271Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#634576}
-
Abhijeet Kandalkar authored
This CL replaces use of AccountFetcherService::OnRefreshTokensLoaded() method by IdentityTestEnvironment. As per new implementation, AccountFetcherService is wrapped inside ITE to interact with identity_apitest. Bug: 929603 Change-Id: I95bd34d549e6a03703ca15014de87359469547e8 Reviewed-on: https://chromium-review.googlesource.com/c/1458404 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#634575}
-
Luciano Pacheco authored
Add logging as warn so it shows up in the logs file. Add logging for: - Earliest startup of Files app. - Before trying to change to the initial directory. - After finished changing to the initial directory. - If there is no initial directory. Change background page logs from debug to warn to have information about the volumes initialization. We can turn this back to debug once we figure out this bug. These cover the bare minimal of the Files app initialization. Add a util function to return a debug string from a give entry, to use in the logging during startup. Bug: 904658 Change-Id: Iaa14b8fe5ac171f4fa2cd070edadaf370e50c5f9 Reviewed-on: https://chromium-review.googlesource.com/c/1480302 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#634574}
-
Alexandre Courbot authored
We are planning to introduce VideoFrames backed by a V4L2-allocated buffer. Such VideoFrames need to prevent that buffer from being reused during their lifetime. They will do so by retaining a reference to the V4L2ReadableBufferRef they were created from. However, contrary to V4L2 buffer references VideoFrames are typically passed between threads, and have a more blurry lifetime. Thus we may destroy the VideoFrame and release the V4L2ReadableBufferRef in a thread different from the one it was created in. Worse, this can also happen after the thread in question or even the V4L2 queue the buffer originated from has been deleted, rendering it impossible to post the destruction to the correct message loop. This CL thus makes it legal to destroy a V4L2ReadableBufferRef from any thread, and even after their originating V4L2Queue has been destroyed. To allow this the only task performed during buffer reference destruction, namely returning the reference to the free buffers list, must be made thread-safe. Also the free buffers list must be able to survive the V4L2Queue's destruction. For this, the thread-safe V4L2BufferList class in introduced, and referenced using a scoped_refptr from the V4L2Queue and all the buffer references. When buffers are freed on the queue, it creates a new instance of V4L2BuffersList, so buffer references can still reference and return to the old one. Bug: 792790 Bug: b:119794200 Test: VDA unittest passed in regular and import mode on Hana. Change-Id: Ib37cf55232aca040f1267e3d0357ebb7c40c7d6c Reviewed-on: https://chromium-review.googlesource.com/c/1481185Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#634573}
-
Risan authored
This CL implements OpenFile logic using DriveFS if it is enabled. Otherwise, VirtualFileProvider is used. BUG=b:119597913 TEST=Manually "Open With" a file in Google Drive (FilesApp) with an Android app (with and without DriveFS enabled). TEST=Tested that FSP still works (open zip mounted file with Google Photos). Change-Id: Ie206f22e717f4c31330f6beb33520d151ec07e66 Reviewed-on: https://chromium-review.googlesource.com/c/1475143Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Risan <risan@chromium.org> Cr-Commit-Position: refs/heads/master@{#634572}
-
Sarthak Kukreti authored
This adds histogram declarations and enums for the histogram added in https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1152301 BUG=chromium:808303 CQ-DEPEND=CL:1152301 TEST=None Signed-off-by:
Sarthak Kukreti <sarthakkukreti@chromium.org> Change-Id: I91f8775cf49b78f4689e143142323d85a7e528fc Reviewed-on: https://chromium-review.googlesource.com/c/1227503Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#634571}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9431161ca973..969659dbb313 git log 9431161ca973..969659dbb313 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 962c222aa3be..b9039bf76bf3 (2 commits) 2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@969659dbb313 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Iaad7f887cd9c37566db8b14f787570687a4861d6 Reviewed-on: https://chromium-review.googlesource.com/c/1482613Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634570}
-
Alexandre Courbot authored
This class was lacking a proper sequence checker. Add it. Bug: 792790 Bug: b:119794200 Test: VDA unittest passed in regular and import mode on Hana. Change-Id: If2ee4d272b396ba28df4082da59a98e5f1f4b5d6 Reviewed-on: https://chromium-review.googlesource.com/c/1481187 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4a5fcd9f3541..a74495a2956d git log 4a5fcd9f3541..a74495a2956d --date=short --no-merges --format='%ad %ae %s' 2019-02-22 crouleau@chromium.org Update chrome reference builds Created with: gclient setdep -r src/third_party/catapult@a74495a2956d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:932615,chromium:932595 TBR=sullivan@chromium.org Change-Id: I5a96c0f5f9a19dbb0603c1988c101cea052ffc6c Reviewed-on: https://chromium-review.googlesource.com/c/1482614Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2fdee39b44ee..c0546b9817ee git log 2fdee39b44ee..c0546b9817ee --date=short --no-merges --format='%ad %ae %s' 2019-02-22 crouleau@chromium.org presubmit: support 'Bug: 1234, 5678' Created with: gclient setdep -r src/third_party/depot_tools@c0546b9817ee The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I6ae0ee34fc7b6c34c3645cf5bf7d283d50852bb8 Reviewed-on: https://chromium-review.googlesource.com/c/1482611Reviewed-by:
-
Nate Fischer authored
No change to logic. This splits Safe Browsing code out of android_webview/browser/ and into a subdirectory, for better code layout. This adds an OWNERS file to list me as the owner, since I worked on the original integration and have acted as reviewer since. This does not split this into a separate GN target, since there's still circular dependencies with android_webview/browser/. This move was auto-generated with tools/git/move_source_file.py. R=boliu@chromium.org Bug: 934597 Test: ninja -C out/Default system_webview_apk Change-Id: Ib7157fe635032ebd76fd3564c9ad13fc9f6c0213 Reviewed-on: https://chromium-review.googlesource.com/c/1480637 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634566}
-
Gyuyoung Kim authored
Thanks to all effort to replace the uses of Blink's WaitableEvent with base::WaitableEvent, there is no uses of Blink's WaitableEvent now. So this CL removes waitable_event.h/cc files in blink finally. Bug: 919388 Change-Id: I8b5105fc2a14ae515617bd5059869bb6df4ff8aa Reviewed-on: https://chromium-review.googlesource.com/c/1482097Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6817d76a0fbc..509f53e8e4d4 Created with: gclient setdep -r src-internal@509f53e8e4d4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I38d67da2f5c7f8133984ce988af4cc98b2cfe69e Reviewed-on: https://chromium-review.googlesource.com/c/1482612Reviewed-by:
-
Kouhei Ueno authored
Bug: 923213 Change-Id: Ie7a311b3aef623d0cd5a0aa9dd5f9da0a94444d5 Reviewed-on: https://chromium-review.googlesource.com/c/1420498 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#634563}
-
Anand K. Mistry authored
BUG=934541 Change-Id: Ibd06bda730bd10c270d187d83f68315159fa6a43 Reviewed-on: https://chromium-review.googlesource.com/c/1482172Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#634562}
-
Zhuoyu Qian authored
As now we use blink instead of webkit, this CL rename check_webkit_style* to check_blink_style*. Change-Id: I340719a4c80cbc1dc4934fbdc4fa40b56347d8f8 Reviewed-on: https://chromium-review.googlesource.com/c/1482274Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#634561}
-
Dominic Mazzoni authored
Propagates the command-line flag for experimental accessibility labels to the renderer process, so that if the flag is enabled but the user hasn't opted in yet, we can still add a flag to unlabeled images that could possibly be described by Google to advertise it. Then, skips images that have an explicitly empty label or images that are already labeled, and for the remaining images either queries the annotator as before, or marks them as eligible for annotation if the annotator isn't running yet. Bug: 905419 Change-Id: I360670c6caa2200ae5016546f3ac5d89055f8e60 Reviewed-on: https://chromium-review.googlesource.com/c/1480303 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#634560}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5100fd8f459d..4a5fcd9f3541 git log 5100fd8f459d..4a5fcd9f3541 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 crouleau@chromium.org Disable failing scroll tests on Android Created with: gclient setdep -r src/third_party/catapult@4a5fcd9f3541 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:934649 TBR=sullivan@chromium.org Change-Id: Ic25f8f6d6a435d4e460362ba5388814992671653 Reviewed-on: https://chromium-review.googlesource.com/c/1482610Reviewed-by:
-
Christopher Lam authored
This is a reland of cd38dfe2 Original change's description: > [Mojo Lite] Remove externs generators and use for-compile generators everywhere. > > This CL removes the Mojo Lite externs generators and compiles all WebUIs > with the for-compile targets instead. > > Structurally, all Mojo types are now Closure record typedefs, and their > generated business logic is underneath a Spec object to prevent the name > collisions that were happening in the original implementation. > > All goog.requires have also been dropped, and goog.provides are now > per interface/struct/enum. > > This CL paves the way for generating single file Closure compiled blobs > that have all the Mojo bindings for a single WebUI. > > TBR=kinuko@chromium.org > > Bug: 914149 > Change-Id: I8866fa9eaa707b2db42369e695ed0a51c373c6b6 > Reviewed-on: https://chromium-review.googlesource.com/c/1476886 > Commit-Queue: calamity <calamity@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#634527} TBR=kinuko@chromium.org, rockot@chromium.org Bug: 914149 Change-Id: I415071a2bf94abc78eb331152b1818bba1c4753b Reviewed-on: https://chromium-review.googlesource.com/c/1482353Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#634558}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6a00e68a3448..9431161ca973 git log 6a00e68a3448..9431161ca973 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@9431161ca973 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I51c04ec86ac2fd7c5a2ec54cb93f8707ff76fde8 Reviewed-on: https://chromium-review.googlesource.com/c/1482331Reviewed-by:
-
Matt Falkenhagen authored
This happened when the eager code caching started a task but the timeout timer aborted it. The eager code caching code wasn't aware of the timeout so would call EndTask() and cause a crash when the timeout timer couldn't find the task. Bug: 933273 Change-Id: I09e9b2472f32413343c22d0d271b7b3dda40ef90 Reviewed-on: https://chromium-review.googlesource.com/c/1482433Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#634556}
-
dstockwell authored
Bug: 902646 Change-Id: I445c807725f5fef4bc987be9759dd346fdf55c06 Reviewed-on: https://chromium-review.googlesource.com/c/1482355 Commit-Queue: dstockwell <dstockwell@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: dstockwell <dstockwell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#634555}
-
dstockwell authored
Bug: 902646 Change-Id: I69015588df66c1d80817c141580f9fc29b248ece Reviewed-on: https://chromium-review.googlesource.com/c/1482354 Commit-Queue: dstockwell <dstockwell@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: dstockwell <dstockwell@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#634554}
-
Aleks Totic authored
We have not maintained our virtual expectations in a while. Bug: 635619 Change-Id: Id9961eb9685b237af80a0c565de2eacfc8858ae1 Reviewed-on: https://chromium-review.googlesource.com/c/1482333Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#634553}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dda2895279c9..6817d76a0fbc Created with: gclient setdep -r src-internal@6817d76a0fbc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1d5630a5319773d828f8badf131c48efe838d0e9 Reviewed-on: https://chromium-review.googlesource.com/c/1482332Reviewed-by:
-
Koji Ishii authored
Bug: 934129, 922407, 934634, 922645 Change-Id: Ia85a2ee6d94fc56df83b0677338ed2206564ce07 Reviewed-on: https://chromium-review.googlesource.com/c/1482291Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
-
David Trainor authored
The update app menu item has an odd alignment when there is no summary to show. This is because the summary is still taking vertical space, which leaves a larger than normal gap between the update app menu item and the next menu item. This CL makes the summary visibility GONE when there is no text to show, which removes it from layout calculations. Bug: 922711 Change-Id: I34d62ff1ba0cdf68a8b53df3b75a9e91a21f55df Reviewed-on: https://chromium-review.googlesource.com/c/1479301Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#634550}
-
Shao-Chuan Lee authored
ArcSessionManager state is reset before final UMA recording happens on browser shutdown, which result in missing Arc.State and incorrectly recorded Arc.StateByUserType. This CL adds fields to ArcSessionManager to persist state across Shutdown() for UMA recording purposes. Bug: 929583 Change-Id: I5fdf58ec60f9720599fa15c997cd2a23ed524fd9 Reviewed-on: https://chromium-review.googlesource.com/c/1481180 Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Auto-Submit: Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#634549}
-
Anand K. Mistry authored
BUG=934541 Change-Id: I6615fd0cdaa91f3806147fe44ecfbc1595e4b36b Reviewed-on: https://chromium-review.googlesource.com/c/1482091Reviewed-by:
-
