- 18 Apr, 2018 40 commits
-
-
Mark Cogan authored
Bug: 659649 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8813d293c71b1403f18368c60fa0a2435193cac4 Reviewed-on: https://chromium-review.googlesource.com/1016286 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551626}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/084709505993..84ba9179592f $ git log 084709505..84ba91795 --date=short --no-merges --format='%ad %ae %s' 2018-02-07 yhong cros_sdk: Add a non-interactive mode friendly flag `--working-dir`. 2018-04-17 yueherngl nami: add additional sign_type Created with: roll-dep src/third_party/chromite BUG=chromium:None,chromium:None The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6cd2a2612c1ab54ff8e1e8fe0c5dd9ea6d64a9fc Reviewed-on: https://chromium-review.googlesource.com/1016541 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551625}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I42c2e90e868728390129c4b537b005c28aba0a54 Reviewed-on: https://chromium-review.googlesource.com/1016322Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551624}
-
Takuto Ikuta authored
Current goma backend does not support cl.exe execution with /Brepro. Change-Id: Ie892880488e3ed22b9253bd8f3bc21306f9b0524 Reviewed-on: https://chromium-review.googlesource.com/1016446Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#551623}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 322e3b54. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15752 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=robertma No-Export: true Change-Id: I845d6637ab248725f660724da03550de692808e7 Reviewed-on: https://chromium-review.googlesource.com/1016362 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#551622}
-
Takashi Toyoshima authored
In the legacy Blink CORS, these information are stripped in DocumentThreadableLoader in MakeCrossOriginAccessRequest(). Current OOR-CORS implementation only has DCHECKS for them, but hasn't stripped. Bug: 803766 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If1a4657804215a8ce9a302acb658f9407348a79a Reviewed-on: https://chromium-review.googlesource.com/999672 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#551621}
-
Jinsuk Kim authored
The internal API in CVC fits conceptually in GestureListenerManagerImpl. There is no functional changes. Bug: 598880 Change-Id: I571745b33f9e8b64c94f32fd8ce5faa950aec422 Reviewed-on: https://chromium-review.googlesource.com/1014861 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#551620}
-
Marc Treib authored
This will effectively turn off Sync for Supervised Users. Supervised Users have been deprecated, and it's not possible anymore for custodians to add or update any restrictions, which was to main reason for requiring Sync. Bug: 829304, 809030 Change-Id: I510cc9da1aa26147e890b94e17dcb147d5ca9034 Reviewed-on: https://chromium-review.googlesource.com/997654Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#551619}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6a93eff9ef52..084709505993 $ git log 6a93eff9e..084709505 --date=short --no-merges --format='%ad %ae %s' 2018-04-17 ihf caroline-arcnext: mark CQ/PFQs bvt-arc important. 2018-04-17 dgarrett chromeos_config: Record builders moved to Legoland. 2018-04-17 dgarrett config_lib: UseBuildbucketScheduler. Created with: roll-dep src/third_party/chromite BUG=chromium:834078,chromium:None The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iba4ad91e214467453d3327f5cf4db291476cb558 Reviewed-on: https://chromium-review.googlesource.com/1015983Reviewed-by:
-
David 'Digit' Turner authored
symbol.py: - Remove _GetChromeOutputDirCandidates() because the function would normally always return a list with a single item, the result of constants.GetOutDirectory(). Even in the case where none of CHROMIUM_OUTPUT_DIRECTORY or BUILDTYPE are defined in the environment, it would have reported a list with *two* default directories (i.e. ["$OUT/Debug", "$OUT/Release"]), which is error prone since one cannot assume that their content corresponds to the same set of sources / DEPS, and hence may lead to incorrect symbolization. Besides, all high-level scripts that call into this one already set these environment variables through constants.SetBuildType() or constants.SetOutDirectory() - Make the SECONDARY_ABI_OUTPUT_PATH variable private with an underscore prefix, and improve the error message in SetSecondaryAbiOutputPath(). - Remove the "$OUT/lib" paths from the result of GetLibrarySearchPaths(), since GYP is not used anymore. Update the comment that explains the library locations. stack_core.py: - Make a few functions private using an underscore prefix. Also document the weird / error-prone behaviour of _FindSharedLibraryFromAPKs(). Unfortunately, it is not trivial to pass a list of APKs without introducing yet another global variable (a better solution is planned in the future). constants.py: - Remove 'build_type' parameter from GetOutDirectory() since its only user was removed (see above). Also slightly improve the exception message when the method is called without CHROMIUM_OUTPUT_DIR or BUILDTYPE being defined. - Remove obsolete SetBuildDirectory() function, since there are no callers for it, and its usage is slightly confusing with that of SetOutputDirectory() (!) - Log a warning when SetBuildType() is called when CHROMIUM_OUTPUT_DIR is already defined, because the value will completely be ignored by GetOutDirectory(). - Remove GetBuildType() (no callers). - Remove GetAdbPath(), code search reveals there are no callers anymore for it :-) Tested manually by running a few scripts, like build/android/tombstones.py BUG=NONE R=agrieve@chromium.org,jbudorick@chromium.org,pasko@chromium.org Change-Id: Icb38da2a6d5511aca4cb217abd6ac25f1cb313df Reviewed-on: https://chromium-review.googlesource.com/1007280 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#551617}
-
Olivier Robin authored
- If multiple events are received on the same runloop, autofill will only react to the last one. Only send this one to avoid useless computation. - Also avoid to send events on unfocus events, as autofill UI should only apply to the field that has focus (and is the keyboard responder). Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idc316480a4c03550766d549104609fb5b052c38d Reviewed-on: https://chromium-review.googlesource.com/998154Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551616}
-
Christopher Lam authored
This CL fixes an issue where the right-click of a bookmark item wouldn't show a new command menu when a command menu was already open. This was caused by the mousedown on the original menu not closing the menu. When cr-action-menu changed to no longer be a type extension, the event was no longer fired by the dropdown itself, and rather a child. This CL changes the event expectation so that the menu will close correctly. Bug: 825119 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1cd5494c7208b21d55f817303389bb845794458e Reviewed-on: https://chromium-review.googlesource.com/1013769 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#551615}
-
stkhapugin@chromium.org authored
Hooks the location bar to the fullscreen animations, and adds animations to scale the location bar contents and to fade out the share button. Bug: 829397 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I05b0d4bee4ecc430d74a54a54d23c3708d3bfcbd Reviewed-on: https://chromium-review.googlesource.com/1012080 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551614}
-
tanvir.rizvi authored
PositionWithAffinity uses default affinity as second parameter. This CL introduces 1) PositionWithAffinity(Position) and 2) Makes default affinity as a required field. Bug: 831952 Change-Id: Ie13f8ca3b612587d953628c56402bb9108fea1b5 Reviewed-on: https://chromium-review.googlesource.com/1014862 Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551613}
-
https://skia.googlesource.com/skia.git/+log/a05e199cd962..2f54f2c31572 $ git log a05e199cd..2f54f2c31 --date=short --no-merges --format='%ad %ae %s' 2018-04-18 angle-skia-autoroll Roll third_party/externals/angle2/ aed1b56aa..c90d4d38c (2 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ide71b27f0602579c29ec3349b600d66a2ed17723 Reviewed-on: https://chromium-review.googlesource.com/1015205 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551612}
-
David 'Digit' Turner authored
This hardens the zip parsing code in the crazy linker library to avoid integer type and overflow problems. - Defines packed struct types for various ZIP records, and helper functions to read their fields more easily. - Provides a MemoryRangeReader convenience class to ensure parsing the file data doesn't try to read values out of bounds, and check offsets / ranges properly. FYI, another CL adds unit-tests to the zip parser, but the code was split since it required other non-trivial changes to other classes. See https://chromium-review.googlesource.com/c/chromium/src/+/911408 BUG=543292 R=palmer@chromium.org,rsesek@chromium.org,agrieve@chromium.org,pasko@chromium.org,rmcilroy@chromium.org Change-Id: Ic378c83396eb124b9ef8c605f21c5fa5dcc8139a Reviewed-on: https://chromium-review.googlesource.com/910852 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
This reverts commit 96b9e995. Reason for revert: introduces memory leak on youtube.com test First failling here: https://ci.chromium.org/buildbot/chromium.linux/Leak%20Detection%20Linux/4115 Original change's description: > [Spellcheck] Enable cold mode idle time spellchecker in M68 > > As previously planned, we will enable cold mode checker as bug fix to > the current spellchecker, and will monitor its performance. > > Bug: 824030, 716642 > Change-Id: Ie37a08fb6d5562d2f2ff2c2ac84e8033b6ffb776 > Reviewed-on: https://chromium-review.googlesource.com/1015790 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551558} TBR=yosin@chromium.org,tkent@chromium.org,xiaochengh@chromium.org Change-Id: I03087aad24d41208a56aa1904eb55c719e771578 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824030, 716642 Reviewed-on: https://chromium-review.googlesource.com/1015363Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#551610}
-
Ramin Halavati authored
Traffic annotation auditor's tester on FYI bot is updated to return more gracefull output if auditor cannot produce any result. Bug: 690323 Change-Id: If39c0cf092010c43d4c8a5b26a786172ba3cf937 TBR: msramek@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1015901Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#551609}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bde5be65..f70a4135 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ie74203b7ebe4b3793a93bf51a5721dcd63aded81 Reviewed-on: https://chromium-review.googlesource.com/1015144Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#551608}
-
Takashi Toyoshima authored
There are two ToRtcOptinlal functions in the same jumbo build group, and it breaks jumbo builders. Bug: 834162 Change-Id: Id37adc6bef5ce4d0e38b8e564f3998d27084a53d Tbr: sergeyu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1016217Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#551607}
-
Kent Tamura authored
external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html http/tests/fetch/serviceworker-proxied/thorough/redirect-credentials-base-https-other-https.html http/tests/fetch/serviceworker/thorough/redirect-credentials-base-https-other-https.html http/tests/fetch/window/thorough/redirect-credentials-base-https-other-https.html http/tests/fetch/workers/thorough/redirect-credentials-base-https-other-https.html virtual/outofblink-cors/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html TBR=dcheng@chromium.org NOTRY=true Bug: 834183, 834185 Change-Id: I6eb3d60775dc18aea2339f1be17358d9a00e5e97 Reviewed-on: https://chromium-review.googlesource.com/1016340Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#551606}
-
Gauthier Ambard authored
When UI Refresh is enabled, it is possible to enter fullscreen mode when scrolling a loading page. Bug: 824929 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I18f724182dc25fe4827b7299d82cc1b350b7f31e Reviewed-on: https://chromium-review.googlesource.com/1013930Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551605}
-
Takashi Toyoshima authored
Suppress fast/peerconnection/RTCRtpSender-setParameters-crash.html timeout for Windows. Bug: 834177 Change-Id: I7fc2b96ca0329da34cbdd4f969ffc34b0a85142e Tbr: orphis@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/1016225 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Noel Gordon authored
Bug: 832192, 833049 Change-Id: I9e4816bbe1fe071a55791d706017ea5efa4e87fa Reviewed-on: https://chromium-review.googlesource.com/1015337Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#551603}
-
Takuto Ikuta authored
This reverts commit 953fcf3f. Reason for revert: We want to set envvar directly. Original change's description: > Add disable_goma for args.gn on win > > Switching use_goma causes full rebuild due to command line update in build.ninja. > I added disable_goma to set GOMA_DISABLED on environment.{x86,x64}. > > If we specify disable_goma=true, GOMA_DISABLED env is passed to gomacc. > Then gomacc executes given argument instead of sending args to goma daemon. > > This will help toolchain maintainer to check difference of build behavior w/wo goma without rebuilding everything. > > Bug: > Change-Id: Ie58958b5484d57be1c40fbbca363f1eef4b55c7e > Reviewed-on: https://chromium-review.googlesource.com/768549 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#518134} TBR=dpranke@chromium.org,brucedawson@chromium.org,tikuta@chromium.org Change-Id: Ia2d510f4149b30cff3f8dc6c0b89e37190c39368 Reviewed-on: https://chromium-review.googlesource.com/1015860Reviewed-by:
-
Jinsuk Kim authored
RenderCoordinates is now a public interface backed by its impl class within content layer (RenderCoordinatesImpl) and makes some of its methods accessible by embedders, such as view/viewport dimension and scroll offset which are necessary for Android container view to work. Also deleted unused fields/methods, turned some methods to private for RenderCoordinatesImpl. Bug: 598880 Change-Id: Iee9983f9eb71d46e3318be6c2a37260352832c1e Reviewed-on: https://chromium-review.googlesource.com/1013670Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
-
Ryan Sleevi authored
To better support network S13N, expose the CT log information directly via the //net API, rather than constructing CTLogVerifiers. This is part of an overall cleanup of the ct_known_logs as part of uplifting it out of //net. BUG=702062 Change-Id: I6abb95351d3b7c6c32c8247a03da55776d80b817 Reviewed-on: https://chromium-review.googlesource.com/1015061 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#551600}
-
Francois Doray authored
Previously, storage::ObfuscatedFileUtil used a custom timer implementation (TimedTaskHelper). Crash involving this custom timer implementation have been reported (e.g. http://crash/e2c6ff1ef4863460). Therefore, we are moving all uses of TimedTaskHelper to the well maintained base::Timer. Note: The TaskRunner passed to the TimedTaskHelper in storage::ObfuscatedFileUtil was always the one on which the storage::ObfuscatedFileUtil was used (as proved by added sequence checker), so there is no need to an explicit call to base::Timer::SetTaskRunner in this CL. Bug: 760326 Change-Id: Iee641ca876560a60c91ce17397dbcfb39a4bfc35 Reviewed-on: https://chromium-review.googlesource.com/1012519 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#551599}
-
Ryan Sleevi authored
A number of CertDatabaseNSSTests were changed in 2012 to test the wrong thing, after a certificate expired, rather than to DISABLE the test. This updates all of the expectations to match what they were intended to test, using regular test certificates that can be easily updated. BUG=111029 Change-Id: If7fcb67a20f52fe551da53ea809274ee5775a8bf Reviewed-on: https://chromium-review.googlesource.com/1012452 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551598}
-
Andrey Kosyakov authored
This is a reland of 031b31c4 Original change's description: > DevTools: fix interception for <a download='...'> downloads with network service > > Bug: 721408 > > Change-Id: I60f0cf81a69d7826d2043aa8222d2e69ff9e406a > Reviewed-on: https://chromium-review.googlesource.com/1006231 > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550690} Bug: 721408 Change-Id: Ia02958bcecb911f288c30699e4b265574c8807e3 Reviewed-on: https://chromium-review.googlesource.com/1015852Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#551597}
-
Jialiu Lin authored
Safe Browsing private extension API make key Safe Browsing events observable by Enterprise Reporting Extension (go/ent-rep-ext-dd). These proposed APIs do not add or facilitate new functionalities in the browser. go/safebrowsing-ext-api Note that, this CL doesn't trigger this API. Follow-up CL(s) will handle the triggering part. Bug: 806112 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1da2b643eb3d4c8c35dc68480e94c08cfb723fad Reviewed-on: https://chromium-review.googlesource.com/1005975 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#551596}
-
Xi Cheng authored
... because they have quite different file locations due to data dependency restriction. Bug: 734095 Change-Id: I737e7a9f7edc3fb12ef14ccd025ff0afc6688535 Reviewed-on: https://chromium-review.googlesource.com/1013096 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#551595}
-
Ned Nguyen authored
This makes it a lot easier to do code search for blink_perf benchmark Change-Id: Ib1257088c4eb99d0f61ebb8fc6dc511d748459aa Reviewed-on: https://chromium-review.googlesource.com/1013150 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#551594}
-
Nicholas Verne authored
Once crostini is already installed, it needs to be restarted after Chrome shuts down. These restart steps are all very fast in the case that the default vm and container are already running. If not, there can be a several second delay. Launching crostini apps always goes through this flow and testing shows the impact is not user-noticeable when the vm and container are running. A future CL will add an observer to the CrostiniRestarter class for this case. Bug: 832509 Change-Id: I359e5a25c30664fad6425c218853dda204c605d9 Reviewed-on: https://chromium-review.googlesource.com/1013804 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#551593}
-
Jianzhou Feng authored
Make a transparent window, and use a zero overlap in InitInsets and UpdateInsetsForWindow to avoid the window beneath not rendering anything. Bug: 826617 Change-Id: I9b5e8140a6b9a9c481caf92ef3d244ffc14b64d8 Reviewed-on: https://chromium-review.googlesource.com/1013444 Commit-Queue: Jianzhou Feng <jzfeng@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#551592}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/adc953f927bd..85c75025906a $ git log adc953f92..85c750259 --date=short --no-merges --format='%ad %ae %s' 2018-04-17 brucedawson Teach autoninja.py to support GOMA_DISABLED env var Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I6d293ee3d3d21ed9d37ea739f514fcfe30a5567f Reviewed-on: https://chromium-review.googlesource.com/1015197Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551591}
-
Anita Woodruff authored
- The final piece in the jigsaw of migrating notification methods over to mojo. - Note this is still behind the NotificationsWithMojo feature flag. R=peter@chromium.org Bug: 796991 Change-Id: Ic590154af590595b122f33ab200be22a628b1d67 Reviewed-on: https://chromium-review.googlesource.com/1014042 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#551590}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bc3cd02b. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15738 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I3dc0da8ef963cb600fbaa5caf4b6b8a3262c61bf Reviewed-on: https://chromium-review.googlesource.com/1015334 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Sadrul Habib Chowdhury authored
Notable changes: . Use the regular aura-path for setting the LocalSurfaceId for the compositor, instead of specially setting it from WindowTreeClient, when the window-server sets the LocalSurfaceId with a bounds-change. WindowTreeHost::SetBoundsInPixels() is changed to take LocalSurfaceId as an input-param to facilitate this. . When the client itself changes the size, do not set the LocalSurfaceId on the compositor multiple times for the same size from various places (e.g. WindowTreeHostMus, WindowTreeClient etc.). . Add validation checks for ui::Compositor that a new LocalSurfaceId is assigned whenever the size changes. This makes it easier to catch errors earlier in the pipeline. BUG=821987 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic9703c57b7a7f9ef2b65b34fa38c8ec7de9e9f36 Reviewed-on: https://chromium-review.googlesource.com/1014568 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#551588}
-
Tom Anderson authored
This CL removes the last static initializer on Mac. The AtomicOps_Internalx86CPUFeatures structure used to be initialized at start time. I've changed it to be initialized lazily. Code that used to look like: if (AtomicOps_Internalx86CPUFeatures.has_amd_lock_mb_bug) will now look like: if (Get_AtomicOps_Internalx86CPUFeatures().has_amd_lock_mb_bug) This structure is used in low-level atomic operations like compare-and-swap, so performance is a priority. In the fast case where the structure is already initialized, the new implementation shouldn't require any additional cycles on modern CPUs. BUG=831951 R=pkasting CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.android:android_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.win:win_archive;master.tryserver.chromium.win:win_x64_archive Change-Id: I37166109190d7a764c4234e0de343360d18cfbab Reviewed-on: https://chromium-review.googlesource.com/1015628Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#551587}
-
