GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a998a1a6..166ecce7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ia62655ea37142a809b388e998636147ca7e26ffc
Reviewed-on: https://chromium-review.googlesource.com/877019Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530709}

Bug: 803754
Change-Id: I97b1d39af46eed3f1d730945d962579dabd5bb6e
Reviewed-on: https://chromium-review.googlesource.com/875527Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530708}

https://skia.googlesource.com/skia.git/+log/16d0ad06b468..b76c71702517

$ git log 16d0ad06b..b76c71702 --date=short --no-merges --format='%ad %ae %s'
2018-01-19 reed simplify GrFPArgs, isolating localmatrix
2018-01-18 vmpstr Use equal_range for factory lookups

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=halcanary@chromium.org

Change-Id: Ifc0d1876e91c19b3b5058f0e3b32fbcf16f5a6d7
Reviewed-on: https://chromium-review.googlesource.com/876934
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530707}

Use python, instead of vpython, for all gclient hooks that are not catapult.
This is a partial revert of
https://chromium-review.googlesource.com/c/chromium/src/+/762037

Reasoning: https://crbug.com/803763#c10

TBR=cmasso@google.com

Bug: 803763#
Change-Id: I8d3145a73ee77fe69c34b479ecb74cebba08cb05
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/877380
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530706}

This conitnues the refactor in
https://chromium-review.googlesource.com/q/I940f44aeb5af65f4b8cac9bf4fa593d52319d5c9.

Bug: 669219
Change-Id: I4a828d1534cce44d2d60eb5069e9aee9b0f5b89f
Reviewed-on: https://chromium-review.googlesource.com/876482Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530705}

https://webrtc.googlesource.com/src.git/+log/565e3e07d7ba..0a6a2b73a1c5

$ git log 565e3e07d..0a6a2b73a --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib785379ebe41e438783cbf819e7fa8ad2d5add62
Reviewed-on: https://chromium-review.googlesource.com/877105
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530704}

This CL changes the ruleset file data to no longer be memory mapped. This was
not ideal since mmap-ing a file on the IO thread can cause it to get de-
scheduled in case of a page fault, which we do not want. This CL changes the
ruleset file data to be copied and available directly in memory.

BUG=774271, 696822

Change-Id: I1c8aae2c1d48a7bf68a2c878a227d15344588039
Reviewed-on: https://chromium-review.googlesource.com/874595Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530703}

This cl implements the side tabs layout.
Major changes:
1. Allow choosing tab alignment upon init.
2. Support MD for vertical tab alignment.
3. Draw boarder for vertical tab alignment.

Bug: 793870
Test: Run in linux build. Screenshots are attached in the bug.
Change-Id: Ie39f6693ffb5271388f977e280e03d28c1957db9
Reviewed-on: https://chromium-review.googlesource.com/872050Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530702}

This reverts commit 4d9e568b.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> shelf: Users cannot hide shelf by swipe down in tablet mode anymore.
> 
> Test: ash_unittests ShelfLayoutManagerTest.SwipingUpOnShelfInTabletModeForFullscreenAppList
> Bug: 801684
> Change-Id: I142180f8204fc413a46381c45267c7be9463c1ef
> Reviewed-on: https://chromium-review.googlesource.com/868453
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#529507}

TBR=xiyuan@chromium.org,sammiequon@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 801684
Change-Id: I5edae712f04a26eea47811e3f2fd69fd0b9c79d9
Reviewed-on: https://chromium-review.googlesource.com/877160Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530701}

The TaskManagerBrowserTest.IdleWakeup browser test was disabled for
flakiness. The issue is this test, written with Chrome Win in mind,
was expected to generate 1000s of idle wakes, but at least 100. However
on the Mac the idle wake count is lower on certain releases (e.g.
between 65 and 81 on macOS 10.12). This cl reenables the test on macOS
and lowers the expected wake count.

Bug: 636823
Change-Id: Idba223012e2e868c39bf2b27d02c167e3d3dbad2
Reviewed-on: https://chromium-review.googlesource.com/876920
Commit-Queue: Jayson Adams <shrike@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530700}

Replace it's usages (in tests) with a new KioskAppManagerObserver
method.

BUG=None

Change-Id: I45b569ed23bc69ac0d4888959769828453b3ed3d
Reviewed-on: https://chromium-review.googlesource.com/862242Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530699}

Overflow controls (scrollbars, resizers, scroll corners) need to be
clipped by the border box rect. When they would overflow the border
box rect, create a OverflowControlsClip property node and use it when
painting the overflow controls.

Bug: 771643
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I96e362c643ec1643d7099273fae11c0943360f10
Reviewed-on: https://chromium-review.googlesource.com/875257
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530698}

This test was recently enabled and seems to be timing out on Windows
sometimes. The test already has long timeout (<meta timeout long>), so
the last resort is to mark it as flaky timeout.

TBR=nednguyen@google.com

Bug: 803943
Change-Id: I0d3c3e3111d5144dfac62040fee2f4e7df06c769
Reviewed-on: https://chromium-review.googlesource.com/876922Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530697}

This is in preparation of fully removing paper-menu from third_party/polymer.

Bug: 802912
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic9b8a54d07b21ceb34d2f665db85c015d3cd386f
Reviewed-on: https://chromium-review.googlesource.com/876984Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530696}

This prepares the front-end for https://chromium-review.googlesource.com/c/chromium/src/+/861952,
which will cause requestWillBeSent and responseReceived to
be sent from a different target with regards to dataReceived
and loadingFinished events for the main resources.

Change-Id: Iae80c139e01523375689468866c228a15c2e6a89
Reviewed-on: https://chromium-review.googlesource.com/872255
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530695}

Bug: 733662
Change-Id: Ida6406a14b3a92ad2fa85fd4c376344f64989555
Reviewed-on: https://chromium-review.googlesource.com/877041Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#530694}

Previously ImageTransportSurface was creating GLSurfaceOSMesa, but
that this is wrong because GLSurfaceOSMesa doesn't support
SwapBuffers(). Updated ImageTransportSurface to call
CreateViewGLSurface(), which in turn creates GLSurfaceOSMesaHeadless.
That class handles SwapBuffers() correctly.

Bug: 778467
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I701dd219ad5867359ade613fbb1ea24d722f55f3
Reviewed-on: https://chromium-review.googlesource.com/876993Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530693}

Allow for certain number of UNKOWN fields between credit card fields.
Otherwise, we would miss some fields (CVC in most cases,) because
the detection of the fields are inter-dependent.

We can't allow for unlimited number of UNKONWN fields, because then
the name fields in the address sections may be detected as the card
holder name.

Tests:
test/135 the output was wrong, it's corrected.
test/141 the output was wrong, it's still wrong, it would need
another CL to fix the problem of the expiration date detection.
It is modified to let this CL pass the tests, but the problem is not
caused by this CL.

Fixes:
bbc.com (Desktop),
barnesandnoble.com (Desktop),
www.sky.com (Desktop),
homedepot.com, and .. .


Bug: 799990
Change-Id: Ie90bc7e33bee48e736af6783a697f680665ee3fc
Reviewed-on: https://chromium-review.googlesource.com/862698
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530692}

The GlassPane relies on an accurate scrollbar width to determine
correct popover dimensions. It used to hard code a number, but due
to overlay scrollbars, platform differences, and OS scrollbar size
settings, it could fail.

Screenshot: https://imgur.com/a/slnDX

Bug: 746861
Change-Id: I8d37ff1842ba201bf26cdf6de6596716c4eab092
Reviewed-on: https://chromium-review.googlesource.com/876656Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530691}

When build optimizations collide...

In order to avoid the non-trivial cost of including windows.h almost
everywhere the windows_types.h file was added. This includes enough
defines and types that many header files that previously required
windows.h can use it instead. However there are a couple of .cc
files - win_util.cc and process_metrics_win.cc - that need to include
windows.h before including their associated header files so that they
will get the full declarations of internal types. This sort of include
ordering guarantee is incompatible with jumbo files. This change solves
the problem in a more stable way by adding separate header files
which include windows.h and then unilaterally declare the necessary
Windows-dependent structs. These headers are then used when needed
to gain access to IoCounters and NONCLIENTMETRICS_XP.

This change also removes a redundant include of windows.h.

Bug: 796644
Change-Id: I81e3f8f21a7ba917e20f0a710285d7da64a95ae8
Reviewed-on: https://chromium-review.googlesource.com/872230
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530690}

String remains the same, but context is expanded on.

Bug: b/71972241
Change-Id: I522cb01d840fcc7204448c9c40dcfa869ee0e543
Reviewed-on: https://chromium-review.googlesource.com/876951Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530689}

Make a copy of the string in TracingUmaTracker to avoid crashes on
some platforms.

BUG=803856

Change-Id: Ie7a1f28c7b934d1087cd6ec6602cdc9dec1b1ca9
Reviewed-on: https://chromium-review.googlesource.com/876534Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530688}

Change-Id: I2c5b0d9fb800923cc68d49ee3293fe8299edfc12
Reviewed-on: https://chromium-review.googlesource.com/876684Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530687}

crrev.com/c/765642 makes user style sheets opt-in. In this patch we
implement the "cssOrigin" option for tabs.insertCSS, similar to Firefox.
If the value is set to "user", the CSS will be injected as a user style
sheet.

Style sheets specified in an extension's manifest are still injected as
author style sheets.

These are the code-level changes:

 1.  InjectDetails in extension_types.json now has a new "cssOrigin"
     property that takes the values "author" (default) and "user"
 2.  ScriptExecutor::ExecuteScript now takes a css_origin parameter of
     type base::Optional<CSSOrigin>
 3.  ExtensionMsg_ExecuteCode_Params now has a new member called
     css_origin of type base::Optional<CSSOrigin>, the value of which
     comes from the API call and is propagated down to
     blink::WebDocument

This API change is fully backwards compatible.

BUG=632009

Change-Id: Ia41ea4b917c7a9a4729e0a340ed7b3be43abdc11
Reviewed-on: https://chromium-review.googlesource.com/778402
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530686}

This CL fixes an issue when creating an impersonation LowBox token. The
new token's DACL is taken from the current caller's default DACL which
results in the an AC process not being able to open the token. This can
lead to weird bugs during the bootstrapping of a process.

Bug: 760977
Change-Id: Iac970feb2444f5aa6027838ce38bb88a3633caaa
Reviewed-on: https://chromium-review.googlesource.com/873920Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530685}

This matches the gpu rasterization benchmark using the same page set,
and hopefully should avoid timing out on the FYI waterfall.

Change-Id: I60132867929540e42c438a1e28ec412c35e15b00
Reviewed-on: https://chromium-review.googlesource.com/876958
Commit-Queue: enne <enne@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#530684}

The bug occurred in finding the valid target. Specifically if the root
has a transform we transform the event first, and then compare against
the size of the root. For transforms that result in increasing the
location (transform value < 1) the location would end up outside the
bounds of the window, which results in treating the location as in the
non-client area and targeting the root.

The fix for now is not to consider the root as a target for the non-client
area. A better fix may be to potentially transform the size by the
targets transform (if there is one), but I'm holding off on that for
now. We don't do scale bounds in WindowTargeter either.

BUG=794262
TEST=covered by tests

Change-Id: If7a913d934808fd4ffc404f74eea73d9f98b71ab
Reviewed-on: https://chromium-review.googlesource.com/877219Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530683}

RawInputDataFetcher previously stored information about each connected
gamepad in a RawGamepadInfo object internal to the data fetcher. This
CL renames the object to RawInputGamepadDeviceWin and moves more of the
capabilities and polling logic into that class.

BUG=749295

Change-Id: I9b2ad1f2712e3c14289a9d9a159a04c4cf952d4e
Reviewed-on: https://chromium-review.googlesource.com/875194
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530682}

This prevents the old image from being discarded until it has
been processed by the browser. It was possible to discard the
image before receiving the ack from the browser without this.
The result was a confusing UX, where the image had been
discarded, but was still appeared in the picture list.

Bug: 802218
Test: manual
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0d9006361919a4a11edd515929384131427e3b73
Reviewed-on: https://chromium-review.googlesource.com/874799Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530681}

Bug: 784495
Change-Id: Ia7a4450ea63eda77555b87357dda8834ea6ae3a4
Reviewed-on: https://chromium-review.googlesource.com/871573Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530680}

This was an incorrect conversion from the old UI; VPN should show
the proxy section.

Bug: 802930
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iba5385a7286b8fc2c2b92a5ab15a4add65b79870
Reviewed-on: https://chromium-review.googlesource.com/876983Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530679}

This performs reload in the browser, to make it more consistent with
regular reload expirience (e.g. warning about resubmitting POST
navigation would be shown now).

Bug: 614869
Change-Id: I90d36eb389b04cc41f5ab7524cbc6209bf100412
Reviewed-on: https://chromium-review.googlesource.com/860575
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530678}

https://pdfium.googlesource.com/pdfium.git/+log/f668ed47ae54..5ca283f37681

$ git log f668ed47a..5ca283f37 --date=short --no-merges --format='%ad %ae %s'
2018-01-19 rharrison Remove code added in by a bad rebase or merge
2018-01-19 hnakashima Fix CFX_Matrix.RotateAt()

Created with:
  roll-dep src/third_party/pdfium
BUG=803732,803735


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib98604211a47521d853516da68adcdf091973e43
Reviewed-on: https://chromium-review.googlesource.com/876882
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530677}

This was only recently noticed when Shill started setting the property.

Bug: 798924
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I031e0faf80fda62c006968009ab746d8c105e2de
Reviewed-on: https://chromium-review.googlesource.com/876881
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530676}

A handful of TestExpectations entries noted in crbug.com/508734 tracked
test behavior changes back when --enable-wptserve was a thing. Now it's
the default for imported tests, so rebaseline and/or update expectations
with specific tracking bugs.

Bug: 508728,508734,651778,803942,803949
Change-Id: I9b360f3f2e0d46320e0c063ce27f992cfd8d2e81
Reviewed-on: https://chromium-review.googlesource.com/876769Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530675}

The CSSGeneratedImageValue image and client cache has only
one slot for the size of the image associated with any given
client, but the client could be registered with an empty size
and a non-empty size. In such cases we would not over-write
the non-empty size with the empty size, despite having deleted
the non-empty image. Subsequently removing the client again
would try to remove the non-empty one instead.

This patch adds DCHECKs to catch these cases, and fixes the
logic to only store non-empty sizes. Comments are added explaining
the invariant that the client only be present at one non-empty size
at any given time.

R=fs@opera.com
BUG=803224

Change-Id: Ie5601aaffe6e3eace4ff4a989dc892bea4fd381b
Reviewed-on: https://chromium-review.googlesource.com/876900Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530674}

Screenshot: https://drive.google.com/file/d/1H0fFnEPwxOtIwXQ_XOyChjaR-V88klKq/view?usp=sharing

Bug: 803191
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1a41f51a82213f628a3ab11b5af341cc94f89a56
Reviewed-on: https://chromium-review.googlesource.com/876765Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530673}

R=piman@chromium.org

Change-Id: If0c213fe5b96ce874908a9ebafd92923c7c56be8
Reviewed-on: https://chromium-review.googlesource.com/877183Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530672}

Also refine GetActiveTextureUnit and FakeResourceProvider.
This was to followup https://chromium-review.googlesource.com/c/chromium/src/+/859106.

BUG=757291

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I40dd516e12c35a2388e9c857e87dbe83e638804c
Reviewed-on: https://chromium-review.googlesource.com/875530Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#530671}

GamepadSharedBuffer was internally creating an anonymous shared memory
object, prohibiting the object from being sharable as anything other
than read-write on some platforms.

This CL corrects the situation.

Bug: 803768
Change-Id: I122d71753be2dd02d12e5bb9f23c1bfc71623f34
Reviewed-on: https://chromium-review.googlesource.com/877042Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530670}