- 02 Oct, 2020 40 commits
-
-
Matt Jones authored
This patch replaces the TopToolbarOverlay's dependency on the ControlContainer with a callback for the progress bar's draw info. This will make chainging the ownership of TopToolbarOverlay from the LayoutManager to the TopToolbarCoordinator easier. Bug: 1100332 Change-Id: Id6cd9ae9f2ffe8b4dd70436c360147fb9877dcc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357955Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#813386}
-
Taylor Brandstetter authored
Fixes some windows compile warnings that were preventing fuzzers from being added; only minor functional changes since last update. https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/995c0b844144..2caaff2b0a1d $ git log 995c0b844..2caaff2b0 --date=short --no-merges --format='%ad %ae %s' 2020-10-02 tuexen Minor cleanup. 2020-10-01 deadbeef Call getrandom via syscall directly on Linux. (#533) 2020-10-01 tuexen I guess Bitrig support arc4random(). 2020-10-01 tuexen Whitespace change. 2020-10-01 tuexen Don't start SCTP/UDP receive threads (and don't open corresponding UDP sockets) when the UDP port specified in scpt_init() is 0. 2020-09-30 deadbeef Add missing return type to init_random. (#531) 2020-09-30 tuexen Try to fix the Windows build. 2020-09-30 tuexen Add Android specific code for the random number generator. 2020-09-30 tuexen Add platform specifc includes to the corresponding code. 2020-09-30 tuexen Add a cleanup routine for the random number generator. 2020-09-29 tuexen Improve the input validation and processing of cookies. 2020-09-28 tuexen Whitespace cleanup 2020-09-28 tuexen Improve random number generation on __Fuchsia__. 2020-09-27 tuexen Improve the handling of fragmented, unordered, and unreliable user data using DATA chunks in the receive path. 2020-09-26 tuexen Fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25984 2020-09-24 tuexen Whitespace changes 2020-09-22 deadbeef Avoid duplicate definition of _CRT_RAND_S. (#529) 2020-09-22 deadbeef Fix gcc/clang type mismatch warnings on Windows (#527) 2020-09-22 deadbeef Fix -Wunreachable-code in programs/ (#528) 2020-09-19 tuexen Improve consistency. 2020-09-19 tuexen Cleanup. 2020-09-19 tuexen Improve Windows build. 2020-09-19 tuexen Fix syntax error on windows. 2020-09-19 tuexen Add include for getrandom() on Linux. 2020-09-19 tuexen Fix type of init_random() on Linux and Windows. 2020-09-19 tuexen Improve Windows build. 2020-09-19 tuexen Improve consistency. 2020-09-19 tuexen Improve random number generation on Linux and Windows. 2020-09-19 tuexen Cleanup read_random(). No functional change. 2020-09-19 tuexen Fix NetBSD related #ifdef. 2020-09-19 tuexen Whitespace changes 2020-09-18 tuexen Add license. 2020-09-18 tuexen Add license statement. 2020-09-18 tuexen Fox more typos. 2020-09-18 tuexen Fix typo. 2020-09-18 tuexen Remove trailing whitspaces. 2020-09-18 tuexen Improve consistency, no functional change intended. 2020-09-18 tuexen Check for too short packets when using the receive threads. 2020-09-18 tuexen Fix mask for ECN bits. Created with: roll-dep src/third_party/usrsctp/usrsctplib Bug: chromium:1025302 Change-Id: I3faeb75f9f12d71b7b6ef3d326ad2e8d8becf3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430446 Commit-Queue: Taylor <deadbeef@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#813385}
-
Sammie Quon authored
Test: manual Change-Id: Ic3cfb8d62a72a07b9ced7d8de778b25134e16dca Fixed: 1134451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446531 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#813384}
-
Michael Checo authored
- Unnecessary because the "title" slot can be placed directly on the div that contains the title text content for the card. Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I4f5620c6c07d5afc28288fd04dd902ca5f92dc0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443499 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#813383}
-
Garrett Beaty authored
Bug: 1134662 Change-Id: I4a4d5f576110045ea355dc6c7fa11cb69711b37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446830Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#813382}
-
Xi Han authored
Bug: 1132948 Change-Id: I48988ab9e0aa9b8f17e93674ad443225b30ef837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446778Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#813381}
-
Kevin Babbitt authored
When the computed value of a property contains a color keyword, that keyword should be reported from the computedStyleMap API in its unresolved form. By contrast, getComputedStyle should report used values, i.e. rgb values, for certain properties per the CSSOM spec[1]. We don't currently distinguish between the two use cases for those properties. This CL introduces a distinction between computed and used values for serializing properties containing color keywords and passes the correct parameter at various call sites. The parameter does not yet influence serialization - that will come in a follow-up change - so no Web-facing behavior difference is expected. [1] https://drafts.csswg.org/cssom/#resolved-values Bug: 1112362,1099874 Change-Id: Ifcbd3d197b78195023f394b0e527907488990cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438010Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#813380}
-
Weiliang Chen authored
Since Android SurfaceControl code is not depended on GL, move it from ui/gl to ui/gfx. R=Khushal TBR=sadrul, kenrb Bug: 1134453 Change-Id: If73f518da053579180b9bf05b2b18f7d7d90dae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444533 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#813379}
-
Lei Zhang authored
For chromeosInfoPrivate and imageWriterPrivate, some apps remain active beyond the original 2017 deprecation date. Update the TODO comments so readers do not try to remove them. BUG=329088,510270 Change-Id: I78547cca1d5b46f31217e49aa1cbbbc9866b5d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591968Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#813378}
-
Mingjing Zhang authored
This is a reland of bfeec8b7. This CL fixes a use-of-uninitialized-value error in the original change. Original change's description: > Exclude no-update frames for jank detection > > > This CL improves the jank metrics by excluding the delays caused by > frames without intended updates and prevents certain outlier cases > when a high jank percent is reported on a page with very low percent > of dropped frames. > > Bug: 1133058 > Change-Id: If32576e8b528e22b184a0b549161751fcfd976bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417211 > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812988} Bug: 1133058 Change-Id: I270ca4ad044468e19136d3ed544c25de8ec3c916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446530Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#813377}
-
Findit authored
This reverts commit 239e4113. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 813342 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzIzOWU0MTEzYTBmYWVkYzdhMjY2NzcwYmQxNjQ1ZTQ3OGY0ZmU5ZTQM Sample Failed Build: https://ci.chromium.org/b/8867519387170143872 Sample Failed Step: compile Original change's description: > [Autofill] Move legacy server request/response protos to be test only > > > Bug: 1114655 > Change-Id: If1f6a68aa8f42b4e5df16b862022f5547ac08b1e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442733 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813342} Change-Id: Ic183da760ca10d8d03f03ebf5c43fade7ff6b4f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446557 Cr-Commit-Position: refs/heads/master@{#813376}
-
Anastasia Helfinstein authored
TBR=dmazzoni@chromium.org AX-Relnotes: n/a. Bug: None. Change-Id: I242cdd57d3f762684c613a826e6787a26f18e35c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446657Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#813375}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/375fee944c76..16636f480f81 2020-10-02 vantablack@google.com Added support for AndroidHardwareBuffer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I41519c4559cfefe0d5f1cb87433c241d10047c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446751Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813374}
-
Dominic Mazzoni authored
This is one more step towards enabling the flag AccessibilityExposeHTMLElementEnabled to include the HTML element in the accessibility tree. Bug: 1063155 Change-Id: I3160bf5f9d39b46e2f7ff08ea81215ee7765e4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441282 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#813373}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/36366209d412..6d696086211d 2020-10-02 johnstiles@google.com Store a unique_ptr* for a candidate's parent statement. 2020-10-02 egdaniel@google.com Always bind input attachment to all pipelines in subpasses that uses one. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1134454 Tbr: brianosman@google.com Change-Id: Idfac697a3bd46168f0ec2aea96edf73b4c67219e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446756Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813372}
-
Siyu An authored
Bug: 1112095 Change-Id: I3137ed5e2bda1a3408b1c08d5f163e159780a7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444456Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#813371}
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ib7591b14f25a67815a9a19eb09745b62d0560631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431411 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#813370}
-
Ted Meyer authored
(use_v4l2_codec || use_vaapi) was being used as a poor proxy for chromeos builds. Also reformat the file. Change-Id: I9eb3615935c7cbc07f7f0918dad40ce80468c760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441733Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#813369}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/be7345166a4f..77107392837f 2020-10-02 rwkeane@google.com [Discovery] Fix MdnsRecord Comparison Bugs 2020-10-02 jophba@chromium.org Add more trace logging to standalone_ impls 2020-10-02 jophba@chromium.org [Minor] fix periods in headers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I174576872ef782a03d747e35cdfb7d585915d397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446752Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813368}
-
Sven Zheng authored
This reverts commit 01d5d6cf. Reason for revert: Breaks lacros builder. https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-builder-rel/4366? Original change's description: > Switch angle_unittests to isolated script API. > > Uses the new 'use_isolated_scripts_api' feature added here: > https://crrev.com/c/2425210 to switch the tests to the ANGLE > standalone testing harness. > > Bug: angleproject:5124 > Change-Id: I363997060874df09653bcb78bb9c57f3cce3f6e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441149 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813269} TBR=ynovikov@chromium.org,dpranke@google.com,jmadill@chromium.org Change-Id: I7d8a8b4f312038c40d8090d30b95da23ccc17df2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:5124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446655Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#813367}
-
Aleks Totic authored
NGTableTypes::Columns is not dependent on ConstraintSpace, and can be shared between MinMax/Layouts. It gets cached in LayoutNGTable. Cache is invalidated by LayoutObject bitfield: TableColumnConstraintDirty() TableColumnConstraintDirty gets set when table needs layout (SetNeedsLayout/SetChildNeedsLayout) Cached Columns need to be immutable. Had to modify few parts of code that assumed Columns were mutable, mostly in NGTableAlgorithmHelpers. Some related fixes in ng_length_utils included, will need review. Few minor fixes that were in the same files included too. Bug: 958381 Change-Id: I497c03b2e0b8c8d58b90cde8d0f21f240bac573a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436302 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#813366}
-
David Van Cleve authored
We're seeing a surprising number of "TypeError: Failed to fetch" errors in live testing when executing fetches with accompanying Trust Tokens operations (see the linked bug---internal due to describing metrics, sorry---for more information). Analyzing logs added in crrev.com/c/2416882 shows that these failures are *not* due to an increased incidence of connection-related errors (DNS, ERR_CONNECTION_FAILED, etc), so it seems likely that they could be due to some kind of Fetch API requirement being violated closer to the fetch callsite. This CL adds some temporary logging to fetch_manager.cc that, for failed fetches with accompanying Trust Tokens operations, histograms a reason why the fetch failed. This is the union of: - a new enum that captures each code path into FetchManager::Loader::Failed - a ResourceRequestBlockedReason. I've filed crbug.com/1133944 to track cleaning up these log lines after the investigation has finished. Test: expands trust_token_browsertest to cover some logging cases Bug: 1128174 Change-Id: Idbe424a3b68939a687ea1243cf1b9a681e82e51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442229Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#813365}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601575120-30d2ff52ccba123fa446e04afa93e5dc42388f0f.profdata to chrome-mac-master-1601661327-f1cf60f844e0debf5bf4063a28b1716a25f6a438.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: If59e218148889559065bee5046033f835ee76884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446758Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813364}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/39117d2b244e..e4b0c039a1f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kelvinjiang@google.com,anthonyvd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1134625 Tbr: kelvinjiang@google.com,anthonyvd@google.com Change-Id: I0f95bb530630bddcad88e49aa5e4456609e7936f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446753Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813363}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c0482f7bd156..9b8970cc0198 2020-10-02 treehugger-gerrit@google.com Merge "Reserve space for frames in AllocRecord." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia4c76bbceafcfca75f862c3e7970e8136dbe7fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446757Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813362}
-
Akihiro Ota authored
The interactive tutorial uses hard-coded strings to specify text content. Included in this patch: 1. Add tutorial_common.js, which can be used to share code between the tutorial and lesson components 2. Add a function, getMsg(), to fetch localized strings 3. Change some hard coded strings to message IDs 4. Clean up BUILD.gn fr and es) and verify that content gets translated. Bug: 1075752 Test: Manually load the tutorial in several locales (I used Change-Id: I5784f1466f3646e31a41145478db9dfcb766f70e AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254345 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813361}
-
Anne Lim authored
Bug: 1121806 Change-Id: I8a24e775c3b3955a86d606d199f6ee966f681ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444431Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#813360}
-
Tommy Li authored
We are no longer using ZeroSuggestVariant. Instead, we are moving to using separate base::Feature flags for each experiment. See here for a discussion about removing this: http://g/chrome-omnibox-team/lNT8EsY1gFI Bug: 1124050 Change-Id: I20fb3d79ad2ab64fb7daf52729449cbad3193e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430227 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#813359}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8c88c750bd45..b494582b95e5 2020-10-02 bsheedy@chromium.org Revert "Make Catapult build as a part of Chromium under Python 3." 2020-10-02 bsheedy@chromium.org Revert "[Devil] Add install sanity check" 2020-10-02 landrey@webrtc.org Reduce upload completion token usage back to 5% 2020-10-02 dpranke@google.com Make Catapult build as a part of Chromium under Python 3. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1112471,chromium:1114061,chromium:1132297,chromium:1134629 Tbr: oysteine@google.com Change-Id: I7496a084db82d0b09b4e5410b9ed78eb16a38618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446750Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813358}
-
Dave Tapuska authored
The content side was deferring to the gfx:: structs so just use them on the public blink API. BUG=738465 Change-Id: I4f8f449d86310fa80b72054c8465756a17b90f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443534Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#813357}
-
Bo Liu authored
This reduces binary size. Change-Id: I99d5567246baa03865bd822b9b7f6dced1fdecf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446020Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813356}
-
David Bienvenu authored
This reverts commit 1a8fc80a. Reason for revert: <relanding with fix for crbug.com/1132543> Original change's description: > Revert "Make Launch.Modes an enum histogram, not sparse." > > This reverts commit 085b583f. > > Reason for revert: <crbug.com/1132543> > > Original change's description: > > Make Launch.Modes an enum histogram, not sparse. > > > > In response to comment on crrev.com/c/2384332. > > > > Per mpearson@: For enums versus sparses, the underlying UMA > > data / logs will look the same. It's only the implementation > > in Chromium that would be different. > > > > Change-Id: Ia75d78379977f36ec7873d5fb5d52998e6a366d3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429975 > > Reviewed-by: Peter Boström <pbos@chromium.org> > > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#810438} > > TBR=pbos@chromium.org,davidbienvenu@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: Ia7edc131b855a4ceb384b8e2d76055386d1044c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433060 > Reviewed-by: David Bienvenu <davidbienvenu@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811005} TBR=pbos@chromium.org,davidbienvenu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia1a2167c31b5bcb076e9f334151a46e369cc676a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436390Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813355}
-
James Cook authored
Exercise the basic API (create, get, close). This test depends on the parent CL which adds the API for GetDisplayedNotifications. Bug: 1134389 Test: lacros_chrome_browsertests Change-Id: Ia8da142ee0f0ee60af2664098ebd11dc06a2a1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445851 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#813354}
-
Morten Stenshorne authored
In certain cases it was possible to lay out stuff before and after a spanner in the same column, because we didn't detect that something broke. This was due to an ancient out-of-space check in FinalizeForFragmentation(), which sometimes prevented us from finishing fragmentation correctly (the assumption was that if there's zero space left, this fragment can't fit here (so just return early), but that's not necessarily true). Check correctly for out-of-space in the generic fragmentation machinery instead. This addresses a TODO about DCHECKing that we broke inside when encountering a spanner. Bug: 829028 Change-Id: I86af5dcdf01e44c2b0d05d7c6c04821000b25426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443854 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#813353}
-
Lijin Shen authored
PackageManagerUtils#resolveDefaultWebBrowserActivity can return null. The utils should return no in this case. Bug: 1131772 Change-Id: I7421d250e01ca8149e284e474c5c8852a79b3668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436393 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#813352}
-
Thomas Lukaszewicz authored
This CL adds class member getters and setters to the BoxLayout class where needed for the BoxLayoutView properties. Adds a TODO to ensure layout is invalidated when these members are set. Bug: None Change-Id: I13d73c75ca93f9de391b46c7241682ee7ced9a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434561Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#813351}
-
Alexander Cooper authored
While not fully moving the InstallHelpers to a component yet, this reduces their dependency on //chrome specific code, and gets them a step closer to being moved to //components. The main dependencies that needed to be broken were on Tab/TabUtils. Tab was typically used to get the WebContents and the Activity. WebContents are now passed directly in, rather than gotten from the Tab (which in C++ code was gotten from the WebContents anyway...), and are then used to get the top level window and thus the appropriate corresponding activity. In addition to removing these dependencies on TabUtils, the ArCore's install helper *also* now uses ApplicationStatus to track when it is resumed, thus reducing it's dependency on ChromeActivity. This is similar to what Vr does for it's DFM install. VR's install path is a bit different in that it launches an activity for a result, and thus that is not changed quite yet. Bug: 960542 Change-Id: Ia42a73ecd1c491ee9899f8113a2905860b66366a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438639 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#813350}
-
Kai Ninomiya authored
TBR: kbr@chromium.org Bug: 663601, 679058 Change-Id: Ib861dc6a8e40cc2038359a04113db757fb8d210e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446594Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#813349}
-
evliu authored
This is a reland of 6ff69d8a Original change's description: > Move SODA client unit test to Chromium repo > > This CL moves the SodaClientUnitTest from the internal SODA repo to the > Chromium repo. > > Bug: 1124873 > Change-Id: Ib2dabb242f21817a117f379fb0a1b017dd5bcffc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443218 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Evan Liu <evliu@google.com> > Cr-Commit-Position: refs/heads/master@{#812968} Bug: 1124873 Change-Id: Ic6de3f55a80d15165a92fb474b41b8999394aa8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444116Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#813348}
-
Nick Harper authored
Change-Id: I87ccef2bb33ee0651a254ac539b8ad21872df6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437475Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#813347}
-