GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146086 0039d316-1c4b-4281-b951-d872f2087c98

No UI changes were shipped (apart from the startup option string change).

BUG=133904
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10689116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146084 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146083 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jbates@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10704152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146082 0039d316-1c4b-4281-b951-d872f2087c98

This is a band-aid fix that runs ui_unittests when runing chrome_tests.sh with a '-t gfx' option. Also, it renames an exclude file to use it when running ui_unittests.

BUG=none
TEST=make valgrind and heapchecker bots green.
Review URL: https://chromiumcodereview.appspot.com/10698146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146081 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101244
TEST=N/A, only moving code, no change in functionality


Review URL: https://chromiumcodereview.appspot.com/10696144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146079 0039d316-1c4b-4281-b951-d872f2087c98

Revert 146038 as it might have broken chromeos browser_tests - Make eventArgumentMassagers asynchronous so custom bindings don't need to override chrome.Event.prototype.dispatch.

BUG=121479

Review URL: https://chromiumcodereview.appspot.com/10704073

TBR=koz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10736024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146078 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10695140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146077 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10701135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146076 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10693135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146075 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10700154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146074 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10693138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146073 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10702139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146072 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10696166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98

This change prevents using the spellcheck service when Chrome is launched with a --disable-asynchronous-spellchecking flag because the spellcheck service depends on asynchronous spellchecking.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10753023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146070 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=compiles, works, passes tests
R=csilv@chromium.org,thestig@chromium.org
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10698140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146069 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10689154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146068 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10693137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146067 0039d316-1c4b-4281-b951-d872f2087c98

To support this, shortcut creation on Linux for extensions has been modified so that the filename encodes the extension ID and the profile. Also, when creating shortcuts any existing shortcuts are removed first.

Web page shortcuts are not affected.

BUG=130456
TEST=Test uninstalling apps removes their shortcuts; test uninstalling
apps is not broken in any way; test shortcuts for web apps
are not broken in any way.


Review URL: https://chromiumcodereview.appspot.com/10698114

TBR=benwells@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10735048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146066 0039d316-1c4b-4281-b951-d872f2087c98

To support this, shortcut creation on Linux for extensions has been modified so that the filename encodes the extension ID and the profile. Also, when creating shortcuts any existing shortcuts are removed first.

Web page shortcuts are not affected.

BUG=130456
TEST=Test uninstalling apps removes their shortcuts; test uninstalling
apps is not broken in any way; test shortcuts for web apps
are not broken in any way.


Review URL: https://chromiumcodereview.appspot.com/10698114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146065 0039d316-1c4b-4281-b951-d872f2087c98

Instead of DCHECKing (and then later crashing) if the state machine thinks it should be uploading old logs, but there aren't any, just advance the state and return.

This should prevent crashing in edge cases where something else has gone wrong and the state is out of sync.

Also change StageNextLogForUpload to CHECK instead of DCHECK that there is a next log before doing a swap(), since swap()ing in garbage pointers leads to hard-to-understand crashes later.

BUG=135285
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10692059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146064 0039d316-1c4b-4281-b951-d872f2087c98

[NTP4] Fix pane switcher images while we figure out the difference between <structure type="chrome_html">s and <include type="BINDATA">s.  This is partial revert of r145332.

R=tbreisacher@chromium.org
BUG=136389
TEST=Pane switchers have arrows again.


Review URL: https://chromiumcodereview.appspot.com/10689155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146063 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10763011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146062 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134821
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10704062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146061 0039d316-1c4b-4281-b951-d872f2087c98

TBR=
BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10754002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146060 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136625
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10690126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146059 0039d316-1c4b-4281-b951-d872f2087c98

The leakage ocurrred on failure.

BUG=136597
TEST=tools/valgrind/valgrind.sh  --leak-check=full  out/Release/unit_tests --gtest_filter=GDataDBTest.*

Review URL: https://chromiumcodereview.appspot.com/10735040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146058 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10689131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146057 0039d316-1c4b-4281-b951-d872f2087c98

This just reflects --enable-drive-v2-api flag for use by drive API code.
Not used by anyone so far.

This code depends on https://chromiumcodereview.appspot.com/10753024/

BUG=chromium:127728
TEST=compile

Review URL: https://chromiumcodereview.appspot.com/10692149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146056 0039d316-1c4b-4281-b951-d872f2087c98

This is a part of effort to remove CrosLibrary and its belongings.

BUG=126719
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10701075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135388
TEST=run chrome on Server 2003 SP2 x86.
TBR=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10701125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146054 0039d316-1c4b-4281-b951-d872f2087c98

TBR=satorux@chromium.org
BUG=chromium-os:32464
TEST=

Review URL: https://chromiumcodereview.appspot.com/10736023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146053 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=ran chromeos_unittests


Review URL: https://chromiumcodereview.appspot.com/10704118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146052 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE


Review URL: https://chromiumcodereview.appspot.com/10413036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146051 0039d316-1c4b-4281-b951-d872f2087c98

Original codereview at http://codereview.chromium.org/10766016/

[Sync] Add location parameter to SyncChange in Sync API.

SyncChanges now require the location they were created as a parameter. This
is then used in the case that the change violates and invariant. We display
the location and type of erroneous change in about:sync, in addition to
disabling the offending datatype.

TBR=stevet@chromium.org, rlarocque@chromium.org
BUG=135108
TEST=unit_tests


Review URL: https://chromiumcodereview.appspot.com/10690128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146050 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146049 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10698143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146048 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10692150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146047 0039d316-1c4b-4281-b951-d872f2087c98

gdata: Move GDataFileSystem::AddUploadedFile() call out of uploader and into GDataDownloadObserver class.

The async GDataFileSystem::AddUploadedFile() call causes the file to be moved to the gdata cache. This must be invoked after DownloadObserver receives the COMPLETE status notification.

BUG=136435
TEST=unit_tests, lumpy

Review URL: https://chromiumcodereview.appspot.com/10759007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146046 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136474
TEST=./build/android/run_tests.py -s out/Release/base_unittests_apk/base_unittests-debug.apk -e 1


Review URL: https://chromiumcodereview.appspot.com/10692132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146045 0039d316-1c4b-4281-b951-d872f2087c98