- 21 Nov, 2017 40 commits
-
-
dpapad authored
Also fixing remaining ESLint violations automatically with --fix flag. Bug: 720034 Change-Id: I3fe1b0fbe7b559316a26c1526abacbde0486f418 Reviewed-on: https://chromium-review.googlesource.com/775597 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#518379}
-
Sidney San Martín authored
Bug: 773944 Change-Id: Ic1ed323b5facb6479bdbeaf319260269426400a8 Reviewed-on: https://chromium-review.googlesource.com/783250Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#518378}
-
Owen Min authored
With this new flow parameter value, sign in dialog will not contains chrome sync related information in the embedded sign-in page. Bug: 784582 Change-Id: I2b315d381750bc1ad3932d5a8bf3edcab8a64285 Reviewed-on: https://chromium-review.googlesource.com/775693 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#518377}
-
Miguel Casas authored
This CL moves gpu_jpeg_decode_accelerator_factory_provider.* from //media/gpu/ipc/service/ to //media/gpu/ and renames them (and the class inside) to GpuJpegDecodeAcceleratorFactory, updating call sites. No new code is intended. TBR=rjkroege@chromium.org for components/viz/...gpu_service_impl.cc since it's pure renaming. Bug: 787176 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia85d58a9906752f49a5362c7cb85605986e44445 Reviewed-on: https://chromium-review.googlesource.com/781583 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#518376}
-
Koji Ishii authored
This patch fixes NGBoxFragmentPainter::PaintText to check cached drawing before it creates DrawingRecorder. This is currently the top crasher when NGPaintFragments is enabled, and this patch fixes ~7000 crashes. Bug: 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3cac0517e06b52b394ab0838db441cbb0a971296 Reviewed-on: https://chromium-review.googlesource.com/773791 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#518375}
-
Eric Lawrence authored
On ChromeOS, any prior observation of a policy-installed cert is an indicator of a MITM being present (the enterprise). Previously, the SECURE_WITH_POLICY_INSTALLED_CERT security level was returned even if the page contained mixed content or used a SHA-1 certificate. Instead, such problems should impact the security level instead of being ignored. Bug: 756639 Change-Id: I4e87fc6039eb76ff8b5b87612c5d0dc004ddd867 Reviewed-on: https://chromium-review.googlesource.com/779743Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#518374}
-
Vlad Tsyrklevich authored
This is a reland of e77256b1 now that crrev.com/00fb4b7e landed fixing the lock-up issue we previously saw. Original change's description: > [cfi-icall] Use ProtectedMemory for localtime ptrs > > Control Flow Integrity [1] indirect call (cfi-icall) checking can not > verify that dynamically resolved function pointers call their intended > function. Instead we place the LibcFunctions pointers in > ProtectedMemory, a wrapper for keeping variables in read-only memory > except for when they are initialized. After setting the pointers in > protected memory we can use the UnsanitizedCfiCall wrapper to disable > cfi-icall checking when calling them since we know they can not be > tampered with. > > [1] https://www.chromium.org/developers/testing/control-flow-integrity > > Bug: 771365 > Change-Id: Ib74faff066e1107293b67d11f2a1a054bbff08b5 > Reviewed-on: https://chromium-review.googlesource.com/769853 > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517152} Bug: 771365 Change-Id: Iaba5de8e37332878cd0b85c9dbdafc08e2d9a6ba Reviewed-on: https://chromium-review.googlesource.com/782739Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#518373}
-
Bugs Nash authored
This is to prevent upcoming larger style builder functions from making the headers difficult to read This patch - Added a comment to section off style builder functions in the property class header files for readability - Moved style builder functions to end of class so that that section does not merge with another optional section - Changed the condition to print style builder functions from should_declare to should_implement so that the comment does not appear for classes that have not yet had the style builder methods moved into them. The should_declare member is kept as it will be required in future for declaration only cases. Diff of generated files: https://gist.github.com/BugsNash/49febc392af82920fea3e59e6c7d3224/revisions Bug: 751354 Change-Id: Ic664b6fcad97d70bf24d46428561fff2dd6107a0 Reviewed-on: https://chromium-review.googlesource.com/780160 Commit-Queue: Bugs Nash <bugsnash@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#518372}
-
Peter Lee authored
This reverts commit 2d1368a2. Reason for revert: This will break on iOS 11.2 beta Original change's description: > Calls decisionHandler asynchronously, part 2 > > Only one of two calls to decisionHandler was converted to async in > http://crrev/c/773570. This changes the other call. > > Bug: 774736 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Ie72c6efc42e5921eae8983d01f4be29fd3934d98 > Reviewed-on: https://chromium-review.googlesource.com/777400 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Peter Lee <pkl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517730} TBR=eugenebut@chromium.org,pkl@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 774736 Change-Id: I589fdeee11059b25edc1f755c0411f8ff9d7e87f Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/782744Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#518371}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/120c19b6a193..135c6601bd9d $ git log 120c19b6a..135c6601b --date=short --no-merges --format='%ad %ae %s' 2017-11-21 thestig Add {Byte/Wide}String::Trim(). 2017-11-21 thestig Clean up CJS_PublicMethods. 2017-11-21 dsinclair Make CXFA_CaptionData methods const 2017-11-21 dsinclair Make CXFA_CalculateData methods const 2017-11-21 dsinclair Remove unused CXFA_BoxData methods 2017-11-21 dsinclair Cleanup CXFA_BindItemsData methods 2017-11-21 dsinclair Cleanup CXFA_EventData methods 2017-11-21 dsinclair Rename CXFA_DataData::TryMeasure 2017-11-21 dsinclair Remove unused CXFA_DataData::SetMeasure 2017-11-21 dsinclair Convert CXFA_WidgetData methods to Optional 2017-11-21 dsinclair Rename the CXFA_WidgetData size methods from Get to Try 2017-11-21 dsinclair Make CXFA_MarginData::Try* methods return Optional 2017-11-21 dsinclair Add CXFA_MarginData::Get*Inset helpers Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I67288b0345817e8fcf2bff7169fcac484bf02f0f Reviewed-on: https://chromium-review.googlesource.com/782620 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518370}
-
Michael Thiessen authored
Moves the concept of disabling magic window poses into VRDeviceBase. Bug: 777868 Change-Id: I5ab317faf5ad04abb47558e041446cfc1a484da0 Reviewed-on: https://chromium-review.googlesource.com/776165 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#518369}
-
Christopher Cameron authored
Ensure ca_context_id be initialized to 0 (otherwise the browser will attempt to use it). TBR=zmo Bug: 785599 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idcc8b0e6922c9842ecc7462fe93788aa942793db Reviewed-on: https://chromium-review.googlesource.com/779306Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#518368}
-
Min Qin authored
This logic is present in ResourceDispatcherHostImpl::ContinuePendingBeginRequest(). However, it is missing in URLLoader when constructing the URLRequest. The bug causes the wrong cookie to be presented if server redirection happens. DownloadContentTest.DownloadAttributeSameSiteCookie should provide test coverage for this CL. BUG=787046 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I708ecba1c386d101ae21e968351732a15fb6f31f Reviewed-on: https://chromium-review.googlesource.com/779065Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#518367}
-
Yixin Wang authored
Allow HttpNetworkSession::Params::quic_max(_idle)_time_before_crypto_handshake to be set by Cronet experiments Bug: 780964 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib405bcdd6ae986f0eb2f6e1be9f360a61dbf1e3c Reviewed-on: https://chromium-review.googlesource.com/778043 Commit-Queue: Yixin Wang <wangyix@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#518366}
-
Yuwei Huang authored
These code are no longer used and can be removed. Bug: 786616 Change-Id: I81782e7935026d36c9d3207da4db11c80057e3bf Reviewed-on: https://chromium-review.googlesource.com/780585Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#518365}
-
Julia Tuttle authored
Bug: Change-Id: I2412fd464a2efc2a5fe1900818804b636cc43d59 Reviewed-on: https://chromium-review.googlesource.com/779251Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#518364}
-
Yuwei Huang authored
The percentage of seeing a GLES2-only device is low but it's still safer to handle that, given that doing so requires only a few more lines. Bug: 787224 Change-Id: I63650f3ce4c2afe93492b81e30d7075d7007ebdc Reviewed-on: https://chromium-review.googlesource.com/780801Reviewed-by:
-
Andrey Kosyakov authored
Bug: 787173 Change-Id: Ia5d9aec2b96b5cfbfb25ff71d3a436a3575c16fd Reviewed-on: https://chromium-review.googlesource.com/782141Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#518362}
-
Min Qin authored
BUG=778255 TBR=dtrainor@chromium.org Change-Id: I599eec2a7123584d4943171e15da326ec730325d Reviewed-on: https://chromium-review.googlesource.com/783275Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#518361}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c11c947e..fdf73522 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib5a7e4de403a8a58e82b5fcce537e0fa4056991c Reviewed-on: https://chromium-review.googlesource.com/782459Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#518360}
-
danakj authored
TextureMailboxDeleter has nothing to do with the now-defunct TextureMailbox, it just deletes textures. So name it so. While doing so we uncovered a use of base::ThreadTaskRunnerHandle::Get() in GLRenderer, which may not be the same task runner given to the compositor to run its tasks on, so change things to plumb in the task runner to GLRenderer. Then creators of GLRenderer do not need to make a TextureDeleter anymore, so have GLRenderer do that itself. While sorting this out, clean up the GLRendererCopier tests to not subclass GLRendererPixelTest, and make and destroy a GLRenderer. Instead subclass PixelTest and make only the things it needs. R=ccameron@chromium.org TBR=boliu Bug: 769423 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I15a93b3f858fd52272341e19edf8e5ed989721dd Reviewed-on: https://chromium-review.googlesource.com/782403 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
yiyix authored
This patch is aimed to reduce the running time of draw occlusion algorithm. In draw occlusion, quad++ is used to increase the iterator pointer to visit the next draw quad. In reality, the quad++ calls cc::ListContainer::Iterator::operator++ and creates a new Iterator which points at the next draw quad. As a result, quad++ is always the top 3 expensive line in draw occlusion. BEFORE: 91.61% viz::Display::RemoveOverdrawQuads(CompositorFrame) 32.21% cc::ListContainer::viz::DrawQuad::Iterator 29.26% cc::ListContainer::viz::SharedQuadState::end 7.42% cc::ListContainerHelper::PositionInCharAllocator 4.40% cc::ListContainer::viz::SharedQuadState::begin 4.23% gfx::Transform(SkMatrix44) 1.59% cc::ListContainer::viz::SharedQuadState::Iterator AFTER: 91.51% viz::Display::RemoveOverdrawQuads(CompositorFrame) 83.37% viz::Display::RemoveOverdrawQuads(CompositorFrame) 32.04% cc::ListContainer::viz::SharedQuadState::end 29.08% cc::ListContainer::viz::SharedQuadState::ConstIterator 7.54% cc::ListContainerHelper::PositionInCharAllocator 4.75% cc::ListContainer::viz::SharedQuadState::begin 4.35% gfx::Transform(SkMatrix44) 0.99% cc::ListContainer::viz::SharedQuadState::ReverseIterator ref: https://docs.google.com/document/d/1gM4h1ca2jDWdXbYa9yjC53m0sJzaT9skqbPGnfDsdyI Bug: 672929 Change-Id: I377ab3af3fdfa7e3d7ceb42dcfc2056de149424d Reviewed-on: https://chromium-review.googlesource.com/782063 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#518358}
-
Gurchetan Singh authored
CMAA makes graphics_WebGLPerformance go from 2 failures to 67 failures. These failures are triggered by GL errors: GL ERROR :GL_INVALID_FRAMEBUFFER_OPERATION : glFramebufferTexture2D Let's disable CMAA so we don't break WebGL on Tegra. BUG=b:67387379, chromium:787087 TEST=graphics_WebGLPerformance failures return to normal on Tegra NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iacaf76ee7a0c9c0f249075f6b65c0e53ace09552 Reviewed-on: https://chromium-review.googlesource.com/780430 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#518357}
-
Mike Baxley authored
These Tools menu items are used in several tests. Remove the dependency of tests on tools_menu_constants.h. Bug: 787015 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie5d6b180f86d2628737c96feed96245c095d374a Reviewed-on: https://chromium-review.googlesource.com/780051 Commit-Queue: Mike Baxley <baxley@chromium.org> Reviewed-by:
Menglu Huang <huangml@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#518356}
-
Eugene But authored
It is possible for WKWebView.URL to be empty inside webView:didCommitNavigation:. That's probably a bug, but WKWebView.URL does not represent last committed URL anyway, so it is safer to fallback to WKBackForwardList's currentItem when WKWebView.URL is nil. Using webView.backForwardList.currentItem.URL everywhere is not an option because that URL is not correct for WebUI pages loaded via loadHTML:. After dropping iOS 10 and switching WebUI to iOS 11's custom URL protocols it might be possible to use webView.backForwardList.currentItem.URL unconditionally. Bug: 784480 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2c2cdb9fad425afec6756bc8e841389e979d066b Reviewed-on: https://chromium-review.googlesource.com/773621 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#518355}
-
Etienne Bergeron authored
The vector exception code used by chrome is incompatible with ASAN 64. The following patch is commenting out the code when ASAN is present. See comment in the code for details. R=rnk@chromium.org, siggi@chromium.org, inferno@chromium.org Bug: 783296 Change-Id: I8dbe192e658225840fe2249e99d9b84b518f558b Reviewed-on: https://chromium-review.googlesource.com/782399 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#518354}
-
Philip Rogers authored
paint/invalidation/svg/js-update-stop-linked-gradient.svg: This test was recently updated which removed gradient stops: https://chromium.googlesource.com/chromium/src/+/e3276a9902608cd3930d2a1dad67d56b5ae98313 This patch updates the RLS expectation too. http/tests/devtools/agents-enable-disable.js (and virtual variant): This test is crashing on all platforms but the expectation was marked as timeout on just mac. plugins/mouse-events-fixedpos.html: This test is crashing flakily (see: https://crbug.com/786117). To make it easier to update the expectations file, a new section for flaky tests has been added. Bug: 781419, 786117 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: Iba1f45b03a1ac2093c48a2cfcabf70c6f93a9d4d Reviewed-on: https://chromium-review.googlesource.com/779760 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#518353}
-
Peter Collingbourne authored
Running content_unittests on Android with CFI bad cast checks enabled [1] revealed two bad cast errors in accessibility: a bad cast from CountedBrowserAccessibility to BrowserAccessibilityAndroid in browser_accessibility_manager_android.cc:69 and from TestBrowserAccessibilityManager to BrowserAccessibilityManagerAndroid in browser_accessibility_android.cc:148. In the former case, the code from BrowserAccessibilityAndroid can easily be inlined into the caller, so this patch does that. In the latter case, the caller is accessing a field that is only present on BrowserAccessibilityManagerAndroid, so the fix is to derive TestBrowserAccessibilityManager from BrowserAccessibilityManagerAndroid on Android platforms. This change hopefully fixes the memory error that was detected by asan. In a followup I plan to attempt to re-enable these tests on Android with asan. [1] https://build.chromium.org/p/chromium.clang/builders/ToTAndroidCFI/builds/397/steps/content_unittests%20on%20Android Bug: 469376 Change-Id: I4560451ec276ab1057feac3ef906daf5fc045ca3 Reviewed-on: https://chromium-review.googlesource.com/780884 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#518352}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/03fd0356b4c9..378734c51221 $ git log 03fd0356b..378734c51 --date=short --no-merges --format='%ad %ae %s' 2017-11-20 jmadill D3D11: Lazy evaluation for draw call vertex params. 2017-11-20 oetuaho Remove unreferenced struct types from the AST Created with: roll-dep src/third_party/angle BUG=786535 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I6242b15e81048eee80e86cca5198bfbe8699a90c Reviewed-on: https://chromium-review.googlesource.com/782443Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518351}
-
Jose Dapena Paz authored
Avoid duplication of the g_type_init call and reuse the guard to call it only one time from AXPlatformNodeAuraLinux initialization. Bug: 784583 Change-Id: I4ef553f8f123f3c76a6610c7c94ac1e2e3363a47 Reviewed-on: https://chromium-review.googlesource.com/781760 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
This triggered a DCHECK in the OpenTypeVerticalData code since the fallback font did not have a HHEA table. It couldn't have, since the fallback font for the PUA U+F6DB codepoint was a Type1 font which was not filtered out correctly in the per-character fallback code path. Test: NoType1InFallbackFonts in font_fallback_linux_unittest.cc Bug: 785517 Change-Id: I79f0811625adb5dbc77fdd62db08d0be68606857 Reviewed-on: https://chromium-review.googlesource.com/781864Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#518349}
-
Kenneth Russell authored
When needed, during reallocation of a depth-stencil renderbuffer, create a new object and point all existing framebuffer objects to it. Apply this workaround on NVIDIA GPUs on macOS 10.13 and later. This works around an apparent bug in the graphics driver introduced in this release. This is a slight expansion of the earlier multisample_renderbuffer_resize_emulation workaround. Remove associated failure expectations. Also update the bug ID in the conformance expectations for a workaround applying to the same platform. BUG=775202, 786717, 784817 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I051009b17df1cb5dabe1b00fbdcc35008042eee9 Reviewed-on: https://chromium-review.googlesource.com/780211Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#518348}
-
Elly Fong-Jones authored
Right now, this text is redundant with the infobar, although it will need to be re-added when this dialog is redesigned without the infobar. Worse, it is inaccurate in the "clear on exit" case of the Blocked panel. Bug: 610428, 787375 Change-Id: I653ff6790f1b141a71007df38c09f8e917fcfa6b Reviewed-on: https://chromium-review.googlesource.com/782661 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#518347}
-
xdai authored
- The recent destinations list number is bounded by print_preview.AppState.NUM_DESTINATIONS_. - The Recent destinations list will be ordered from the most to the least recent selected. This is a followup CL of https://chromium-review.googlesource.com/c/chromium/src/+/775578. See proposed change: https://docs.google.com/presentation/d/13_Hgj3GPIjXG7RKspRpOAg-GiQ1TSCOjkBmuU979g9E/edit#slide=id.g2702f89868_0_0 Bug: 779591 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib1ea6d1af71199e7346335dcb20a02d698f1d8d0 Reviewed-on: https://chromium-review.googlesource.com/777703Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/cac381990140..0a3adc0b0ad8 $ git log cac381990..0a3adc0b0 --date=short --no-merges --format='%ad %ae %s' 2017-11-21 update-skps Update SKP version 2017-11-21 brianosman Remove SkV8Example 2017-11-21 brianosman Remove expectations kruft from experimental 2017-11-21 brianosman Remove more iOS sample code 2017-11-21 brianosman Remove clutter from experimental Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I7c28d609895f3af1127685b2d2ac001a59c0a4ec Reviewed-on: https://chromium-review.googlesource.com/782381Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518345}
-
Jamie Madill authored
Bug: 786044 Change-Id: I289799d50bbca3adb8ed50f7fb7141ed600a910a Reviewed-on: https://chromium-review.googlesource.com/782405Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#518344}
-
Wez authored
As the first step to merging ScopedPlatformHandle into PlatformHandle to have a single, always-managed container for platform handles, we: - Replace ScopedPlatformHandleVectorPtr and PlatformHandleVector with vector<ScopedPlatformHandle>. - Replace PlatformHandle with ScopedPlatformHandle in some core APIs. - Use const& to pass handles to APIs without passing ownership, for both individual platform handles, and vectors. Bug: 753541 Change-Id: Id965dcf3770ef11bf36f78277fa7199ea779599e Reviewed-on: https://chromium-review.googlesource.com/742309Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#518343}
-
Peter Lee authored
This reverts commit 445feb54. Reason for revert: This will break on iOS 11.2 beta. Original change's description: > Calls decisionsHandler asynchronously > > This change is a precursor to a more extensive change where > ExternalAppLauncher API is changed to be asynchronous. > > This simpler change is to call the decision handler in the implemention > of WKNavigateDelegate method > webView:decidePolicyForNavigationResponse:decisionHandler: > asynchronously on iOS 11 and up. > > iOS 10 (and possible below) has a bug where JavaScript on the page would > not execute if the decision handler is called asynchronously. > > This change is to make sure that there are no other unforeseen > issues with calling decision handler asynchronously on iOS 11. > > Bug: 774736 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I7a6dfe637cb6be4ce5c7efe5824728b8f06b902a > Reviewed-on: https://chromium-review.googlesource.com/773570 > Commit-Queue: Peter Lee <pkl@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517129} TBR=eugenebut@chromium.org,pkl@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 774736 Change-Id: I007149ee9ef15d4187a76d66f90bc52d21ff09aa Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/782682 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
-
Qiang Xu authored
changes: - Move Is{Set}MonoAudioEnabled code to ash, the mono audio pref prefs::kAccessibilityMonoAudioEnabled is already moved to ash. - Remove audio_a11y_controller proxy, using CrasAudioHandler instance directly. Bug: 594887 Test: tested on device with/without --mash, the feature is working fine Change-Id: Ie1803f9e6a783b7bbd76305d91c5f81dcf83f916 Reviewed-on: https://chromium-review.googlesource.com/768338Reviewed-by:Jenny Zhang <jennyz@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#518341}
-
Dave Tapuska authored
In TouchSelectionControllerClientAuraScaleFactorTest InsertionHandleCoordinates test the device scale factor is set. However the test sends input before the screen info is retrieved which adjusted the coordinates on the input router. This change adds the initialization of the scale factor immediately after the InputRouter is created. BUG=722928 Change-Id: Id2e8590a239b05530afc960e35f7d67a0a1aff7d Reviewed-on: https://chromium-review.googlesource.com/779884Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#518340}
-
